finapps_core 5.0.7 → 5.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7da6746a9d41a5a653232294b795c91e9a12b5c6879e3fcd3cef0ae199c7856
-  data.tar.gz: e6cd9df962d35834b073dea681bc56c4a0283130e535dd9e38e03b0431febc76
+  metadata.gz: 893d6f6d8d65e6a2fda82aef09549fef0946de4cb18bb71eb1567a7d25aafc13
+  data.tar.gz: cb75d6b2f6ca7edd7cf469b813ebaa5b0f5213283c7ddb1637294ddc7caf9adc
 SHA512:
-  metadata.gz: c0adf1096463f145ced38476aed16b78a9e1db262881614e727e74eb6a015fc80fae7a6c15a4452e3bc16de47b3536379caeb19b63da86980da890971885c720
-  data.tar.gz: d856c0cd51760de8fb94e2b1907acfe594c3bfb8b8afc54f1bf8447c8759b60ecbaedbfae9c533d46d5eacf7af14c088bc9ca0fdd81166e8ffeed19a9c025370
+  metadata.gz: 1fa618956bad1c72eca4f6e6a22f7c409cc11f57cef754f39a2a2fee321bbb86b71fa723433b3913cbcc56e5def74622b767bf9f8c6bb5bd6dc731f8c9342883
+  data.tar.gz: 2ae2c2d76cf9e878551b2e407eec3a0708bb1602acce8788b7a789987e44b4f5cc2e4bb3927250033e895963724f9706530cdefdc44fb8a8b435c1bf32ab9e89

data/.rubocop.yml

@@ -1,24 +1,78 @@
+require: 
+  - rubocop-rspec
+  - rubocop-performance
+
 AllCops:
-  DisplayCopNames: true
+  TargetRubyVersion: 2.6
   Exclude:
-    - "finapps_core.gemspec"
-  UseCache: false
-
-# Commonly used screens these days easily fit more than 80 characters.
-Layout/LineLength:
-  Max: 120
-
-# Re-enable this when the following is resolved:
-# https://github.com/rubocop-hq/rubocop/issues/5953
-Style/AccessModifierDeclarations:
-  Enabled: false
+    - "vendor/**/*"
+    - "bin/**/*"
+  CacheRootDirectory: tmp
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
 Layout/SpaceInsideBlockBraces:
   # The space here provides no real gain in readability while consuming
   # horizontal space that could be used for a better parameter name.
   # Also {| differentiates better from a hash than { | does.
   SpaceBeforeBlockParameters: false
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+Layout/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: leading
+  SupportedStyles:
+  - leading
+  - trailing
+Layout/LineLength:
+  Max: 110
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
 
+Metrics/ClassLength:
+  Exclude:
+    - app/controllers/orders_controller.rb
+    - app/models/order.rb
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+  Exclude:
+    - config/environments/**/**
+    - '*.gemspec'
+    - Guardfile
+    - config/routes.rb
+    - config/Guardfile
+
+Naming/PredicateName:
+  Description: Check the names of predicate methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
+  Enabled: true
+  NamePrefix:
+  - is_
+  - has_
+  - have_
+  ForbiddenPrefixes:
+  - is_
+  Exclude:
+  - spec/**/*
+
+RSpec/FilePath:
+  Enabled: false
+    
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
 Style/CollectionMethods:
   Description: Preferred collection methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
@@ -29,73 +83,76 @@ Style/CollectionMethods:
     find: detect
     find_all: select
     reduce: inject
+Style/GuardClause:
+  Description: Check for conditionals that can be replaced with guard clauses
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
+  Enabled: true
+  MinBodyLength: 1
 Style/OptionHash:
   Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
-Naming/PredicateName:
-  Description: Check the names of predicate methods.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
-  Enabled: true
-  NamePrefix:
-    - is_
-    - has_
-    - have_
-  ForbiddenPrefixes:
-    - is_
-  Exclude:
-    - spec/**/*
-Metrics/AbcSize:
-  Description: A calculated magnitude based on number of assignments, branches, and
-    conditions.
-  Enabled: false
-  Max: 15
-Metrics/BlockLength:
-  ExcludedMethods: ['describe', 'context']
-Metrics/ClassLength:
-  Description: Avoid classes longer than 100 lines of code.
-  Enabled: false
-  CountComments: false
-  Max: 100
-Metrics/ModuleLength:
-  CountComments: false
-  Max: 100
-  Description: Avoid modules longer than 100 lines of code.
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Description: A complexity metric that is strongly correlated to the number of test
-    cases needed to validate a method.
-  Enabled: false
-  Max: 6
-Metrics/MethodLength:
-  Description: Avoid methods longer than 10 lines of code.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
-  Enabled: false
-  CountComments: false
-  Max: 10
-Metrics/ParameterLists:
-  Description: Avoid parameter lists longer than three or four parameters.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#too-many-params
+Style/PercentLiteralDelimiters:
+  Description: Use `%`-literal delimiters consistently
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
   Enabled: false
-  Max: 5
-  CountKeywordArgs: true
-Metrics/PerceivedComplexity:
-  Description: A complexity metric geared towards measuring complexity for a human
-    reader.
-  Enabled: false
-  Max: 7
+  PreferredDelimiters:
+    "%": "()"
+    "%i": "()"
+    "%q": "()"
+    "%Q": "()"
+    "%r": "{}"
+    "%s": "()"
+    "%w": "()"
+    "%W": "()"
+    "%x": "()"
+Style/SignalException:
+  Description: Checks for proper usage of fail and raise.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
+  Enabled: true
+  EnforcedStyle: semantic
+  SupportedStyles:
+  - only_raise
+  - only_fail
+  - semantic
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
 Style/Documentation:
   Description: Document classes and non-namespace modules.
   Enabled: false
-Style/EmptyLiteral:
-  Description: Prefer literals to Array.new/Hash.new/String.new.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
-  Enabled: false
-Style/VariableInterpolation:
-  Description: Don't interpolate global, instance and class variables directly in
-    strings.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
+Style/OneLineConditional:
+  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
   Enabled: false
-Lint/SuppressedException:
-  Description: Don't suppress exception.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
-  Enabled: false
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+RSpec/NestedGroups:
+  Max: 5
+RSpec/DescribeClass:
+  Exclude:
+    - spec/system/*
+    - spec/factories_spec.rb

data/.tmuxinator.yml

@@ -0,0 +1,20 @@
+--- 
+name: ruby-client-core
+root: ~/projects/ruby-client-core/
+windows: 
+  - 
+    editor: 
+      layout: main-vertical
+      panes: 
+        - vim: $EDITOR
+        - bash: 
+          - git pull
+          - git status
+          - bundle
+          - bundle outdated
+  - 
+    guard: 
+      layout: even-horizontal
+      panes:
+        - guard:
+          - bundle exec guard

data/.travis.yml

@@ -1,17 +1,16 @@
-sudo: false
 language: ruby
+os: ["linux"]
+dist: "xenial"
+
 cache:
   bundler: true
 
 rvm:
-  - 2.5
   - 2.6
-#  - ruby-head
 
 before_install:
   - "echo 'gem: --no-document' > ~/.gemrc"
-  - gem update --system
-  - gem install bundler -v "~>2.0"
+  - gem install bundler --force --quiet
 
 script:
   - bundle exec rspec
@@ -23,4 +22,4 @@ addons:
   code_climate:
     repo_token: 5a8d194cbc23aa4c171e3478e3b6bbea9dd96041071380ec25bf80c07770b39a
 after_success:
-  - bundle exec codeclimate-test-reporter
+  - bundle exec codeclimate-test-reporter

data/finapps_core.gemspec

@@ -1,6 +1,6 @@
-# coding: utf-8
 # frozen_string_literal: true
-lib = File.expand_path('../lib', __FILE__)
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'finapps_core/version'
 Gem::Specification.new do |spec|
@@ -26,11 +26,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler',                    '~> 2.0', '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
   spec.add_development_dependency 'gem-release',                '~> 2.0',   '>= 2.0.3'
-  spec.add_development_dependency 'rake',                       '~> 12.3',  '>= 12.3.2'
+  spec.add_development_dependency 'rake',                       '~> 13.0',  '>= 13.0.1'
   spec.add_development_dependency 'rspec',                      '~> 3.8',   '>= 3.8.0'
-  spec.add_development_dependency 'rubocop',                    '~> 0.75',  '>= 0.75.0'
-  spec.add_development_dependency 'rubocop-performance',        '~> 1.5',   '>= 1.5.0'
-  spec.add_development_dependency 'rubocop-rspec',              '~> 1.36',  '>= 1.36.0'
+  spec.add_development_dependency 'rubocop',                    '~> 0.86',  '>= 0.86.0'
+  spec.add_development_dependency 'rubocop-performance',        '~> 1.6',   '>= 1.6.1'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 1.40',  '>= 1.40.0'
   spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.5'
   spec.add_development_dependency 'webmock',                    '~> 3.6',   '>= 3.6.0'
 

data/lib/finapps_core/middleware/middleware.rb

@@ -6,8 +6,10 @@ module FinAppsCore
   module Middleware
     autoload :AcceptJson, 'finapps_core/middleware/request/accept_json'
     autoload :UserAgent, 'finapps_core/middleware/request/user_agent'
-    autoload :NoEncodingBasicAuthentication, 'finapps_core/middleware/request/no_encoding_basic_authentication'
-    autoload :TenantAuthentication, 'finapps_core/middleware/request/tenant_authentication'
+    autoload :NoEncodingBasicAuthentication,
+             'finapps_core/middleware/request/no_encoding_basic_authentication'
+    autoload :TenantAuthentication,
+             'finapps_core/middleware/request/tenant_authentication'
     autoload :RequestId, 'finapps_core/middleware/request/request_id'
     autoload :XConsumerId, 'finapps_core/middleware/request/x_consumer_id'
 

data/lib/finapps_core/middleware/request/accept_json.rb

@@ -2,7 +2,8 @@
 
 module FinAppsCore
   module Middleware
-    # This middleware sets the Accept request-header field to specify JSON as acceptable media type for the response.
+    # This middleware sets the Accept request-header field to specify JSON
+    # as acceptable media type for the response.
     class AcceptJson < Faraday::Middleware
       KEY = 'Accept' unless defined? KEY
 

data/lib/finapps_core/middleware/response/raise_error.rb

@@ -16,12 +16,7 @@ module FinAppsCore
       def on_complete(env)
         return if SUCCESS_STATUSES.include?(env[:status])
 
-        raise(FinAppsCore::ApiUnauthenticatedError, 'API Invalid Session') if env[:status] == API_UNAUTHENTICATED
-        raise(FinAppsCore::ApiSessionTimeoutError, 'API Session Timed out') if env[:status] == API_SESSION_TIMEOUT
-        raise(FinAppsCore::ConnectionFailedError, 'Connection Failed') if env[:status] == CONNECTION_FAILED_STATUS
-        raise(FinAppsCore::UserLockoutError, 'User is Locked') if user_is_locked?(env)
-
-        raise(Faraday::ClientError, response_values(env))
+        failures env
       end
 
       def response_values(env)
@@ -35,6 +30,39 @@ module FinAppsCore
 
       private
 
+      def failures(env)
+        api_authentication_fail env
+        api_session_timeout_fail env
+        locked_user_fail env
+        connection_fail env
+
+        fail(Faraday::ClientError, response_values(env))
+      end
+
+      def locked_user_fail(env)
+        return unless user_is_locked?(env)
+
+        fail(FinAppsCore::UserLockoutError, 'User is Locked')
+      end
+
+      def api_session_timeout_fail(env)
+        return unless env[:status] == API_SESSION_TIMEOUT
+
+        fail(FinAppsCore::ApiSessionTimeoutError, 'API Session Timed out')
+      end
+
+      def connection_fail(env)
+        return unless env[:status] == CONNECTION_FAILED_STATUS
+
+        fail(FinAppsCore::ConnectionFailedError, 'Connection Failed')
+      end
+
+      def api_authentication_fail(env)
+        return unless env[:status] == API_UNAUTHENTICATED
+
+        fail(FinAppsCore::ApiUnauthenticatedError, 'API Invalid Session')
+      end
+
       def error_messages(body)
         return nil if empty?(body)
 
@@ -59,7 +87,8 @@ module FinAppsCore
       end
 
       def user_is_locked?(env)
-        env.status == FORBIDDEN && error_messages(env.body)&.[](0)&.downcase == LOCKOUT_MESSAGE
+        env.status == FORBIDDEN &&
+          error_messages(env.body)&.[](0)&.downcase == LOCKOUT_MESSAGE
       end
 
       def symbolize(obj)

data/lib/finapps_core/rest/base_client.rb

@@ -31,7 +31,8 @@ module FinAppsCore
       end
 
       # Performs HTTP GET, POST, UPDATE and DELETE requests.
-      # You shouldn't need to use this method directly, but it can be useful for debugging.
+      # You shouldn't need to use this method directly,
+      # but it can be useful for debugging.
       # Returns a hash obtained from parsing the JSON object in the response body.
       #
       # @param [String] path
@@ -42,7 +43,7 @@ module FinAppsCore
         not_blank(path, :path)
         not_blank(method, :method)
 
-        response, error_messages = execute_request(path, method, params)
+        response, error_messages = execute_request(method, path, params)
         result = block_given? ? yield(response) : response_body(response)
 
         [result, error_messages]
@@ -76,26 +77,19 @@ module FinAppsCore
         end
       end
 
-      def execute_request(path, method, params)
-        response = nil
-        errors = []
-
-        begin
-          response = execute_method path, method, params
-        rescue FinAppsCore::InvalidArgumentsError,
-               FinAppsCore::MissingArgumentsError,
-               Faraday::Error::ConnectionFailed => e
-          handle_error e
-        rescue Faraday::ClientError => e
-          errors = handle_client_error(e)
-        end
-
-        [response, errors]
+      def execute_request(method, path, params)
+        [send(method, path, params), []]
+      rescue FinAppsCore::InvalidArgumentsError,
+             FinAppsCore::MissingArgumentsError,
+             Faraday::Error::ConnectionFailed => e
+        [nil, handle_error(e)]
+      rescue Faraday::ClientError => e
+        [nil, handle_client_error(e)]
       end
 
       def handle_error(error)
         logger.fatal "#{self.class}##{__method__} => #{error}"
-        raise error
+        fail error
       end
 
       def handle_client_error(error)
@@ -103,19 +97,13 @@ module FinAppsCore
         error.response && error.response[:error_messages] ? error.response[:error_messages] : [error.message]
       end
 
-      def execute_method(path, method, params)
-        case method
-        when :get
-          get(path)
-        when :post
-          post(path, params)
-        when :put
-          put(path, params)
-        when :delete
-          delete(path, params)
-        else
-          raise FinAppsCore::UnsupportedHttpMethodError, "Method not supported: #{method}."
+      def execute_method(method, path, params)
+        unless %i(get post put delete).include?(method)
+          fail FinAppsCore::UnsupportedHttpMethodError,
+               "Method not supported: #{method}."
         end
+
+        send(method, path, params)
       end
     end
   end