finapps_core 5.0.3 → 5.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36b9473cac6b1a6ceb5397468058ebaf913c99083199d9f5a95b7390f40852a0
-  data.tar.gz: 40703497d825004f9f47db602789240ff8830fa619f431a9773e442248c15a7c
+  metadata.gz: d73742939d1896b096ba4ea23eae7381c812565acc344b634467ec581b24bd0e
+  data.tar.gz: 1e9acbd80be922e20b13ddbc399f07e6adfa2ad9dea799a77a44ea06516029bd
 SHA512:
-  metadata.gz: 5811f5108aa523ac561d168a258a297ddc6e98ac4dec2377c323f3c9225895fe70209f3cc9ff2e4cc4dbd0b811d25f0ec7810c688ad58421154effe463a49a92
-  data.tar.gz: bc5adcc3c74ec2b362f3a7d0e55b7bebb90d6999475c7e5ea9d4065c5a725c9247dc1d9c311975bc0d51da3dfde4a98fbc293437b7bbc55898938c1ca05da5cd
+  metadata.gz: 648f16e4ea04e82aa0bc1d281872b12172653834a41bc950634b38b549b20e25c94bf6a56a471bf0c294f7bc5ea49874fefb2263315cfc5795b49da4cae7229b
+  data.tar.gz: 163c427e8170c8613acd7cc1d0bcfb56c6270af9d9ec444579b6e3e0103e1cf9759e0da38661a36433088887d4163d5da74d895bc4d670f25249566daede8fc0

data/lib/finapps_core/rest/base_client.rb

@@ -43,11 +43,7 @@ module FinAppsCore
         not_blank(method, :method)
 
         response, error_messages = execute_request(path, method, params)
-        result = if empty?(response)
-                   nil
-                 else
-                   block_given? ? yield(response) : response.body
-                 end
+        result = block_given? ? yield(response) : response_body(response)
 
         [result, error_messages]
       end
@@ -69,6 +65,10 @@ module FinAppsCore
 
       private
 
+      def response_body(response)
+        response.body if response.respond_to?(:body)
+      end
+
       def send_to_connection(method_id, arguments)
         connection.send(method_id) do |req|
           req.url arguments.first
@@ -76,24 +76,15 @@ module FinAppsCore
         end
       end
 
-      def empty?(response)
-        !response || empty_body?(response)
-      end
-
-      def empty_body?(response)
-        !response.respond_to?(:body) || !response.body || (response.body.respond_to?(:empty?) && response.body.empty?)
-      end
-
       def execute_request(path, method, params)
+        response = nil
         errors = []
 
         begin
           response = execute_method path, method, params
-        rescue FinAppsCore::InvalidArgumentsError => e
-          handle_error e
-        rescue FinAppsCore::MissingArgumentsError => e
-          handle_error e
-        rescue Faraday::Error::ConnectionFailed => e
+        rescue FinAppsCore::InvalidArgumentsError,
+               FinAppsCore::MissingArgumentsError,
+               Faraday::Error::ConnectionFailed => e
           handle_error e
         rescue Faraday::Error::ClientError => e
           errors = handle_client_error(e)

data/lib/finapps_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinAppsCore
-  VERSION = '5.0.3'
+  VERSION = '5.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 5.0.3
+  version: 5.0.4
 platform: ruby
 authors:
 - Erich Quintero