finapps_core 5.0.3 → 5.0.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 36b9473cac6b1a6ceb5397468058ebaf913c99083199d9f5a95b7390f40852a0
4
- data.tar.gz: 40703497d825004f9f47db602789240ff8830fa619f431a9773e442248c15a7c
3
+ metadata.gz: d73742939d1896b096ba4ea23eae7381c812565acc344b634467ec581b24bd0e
4
+ data.tar.gz: 1e9acbd80be922e20b13ddbc399f07e6adfa2ad9dea799a77a44ea06516029bd
5
5
  SHA512:
6
- metadata.gz: 5811f5108aa523ac561d168a258a297ddc6e98ac4dec2377c323f3c9225895fe70209f3cc9ff2e4cc4dbd0b811d25f0ec7810c688ad58421154effe463a49a92
7
- data.tar.gz: bc5adcc3c74ec2b362f3a7d0e55b7bebb90d6999475c7e5ea9d4065c5a725c9247dc1d9c311975bc0d51da3dfde4a98fbc293437b7bbc55898938c1ca05da5cd
6
+ metadata.gz: 648f16e4ea04e82aa0bc1d281872b12172653834a41bc950634b38b549b20e25c94bf6a56a471bf0c294f7bc5ea49874fefb2263315cfc5795b49da4cae7229b
7
+ data.tar.gz: 163c427e8170c8613acd7cc1d0bcfb56c6270af9d9ec444579b6e3e0103e1cf9759e0da38661a36433088887d4163d5da74d895bc4d670f25249566daede8fc0
@@ -43,11 +43,7 @@ module FinAppsCore
43
43
  not_blank(method, :method)
44
44
 
45
45
  response, error_messages = execute_request(path, method, params)
46
- result = if empty?(response)
47
- nil
48
- else
49
- block_given? ? yield(response) : response.body
50
- end
46
+ result = block_given? ? yield(response) : response_body(response)
51
47
 
52
48
  [result, error_messages]
53
49
  end
@@ -69,6 +65,10 @@ module FinAppsCore
69
65
 
70
66
  private
71
67
 
68
+ def response_body(response)
69
+ response.body if response.respond_to?(:body)
70
+ end
71
+
72
72
  def send_to_connection(method_id, arguments)
73
73
  connection.send(method_id) do |req|
74
74
  req.url arguments.first
@@ -76,24 +76,15 @@ module FinAppsCore
76
76
  end
77
77
  end
78
78
 
79
- def empty?(response)
80
- !response || empty_body?(response)
81
- end
82
-
83
- def empty_body?(response)
84
- !response.respond_to?(:body) || !response.body || (response.body.respond_to?(:empty?) && response.body.empty?)
85
- end
86
-
87
79
  def execute_request(path, method, params)
80
+ response = nil
88
81
  errors = []
89
82
 
90
83
  begin
91
84
  response = execute_method path, method, params
92
- rescue FinAppsCore::InvalidArgumentsError => e
93
- handle_error e
94
- rescue FinAppsCore::MissingArgumentsError => e
95
- handle_error e
96
- rescue Faraday::Error::ConnectionFailed => e
85
+ rescue FinAppsCore::InvalidArgumentsError,
86
+ FinAppsCore::MissingArgumentsError,
87
+ Faraday::Error::ConnectionFailed => e
97
88
  handle_error e
98
89
  rescue Faraday::Error::ClientError => e
99
90
  errors = handle_client_error(e)
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module FinAppsCore
4
- VERSION = '5.0.3'
4
+ VERSION = '5.0.4'
5
5
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: finapps_core
3
3
  version: !ruby/object:Gem::Version
4
- version: 5.0.3
4
+ version: 5.0.4
5
5
  platform: ruby
6
6
  authors:
7
7
  - Erich Quintero