finapps_core 5.0.15 → 6.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15287486b44c005d79a5b2df3a5f21c2aabe9c4a2b64831fbfa3dcc3cf0d537a
-  data.tar.gz: 854733e5448065c154b7db0c40f0c8be4ea772f924845cbf7035eea1f2ef7594
+  metadata.gz: 3b9fa5ca000c09b230c7032f5c9440717277f1f4aaf6f0378db29fecf33876b9
+  data.tar.gz: 037fc8c35abc696cbab2f25c62891a1e0c886a01f70bc2138d4c70d874e894c1
 SHA512:
-  metadata.gz: 622a1963d7b63526bc7210d27e21fb318e0a07d964c889c9531e10cff27c89e3c9368a9138ed242cb77e609d5ccf75918c329d7b7984580f656d1f4b1b1e53ef
-  data.tar.gz: 551f19f7f5d4f7eb64dd0879a73054f882a25fa92a7360aa0ab9c595c811d468ba72912087bfd756b5a327aa30100520a5da74f957298bc8961130325514e09a
+  metadata.gz: 6f933574cc7893beed8b32d12c05a41be05bfffcf4819c6092a32c31ffa8be0b458502982f3c7067a1d2ed5ec3343d229ebe316df83fb7ae9444b0f5e0ab700f
+  data.tar.gz: f2d8db2e4f877a97fc4a2415f7cfd7a91043b701fc28a4ebff3a0b29e3769042b4a6291a768b1eb23ac9c640bd0c272748fa660bd48a370ad1c836231fe81902

data/.github/dependabot.yml

@@ -0,0 +1,7 @@
+version: 2
+updates:
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.github/workflows/ci.yaml

@@ -10,38 +10,31 @@ on:
       - ".github/**"
       - ".VERSION"
 jobs:
-  tests:
+  test:
     if: "!contains(github.event.head_commit.message, 'skip ci')"
-    runs-on: ubuntu-latest
-
     strategy:
-      fail-fast: true
-
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout source code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v2.4.0
 
       - name: Install required ruby version
         uses: ruby/setup-ruby@v1
-
-      - name: Setup cache key and directory for gems cache
-        uses: actions/cache@v2
         with:
-          path: vendor/bundle
-          key: ${{ runner.os  }}-gems-${{ hashFiles('**/Gemfile.lock')  }}
-          restore-keys: |
-            ${{ runner.os  }}-gems-
+          bundler-cache: true # runs 'bundle install' and caches gems
 
-      - name: Bundle install
+      - name: Run rspec with coverage
         run: |
-          bundle config path vendor/bundle
-          bundle config set jobs 4
-          bundle config set retry 3
-          bundle install
+          COVERAGE=true bundle exec rspec
 
       - name: Run rubocop
-        run: | 
+        run: |
           bundle exec rubocop --parallel
 
-      - name: Run rspec
-        run: bundle exec rspec
+      - name: Run Skunk on Project
+        run: |
+          gem install skunk
+          skunk lib/ 

data/.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
 
     steps: 
       - name: Checkout source code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v2.4.0
         with:
           persist-credentials: false
           fetch-depth: 0 # otherwise, you will fail to push refs to dest repo

data/.github/workflows/verify-pr-labeled.yml

@@ -7,8 +7,17 @@ jobs:
   label:
     runs-on: ubuntu-latest
     steps:
-      - uses: mheap/github-action-required-labels@v1
+      - uses: mheap/github-action-required-labels@v1.2
         with:
-          mode: exactly
+          mode: minimum
           count: 1
-          labels: "bug, change, enhancement"       
+          #
+          # Releases will group changes under Added/Fixed/Changed sub-headers 
+          # based on labels and follwing these rules: 
+          #
+          # Added: enhancement
+          # Fixed: bug
+          # Changed: maintenance, change, dependencies (used by Dependabot)
+          # Ignore: skip-changelog
+          #
+          labels: "enhancement, bug, maintenance, change, dependencies, skip-changelog"

data/README.md

@@ -3,9 +3,6 @@ FinApps Ruby-Client-Core
 ========================
 
 [![Gem Version](https://img.shields.io/gem/v/finapps_core.svg)](https://rubygems.org/gems/finapps_core)
-[![Build Status](https://travis-ci.org/finapps/ruby-client-core.svg?branch=master)](https://travis-ci.org/finapps/ruby-client-core)
-[![Code Climate](https://codeclimate.com/github/finapps/ruby-client-core/badges/gpa.svg)](https://codeclimate.com/github/finapps/ruby-client-core)
-[![Test Coverage](https://codeclimate.com/github/finapps/ruby-client-core/badges/coverage.svg)](https://codeclimate.com/github/finapps/ruby-client-core/coverage)
 [![License](http://img.shields.io/:license-mit-blue.svg?style=flat-square)](http://finapps.mit-license.org)
 
 Common library for Ruby clients.
@@ -18,4 +15,4 @@ See Financial Apps API [Ruby Client][ruby-client].
 [FinancialApps.com][financialapps]
 
 [ruby-client]: https://github.com/finapps/ruby-client
-[financialapps]: https://financialapps.com
+[financialapps]: https://financialapps.com

data/finapps_core.gemspec

@@ -20,20 +20,24 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'faraday',                    '~> 1.3',   '>= 1.3.0'
+  spec.add_runtime_dependency     'faraday',                    '~> 1.4',   '>= 1.4.0'
   spec.add_runtime_dependency     'faraday_middleware',         '~> 1.0',   '>= 1.0.0'
 
-  spec.add_development_dependency 'bundler',                    '~> 2.1',   '>= 2.1.4'
-  spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
+  spec.add_development_dependency 'bundler',                    '~> 2.2',   '>= 2.2.16'
   spec.add_development_dependency 'rake',                       '~> 13.0',  '>= 13.0.1'
   spec.add_development_dependency 'rspec',                      '~> 3.10',  '>= 3.10.0'
   spec.add_development_dependency 'rubocop',                    '~> 1.9',   '>= 1.9.1'
   spec.add_development_dependency 'rubocop-performance',        '~> 1.9',   '>= 1.9.2'
   spec.add_development_dependency 'rubocop-rake',               '~> 0.5',   '>= 0.5.1'
   spec.add_development_dependency 'rubocop-rspec',              '~> 2.2',   '>= 2.2.0'
+  spec.add_development_dependency 'simplecov',                  '~> 0.21',  '>= 0.21.2'
+  spec.add_development_dependency 'simplecov-console',          '~> 0.9'
   spec.add_development_dependency 'sinatra',                    '~> 2.1',   '>= 2.1.0'
-  spec.add_development_dependency 'webmock',                    '~> 3.11',  '>= 3.11.2'
+  spec.add_development_dependency 'webmock',                    '~> 3.12',  '>= 3.12.2'
 
   spec.extra_rdoc_files = %w(README.md LICENSE)
   spec.rdoc_options = %w(--line-numbers --inline-source --title finapps-ruby-core --main README.md)
+  # rubocop:disable Gemspec/RequireMFA
+  spec.metadata['rubygems_mfa_required'] = 'false'
+  # rubocop:enable Gemspec/RequireMFA
 end

data/lib/finapps_core/logging/content_type_formatter.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'faraday/logging/formatter'
+
+module FinAppsCore
+  module Logging
+    class ContenTypeFormatter < Faraday::Logging::Formatter
+      CONTENT_TYPE = 'Content-Type' unless defined?(ContenTypeFormatter::CONTENT_TYPE)
+
+      def response(env)
+        status = proc { "Status #{env.status}" }
+        public_send(log_level, 'response', &status)
+
+        log_headers('response', env.response_headers) if log_headers?(:response)
+        log_body('response', env[:body]) if env[:body] && log_body?(:response) && loggable?(env)
+      end
+
+      private
+
+      def loggable?(env)
+        loggable_types = ['application/json', 'text/plain']
+        process_response_type?(env, loggable_types)
+      end
+
+      def process_response_type?(env, content_types)
+        type = response_type(env)
+        content_types.empty? || content_types.any? do |pattern|
+          pattern.is_a?(Regexp) ? type.match?(pattern) : type == pattern
+        end
+      end
+
+      def response_type(env)
+        type = env[:response_headers][CONTENT_TYPE].to_s
+        type = type.split(';', 2).first if type.index(';')
+        type
+      end
+    end
+  end
+end

data/lib/finapps_core/rest/configuration.rb

@@ -27,7 +27,7 @@ module FinAppsCore
       def assign_attributes(new_attributes)
         unless new_attributes.respond_to?(:each_pair)
           fail ArgumentError, 'When assigning attributes, '\
-            "you must pass a hash argument, #{new_attributes.class} passed."
+                              "you must pass a hash argument, #{new_attributes.class} passed."
         end
         return if new_attributes.empty?
 

data/lib/finapps_core/rest/connection.rb

@@ -19,10 +19,13 @@ module FinAppsCore
       end
 
       def init_connection_response(conn, logger)
-        conn.response :logger, logger, bodies: true
         conn.response :json,
                       content_type: /\bjson$/,
                       parser_options: {symbolize_names: true}
+        conn.response :logger, logger, bodies: true,
+                                       headers: true,
+                                       formatter: FinAppsCore::Logging::ContenTypeFormatter,
+                                       log_level: :debug
       end
 
       def init_connection_request(conn, config)

data/lib/finapps_core/rest/defaults.rb

@@ -5,11 +5,11 @@ require 'logger'
 module FinAppsCore
   module REST
     module Defaults
-      API_VERSION = '4'
+      API_VERSION = '5'
 
       # noinspection SpellCheckingInspection
       DEFAULTS = {
-        host: 'https://api.finclear.io',
+        host: 'https://api.allcleardecisioning.com',
         timeout: 30,
         proxy: nil,
         log_level: Logger::UNKNOWN

data/lib/finapps_core/utils/validatable.rb

@@ -12,7 +12,7 @@ module FinAppsCore
       end
 
       def nil_or_empty?(value)
-        !value || value.respond_to?(:empty?) && value.empty?
+        !value || (value.respond_to?(:empty?) && value.empty?)
       end
     end
   end

data/lib/finapps_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinAppsCore
-  VERSION = '5.0.15'
+  VERSION = '6.0.2'
 end

data/lib/finapps_core.rb

@@ -12,6 +12,8 @@ require 'finapps_core/utils/loggeable'
 require 'finapps_core/utils/validatable'
 require 'finapps_core/error'
 
+require 'finapps_core/logging/content_type_formatter'
+
 require 'finapps_core/middleware/request/tenant_authentication'
 require 'finapps_core/middleware/request/no_encoding_basic_authentication'
 require 'finapps_core/middleware/request/accept_json'

data/spec/logging/conten_type_formatter_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require 'stringio'
+require 'logger'
+
+RSpec.describe Faraday::Response::Logger do
+  let(:string_io) { StringIO.new }
+  let(:logger) { Logger.new(string_io) }
+  let(:conn) do
+    rubbles = %w(Barney Betty)
+    logger_options = {
+      bodies: true,
+      formatter: FinAppsCore::Logging::ContenTypeFormatter
+    }
+
+    Faraday.new do |b|
+      b.response :logger, logger, logger_options
+      b.adapter :test do |stubs|
+        stubs.get('/text') { [200, {'Content-Type' => 'text/plain'}, 'hello'] }
+        stubs.get('/json') { [200, {'Content-Type' => 'application/json'}, rubbles] }
+        stubs.get('/pdf') { [200, {'Content-Type' => 'application/pdf'}, 'binary-here'] }
+      end
+    end
+  end
+
+  before do
+    logger.level = Logger::DEBUG
+  end
+
+  context 'when content type is text/plain' do
+    before { conn.get '/text' }
+
+    it 'logs response body' do
+      expect(string_io.string).to match('hello')
+    end
+  end
+
+  context 'when content type is application/json' do
+    before { conn.get '/json' }
+
+    it 'logs response body' do
+      expect(string_io.string).to match('[\"Barney\", \"Betty\"]')
+    end
+  end
+
+  context 'when content type is something else' do
+    before { conn.get '/pdf' }
+
+    it 'does not log response body' do
+      expect(string_io.string).not_to match('binary-here')
+    end
+  end
+end

data/spec/rest/defaults_spec.rb

@@ -6,12 +6,25 @@ RSpec.describe FinAppsCore::REST::Defaults do
   describe 'set constants' do
     before { stub_const(described_class.to_s, fake_class) }
 
-    it('sets API_VERSION') { expect(described_class::API_VERSION).to eq '4' }
+    it('sets API_VERSION') { expect(described_class::API_VERSION).to eq '5' }
     it('sets DEFAULTS') { expect(described_class::DEFAULTS).to be_a(Hash) }
     it('freezes DEFAULTS') { expect(described_class::DEFAULTS).to be_frozen }
-    it('sets DEFAULTS[:host]') { expect(described_class::DEFAULTS[:host]).to eq 'https://api.finclear.io' }
-    it('sets DEFAULTS[:timeout]') { expect(described_class::DEFAULTS[:timeout]).to eq 30 }
-    it('does not set DEFAULTS[:proxy]') { expect(described_class::DEFAULTS[:proxy]).to be_nil }
-    it('sets DEFAULTS[:log_level]') { expect(described_class::DEFAULTS[:log_level]).to eq Logger::UNKNOWN }
+
+    it('sets DEFAULTS[:host]') {
+      expected = 'https://api.allcleardecisioning.com'
+      expect(described_class::DEFAULTS[:host]).to eq expected
+    }
+
+    it('sets DEFAULTS[:timeout]') {
+      expect(described_class::DEFAULTS[:timeout]).to eq 30
+    }
+
+    it('does not set DEFAULTS[:proxy]') {
+      expect(described_class::DEFAULTS[:proxy]).to be_nil
+    }
+
+    it('sets DEFAULTS[:log_level]') {
+      expect(described_class::DEFAULTS[:log_level]).to eq Logger::UNKNOWN
+    }
   end
 end

data/spec/spec_helper.rb

@@ -1,10 +1,19 @@
 # frozen_string_literal: true
 
-if ENV['CODECLIMATE_REPO_TOKEN']
-  # require 'codeclimate-test-reporter'
-  # CodeClimate::TestReporter.start
+if ENV['COVERAGE'] == 'true'
   require 'simplecov'
-  SimpleCov.start
+  require 'simplecov-console'
+
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+        SimpleCov::Formatter::HTMLFormatter,
+        SimpleCov::Formatter::Console,
+  ]
+
+  SimpleCov.start do
+    track_files 'lib/**/*.rb'
+  end
+
+  puts "Using SimpleCov v#{SimpleCov::VERSION}"
 end
 
 require 'bundler/setup'
@@ -33,7 +42,6 @@ RSpec.configure do |config|
     base_url = "#{FinAppsCore::REST::Defaults::DEFAULTS[:host]}/v#{FinAppsCore::REST::Defaults::API_VERSION}/"
     stub_request(:any, /#{base_url}/).to_rack(::FakeApi)
   end
-  WebMock.disable_net_connect!(allow: 'codeclimate.com')
 end
 
 VALID_CREDENTIALS = {identifier: '49fb918d-7e71-44dd-7378-58f19606df2a',

data/spec/support/fake_api.rb

@@ -34,7 +34,7 @@ class FakeApi < Sinatra::Base
   def json_response(response_code, file_name)
     content_type :json
     status response_code
-    File.open("#{File.dirname(__FILE__)}/fixtures/#{file_name}", 'rb').read
+    File.binread("#{File.dirname(__FILE__)}/fixtures/#{file_name}")
   end
 
   def version; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 5.0.15
+  version: 6.0.2
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-03 00:00:00.000000000 Z
+date: 2022-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -16,20 +16,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
@@ -56,40 +56,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.1.4
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.1.4
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.9
+        version: 2.2.16
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.9
+        version: 2.2.16
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -210,6 +190,40 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.2.0
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.21'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.21.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.21'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.21.2
+- !ruby/object:Gem::Dependency
+  name: simplecov-console
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -236,20 +250,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.11'
+        version: '3.12'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.11.2
+        version: 3.12.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.11'
+        version: '3.12'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.11.2
+        version: 3.12.2
 description: A simple library for communicating with the FinApps REST API. Core functionality.
 email:
 - erich@financialapps.com
@@ -260,6 +274,7 @@ extra_rdoc_files:
 - LICENSE
 files:
 - ".codeclimate.yml"
+- ".github/dependabot.yml"
 - ".github/release-drafter.yml"
 - ".github/workflows/ci.yaml"
 - ".github/workflows/release-drafter.yml"
@@ -284,6 +299,7 @@ files:
 - lib/core_extensions/string/json_to_hash.rb
 - lib/finapps_core.rb
 - lib/finapps_core/error.rb
+- lib/finapps_core/logging/content_type_formatter.rb
 - lib/finapps_core/middleware/middleware.rb
 - lib/finapps_core/middleware/request/accept_json.rb
 - lib/finapps_core/middleware/request/no_encoding_basic_authentication.rb
@@ -304,6 +320,7 @@ files:
 - lib/finapps_core/version.rb
 - lib/tasks/releaser.rake
 - spec/core_extensions/object/is_integer_spec.rb
+- spec/logging/conten_type_formatter_spec.rb
 - spec/middleware/request/accept_json_spec.rb
 - spec/middleware/request/no_encoding_basic_authentication_spec.rb
 - spec/middleware/request/request_id_spec.rb
@@ -330,7 +347,8 @@ files:
 homepage: https://github.com/finapps/ruby-client-core
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'false'
 post_install_message: 
 rdoc_options:
 - "--line-numbers"
@@ -357,21 +375,22 @@ signing_key:
 specification_version: 4
 summary: FinApps REST API ruby client - Core.
 test_files:
-- spec/support/fake_api.rb
-- spec/spec_helpers/client.rb
-- spec/rest/configuration_spec.rb
-- spec/rest/base_client_spec.rb
-- spec/rest/resources_spec.rb
-- spec/rest/defaults_spec.rb
-- spec/rest/credentials_spec.rb
-- spec/spec_helper.rb
 - spec/core_extensions/object/is_integer_spec.rb
+- spec/logging/conten_type_formatter_spec.rb
 - spec/utils/validatable_spec.rb
-- spec/middleware/response/raise_error_spec.rb
-- spec/middleware/request/tenant_authentication_spec.rb
+- spec/support/fake_api.rb
+- spec/middleware/request/request_id_spec.rb
+- spec/middleware/request/accept_json_spec.rb
 - spec/middleware/request/no_encoding_basic_authentication_spec.rb
-- spec/middleware/request/user_agent_spec.rb
 - spec/middleware/request/x_consumer_id_spec.rb
-- spec/middleware/request/request_id_spec.rb
+- spec/middleware/request/user_agent_spec.rb
+- spec/middleware/request/tenant_authentication_spec.rb
 - spec/middleware/request/x_tenant_id_spec.rb
-- spec/middleware/request/accept_json_spec.rb
+- spec/middleware/response/raise_error_spec.rb
+- spec/spec_helper.rb
+- spec/rest/configuration_spec.rb
+- spec/rest/base_client_spec.rb
+- spec/rest/defaults_spec.rb
+- spec/rest/credentials_spec.rb
+- spec/rest/resources_spec.rb
+- spec/spec_helpers/client.rb