finapps_core 5.0.13 → 5.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '048fa78b23468e14dd5756a875178f323687de38537d46db6b0f7da842bbf375'
-  data.tar.gz: fe171551416bfc98902f958cae69220f4923f6e9b0445883689a3d4edff73c08
+  metadata.gz: 4a0b9d68f085e0831b039da71cd442e4c96d58f8e6cd9787c4b8ec4eef9edf8d
+  data.tar.gz: aacb0dc131db339c2360f38fa8918360bdcc2f5ada120e97b21cdd1c15a2daf4
 SHA512:
-  metadata.gz: 947a8a2ee8caff1d0de36924480926db3c12e4dc76d3904735929265f3a981e98062695dfbd54dfebdde462fd8a6244086a86f5a3e2d2877d52ee3cc4187a3c3
-  data.tar.gz: c5b3d107db58545e5eafadf8ab09c87e834af608ba8294ae857cb15abb16eb6ec3079eff290cb8f04322c7a3b66bdf4fad0ecf6d2a81af57d0dcc9727feacebf
+  metadata.gz: 1487eb6356e82eccf6b8584b0a7074fb8af3ef893b74bbda50b1e4087fdb35132e84c8eb44801f376f504b44e6d80e7fcb1a45cdf4a8520c49ad08c148659d2d
+  data.tar.gz: 61838248219a84def621b1136da25ac25a93404a35cd67d8e2435e3ec16d84873862e52453293fa22f3c8cb73382e2ee5a259057c7b295207e0edaec31e1c724

data/lib/finapps_core/rest/configuration.rb

@@ -11,10 +11,11 @@ module FinAppsCore
                     :log_level, :request_id, :consumer_id, :tenant_id
 
       def initialize(options = {})
-        FinAppsCore::REST::Defaults::DEFAULTS.merge(remove_empty_options(options))
-                                             .each {|key, value| public_send("#{key}=", value) }
-        fail_invalid_host
+        assign_attributes FinAppsCore::REST::Defaults::DEFAULTS
+          .merge(options.compact)
         fail_invalid_timeout
+        fail_invalid_host
+        @host = @host.chomp('/')
       end
 
       def valid_user_credentials?
@@ -23,6 +24,27 @@ module FinAppsCore
 
       private
 
+      def assign_attributes(new_attributes)
+        unless new_attributes.respond_to?(:each_pair)
+          fail ArgumentError, 'When assigning attributes, '\
+            "you must pass a hash argument, #{new_attributes.class} passed."
+        end
+        return if new_attributes.empty?
+
+        _assign_attributes new_attributes
+      end
+
+      def _assign_attributes(attributes)
+        attributes.each {|key, value| _assign_attribute(key, value) }
+      end
+
+      def _assign_attribute(key, value)
+        setter = :"#{key}="
+        fail UnknownAttributeError.new(self, key.to_s) unless respond_to?(setter)
+
+        public_send(setter, value)
+      end
+
       def fail_invalid_host
         return if valid_host?
 
@@ -40,10 +62,6 @@ module FinAppsCore
       def valid_host?
         host.start_with?('http://', 'https://')
       end
-
-      def remove_empty_options(hash)
-        hash.compact
-      end
     end
   end
 end

data/lib/finapps_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinAppsCore
-  VERSION = '5.0.13'
+  VERSION = '5.0.14'
 end

data/spec/rest/configuration_spec.rb

@@ -4,33 +4,59 @@ require 'finapps_core/error'
 
 RSpec.describe FinAppsCore::REST::Configuration do
   describe '#new' do
+    expected_error = FinAppsCore::InvalidArgumentsError
+    default_host = FinAppsCore::REST::Defaults::DEFAULTS[:host]
+    default_timeout = FinAppsCore::REST::Defaults::DEFAULTS[:timeout]
+
     context 'with invalid timeout configuration' do
-      subject(:configuration) { described_class.new(timeout: 'whatever') }
+      subject(:configuration) { described_class.new(timeout: 'foo') }
 
-      expected_error = FinAppsCore::InvalidArgumentsError
-      it { expect { configuration }.to raise_error(expected_error, 'Invalid argument. {timeout: whatever}') }
+      it {
+        expect { configuration }
+          .to raise_error(expected_error, 'Invalid argument. {timeout: foo}')
+      }
     end
 
     context 'with missing timeout configuration' do
       subject(:configuration) { described_class.new(timeout: nil) }
 
       it 'has a default timeout value' do
-        expect(configuration.timeout).to eq(FinAppsCore::REST::Defaults::DEFAULTS[:timeout])
+        expect(configuration.timeout).to eq(default_timeout)
       end
     end
 
     context 'with invalid host configuration' do
-      subject(:configuration) { described_class.new(host: 'whatever') }
+      subject(:configuration) { described_class.new(host: 'foo') }
 
-      expected_error = FinAppsCore::InvalidArgumentsError
-      it { expect { configuration }.to raise_error(expected_error, 'Invalid argument. {host: whatever}') }
+      it do
+        expect { configuration }
+          .to raise_error(expected_error, 'Invalid argument. {host: foo}')
+      end
+    end
+
+    context 'with valid host configuration' do
+      subject(:configuration) { described_class.new(host: 'https://api.com/') }
+
+      it 'the default host value is not used' do
+        expect(configuration.host).not_to eq(default_host)
+      end
+
+      it 'the provided host value is assigned to host' do
+        expect(configuration.host).to include('https://api.com')
+      end
+
+      context 'when given host value ends on /' do
+        it 'the / character is removed' do
+          expect(configuration.host).not_to end_with('/')
+        end
+      end
     end
 
     context 'with missing host configuration' do
       subject(:configuration) { described_class.new(host: nil) }
 
       it 'has a default host value' do
-        expect(configuration.host).to eq(FinAppsCore::REST::Defaults::DEFAULTS[:host])
+        expect(configuration.host).to eq(default_host)
       end
     end
   end
@@ -43,7 +69,9 @@ RSpec.describe FinAppsCore::REST::Configuration do
     end
 
     context 'when user credentials were set' do
-      subject(:configuration) { described_class.new(user_identifier: 1, user_token: 2) }
+      subject(:configuration) do
+        described_class.new(user_identifier: 1, user_token: 2)
+      end
 
       it { expect(configuration.valid_user_credentials?).to eq(true) }
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 5.0.13
+  version: 5.0.14
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-19 00:00:00.000000000 Z
+date: 2021-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -357,21 +357,21 @@ signing_key:
 specification_version: 4
 summary: FinApps REST API ruby client - Core.
 test_files:
-- spec/rest/resources_spec.rb
-- spec/rest/defaults_spec.rb
-- spec/rest/credentials_spec.rb
-- spec/rest/base_client_spec.rb
-- spec/rest/configuration_spec.rb
-- spec/support/fake_api.rb
+- spec/spec_helpers/client.rb
 - spec/spec_helper.rb
+- spec/core_extensions/object/is_integer_spec.rb
 - spec/utils/validatable_spec.rb
-- spec/spec_helpers/client.rb
-- spec/middleware/request/request_id_spec.rb
-- spec/middleware/request/x_consumer_id_spec.rb
-- spec/middleware/request/user_agent_spec.rb
-- spec/middleware/request/tenant_authentication_spec.rb
-- spec/middleware/request/x_tenant_id_spec.rb
+- spec/support/fake_api.rb
 - spec/middleware/request/no_encoding_basic_authentication_spec.rb
+- spec/middleware/request/x_tenant_id_spec.rb
+- spec/middleware/request/tenant_authentication_spec.rb
 - spec/middleware/request/accept_json_spec.rb
+- spec/middleware/request/user_agent_spec.rb
+- spec/middleware/request/x_consumer_id_spec.rb
+- spec/middleware/request/request_id_spec.rb
 - spec/middleware/response/raise_error_spec.rb
-- spec/core_extensions/object/is_integer_spec.rb
+- spec/rest/credentials_spec.rb
+- spec/rest/defaults_spec.rb
+- spec/rest/configuration_spec.rb
+- spec/rest/resources_spec.rb
+- spec/rest/base_client_spec.rb