finapps_core 4.0.7 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f22a7b4ea00e31d4b111da67bac58c9f057f9ccad140bc5c289ac55c6642388
-  data.tar.gz: 89d7b307b99b69caab32bf77651b212fe06284d937357b9bdf1d2218675b70cd
+  metadata.gz: 66532598858848d452cd425fd460cd1392b62a5315a6ee063e9e76640b6d501b
+  data.tar.gz: 2448252963e535c66805d07334b0e481aa7e9d69a479b00014e91c7c5fbd9b10
 SHA512:
-  metadata.gz: 6f0d053e0133325452023e22b22f4817036625b367a5cb9e4762be5e85e8d4baa8c1705a73712a426ced1918c20bbd67d13adefa5e395c60a8089b4eb1624e09
-  data.tar.gz: 4d43a2719972ae4b7468844d691d5c5ba6f9ceeb28bd125500fbf025011a197e5bddb7c411ed3bfadd941953b80ba622a672f3806fb8bdaa12861b7978490a1c
+  metadata.gz: bcc33e1bb69f5408589506949c0f7362b75dd4dbed688ad4d5ebff6119f9f895fce1b6f70c9cf9ae2acf2d77573380c9e3d969c39135f3923541afb233fd80ae
+  data.tar.gz: 62560fb19987c18da9e0b2b16b004271f18ccf4d85dd5cb1af46456116d94e30759e0478c3e07301eaf3cbae397d06b4d3416edc0cebcf791cfb7948dcd2e6eb

data/.gitignore

@@ -1,54 +1,30 @@
-*.gem
-*.rbc
-/.config
-/coverage/
-/InstalledFiles
-/pkg/
-/spec/reports/
 /spec/examples.txt
-/test/tmp/
-/test/version_tmp/
-/tmp/
-Gemfile.lock
-
-# Used by dotenv library to load environment variables.
-# .env
-
-## Specific to RubyMotion:
-.dat*
-.repl_history
-build/
-*.bridgesupport
-build-iPhoneOS/
-build-iPhoneSimulator/
-
-## Specific to RubyMotion (use of CocoaPods):
-#
-# We recommend against adding the Pods directory to your .gitignore. However
-# you should judge for yourself, the pros and cons are mentioned at:
-# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
-#
-# vendor/Pods/
-
-## Documentation cache and generated files:
-/.yardoc/
-/_yardoc/
-/doc/
-/rdoc/
-
-## Environment normalization:
-/.bundle/
-/vendor/bundle
-/lib/bundler/man/
-
-# for a library or gem, you might want to ignore these files since the code is
-# intended to run in multiple environments; otherwise, check them in:
-# -Gemfile.lock
-# .ruby-version
-# .ruby-gemset
-
-# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
-.rvmrc
-
-# Rubymine
+coverage/
+*.gem
+.config
+lib/bundler/man
+pkg
+rdoc
+*.bundle
+*.so
+*.o
+*.a
+mkmf.log
+
+
+# Ignore bundler config.
+/.bundle
+/vendor/bundle/
+/vendor/ruby/
+
+# Ignore all log files and tempfiles.
+/log/*
+!/log/.keep
+/tmp
+
+# various artifacts
+.project
+.secret
 .idea/
+/spec/tmp/*
+/Gemfile.lock

data/.gitlab-ci.yml

@@ -0,0 +1,11 @@
+test:
+  stage: test
+  script:
+    - apt-get update -qy
+    - gem update --system
+    - "echo 'gem: --no-document' > ~/.gemrc"
+    - gem install bundler
+    - bundle install --path /cache
+    - bundle exec rspec
+include:
+  template: Dependency-Scanning.gitlab-ci.yml

data/.rubocop.yml

@@ -1,12 +1,6 @@
-Rails:
-  Enabled: true
-
 AllCops:
   DisplayCopNames: true
   Exclude:
-    - "vendor/**/*"
-    - "db/schema.rb"
-    - "bin/**/*"
     - "finapps_core.gemspec"
   UseCache: false
 
@@ -43,13 +37,13 @@ Naming/PredicateName:
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
   Enabled: true
   NamePrefix:
-  - is_
-  - has_
-  - have_
+    - is_
+    - has_
+    - have_
   NamePrefixBlacklist:
-  - is_
+    - is_
   Exclude:
-  - spec/**/*
+    - spec/**/*
 Metrics/AbcSize:
   Description: A calculated magnitude based on number of assignments, branches, and
     conditions.
@@ -104,4 +98,4 @@ Style/VariableInterpolation:
 Lint/HandleExceptions:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
-  Enabled: false
+  Enabled: false

data/.ruby-version

@@ -1 +1 @@
-ruby-2.5.1
+ruby-2.6.3

data/.travis.yml

@@ -1,14 +1,21 @@
+sudo: false
 language: ruby
-cache: bundler
+cache:
+  bundler: true
+
 rvm:
-  - 2.5.1
+  - 2.5
+  - 2.6
+  - ruby-head
+
 before_install:
-  - "echo 'gem: --no-ri --no-rdoc' > ~/.gemrc"
+  - "echo 'gem: --no-document' > ~/.gemrc"
   - gem update --system
-  - gem --version
-  - gem install bundler -v "~>1.0"
+  - gem install bundler -v "~>2.0"
+
 script:
   - bundle exec rspec
+
 notifications:
   email: false
   slack: financialapps:fA8XwEcap3hHZk0iNmPPJvT1

data/README.md

@@ -2,11 +2,10 @@
 FinApps Ruby-Client-Core
 ========================
 
-[![Gem Version](https://badge.fury.io/rb/finapps_core.svg)](https://badge.fury.io/rb/finapps_core)
+[![Gem Version](https://img.shields.io/gem/v/finapps_core.svg)](https://rubygems.org/gems/finapps_core)
 [![Build Status](https://travis-ci.org/finapps/ruby-client-core.svg?branch=master)](https://travis-ci.org/finapps/ruby-client-core)
 [![Code Climate](https://codeclimate.com/github/finapps/ruby-client-core/badges/gpa.svg)](https://codeclimate.com/github/finapps/ruby-client-core)
 [![Test Coverage](https://codeclimate.com/github/finapps/ruby-client-core/badges/coverage.svg)](https://codeclimate.com/github/finapps/ruby-client-core/coverage)
-[![Dependency Status](https://gemnasium.com/badges/github.com/finapps/ruby-client-core.svg)](https://gemnasium.com/github.com/finapps/ruby-client-core)
 [![License](http://img.shields.io/:license-mit-blue.svg?style=flat-square)](http://finapps.mit-license.org)
 
 Common library for Ruby clients.

data/finapps_core.gemspec

@@ -24,15 +24,16 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency     'faraday_middleware',         '~> 0.12',  '>= 0.12.2'
   spec.add_runtime_dependency     'rash_alt',                   '~> 0.4',   '>= 0.4.7'
 
-  spec.add_development_dependency 'bundler',                    '~> 1.16',  '>= 1.16.6'
+  spec.add_development_dependency 'bundler',                    '~> 2.0', '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
-  spec.add_development_dependency 'gem-release',                '~> 2.0',   '>= 2.0.1'
-  spec.add_development_dependency 'rake',                       '~> 12.3',  '>= 12.3.1'
+  spec.add_development_dependency 'gem-release',                '~> 2.0',   '>= 2.0.3'
+  spec.add_development_dependency 'rake',                       '~> 12.3',  '>= 12.3.2'
   spec.add_development_dependency 'rspec',                      '~> 3.8',   '>= 3.8.0'
-  spec.add_development_dependency 'rubocop',                    '~> 0.59',  '>= 0.59.2'
-  spec.add_development_dependency 'rubocop-rspec',              '~> 1.30',  '>= 1.30.0'
-  spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.4'
-  spec.add_development_dependency 'webmock',                    '~> 3.4',   '>= 3.4.2'
+  spec.add_development_dependency 'rubocop',                    '~> 0.73',  '>= 0.73.0'
+  spec.add_development_dependency 'rubocop-performance',        '~> 1.4',   '>= 1.4.0'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 1.33',  '>= 1.33.0'
+  spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.5'
+  spec.add_development_dependency 'webmock',                    '~> 3.6',   '>= 3.6.0'
 
   spec.extra_rdoc_files = %w(README.md LICENSE)
   spec.rdoc_options = %w(--line-numbers --inline-source --title finapps-ruby-core --main README.md)

data/lib/finapps_core/rest/base_client.rb

@@ -89,14 +89,14 @@ module FinAppsCore
 
         begin
           response = execute_method path, method, params
-        rescue FinAppsCore::InvalidArgumentsError => error
-          handle_error error
-        rescue FinAppsCore::MissingArgumentsError => error
-          handle_error error
-        rescue Faraday::Error::ConnectionFailed => error
-          handle_error error
-        rescue Faraday::Error::ClientError => error
-          errors = handle_client_error(error)
+        rescue FinAppsCore::InvalidArgumentsError => e
+          handle_error e
+        rescue FinAppsCore::MissingArgumentsError => e
+          handle_error e
+        rescue Faraday::Error::ConnectionFailed => e
+          handle_error e
+        rescue Faraday::Error::ClientError => e
+          errors = handle_client_error(e)
         end
 
         [response, errors]

data/lib/finapps_core/rest/defaults.rb

@@ -5,11 +5,11 @@ require 'logger'
 module FinAppsCore
   module REST
     module Defaults
-      API_VERSION = '3'
+      API_VERSION = '4'
 
       # noinspection SpellCheckingInspection
       DEFAULTS = {
-        host: 'https://api.financialapps.com',
+        host: 'https://api.finclear.io',
         timeout: 30,
         proxy: nil,
         log_level: Logger::INFO

data/lib/finapps_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinAppsCore
-  VERSION = '4.0.8'
+  VERSION = '5.0.0'
 end

data/lib/tasks/releaser.rake

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 
 desc 'Bumps the version to the next patch level, tags and pushes the code to
-origin repository and releases the gem. BOOM!'
-
-# https://github.com/svenfuchs/gem-release
+origin repository'
+task :bump do
+  system 'gem bump --tag --push --skip-ci'
+end
 
+desc 'Releases the gem and pushes any tags to the origin repository'
 task :release do
-  system 'gem bump --tag --release'
+  system 'gem release --push'
 end

data/spec/rest/defaults_spec.rb

@@ -6,10 +6,10 @@ RSpec.describe FinAppsCore::REST::Defaults do
   describe 'set constants' do
     before { stub_const(described_class.to_s, fake_class) }
 
-    it('sets API_VERSION') { expect(described_class::API_VERSION).to eq '3' }
+    it('sets API_VERSION') { expect(described_class::API_VERSION).to eq '4' }
     it('sets DEFAULTS') { expect(described_class::DEFAULTS).to be_a(Hash) }
     it('freezes DEFAULTS') { expect(described_class::DEFAULTS).to be_frozen }
-    it('sets DEFAULTS[:host]') { expect(described_class::DEFAULTS[:host]).to eq 'https://api.financialapps.com' }
+    it('sets DEFAULTS[:host]') { expect(described_class::DEFAULTS[:host]).to eq 'https://api.finclear.io' }
     it('sets DEFAULTS[:timeout]') { expect(described_class::DEFAULTS[:timeout]).to eq 30 }
     it('does not set DEFAULTS[:proxy]') { expect(described_class::DEFAULTS[:proxy]).to be_nil }
     it('sets DEFAULTS[:log_level]') { expect(described_class::DEFAULTS[:log_level]).to eq Logger::INFO }

data/spec/support/fake_api.rb

@@ -4,26 +4,30 @@ require 'sinatra/base'
 
 # the FakeApi class is used to mock API requests while testing.
 class FakeApi < Sinatra::Base
+  def self.version_path
+    "v#{FinAppsCore::REST::Defaults::API_VERSION}"
+  end
+
   # timeout
-  get('/v3/resources/timeout') { status 419 }
+  get("/#{version_path}/resources/timeout") { status 419 }
 
   # resource
-  post('/v3/resources') { json_response 201, 'resource.json' }
-  get('/v3/resources/:id') { json_response 200, 'resource.json' }
-  get('/v3/resources') { json_response 200, 'resources.json' }
-  put('/v3/resources') { json_response 201, 'resource.json' }
-  delete('/v3/resources/:id') { status 202 }
+  post("/#{version_path}/resources") { json_response 201, 'resource.json' }
+  get("/#{version_path}/resources/:id") { json_response 200, 'resource.json' }
+  get("/#{version_path}/resources") { json_response 200, 'resources.json' }
+  put("/#{version_path}/resources") { json_response 201, 'resource.json' }
+  delete("/#{version_path}/resources/:id") { status 202 }
 
   # version
-  get('/v3/version') { 'Version => 2.1.29-.20161208.172810' }
+  get("/#{version_path}/version") { 'Version => 2.1.29-.20161208.172810' }
 
   # errors
-  get('/v3/client_error') { json_response 400, 'error.json' }
-  get('/v3/server_error') { status 500 }
-  get('/v3/proxy_error') { status 407 }
+  get("/#{version_path}/client_error") { json_response 400, 'error.json' }
+  get("/#{version_path}/server_error") { status 500 }
+  get("/#{version_path}/proxy_error") { status 407 }
 
   # relevance
-  get('/v3/relevance/ruleset/names') { json_response 200, 'relevance_ruleset_names.json' }
+  get("/#{version_path}/relevance/ruleset/names") { json_response 200, 'relevance_ruleset_names.json' }
 
   private
 
@@ -32,4 +36,6 @@ class FakeApi < Sinatra::Base
     status response_code
     File.open(File.dirname(__FILE__) + '/fixtures/' + file_name, 'rb').read
   end
+
+  def version; end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 4.0.7
+  version: 5.0.0
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-11 00:00:00.000000000 Z
+date: 2019-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -76,20 +76,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.16.6
+        version: 2.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.16.6
+        version: 2.0.2
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -119,7 +119,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 2.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -129,7 +129,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 2.0.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -139,7 +139,7 @@ dependencies:
         version: '12.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.3.1
+        version: 12.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -149,67 +149,87 @@ dependencies:
         version: '12.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.3.1
+        version: 12.3.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.8'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.8.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.8'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.8.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.59'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.59.2
+        version: 0.73.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.73'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.73.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.59'
+        version: '0.73'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.59.2
+        version: 1.4.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.4.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.30'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.33.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.33'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.30'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.33.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.33'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -219,7 +239,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.4
+        version: 2.0.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -229,27 +249,27 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.4
+        version: 2.0.5
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.2
+        version: 3.6.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.2
+        version: 3.6.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.6'
 description: A simple library for communicating with the FinApps REST API. Core functionality.
 email:
 - erich@financialapps.com
@@ -261,6 +281,7 @@ extra_rdoc_files:
 files:
 - ".codeclimate.yml"
 - ".gitignore"
+- ".gitlab-ci.yml"
 - ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
@@ -340,8 +361,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client - Core.