finapps_core 4.0.4 → 4.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32d0222212c94c51e4c6ca4dbd982102d7a5ce46fbde1fa540cad0731a7fc1cb
-  data.tar.gz: 7447225fa3227bd95c27689e05453ea22b4e9e9a86b114e06d8563e8289a363a
+  metadata.gz: eba98fc6c3a8244d55bb5df6cdf3b7f6d801ca3616832d7d5212a457bc89ae00
+  data.tar.gz: 7a25c2e816c3d042db423f352281576a33d78c16508a78ce777b9d1846475b1d
 SHA512:
-  metadata.gz: 11256723cabf356e93c849148957f17c906186fae6af8009e0c6937d57b37511f15dc75e4cdd2ba7359328f1a6e96731f9d5df09dd99c642074e886738e56a9e
-  data.tar.gz: e4d58a7b71d21bde18cdf1036bd638cc950f6b8f89caa515ae7cb5b07d67256c0ed0765d4c69c78dc6590be219775e1524cc9921b3f725f596404b134173168b
+  metadata.gz: 721f6b53b469d6a438bfeeb480f40cfb93f3ce1623859cc48275557c6db20201aea9fa2b519317ad1bd799b2ca98dbb639bf05e070b5c2672ae1ebc865db8703
+  data.tar.gz: 0e1056a5f6c0dd3a821c37d40d883422abe8f7a9faadac948964c909e95dbffad11d142cb5376143d6e63dee202b6b8cf4ecd1fd16a08032603fd91e0290b9c5

data/finapps_core.gemspec

@@ -30,6 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake',                       '~> 12.3',  '>= 12.3.1'
   spec.add_development_dependency 'rspec',                      '~> 3.8',   '>= 3.8.0'
   spec.add_development_dependency 'rubocop',                    '~> 0.59',  '>= 0.59.2'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 1.30',  '>= 1.30.0'
   spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.4'
   spec.add_development_dependency 'webmock',                    '~> 3.4',   '>= 3.4.2'
 

data/lib/finapps_core/error.rb

@@ -14,6 +14,9 @@ module FinAppsCore # :nodoc:
   # Raised whenever there is a session timeout at the API.
   class ApiSessionTimeoutError < Error; end
 
+  # Raised whenever the session is invalid or does not exist at the API.
+  class ApiUnauthenticatedError < Error; end
+
   # Raised whenever the request specify an unsupported HTTP method.
   class UnsupportedHttpMethodError < Error; end
 

data/lib/finapps_core/middleware/response/raise_error.rb

@@ -6,28 +6,26 @@ using StringExtensions
 module FinAppsCore
   module Middleware
     class RaiseError < Faraday::Response::Middleware # :nodoc:
-      SUCCESS_STATUSES = 200..299
+      SUCCESS_STATUSES = (200..299).freeze
+      API_UNAUTHENTICATED = 401
       CONNECTION_FAILED_STATUS = 407
       API_SESSION_TIMEOUT = 419
 
       def on_complete(env)
         return if SUCCESS_STATUSES.include?(env[:status])
 
-        if env[:status] == API_SESSION_TIMEOUT
-          raise(FinAppsCore::Error::ApiSessionTimeoutError, 'API Session Timed out')
-        end
-        if env[:status] == CONNECTION_FAILED_STATUS
-          raise(FinAppsCore::Error::ConnectionFailedError, 'Connection Failed')
-        end
+        raise(FinAppsCore::ApiUnauthenticatedError, 'API Invalid Session') if env[:status] == API_UNAUTHENTICATED
+        raise(FinAppsCore::ApiSessionTimeoutError, 'API Session Timed out') if env[:status] == API_SESSION_TIMEOUT
+        raise(FinAppsCore::ConnectionFailedError, 'Connection Failed') if env[:status] == CONNECTION_FAILED_STATUS
 
         raise(Faraday::Error::ClientError, response_values(env))
       end
 
       def response_values(env)
         {
-          status:         env.status,
-          headers:        env.response_headers,
-          body:           env.body,
+          status: env.status,
+          headers: env.response_headers,
+          body: env.body,
           error_messages: error_messages(env.body)
         }
       end

data/lib/finapps_core/rest/defaults.rb

@@ -9,10 +9,10 @@ module FinAppsCore
 
       # noinspection SpellCheckingInspection
       DEFAULTS = {
-        host:             'https://api.financialapps.com',
-        timeout:          30,
-        proxy:            nil,
-        log_level:        Logger::INFO
+        host: 'https://api.financialapps.com',
+        timeout: 30,
+        proxy: nil,
+        log_level: Logger::INFO
       }.freeze
     end
   end

data/lib/finapps_core/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinAppsCore
-  VERSION = '4.0.4'
+  VERSION = '4.0.6'
 end

data/spec/middleware/response/raise_error_spec.rb

@@ -11,9 +11,14 @@ RSpec.describe FinAppsCore::Middleware::RaiseError do
       let(:env) { Env.new(200) }
       it { expect { subject.on_complete(env) }.not_to raise_error }
     end
-    context 'for client errors' do
+    context 'for invalid session errors' do
       let(:env) { Env.new(401, {}, '{"messages":["Invalid User Identifier or Credentials"]}') }
-      error_message = 'the server responded with status 401'
+      error_message = 'API Invalid Session'
+      it { expect { subject.on_complete(env) }.to raise_error(FinAppsCore::ApiUnauthenticatedError, error_message) }
+    end
+    context 'for client errors' do
+      let(:env) { Env.new(404, {}, '{"messages":["Resource Not Found"]}') }
+      error_message = 'the server responded with status 404'
       it { expect { subject.on_complete(env) }.to raise_error(Faraday::Error::ClientError, error_message) }
     end
     context 'for connection failed error' do
@@ -21,7 +26,7 @@ RSpec.describe FinAppsCore::Middleware::RaiseError do
       error_message = 'Connection Failed'
       it { expect { subject.on_complete(env) }.to raise_error(FinAppsCore::ConnectionFailedError, error_message) }
     end
-    context 'for connection failed error' do
+    context 'for session timeout error' do
       let(:env) { Env.new(419) }
       error_message = 'API Session Timed out'
       it { expect { subject.on_complete(env) }.to raise_error(FinAppsCore::ApiSessionTimeoutError, error_message) }

data/spec/spec_helper.rb

@@ -37,4 +37,4 @@ RSpec.configure do |config|
 end
 
 VALID_CREDENTIALS = { identifier: '49fb918d-7e71-44dd-7378-58f19606df2a',
-                      token:      'hohoho=' }.freeze
+                      token: 'hohoho=' }.freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.0.5
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-15 00:00:00.000000000 Z
+date: 2018-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -190,6 +190,26 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.59.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.30.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.30.0
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -321,24 +341,24 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client - Core.
 test_files:
-- spec/rest/defaults_spec.rb
-- spec/rest/base_client_spec.rb
+- spec/middleware/response/raise_error_spec.rb
+- spec/middleware/request/user_agent_spec.rb
+- spec/middleware/request/no_encoding_basic_authentication_spec.rb
+- spec/middleware/request/request_id_spec.rb
+- spec/middleware/request/tenant_authentication_spec.rb
+- spec/middleware/request/accept_json_spec.rb
 - spec/rest/credentials_spec.rb
 - spec/rest/configuration_spec.rb
+- spec/rest/defaults_spec.rb
+- spec/rest/base_client_spec.rb
 - spec/rest/resources_spec.rb
-- spec/support/fake_api.rb
 - spec/utils/validatable_spec.rb
-- spec/spec_helpers/client.rb
+- spec/support/fake_api.rb
 - spec/spec_helper.rb
 - spec/core_extensions/object/is_integer_spec.rb
-- spec/middleware/request/no_encoding_basic_authentication_spec.rb
-- spec/middleware/request/user_agent_spec.rb
-- spec/middleware/request/tenant_authentication_spec.rb
-- spec/middleware/request/accept_json_spec.rb
-- spec/middleware/request/request_id_spec.rb
-- spec/middleware/response/raise_error_spec.rb
+- spec/spec_helpers/client.rb