finapps_core 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f37837d2b8bcb2f90e068539256a41ec589530ec
-  data.tar.gz: b05a2cb8fb0c36e4764392a78fe13d8ef80ea39d
+  metadata.gz: 393d3128a7c11cf6c09f606ad1a330a96b005857
+  data.tar.gz: 944722feeedee32d4d2e20f32ce9c6fb70b8d6f2
 SHA512:
-  metadata.gz: 715a1bda039a60ce2fe8a2e8ba09a0a37354dbd2734f122e76889007541e3150f34534c9318d9f2aca490b651028cb1568a603ef76c515768e4a2088a1c7d284
-  data.tar.gz: 7e168a213eb4fccf532934eaac25147d4c4b7e62d101b19a5a4d5528676166ededa8c661e874d5332c41096aa0feb7fd8d4251ae378f7395e0b60e83670796ab
+  metadata.gz: 7c6b157cddb7120e43819c0928059e4e6afb607c41485079b2a75f847fd3ee91a9d1e91620bde7ac8628d8ab11df0d8061ec2a2d0a1aa6ada5f01a313f65b9ee
+  data.tar.gz: 76fdaca3c806008470b02a94781ebbf83e815eb891443ea49eeb5487579f4bc8a59c48483dd80057dd1e1f2bef55612256ad388d0549d1e13b1ae0b1f4f1a531

data/.travis.yml

@@ -12,3 +12,5 @@ notifications:
 addons:
   code_climate:
     repo_token: 5a8d194cbc23aa4c171e3478e3b6bbea9dd96041071380ec25bf80c07770b39a
+after_success:
+  - bundle exec codeclimate-test-reporter

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    finapps_core (2.0.2)
+    finapps_core (2.0.3)
       faraday (~> 0.11, >= 0.11.0)
       faraday_middleware (~> 0.11, >= 0.11.0)
       rash (~> 0.4, >= 0.4.0)

data/lib/finapps_core/error.rb

@@ -3,15 +3,24 @@
 module FinAppsCore # :nodoc:
   # Base error class.
   class Error < StandardError; end
+
   # Raised for existing but invalid arguments.
   class InvalidArgumentsError < Error; end
+
   # Raised whenever a required argument is missing.
   class MissingArgumentsError < Error; end
 
   # Raised whenever there is a session timeout at the API.
   class ApiSessionTimeoutError < Error; end
 
-  %i(InvalidArgumentsError MissingArgumentsError ApiSessionTimeoutError).each do |const|
+  # Raised whenever the request specify an unsupported HTTP method.
+  class UnsupportedHttpMethodError < Error; end
+
+  # Raised whenever the connection fails.
+  class ConnectionFailedError < Error; end
+
+  %i(InvalidArgumentsError MissingArgumentsError ApiSessionTimeoutError
+     UnsupportedHttpMethodError ConnectionFailedError).each do |const|
     Error.const_set(const, FinAppsCore.const_get(const))
   end
 end

data/lib/finapps_core/middleware/response/raise_error.rb

@@ -15,7 +15,7 @@ module FinAppsCore
         if env[:status] == API_SESSION_TIMEOUT
           raise(FinAppsCore::Error::ApiSessionTimeoutError, 'Api Session Timed out')
         elsif env[:status] == CONNECTION_FAILED_STATUS
-          raise(Faraday::Error::ConnectionFailed, '407 "Proxy Authentication Required"')
+          raise(FinAppsCore::Error::ConnectionFailedError, 'Connection Failed')
         else
           raise(Faraday::Error::ClientError, response_values(env))
         end

data/lib/finapps_core/rest/base_client.rb

@@ -73,9 +73,6 @@ module FinAppsCore
 
         begin
           response = execute_method path, method, params
-
-        rescue FinAppsCore::ApiSessionTimeoutError => error
-          handle_error(error)
         rescue FinAppsCore::InvalidArgumentsError => error
           handle_error error
         rescue FinAppsCore::MissingArgumentsError => error
@@ -110,7 +107,7 @@ module FinAppsCore
         when :delete
           delete(path, params)
         else
-          raise FinAppsCore::InvalidArgumentsError.new "Method not supported: #{method}."
+          raise FinAppsCore::UnsupportedHttpMethodError.new "Method not supported: #{method}."
         end
       end
     end

data/lib/finapps_core/utils/loggeable.rb

@@ -6,7 +6,7 @@ module FinAppsCore
       def logger
         @logger ||= begin
           require 'logger'
-          ::Logger.new(STDOUT)
+          Logger.new(STDOUT).tap {|log| log.level = Logger::FATAL }
         end
       end
     end

data/lib/finapps_core/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinAppsCore
-  VERSION = '2.0.3'
+  VERSION = '2.0.4'
 end

data/spec/rest/base_client_spec.rb

@@ -30,7 +30,7 @@ RSpec.describe FinAppsCore::REST::BaseClient do
 
   describe '#send_request' do
     it 'should raise FinAppsCore::InvalidArgumentsError if method is NOT supported' do
-      expect { subject.send_request('fake_path', :option) }.to raise_error(FinAppsCore::InvalidArgumentsError,
+      expect { subject.send_request('fake_path', :option) }.to raise_error(FinAppsCore::UnsupportedHttpMethodError,
                                                                            'Method not supported: option.')
     end
 
@@ -53,15 +53,6 @@ RSpec.describe FinAppsCore::REST::BaseClient do
         expect(subject.size).to eq(return_array.length)
       end
 
-      context 'for unsupported methods' do
-        subject { FinAppsCore::REST::BaseClient.new(valid_tenant_options).send_request('users', :options) }
-
-        it do
-          expect { subject.send_request(nil, :get) }
-            .to raise_error(FinAppsCore::InvalidArgumentsError, 'Method not supported: options.')
-        end
-      end
-
       context 'for client errors' do
         subject { FinAppsCore::REST::BaseClient.new(valid_tenant_options).send_request('client_error', :get) }
 
@@ -81,15 +72,13 @@ RSpec.describe FinAppsCore::REST::BaseClient do
 
       context 'for proxy errors' do
         subject { FinAppsCore::REST::BaseClient.new(valid_tenant_options).send_request('proxy_error', :get) }
-
-        it { expect { subject }.to raise_error(Faraday::ConnectionFailed, '407 "Proxy Authentication Required"') }
+        it { expect { subject }.to raise_error(FinAppsCore::ConnectionFailedError, 'Connection Failed') }
       end
     end
 
     context 'if a block is provided' do
-      it('gets executed on the response') do
-        expect(subject.send_request('relevance/ruleset/names', :get, &:status)[RESPONSE]).to eq(200)
-        expect(subject.send_request('relevance/ruleset/names', :get) {|r| r.body.length }[RESPONSE]).to eq(45)
+      it('gets executed on the response and returned as the result') do
+        expect(subject.send_request('relevance/ruleset/names', :get) {|r| r.body.length }).to eq([45, []])
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 if ENV['CODECLIMATE_REPO_TOKEN']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
+  # require 'codeclimate-test-reporter'
+  # CodeClimate::TestReporter.start
+  require 'simplecov'
+  SimpleCov.start
 end
 
 require 'bundler/setup'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-07 00:00:00.000000000 Z
+date: 2017-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday