finapps_core 2.0.15 → 2.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13f4ba86a94de3e1ca4e6aff4ce2cf64dfbbb423
-  data.tar.gz: ca6db24c7d989854b484e200efcc4d97aff7dd83
+  metadata.gz: e8289131ef370466de3c40eb0cc59b57bc827fe3
+  data.tar.gz: 1db42e4b79ba6cb447a25de5123f94f38a287d54
 SHA512:
-  metadata.gz: ecf9432bd8c9000dc9a7558d631d07b1a667d76ad60f999e0b755953af7cc24c15f0159c3be0c1f558afe45f003659472849cd321ecfa308df3841efa2f7e0e1
-  data.tar.gz: ee47b4f66598ecefb87921ec2c2b4cb1a1b3b608a85ac4aad1808120123faaf8408defbb02bf07595151c8a3d8e5e36254ede7e78da4b07aef33c27d545200de
+  metadata.gz: 5b04fa8f805fe745ebe92066a91a62d045b0498a21376afb4607bdfc576cd1e0b2ef3427e02cb9a420afd2cdf8aceea876339a01d9464cebccfb0ba9eba4b4b0
+  data.tar.gz: 12a997ffd3eee2e90d47efd9088f02295c7519be4f4299a95fe3a6d13f4f4d741008569618dbd2405567ad773f8c7cc73aa95ec384abfc82998a8655fd577446

data/lib/finapps_core/middleware/response/raise_error.rb

@@ -33,7 +33,7 @@ module FinAppsCore
       private
 
       def error_messages(body)
-        return nil if body.blank?
+        return nil if !body || (body.respond_to?(:empty?) && body.empty?)
         body = body.json_to_hash if body.is_a?(String)
         has_message_key?(body) ? body['messages'] : nil
       end

data/lib/finapps_core/rest/base_client.rb

@@ -72,7 +72,11 @@ module FinAppsCore
       private
 
       def empty?(response)
-        response.blank? || (response.respond_to?(:body) && response.body.blank?)
+        !response || empty_body?(response)
+      end
+
+      def empty_body?(response)
+        response.respond_to?(:body) && (!response.body || (response.body.respond_to?(:empty?) && response.body.empty?))
       end
 
       def execute_request(path, method, params)
@@ -100,7 +104,7 @@ module FinAppsCore
 
       def handle_client_error(error)
         logger.warn "#{self.class}##{__method__} => #{error.class.name}, #{error}"
-        error.response.present? && error.response[:error_messages] ? error.response[:error_messages] : [error.message]
+        error.response && error.response[:error_messages] ? error.response[:error_messages] : [error.message]
       end
 
       def execute_method(path, method, params)

data/lib/finapps_core/rest/credentials.rb

@@ -3,9 +3,6 @@ module FinAppsCore
   module REST
     # represents both tenant and user credentials
     class Credentials
-      using ObjectExtensions
-      using StringExtensions
-
       attr_reader :identifier, :token
 
       def initialize(identifier, token)
@@ -14,7 +11,7 @@ module FinAppsCore
       end
 
       def valid?
-        identifier.present? && token.present?
+        !identifier.nil? && !token.nil?
       end
     end
   end

data/lib/finapps_core/utils/validatable.rb

@@ -7,7 +7,14 @@ module FinAppsCore
     # Adds validation capabilities when included into other classes
     module Validatable
       def not_blank(value, name=nil)
-        raise FinAppsCore::MissingArgumentsError.new "Missing argument#{": #{name}" unless name.nil?}" if value.blank?
+        if nil_or_empty?(value)
+          argument_name = name.nil? ? nil : ": #{name}"
+          raise FinAppsCore::MissingArgumentsError.new "Missing argument#{argument_name}"
+        end
+      end
+
+      def nil_or_empty?(value)
+        !value || (value.respond_to?(:empty) && value.empty?)
       end
     end
   end

data/lib/finapps_core/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinAppsCore
-  VERSION = '2.0.15'
+  VERSION = '2.0.16'
 end

data/lib/finapps_core.rb

@@ -6,7 +6,6 @@ require 'faraday_middleware'
 require 'typhoeus'
 require 'typhoeus/adapters/faraday'
 
-require 'core_extensions/object/blank'
 require 'core_extensions/object/is_integer'
 require 'core_extensions/string/json_to_hash'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps_core
 version: !ruby/object:Gem::Version
-  version: 2.0.15
+  version: 2.0.16
 platform: ruby
 authors:
 - Erich Quintero
@@ -292,7 +292,6 @@ files:
 - README.md
 - Rakefile
 - finapps_core.gemspec
-- lib/core_extensions/object/blank.rb
 - lib/core_extensions/object/is_integer.rb
 - lib/core_extensions/string/json_to_hash.rb
 - lib/finapps_core.rb
@@ -315,7 +314,6 @@ files:
 - lib/finapps_core/utils/validatable.rb
 - lib/finapps_core/version.rb
 - lib/tasks/releaser.rake
-- spec/core_extensions/object/blank_spec.rb
 - spec/core_extensions/object/is_integer_spec.rb
 - spec/middleware/request/accept_json_spec.rb
 - spec/middleware/request/no_encoding_basic_authentication_spec.rb
@@ -378,7 +376,6 @@ test_files:
 - spec/spec_helpers/client.rb
 - spec/spec_helper.rb
 - spec/core_extensions/object/is_integer_spec.rb
-- spec/core_extensions/object/blank_spec.rb
 - spec/middleware/request/no_encoding_basic_authentication_spec.rb
 - spec/middleware/request/user_agent_spec.rb
 - spec/middleware/request/tenant_authentication_spec.rb

data/lib/core_extensions/object/blank.rb

@@ -1,49 +0,0 @@
-# frozen_string_literal: true
-module ObjectExtensions
-  refine Object do
-    # An object is blank if it's false, empty, or a whitespace string.
-    # For example, +false+, '', '   ', +nil+, [], and {} are all blank.
-    #
-    # This simplifies
-    #
-    #   !address || address.empty?
-    #
-    # to
-    #
-    #   address.blank?
-    #
-    # @return [true, false]
-    def blank?
-      respond_to?(:empty?) ? !!empty? : !self
-    end
-
-    # An object is present if it's not blank.
-    #
-    # @return [true, false]
-    def present?
-      !blank?
-    end
-  end
-end
-
-module StringExtensions
-  refine String do
-    BLANK_RE = /\A[[:space:]]*\z/
-
-    # A string is blank if it's empty or contains whitespaces only:
-    #
-    #   ''.blank?       # => true
-    #   '   '.blank?    # => true
-    #   "\t\n\r".blank? # => true
-    #   ' blah '.blank? # => false
-    #
-    # Unicode whitespace is supported:
-    #
-    #   "\u00a0".blank? # => true
-    #
-    # @return [true, false]
-    def blank?
-      match BLANK_RE
-    end
-  end
-end

data/spec/core_extensions/object/blank_spec.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-using ObjectExtensions
-
-RSpec.describe ObjectExtensions do
-  context 'when refining Object' do
-    describe '#blank?' do
-      # An object is blank if it's false, empty, or a whitespace string.
-      context 'for false' do
-        it { expect(false.blank?).to eq(true) }
-      end
-      context 'for empty arrays' do
-        it { expect([].blank?).to eq(true) }
-      end
-      context 'for empty hashes' do
-        it { expect({}.blank?).to eq(true) }
-      end
-      context 'for whitespace string' do
-        it { expect(''.blank?).to eq(true) }
-      end
-    end
-
-    describe '#present?' do
-      # An object is present if it's not blank.
-      context 'for not blank objects' do
-        it { expect(1.present?).to eq(true) }
-      end
-
-      context 'for blank objects' do
-        it { expect(false.present?).to eq(false) }
-      end
-    end
-  end
-end