finapps 2.1.4 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80dcb3297ddc318727b508e5dd4c8579ca7d5787
-  data.tar.gz: bdba2a747847213dbcb20d884c2250377e473821
+  metadata.gz: 5e24643441ce8ebb9cb808fe45de0df630e62ef0
+  data.tar.gz: 88348f3841bc6186ce306ed7a7c9ca4bc72a57d0
 SHA512:
-  metadata.gz: f416f7f0c9968f53bbfb1f5806f59c041ecfead41d400c3bc5c5b5c581c8640473f394d399173fc66d846d165a35ab7e71c92318d641f9008889970ebcbc24ef
-  data.tar.gz: 13583d43451a5ac16ba4a678fa98a608a2f4a4174c64ac5f5c8c97e36b17e49189826d7f09a030869a68500da3e0a3865252b16745df339352bb1b86f9cf4418
+  metadata.gz: e398a685f93991829879dd9146023a31713ae60fd12f928432b0d8a9cf0ba256120bc238d15bfe5227891bd9da7d029c04def2d017824c31d243edc329bd73f4
+  data.tar.gz: 649742621d86978e10804929252dd7aa297d2d8be8860620482e0a03adbd5ecef2e2afdc41600f1ef73600b12b1cf078aa439d6e4c55dddae6184b20a36cfe67

data/.rubocop.yml

@@ -142,29 +142,13 @@ Style/StringLiteralsInInterpolation:
   SupportedStyles:
   - single_quotes
   - double_quotes
-Style/TrailingCommaInArguments:
-  Description: 'Checks for trailing comma in argument lists.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
-  Enabled: false
-  EnforcedStyleForMultiline: no_comma
-  SupportedStyles:
-  - comma
-  - consistent_comma
-  - no_comma
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
-  Enabled: false
-  EnforcedStyleForMultiline: no_comma
-  SupportedStyles:
-  - comma
-  - consistent_comma
-  - no_comma
 Metrics/AbcSize:
   Description: A calculated magnitude based on number of assignments, branches, and
     conditions.
   Enabled: false
   Max: 15
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
 Metrics/ClassLength:
   Description: Avoid classes longer than 100 lines of code.
   Enabled: false

data/.ruby-gemset

@@ -1 +1 @@
-ruby-client-v2
+ruby-client

data/.travis.yml

@@ -1,10 +1,11 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.3.0
   - 2.3.1
 before_install:
-- "echo 'gem: --no-ri --no-rdoc' > ~/.gemrc"
+  - "echo 'gem: --no-ri --no-rdoc' > ~/.gemrc"
+  - gem update --system
+  - gem install bundler
 script:
   - bundle exec rspec
 notifications:
@@ -13,3 +14,5 @@ notifications:
 addons:
   code_climate:
     repo_token: dc180b31d340bd88cedd0ec3ea8ba8ec5093f2bafe77a7bf5bbdcb1c5ff9dc7f
+after_success:
+  - bundle exec codeclimate-test-reporter

data/README.md

@@ -3,7 +3,7 @@ FinApps Ruby-Client
 ===================
 
 [![Gem Version](https://badge.fury.io/rb/finapps.svg)](https://badge.fury.io/rb/finapps)
-[![Build Status](http://img.shields.io/travis/finapps/ruby-client.svg?style=flat-square)](https://travis-ci.org/finapps/ruby-client)
+[![Build Status](https://travis-ci.org/finapps/ruby-client.svg?branch=master)](https://travis-ci.org/finapps/ruby-client)
 [![Code Climate](https://codeclimate.com/github/finapps/ruby-client/badges/gpa.svg)](https://codeclimate.com/github/finapps/ruby-client)
 [![Test Coverage](https://codeclimate.com/github/finapps/ruby-client/badges/coverage.svg)](https://codeclimate.com/github/finapps/ruby-client/coverage)
 [![Dependency Status](https://gemnasium.com/badges/github.com/finapps/ruby-client.svg)](https://gemnasium.com/github.com/finapps/ruby-client)

data/finapps.gemspec

@@ -20,19 +20,17 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'faraday', '~> 0.9', '>= 0.9.2'
-  spec.add_runtime_dependency 'faraday_middleware', '~> 0.10', '>= 0.10.0'
-  spec.add_runtime_dependency 'typhoeus', '~> 1.0', '>= 1.0.2'
-  spec.add_runtime_dependency 'rash', '~> 0.4', '>= 0.4.0'
+  spec.add_runtime_dependency     'finapps_core',               '~> 2.0',   '>= 2.0.11'
 
-  spec.add_development_dependency 'bundler', '~> 1.11', '>= 1.11.2'
-  spec.add_development_dependency 'rake', '~> 11.2', '>= 11.2.2'
-  spec.add_development_dependency 'rspec', '~> 3.4', '>= 3.4.0'
-  spec.add_development_dependency 'webmock', '~> 2.1', '>= 2.1.0'
-  spec.add_development_dependency 'sinatra', '~> 1.4', '>= 1.4.7'
-  spec.add_development_dependency 'simplecov', '~> 0.11', '>= 0.11.2'
-  spec.add_development_dependency 'codeclimate-test-reporter', '~> 0.6.0'
-  spec.add_development_dependency 'rubocop', '0.45.0'
+  spec.add_development_dependency 'bundler',                    '~> 1.14',  '>= 1.14.3'
+  spec.add_development_dependency 'gem-release',                '~> 0.7',   '>= 0.7.4'
+  spec.add_development_dependency 'rake',                       '~> 12.0',  '>= 12.0.0'
+  spec.add_development_dependency 'rspec',                      '~> 3.5',   '>= 3.5.0'
+  spec.add_development_dependency 'webmock',                    '~> 2.3',   '>= 2.3.2'
+  spec.add_development_dependency 'sinatra',                    '~> 1.4',   '>= 1.4.7'
+  spec.add_development_dependency 'simplecov',                  '~> 0.11',  '>= 0.11.2'
+  spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.5'
+  spec.add_development_dependency 'rubocop',                    '~> 0.47',  '>= 0.47.1'
 
   spec.extra_rdoc_files = %w(README.md LICENSE.txt)
   spec.rdoc_options = %w(--line-numbers --inline-source --title finapps-ruby --main README.md)

data/lib/finapps.rb

@@ -6,23 +6,7 @@ require 'faraday_middleware'
 require 'typhoeus'
 require 'typhoeus/adapters/faraday'
 
-require 'core_extensions/hash/compact'
-require 'core_extensions/object/blank'
-require 'core_extensions/object/is_integer'
-require 'core_extensions/string/json_to_hash'
-
-require 'finapps/utils/loggeable'
-require 'finapps/utils/parameter_filter'
-require 'finapps/error'
-
-require 'finapps/middleware/request/tenant_authentication'
-require 'finapps/middleware/request/accept_json'
-require 'finapps/middleware/request/user_agent'
-require 'finapps/middleware/response/raise_error'
-require 'finapps/middleware/middleware'
-
-require 'finapps/rest/defaults'
-require 'finapps/rest/resources'
+require 'finapps_core'
 
 require 'finapps/rest/version'
 require 'finapps/rest/users'
@@ -38,8 +22,8 @@ require 'finapps/rest/order_reports'
 require 'finapps/rest/order_statuses'
 require 'finapps/rest/password_resets'
 
-require 'finapps/rest/configuration'
-require 'finapps/rest/credentials'
-require 'finapps/rest/connection'
-require 'finapps/rest/base_client'
+# require 'finapps/rest/configuration'
+# require 'finapps/rest/credentials'
+# require 'finapps/rest/connection'
+# require 'finapps/rest/base_client'
 require 'finapps/rest/client'

data/lib/finapps/rest/client.rb

@@ -1,75 +1,64 @@
 # frozen_string_literal: true
+require 'finapps_core'
+require_relative './version'
+
 module FinApps
   module REST
-    class Client < BaseClient # :nodoc:
+    class Client < FinAppsCore::REST::BaseClient # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
-      include FinApps::REST::Defaults
+      RESOURCES = %i(
+        institutions
+        institutions_forms
+        orders
+        order_reports
+        order_statuses
+        order_tokens
+        password_resets
+        sessions
+        users
+        user_institutions
+        user_institutions_forms
+        user_institutions_statuses
+        version
+      ).freeze
 
-      # @param [String] tenant_identifier
       # @param [String] tenant_token
       # @param [Hash] options
       # @return [FinApps::REST::Client]
-      def initialize(tenant_identifier, tenant_token, options={}, logger=nil)
-        raise FinApps::MissingArgumentsError.new 'Invalid company_identifier.' if tenant_identifier.blank?
-        raise FinApps::MissingArgumentsError.new 'Invalid company_token.' if tenant_token.blank?
+      def initialize(tenant_token, options={}, logger=nil)
+        not_blank(tenant_token, :tenant_token)
 
-        merged_options = FinApps::REST::Defaults::DEFAULTS.merge(options.merge(tenant_identifier: tenant_identifier,
-                                                                               tenant_token: tenant_token))
+        merged_options = options.merge(tenant_token: tenant_token)
         super(merged_options, logger)
       end
 
-      def version
-        @version ||= FinApps::REST::Version.new self
-      end
-
-      def users
-        @users ||= FinApps::REST::Users.new self
-      end
-
-      def sessions
-        @sessions ||= FinApps::REST::Sessions.new self
-      end
-
-      def order_tokens
-        @order_tokens ||= FinApps::REST::OrderTokens.new self
-      end
-
-      def orders
-        @orders ||= FinApps::REST::Orders.new self
-      end
-
-      def order_reports
-        @order_reports ||= FinApps::REST::OrderReports.new self
-      end
-
-      def order_statuses
-        @order_statuses ||= FinApps::REST::OrderStatuses.new self
-      end
-
-      def institutions
-        @institutions ||= FinApps::REST::Institutions.new self
+      def method_missing(symbol, *arguments, &block)
+        if RESOURCES.include? symbol
+          class_name = camelize(symbol.to_s)
+          variable = "@#{class_name.downcase}"
+          unless instance_variable_defined? variable
+            klass = Object.const_get('FinApps').const_get('REST').const_get class_name
+            instance_variable_set(variable, klass.new(self))
+          end
+          instance_variable_get(variable)
+        else
+          super
+        end
       end
 
-      def institutions_forms
-        @institutions_forms ||= FinApps::REST::InstitutionsForms.new self
+      def respond_to_missing?(method_sym, include_private=false)
+        RESOURCES.include?(method_sym) ? true : super
       end
 
-      def user_institutions_statuses
-        @user_institutions_statuses ||= FinApps::REST::UserInstitutionsStatuses.new self
-      end
-
-      def user_institutions
-        @user_institutions ||= FinApps::REST::UserInstitutions.new self
-      end
-
-      def user_institutions_forms
-        @user_institutions_forms ||= FinApps::REST::UserInstitutionsForms.new self
-      end
+      private
 
-      def password_resets
-        @password_resets ||= FinApps::REST::PasswordResets.new self
+      def camelize(term)
+        string = term.to_s
+        string = string.sub(/^[a-z\d]*/) { $&.capitalize }
+        string.gsub!(%r{(?:_|(/))([a-z\d]*)}) { $2.capitalize.to_s }
+        string
       end
     end
   end

data/lib/finapps/rest/institutions.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class Institutions < FinApps::REST::Resources
+    class Institutions < FinAppsCore::REST::Resources
       using ObjectExtensions
       using StringExtensions
 
       def list(search_term)
-        raise MissingArgumentsError.new 'Missing argument: search_term' if search_term.blank?
+        not_blank(search_term, :search_term)
         # API errors when search_term is blank, maybe it shouldn't
 
         path = "#{end_point}/search/#{ERB::Util.url_encode(search_term)}"

data/lib/finapps/rest/institutions_forms.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class InstitutionsForms < FinApps::REST::Resources
+    class InstitutionsForms < FinAppsCore::REST::Resources
       using ObjectExtensions
       using StringExtensions
 
       def show(site_id)
-        raise MissingArgumentsError.new 'Missing argument: site_id.' if site_id.blank?
+        not_blank(site_id, :site_id)
 
         path = "institutions/site/#{ERB::Util.url_encode(site_id)}/form"
         super site_id, path

data/lib/finapps/rest/order_reports.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class OrderReports < FinApps::REST::Resources # :nodoc:
+    class OrderReports < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def show(id, format)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
-        raise MissingArgumentsError.new 'Missing argument: format' if format.blank?
-        raise InvalidArgumentsError.new 'Invalid argument: format' unless accepted_format?(format)
+        not_blank(id, :id)
+        not_blank(format, :format)
+        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: format' unless accepted_format?(format)
 
         path = "orders/#{ERB::Util.url_encode(id)}/report.#{ERB::Util.url_encode(format)}"
         super nil, path

data/lib/finapps/rest/order_statuses.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class OrderStatuses < FinApps::REST::Resources # :nodoc:
+    class OrderStatuses < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def show(id)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
+        not_blank(id, :id)
 
         path = "orders/#{ERB::Util.url_encode(id)}/status"
         super nil, path

data/lib/finapps/rest/order_tokens.rb

@@ -1,13 +1,12 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class OrderTokens < FinApps::REST::Resources # :nodoc:
+    class OrderTokens < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def show(token)
-        raise MissingArgumentsError.new 'Missing argument: token.' if token.blank?
-
+        not_blank(token, :token)
         create nil, "orders/#{ERB::Util.url_encode(token)}"
       end
     end

data/lib/finapps/rest/orders.rb

@@ -1,17 +1,17 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class Orders < FinApps::REST::Resources # :nodoc:
+    class Orders < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def show(id)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
+        not_blank(id, :id)
         super
       end
 
       def create(params)
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
+        not_blank(params, :params)
         super params
       end
 
@@ -25,14 +25,14 @@ module FinApps
       # :asc - sort order true for asc false for desc
       def list(params=nil) # params hash with optional keys [:page, :requested, :sort, :asc]
         return super 'list/orders/1/10000/date/false' if params.nil?
-        raise InvalidArgumentsError.new 'Invalid argument: params' unless params.is_a? Hash
+        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params' unless params.is_a? Hash
 
         super build_path(params)
       end
 
       def update(id, params)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params' if params.blank?
+        not_blank(id, :id)
+        not_blank(params, :params)
         # Params array need matching Institution ids & Account ids
         # Validations to check each Institution id has at least one account id
         # Validations to check at least 1 Institution id or 1 account "params.length >= 1"

data/lib/finapps/rest/password_resets.rb

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class PasswordResets < FinApps::REST::Resources # :nodoc:
+    class PasswordResets < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def create(id)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
+        not_blank(id, :id)
 
         path = "tenant/#{ERB::Util.url_encode(id)}/password"
         super nil, path
       end
 
       def update(id, params)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
+        raise FinAppsCore::MissingArgumentsError.new 'Missing argument: id.' if id.blank?
+        raise FinAppsCore::MissingArgumentsError.new 'Missing argument: params.' if params.blank?
 
         path = "tenant/#{ERB::Util.url_encode(id)}/password"
         super params, path

data/lib/finapps/rest/sessions.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class Sessions < FinApps::REST::Resources # :nodoc:
+    class Sessions < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       # @param [Hash] params
       # @return [Array<String>]
       def create(params)
-        raise InvalidArgumentsError.new 'Invalid argument: params.' unless validates params
+        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params.' unless validates params
 
         super params, 'login'
       end

data/lib/finapps/rest/user_institutions.rb

@@ -1,20 +1,17 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class UserInstitutions < FinApps::REST::Resources # :nodoc:
-      END_POINT = 'institutions/user'
-
+    class UserInstitutions < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def list
-        path = 'institutions/user'
-        super path
+        super END_POINT
       end
 
       def create(site_id, params)
-        raise MissingArgumentsError.new 'Missing argument: site_id.' if site_id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
+        not_blank(site_id, :site_id)
+        not_blank(params, :params)
 
         path = "institutions/site/#{ERB::Util.url_encode(site_id)}/add"
 
@@ -22,40 +19,38 @@ module FinApps
       end
 
       def show(id)
-        raise MissingArgumentsError.new 'Missing Argument: id.' if id.blank?
-
-        path = "#{END_POINT}/#{ERB::Util.url_encode(id)}"
-        super id, path
+        not_blank(id, :id)
+        super(id, user_institutions_path(id))
       end
 
       def credentials_update(id, params)
-        raise MissingArgumentsError.new 'Missing Argument: id.' if id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
-
-        path = "#{END_POINT}/#{ERB::Util.url_encode(id)}/credentials"
-        update params, path
+        update id, params, 'credentials'
       end
 
       def mfa_update(id, params)
-        raise MissingArgumentsError.new 'Missing Argument: id.' if id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
-
-        path = "#{END_POINT}/#{ERB::Util.url_encode(id)}/mfa"
-        update params, path
+        update id, params, 'mfa'
       end
 
       def destroy(id)
-        raise MissingArgumentsError.new 'Missing Argument: id.' if id.blank?
-
-        path = "#{END_POINT}/#{ERB::Util.url_encode(id)}"
-        super id, path
+        not_blank(id, :id)
+        super(id, user_institutions_path(id))
       end
 
       private
 
-      def update(params, path)
+      END_POINT = 'institutions/user'
+
+      def update(id, params, method)
+        not_blank(id, :id)
+        not_blank(params, :params)
+
+        path = "#{user_institutions_path(id)}/#{method}"
         super params, path
       end
+
+      def user_institutions_path(id)
+        "#{END_POINT}/#{ERB::Util.url_encode(id)}"
+      end
     end
   end
 end