finapps 2.1.4 → 2.2.1

data/lib/finapps/rest/user_institutions_forms.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class UserInstitutionsForms < FinApps::REST::Resources
+    class UserInstitutionsForms < FinAppsCore::REST::Resources
       using ObjectExtensions
       using StringExtensions
 
       def show(id)
-        raise MissingArgumentsError.new 'Missing argument: id.' if id.blank?
+        not_blank(id, :id)
 
         path = "institutions/user/#{ERB::Util.url_encode(id)}/form"
         super id, path

data/lib/finapps/rest/user_institutions_statuses.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class UserInstitutionsStatuses < FinApps::REST::Resources # :nodoc:
+    class UserInstitutionsStatuses < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       def show(id)
-        raise MissingArgumentsError.new 'Missing argument: ui_id' if id.blank?
+        not_blank(id, :id)
 
         path = "institutions/user/#{ERB::Util.url_encode(id)}/status"
         super id, path

data/lib/finapps/rest/users.rb

@@ -1,29 +1,29 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class Users < FinApps::REST::Resources # :nodoc:
+    class Users < FinAppsCore::REST::Resources # :nodoc:
       using ObjectExtensions
       using StringExtensions
 
       # @param [String] public_id
       # @return [FinApps::REST::User, Array<String>]
       def show(public_id)
-        raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
+        not_blank(public_id, :public_id)
         super public_id
       end
 
       # @param [Hash] params
       # @return [Array<String>]
       def update(public_id, params)
-        raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
+        not_blank(public_id, :public_id)
+        not_blank(params, :params)
 
         path = "#{end_point}/#{ERB::Util.url_encode(public_id)}#{'/password' if password_update?(params)}"
         super params, path
       end
 
       def destroy(public_id)
-        raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
+        not_blank(public_id, :public_id)
         super public_id
       end
 

data/lib/finapps/rest/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module FinApps
   module REST
-    class Version < FinApps::REST::Resources # :nodoc:
+    class Version < FinAppsCore::REST::Resources # :nodoc:
       def show
         super nil, end_point
       end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.1.4'
+  VERSION = '2.2.1'
 end

data/spec/rest/client_spec.rb

@@ -1,20 +1,15 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::Client do
   describe '#new' do
-    it 'raises for missing company_identifier' do
-      expect { FinApps::REST::Client.new nil, :company_token }.to raise_error(FinApps::MissingArgumentsError)
-    end
-
     it 'raises for missing company_token' do
-      expect { FinApps::REST::Client.new :company_identifier, nil }.to raise_error(FinApps::MissingArgumentsError)
+      expect { FinApps::REST::Client.new nil }.to raise_error(FinAppsCore::MissingArgumentsError)
     end
   end
 
   context 'an instance of Client' do
-    subject { FinApps::REST::Client.new(:company_identifier, :company_token) }
+    subject { FinApps::REST::Client.new(:company_token) }
 
-    %i(version users sessions orders order_tokens order_reports order_statuses institutions institutions_forms
-       user_institutions_statuses user_institutions user_institutions_forms password_resets).each do |method|
+    FinApps::REST::Client::RESOURCES.each do |method|
       it "responds to #{method}" do
         expect(subject).to respond_to(method)
       end
@@ -72,11 +67,7 @@ RSpec.describe FinApps::REST::Client do
       it { expect(subject.password_resets).to be_an_instance_of(FinApps::REST::PasswordResets) }
     end
 
-    # [:users, :institutions, :user_institutions, :transactions, :categories,
-    # :budget_models, :budget_calculation, :budgets, :cashflows,
-    # :alert, :alert_definition, :alert_preferences, :alert_settings, :rule_sets]
-    %i(version users sessions orders order_tokens order_reports order_statuses institutions institutions_forms
-       user_institutions_statuses user_institutions user_institutions_forms password_resets).each do |method|
+    FinApps::REST::Client::RESOURCES.each do |method|
       it "memoizes the result of #{method}" do
         first = subject.send(method)
         second = subject.send(method)

data/spec/rest/institutions_forms_spec.rb

@@ -1,10 +1,13 @@
 # frozen_string_literal: true
+require 'spec_helpers/client'
+
 RSpec.describe FinApps::REST::InstitutionsForms do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
+
   describe '#show' do
     context 'when missing site id' do
       subject { FinApps::REST::InstitutionsForms.new(client).show(nil) }
-      it('raises missing argument error') { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it('raises missing argument error') { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid site id provided' do

data/spec/rest/institutions_spec.rb

@@ -1,13 +1,15 @@
 # frozen_string_literal: true
+require 'spec_helpers/client'
+
 RSpec.describe FinApps::REST::Institutions do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
 
   describe '#list' do
     subject(:institutions) { FinApps::REST::Institutions.new(client) }
 
     context 'when search_term is missing' do
       let(:list) { subject.list(nil) }
-      it { expect { list }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { list }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when proper search_term is provided' do

data/spec/rest/order_reports_spec.rb

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::OrderReports do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  let(:client) { FinApps::REST::Client.new(:company_token) }
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::OrderReports.new(client).show(nil, :pdf) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when missing format' do
       subject { FinApps::REST::OrderReports.new(client).show(:valid_id, nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when invalid format is provided' do
       subject { FinApps::REST::OrderReports.new(client).show(:valid_id, :xml) }
-      it { expect { subject }.to raise_error(FinApps::InvalidArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError) }
     end
 
     context 'when valid params are provided' do

data/spec/rest/order_statuses_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::OrderStatuses do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
+
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::OrderStatuses.new(client).show(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id is provided' do

data/spec/rest/order_tokens_spec.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Client object' do
   describe '#show' do
-    client = FinApps::REST::Client.new :company_identifier, :company_token
+    include SpecHelpers::Client
+
     subject(:order_tokens) { FinApps::REST::OrderTokens.new(client) }
 
     context 'when missing token' do
-      it { expect { subject.show(nil) }.to raise_error(FinApps::MissingArgumentsError, 'Missing argument: token.') }
+      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, 'Missing argument: token') }
     end
 
     context 'for valid token' do

data/spec/rest/orders_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::Orders do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
+
   describe '#show' do
     context 'when missing params' do
       subject { FinApps::REST::Orders.new(client).show(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid params are provided' do
@@ -20,7 +21,7 @@ RSpec.describe FinApps::REST::Orders do
   describe '#create' do
     context 'when missing params' do
       subject { FinApps::REST::Orders.new(client).create(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid params are provided' do
@@ -71,12 +72,12 @@ RSpec.describe FinApps::REST::Orders do
 
     context 'when missing id' do
       let(:update) { subject.update(nil, :params) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinApps::MissingArgumentsError) }
+      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when missing params' do
       let(:update) { subject.update(:id, nil) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinApps::MissingArgumentsError) }
+      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id and params are provided' do

data/spec/rest/password_resets_spec.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::PasswordResets do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
 
   describe '#create' do
     context 'when missing id' do
       subject { FinApps::REST::PasswordResets.new(client).create(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when invalid id is provided' do
@@ -32,12 +32,12 @@ RSpec.describe FinApps::REST::PasswordResets do
 
     context 'when missing id' do
       subject { FinApps::REST::PasswordResets.new(client).update(nil, :params) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when missing params' do
       subject { FinApps::REST::PasswordResets.new(client).update(:valid_user_id, nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when invalid id is provided' do

data/spec/rest/sessions_spec.rb

@@ -14,11 +14,11 @@ RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client
       message = 'Invalid argument: params.'
       it do
         expect { subject.create(email: nil, password: 'password') }
-          .to raise_error(FinApps::InvalidArgumentsError, message)
+          .to raise_error(FinAppsCore::InvalidArgumentsError, message)
       end
       it do
         expect { subject.create(email: 'email', password: nil) }
-          .to raise_error(FinApps::InvalidArgumentsError, message)
+          .to raise_error(FinAppsCore::InvalidArgumentsError, message)
       end
     end
 

data/spec/rest/user_institutions_forms_spec.rb

@@ -1,10 +1,13 @@
 # frozen_string_literal: true
+require 'spec_helpers/client'
+
 RSpec.describe FinApps::REST::UserInstitutionsForms do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
+
   describe '#show' do
     context 'when missing site id' do
       subject { FinApps::REST::UserInstitutionsForms.new(client).show(nil) }
-      it('raises missing argument error') { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it('raises missing argument error') { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid site id provided' do

data/spec/rest/user_institutions_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::UserInstitutions do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
+
   describe '#list' do
     context 'when successful' do
       subject { FinApps::REST::UserInstitutions.new(client).list }
@@ -16,12 +17,12 @@ RSpec.describe FinApps::REST::UserInstitutions do
 
     context 'when missing site_id' do
       let(:create) { subject.create(nil, :params) }
-      it { expect { create }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when missing params' do
       let(:create) { subject.create(:site_id, nil) }
-      it { expect { create }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid site_id and params are provided' do
@@ -38,7 +39,7 @@ RSpec.describe FinApps::REST::UserInstitutions do
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::UserInstitutions.new(client).show(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id is provided' do
@@ -62,12 +63,12 @@ RSpec.describe FinApps::REST::UserInstitutions do
   describe '#mfa_update' do
     context 'when missing id' do
       subject { FinApps::REST::UserInstitutions.new(client).mfa_update(nil, :params) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when missing params' do
       subject { FinApps::REST::UserInstitutions.new(client).mfa_update(:id, nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id and params are provided' do
@@ -90,12 +91,12 @@ RSpec.describe FinApps::REST::UserInstitutions do
   describe '#credentials_update' do
     context 'when missing id' do
       subject { FinApps::REST::UserInstitutions.new(client).credentials_update(nil, :params) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when missing params' do
       subject { FinApps::REST::UserInstitutions.new(client).credentials_update(:id, nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id and params are provided' do
@@ -118,7 +119,7 @@ RSpec.describe FinApps::REST::UserInstitutions do
   describe '#destroy' do
     context 'when missing id' do
       subject { FinApps::REST::UserInstitutions.new(client).destroy(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id is provided' do

data/spec/rest/user_institutions_statuses_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::UserInstitutionsStatuses do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
+
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::UserInstitutionsStatuses.new(client).show(nil) }
-      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when valid id is provided' do

data/spec/rest/users_spec.rb

@@ -4,11 +4,11 @@ require 'spec_helpers/client'
 RSpec.describe FinApps::REST::Users, 'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject(:users) { FinApps::REST::Users.new(client) }
-  missing_public_id = 'Missing argument: public_id.'
+  missing_public_id = 'Missing argument: public_id'
 
   describe '#show' do
     context 'when missing public_id' do
-      it { expect { subject.show(nil) }.to raise_error(FinApps::MissingArgumentsError, missing_public_id) }
+      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
     end
 
     context 'for valid public_id' do
@@ -35,7 +35,7 @@ RSpec.describe FinApps::REST::Users, 'initialized with valid FinApps::Client obj
 
   describe '#update' do
     context 'when missing public_id' do
-      it { expect { subject.update(nil, {}) }.to raise_error(FinApps::MissingArgumentsError, missing_public_id) }
+      it { expect { subject.update(nil, {}) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
     end
 
     context 'when updating user details' do
@@ -88,7 +88,7 @@ RSpec.describe FinApps::REST::Users, 'initialized with valid FinApps::Client obj
 
     describe '#destroy' do
       context 'when missing public_id' do
-        it { expect { subject.destroy(nil) }.to raise_error(FinApps::MissingArgumentsError, missing_public_id) }
+        it { expect { subject.destroy(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
       end
 
       context 'for valid public_id' do

data/spec/rest/version_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::Version do
-  let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
+  include SpecHelpers::Client
 
   subject { FinApps::REST::Version.new(client) }
   describe '#show' do

data/spec/spec_helper.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 if ENV['CODECLIMATE_REPO_TOKEN']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
+  # require 'codeclimate-test-reporter'
+  # CodeClimate::TestReporter.start
+  require 'simplecov'
+  SimpleCov.start
 end
 
 require 'bundler/setup'
@@ -27,7 +29,7 @@ RSpec.configure do |config|
   Kernel.srand config.seed
 
   config.before(:each) do
-    base_url = "#{FinApps::REST::Defaults::DEFAULTS[:host]}/v#{FinApps::REST::Defaults::API_VERSION}/"
+    base_url = "#{FinAppsCore::REST::Defaults::DEFAULTS[:host]}/v#{FinAppsCore::REST::Defaults::API_VERSION}/"
     stub_request(:any, /#{base_url}/).to_rack(::FakeApi)
   end
   WebMock.disable_net_connect!(allow: 'codeclimate.com')