finapps 6.4.3 → 6.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c47f3bb9f6e6702acf5a530b1e9c243a80271bc66e4eecec1fa6c1a088e99e0
-  data.tar.gz: fe0770b6dbe32afe9997a8d631ff5dae85c1963e0b6b26ac52bfec4cf2794159
+  metadata.gz: 735176ac6ed0687571813a8c336c16b69af0c5667c6596700ff9e2a9f68f360a
+  data.tar.gz: c6d8d16e7eefd52b3394211874bb3e525c012b63729465d0fdbad4ff06d23b53
 SHA512:
-  metadata.gz: eb6e96b56b2e64f03eef52e9e5f4573eca2c9940421caa3d15dc42b3fd400781a40bfd44fe592b7886ebf4cd0de3f9854e080a60c85454f0228919524ed513a9
-  data.tar.gz: 3762f06a6f148e7dd040c9005e98614f9bcdd54f497a1b6f1e7a1d148bc5e528852592e3ff4ecaec2df5a8419cc95a53f299e02c292d5d1285e5e28b61575060
+  metadata.gz: 4839196dbed34dce8f802b4e4b95b45b0ce0a8d1e43993290a3783711c6a43394e1ad1680084590ec0ecc3baaa5ae3f4c3c5f52e69b06d72449ef2fd35698e70
+  data.tar.gz: 60afeee0003d524c52a7e966e49e8f6972e5308c7d92c34451149ef25a3041078551eb391a72e38b6723bbcad6e2a8ae284f2b659a5814d6a22fbdb13bc491d8

data/.github/release-drafter.yml

@@ -39,7 +39,7 @@ exclude-labels:
   - invalid
   
 template: |
-  ## [$RESOLVED_VERSION](https://github.com/finapps/ruby-client/compare/$PREVIOUS_TAG...$RESOLVED_VERSION)
+  ## [$RESOLVED_VERSION](https://github.com/finapps/ruby-client/compare/$PREVIOUS_TAG...v$RESOLVED_VERSION)
   $CHANGES
 
 replacers:

data/.github/workflows/ci.yaml

@@ -20,7 +20,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout source code
-        uses: actions/checkout@v2.3.4
+        uses: actions/checkout@v2.4.0
 
       - name: Install required ruby version
         uses: ruby/setup-ruby@v1

data/.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
 
     steps: 
       - name: Checkout source code
-        uses: actions/checkout@v2.3.4
+        uses: actions/checkout@v2.4.0
         with:
           persist-credentials: false
           fetch-depth: 0 # otherwise, you will fail to push refs to dest repo

data/.github/workflows/verify-pr-labeled.yml

@@ -7,7 +7,7 @@ jobs:
   label:
     runs-on: ubuntu-latest
     steps:
-      - uses: mheap/github-action-required-labels@v1.1.2
+      - uses: mheap/github-action-required-labels@v1.2
         with:
           mode: minimum
           count: 1

data/.rubocop.yml

@@ -12,6 +12,9 @@ AllCops:
   CacheRootDirectory: tmp
   NewCops: enable
 
+Gemspec/RequireMFA:
+  Enabled: false
+
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
 Layout/EmptyLinesAroundAttributeAccessor:

data/finapps.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec',                      '~> 3.10',  '>= 3.10.0'
   spec.add_development_dependency 'rubocop-performance',        '~> 1.11',  '>= 1.11.5'
   spec.add_development_dependency 'rubocop-rake',               '~> 0.5',   '>= 0.5.1'
-  spec.add_development_dependency 'rubocop-rspec',              '~> 2.4',   '>= 2.4.0'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 2.5',   '>= 2.5.0'
   spec.add_development_dependency 'simplecov',                  '~> 0.21',  '>= 0.21.2'
   spec.add_development_dependency 'simplecov-console',          '~> 0.9'
   spec.add_development_dependency 'sinatra',                    '~> 2.1',   '>= 2.1.0'

data/lib/finapps/rest/actors.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class Actors < FinAppsCore::REST::Resources
+      END_POINT = 'actor/details'
+
+      def show
+        super nil, END_POINT
+      end
+    end
+  end
+end

data/lib/finapps/rest/client.rb

@@ -7,6 +7,7 @@ module FinApps
   module REST
     class Client < FinAppsCore::REST::BaseClient # :nodoc:
       RESOURCES = %i[
+        actors
         alert_definitions
         alert_occurrences
         consumers
@@ -41,6 +42,7 @@ module FinApps
         portfolio_reports
         products
         screenings
+        screening_metadatas
         sessions
         signed_documents_downloads
         tenant_settings
@@ -74,7 +76,7 @@ module FinApps
       end
 
       def set_variable(class_name, variable)
-        klass = Object.const_get('FinApps').const_get('REST').const_get class_name
+        klass = Object.const_get(:FinApps).const_get(:REST).const_get class_name
         instance_variable_set(variable, klass.new(self))
       end
 

data/lib/finapps/rest/operators.rb

@@ -57,22 +57,33 @@ module FinApps
       end
 
       def build_filter(params)
-        filter = {}
-        filter.merge!(search_query(params[:searchTerm])) if params[:searchTerm]
-        filter.merge!(role_query(params[:role])) if params[:role]
-        filter
+        term_filter(params[:searchTerm]).merge(role_filter(params[:role]))
       end
 
-      def search_query(term)
-        {last_name: term}
+      def term_filter(term)
+        return {} unless term
+
+        {'$or': term_array(term)}
+      end
+
+      def term_array(term)
+        [
+          {email: term},
+          {last_name: term}
+        ]
+      end
+
+      def role_filter(role)
+        return {} unless role
+
+        roles = to_integers_array(role)
+        return {} if roles.empty?
+
+        {role: {'$in': roles}}
       end
 
-      def role_query(role)
-        if role.is_a?(Array)
-          {role: {'$in': role.map(&:to_i)}}
-        else
-          {role: role.to_i}
-        end
+      def to_integers_array(role)
+        (role.respond_to?(:map) ? role : [role]).map {|i| Integer(i) }.compact
       end
     end
   end

data/lib/finapps/rest/screening_metadatas.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class ScreeningMetadatas < FinAppsCore::REST::Resources # :nodoc:
+      def show(id, key)
+        not_blank(id, :session_id)
+        not_blank(key, :key)
+
+        path = "screenings/#{ERB::Util.url_encode(id)}/meta/#{ERB::Util.url_encode(key)}"
+        super(nil, path)
+      end
+
+      def create(id, key, value)
+        not_blank(id, :session_id)
+        not_blank(key, :key)
+        not_blank(value, :value)
+
+        path = "screenings/#{ERB::Util.url_encode(id)}/meta"
+        super({key => value}, path)
+      end
+
+      def destroy(id, key)
+        not_blank(id, :session_id)
+        not_blank(key, :key)
+
+        path = "screenings/#{ERB::Util.url_encode(id)}/meta/#{ERB::Util.url_encode(key)}"
+        super(nil, path)
+      end
+    end
+  end
+end

data/lib/finapps/rest/screenings.rb

@@ -110,7 +110,7 @@ module FinApps
       def progress_filter(progress)
         return {} unless progress
 
-        {progress: progress.to_i}
+        {progress: Integer(progress)}
       end
 
       def space?(string)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '6.4.3'
+  VERSION = '6.7.0'
 end

data/lib/finapps.rb

@@ -4,6 +4,7 @@ require 'faraday'
 require 'faraday_middleware'
 
 require 'finapps_core'
+require 'finapps/rest/actors'
 require 'finapps/rest/version'
 require 'finapps/rest/consumers'
 require 'finapps/rest/consumer_login_tokens'
@@ -39,6 +40,7 @@ require 'finapps/rest/documents_upload_types'
 require 'finapps/rest/signed_documents_downloads'
 require 'finapps/rest/documents_orders_notifications'
 require 'finapps/rest/screenings'
+require 'finapps/rest/screening_metadatas'
 
 require 'finapps/rest/plaid/plaid_resources'
 require 'finapps/rest/plaid/plaid_webhooks'

data/spec/rest/actors_spec.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'spec_helpers/client'
+require 'spec_helpers/api_request'
+
+RSpec.describe FinApps::REST::Actors do
+  include SpecHelpers::Client
+
+  let(:results) { subject[RESULTS] }
+  let(:error_messages) { subject[ERROR_MESSAGES] }
+
+  describe '#show' do
+    subject(:show) { described_class.new(client).show }
+
+    context 'when authorization is not valid' do
+      before { stub_unauthorized_request }
+
+      it { expect { show }.to raise_error(FinAppsCore::ApiUnauthenticatedError) }
+    end
+
+    context 'when authorization is valid' do
+      it_behaves_like 'an API request'
+      it_behaves_like 'a successful request'
+
+      it('returns a valid actor') { expect(results).to be_a(Hash) }
+    end
+  end
+
+  def stub_unauthorized_request
+    stub_request(:get, %r{/actor/details}).to_return(
+      status: 401,
+      body: {
+        error_messages: ['Unauthorized'],
+        results: nil
+      }.to_json,
+      headers: {}
+    )
+  end
+end

data/spec/rest/documents_orders_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helpers/client'
-require 'rest/api_request'
+require 'spec_helpers/api_request'
 
 RSpec.describe FinApps::REST::DocumentsOrders do
   include SpecHelpers::Client

data/spec/rest/documents_upload_types_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helpers/client'
-require 'rest/api_request'
+require 'spec_helpers/api_request'
 
 RSpec.describe FinApps::REST::DocumentsUploadTypes do
   include SpecHelpers::Client

data/spec/rest/documents_uploads_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helpers/client'
-require 'rest/api_request'
+require 'spec_helpers/api_request'
 
 RSpec.describe FinApps::REST::DocumentsUploads do
   include SpecHelpers::Client

data/spec/rest/esign_templates_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'spec_helpers/client'
-require 'rest/api_request'
+require 'spec_helpers/api_request'
 
 RSpec.describe FinApps::REST::EsignTemplates do
   include SpecHelpers::Client