finapps 6.13.0 → 6.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d750e401b5d936b5b67144236c47a9969d1007e2777232171b4831b4bebe2b08
-  data.tar.gz: 3120e93e8acbd4a3b40e946788ab93e86ce064e9530c378d6cf49a91c8826461
+  metadata.gz: 9b5ee328bf6ddb3cd7701096b62c41b1a0fb690af5a022ff5db7d92548f319f1
+  data.tar.gz: 0b823c3b3df60dc4ecc399c7c5d9071d5866095074dc85125e593f5c8a575679
 SHA512:
-  metadata.gz: 800464206ab8c445fa2fe12c7bd2c2a12d74a7fbc8cf384a0fc0573807deb3d4c70115f4eb0f6f930f66cb3c0f777251510903859885c6087cc46cae7501dd59
-  data.tar.gz: de98785d634e7846cc32dc1fa36f5fdca31443cb379b8cc09d15c780e7a53a8dab9e84ebc0cd7a8458a8afac43cc0309d8c89e3d275d1401efd61298d100e1eb
+  metadata.gz: 5cb7810fbf1ca88917776cad3248e695c24291ba2615ab1fe794a21d967e8c08e4de8df46c65294654941561ecc7e20916e413b8518333974443a138159ec5f4
+  data.tar.gz: 5a4518232564c587b524110b667b4da0966361b6eac9f1863695e71c31e7acb84d7b80e88eb67b8835e5a8ab84546a9d9cb152eacc3a10f105a2a1f2929427cd

data/.github/workflows/verify-pr-labeled.yml

@@ -7,7 +7,7 @@ jobs:
   label:
     runs-on: ubuntu-latest
     steps:
-      - uses: mheap/github-action-required-labels@v1.2
+      - uses: mheap/github-action-required-labels@v2.1
         with:
           mode: minimum
           count: 1

data/.rubocop.yml

@@ -52,7 +52,7 @@ Metrics/ClassLength:
     - app/models/order.rb
     - spec/support/fake_api.rb
 Metrics/BlockLength:
-  IgnoredMethods: ['describe', 'context']
+  AllowedMethods: ['describe', 'context']
   Exclude:
     - config/environments/**/**
     - Guardfile

data/lib/finapps/rest/documents_uploads.rb

@@ -8,7 +8,7 @@ module FinApps
         not_blank(doc_id, :doc_id)
 
         path =
-          "consumers/#{ERB::Util.url_encode(consumer_id)}/"\
+          "consumers/#{ERB::Util.url_encode(consumer_id)}/" \
           "documents/#{ERB::Util.url_encode(doc_id)}?thumbnail=#{thumbnail}"
         super(nil, path)
       end

data/lib/finapps/rest/edm_transmissions.rb

@@ -16,6 +16,13 @@ module FinApps
         path = "documents/edm/#{ERB::Util.url_encode(transmission_id)}"
         super transmission_id, path
       end
+
+      def show_by_order(order_id)
+        not_blank(order_id, :order_id)
+
+        path = "documents/edm/#{ERB::Util.url_encode(order_id)}/status"
+        send_request_for_id path, :get, order_id
+      end
     end
   end
 end

data/lib/finapps/rest/signed_documents_downloads.rb

@@ -8,7 +8,7 @@ module FinApps
         not_blank(signature_request_id, :signature_request_id)
 
         path =
-          "consumers/#{ERB::Util.url_encode(consumer_id)}/"\
+          "consumers/#{ERB::Util.url_encode(consumer_id)}/" \
           "documents/#{ERB::Util.url_encode(signature_request_id)}"
         super(nil, path)
       end

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '6.13.0'
+  VERSION = '6.13.1'
 end

data/spec/rest/consumers_spec.rb

@@ -118,11 +118,11 @@ RSpec.describe FinApps::REST::Consumers do
 
         it 'builds query and sends proper request' do
           list
-          filter = '{"$or":['\
-                   '{"external_id":"term"},'\
-                   '{"email":"term"},'\
-                   '{"first_name":"term"},'\
-                   '{"last_name":"term"}'\
+          filter = '{"$or":[' \
+                   '{"external_id":"term"},' \
+                   '{"email":"term"},' \
+                   '{"first_name":"term"},' \
+                   '{"last_name":"term"}' \
                    ']}'
           query = "?filter=#{filter}&page=2&requested=25&sort=date_created"
           url = "#{versioned_api_path}/consumers#{query}"
@@ -141,15 +141,15 @@ RSpec.describe FinApps::REST::Consumers do
 
           it 'treats space as start of a new query for first and last name' do
             list
-            filter = '{"$or":['\
-                     '{"external_id":"Two terms"},'\
-                     '{"email":"Two terms"},'\
-                     '{"first_name":"Two terms"},'\
-                     '{"last_name":"Two terms"},'\
-                     '{"first_name":"Two"},'\
-                     '{"last_name":"Two"},'\
-                     '{"first_name":"terms"},'\
-                     '{"last_name":"terms"}'\
+            filter = '{"$or":[' \
+                     '{"external_id":"Two terms"},' \
+                     '{"email":"Two terms"},' \
+                     '{"first_name":"Two terms"},' \
+                     '{"last_name":"Two terms"},' \
+                     '{"first_name":"Two"},' \
+                     '{"last_name":"Two"},' \
+                     '{"first_name":"terms"},' \
+                     '{"last_name":"terms"}' \
                      ']}'
             query = "?filter=#{filter}&page=2&requested=25&sort=date_created"
             url = "#{versioned_api_path}/consumers#{query}"

data/spec/rest/documents_orders_spec.rb

@@ -49,12 +49,12 @@ RSpec.describe FinApps::REST::DocumentsOrders do
         it 'builds query and sends proper request' do
           list
           url =
-            "#{versioned_api_path}/documents/orders?"\
-            'filter=%7B%22$or%22:%5B%7B%22applicant.email%22:'\
-            '%22term%22%7D,%7B%22applicant.first_name%22:%22term%22%7D,'\
-            '%7B%22applicant.last_name%22:%22term%22%7D,'\
-            '%7B%22applicant.external_id%22:%22term%22%7D,%7B%22reference_no%22:'\
-            '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,'\
+            "#{versioned_api_path}/documents/orders?" \
+            'filter=%7B%22$or%22:%5B%7B%22applicant.email%22:' \
+            '%22term%22%7D,%7B%22applicant.first_name%22:%22term%22%7D,' \
+            '%7B%22applicant.last_name%22:%22term%22%7D,' \
+            '%7B%22applicant.external_id%22:%22term%22%7D,%7B%22reference_no%22:' \
+            '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,' \
             '%22consumer_id%22:%22valid_consumer_id%22%7D&page=2&requested=25&sort=tag'
 
           expect(WebMock).to have_requested(:get, url)
@@ -66,15 +66,15 @@ RSpec.describe FinApps::REST::DocumentsOrders do
           it 'builds query and sends proper request' do
             list
             url =
-              "#{versioned_api_path}/documents/orders?"\
-              'filter=%7B%22$or%22:%5B%7B%22applicant.email%22:'\
-              '%22Blue%20Jay%22%7D,%7B%22applicant.first_name%22:'\
-              '%22Blue%20Jay%22%7D,%7B%22applicant.last_name%22:'\
-              '%22Blue%20Jay%22%7D,%7B%22applicant.external_id%22:'\
-              '%22Blue%20Jay%22%7D,%7B%22reference_no%22:%7B%22$regex%22:'\
-              '%22%5EBlue%20Jay%22,%22$options%22:%22i%22%7D%7D,'\
-              '%7B%22applicant.first_name%22:%22Blue%22%7D,%7B%22'\
-              'applicant.last_name%22:%22Blue%22%7D,%7B%22applicant.first_name%22:'\
+              "#{versioned_api_path}/documents/orders?" \
+              'filter=%7B%22$or%22:%5B%7B%22applicant.email%22:' \
+              '%22Blue%20Jay%22%7D,%7B%22applicant.first_name%22:' \
+              '%22Blue%20Jay%22%7D,%7B%22applicant.last_name%22:' \
+              '%22Blue%20Jay%22%7D,%7B%22applicant.external_id%22:' \
+              '%22Blue%20Jay%22%7D,%7B%22reference_no%22:%7B%22$regex%22:' \
+              '%22%5EBlue%20Jay%22,%22$options%22:%22i%22%7D%7D,' \
+              '%7B%22applicant.first_name%22:%22Blue%22%7D,%7B%22' \
+              'applicant.last_name%22:%22Blue%22%7D,%7B%22applicant.first_name%22:' \
               '%22Jay%22%7D,%7B%22applicant.last_name%22:%22Jay%22%7D%5D%7D&page=2'
 
             expect(WebMock).to have_requested(:get, url)

data/spec/rest/edm_transmissions_spec.rb

@@ -27,4 +27,13 @@ RSpec.describe FinApps::REST::EdmTransmissions do
 
     it_behaves_like 'an EdmTransmission response'
   end
+
+  describe '#show_by_order' do
+    subject(:show) { described_class.new(client).show_by_order(:order_id) }
+
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+
+    it_behaves_like 'an EdmTransmission response'
+  end
 end

data/spec/rest/operators_spec.rb

@@ -75,8 +75,8 @@ RSpec.describe FinApps::REST::Operators do
           list
 
           filter = {'$or': [{last_name: 't'}], role: {'$in': [2]}}
-          expect(WebMock).to have_requested(:get, "#{versioned_api_path}/operators"\
-                                                  "?filter=#{ERB::Util.url_encode filter.to_json}"\
+          expect(WebMock).to have_requested(:get, "#{versioned_api_path}/operators" \
+                                                  "?filter=#{ERB::Util.url_encode filter.to_json}" \
                                                   '&page=2&requested=25&sort=date_created')
         end
       end

data/spec/rest/orders_spec.rb

@@ -132,13 +132,13 @@ RSpec.describe FinApps::REST::Orders do
 
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/orders?"\
-              'filter=%7B%22$or%22:%5B%7B%22public_id%22:%7B%22$regex%22:%22%5E'\
-              'term%22,%22$options%22:%22i%22%7D%7D,%7B%22assignment.last_name%22:%22'\
-              'term%22%7D,%7B%22applicant.first_name%22:%22term%22%7D,%7B%22'\
-              'applicant.last_name%22:%22term%22%7D,%7B%22requestor.reference_no'\
-              '%22:%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,%22'\
-              'status%22:%7B%22$in%22:%5B1,7%5D%7D,%22assignment.operator_id%22:%22'\
+        url = "#{versioned_api_path}/orders?" \
+              'filter=%7B%22$or%22:%5B%7B%22public_id%22:%7B%22$regex%22:%22%5E' \
+              'term%22,%22$options%22:%22i%22%7D%7D,%7B%22assignment.last_name%22:%22' \
+              'term%22%7D,%7B%22applicant.first_name%22:%22term%22%7D,%7B%22' \
+              'applicant.last_name%22:%22term%22%7D,%7B%22requestor.reference_no' \
+              '%22:%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,%22' \
+              'status%22:%7B%22$in%22:%5B1,7%5D%7D,%22assignment.operator_id%22:%22' \
               'valid_operator%22,%22consumer_id%22:%22valid_consumer_id%22%7D&page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
@@ -146,12 +146,12 @@ RSpec.describe FinApps::REST::Orders do
       it 'builds query and sends proper request with searchTerm/relation exclusivity' do
         params[:searchTerm] = nil
         list
-        url = "#{versioned_api_path}/orders?"\
+        url = "#{versioned_api_path}/orders?" \
               'filter=%7B%22status%22:%7B%22$in%22:%5B1,7%5D%7D,' \
-              '%22assignment.operator_id%22:%22valid_operator%22,'\
+              '%22assignment.operator_id%22:%22valid_operator%22,' \
               '%22consumer_id%22:%22valid_consumer_id%22,' \
-              '%22$or%22:%5B%7B%22public_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D,'\
-              '%7B%22original_order_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D%5D%7D&'\
+              '%22$or%22:%5B%7B%22public_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D,' \
+              '%7B%22original_order_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D%5D%7D&' \
               'page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
@@ -159,16 +159,16 @@ RSpec.describe FinApps::REST::Orders do
       it 'handles space in search term for consumer' do
         params[:searchTerm] = 'Spacing Out'
         list
-        url = "#{versioned_api_path}/orders?"\
-              'filter=%7B%22$or%22:%5B%7B%22public_id%22:%7B%22$regex%22:%22%5E'\
-              'Spacing%20Out%22,%22$options%22:%22i%22%7D%7D,%7B%22assignment.last_name'\
-              '%22:%22Spacing%20Out%22%7D,%7B%22applicant.first_name%22:%22'\
-              'Spacing%20Out%22%7D,%7B%22applicant.last_name%22:%22Spacing%20Out'\
-              '%22%7D,%7B%22requestor.reference_no%22:%7B%22$regex%22:%22%5ESpacing%20Out'\
-              '%22,%22$options%22:%22i%22%7D%7D,%7B%22applicant.first_name%22:%22Spacing'\
-              '%22%7D,%7B%22applicant.last_name%22:%22Spacing%22%7D,%7B%22applicant.first_name'\
-              '%22:%22Out%22%7D,%7B%22applicant.last_name%22:%22Out%22%7D%5D,%22status'\
-              '%22:%7B%22$in%22:%5B1,7%5D%7D,%22assignment.operator_id%22:%22valid_operator'\
+        url = "#{versioned_api_path}/orders?" \
+              'filter=%7B%22$or%22:%5B%7B%22public_id%22:%7B%22$regex%22:%22%5E' \
+              'Spacing%20Out%22,%22$options%22:%22i%22%7D%7D,%7B%22assignment.last_name' \
+              '%22:%22Spacing%20Out%22%7D,%7B%22applicant.first_name%22:%22' \
+              'Spacing%20Out%22%7D,%7B%22applicant.last_name%22:%22Spacing%20Out' \
+              '%22%7D,%7B%22requestor.reference_no%22:%7B%22$regex%22:%22%5ESpacing%20Out' \
+              '%22,%22$options%22:%22i%22%7D%7D,%7B%22applicant.first_name%22:%22Spacing' \
+              '%22%7D,%7B%22applicant.last_name%22:%22Spacing%22%7D,%7B%22applicant.first_name' \
+              '%22:%22Out%22%7D,%7B%22applicant.last_name%22:%22Out%22%7D%5D,%22status' \
+              '%22:%7B%22$in%22:%5B1,7%5D%7D,%22assignment.operator_id%22:%22valid_operator' \
               '%22,%22consumer_id%22:%22valid_consumer_id%22%7D&page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
@@ -176,7 +176,7 @@ RSpec.describe FinApps::REST::Orders do
       it 'builds null assignment query properly when supplied w/ empty string' do
         described_class.new(client).list(assignment: '')
 
-        url = "#{versioned_api_path}/orders?"\
+        url = "#{versioned_api_path}/orders?" \
               'filter=%7B%22assignment.operator_id%22:null%7D'
         expect(WebMock).to have_requested(:get, url)
       end

data/spec/support/fixtures/edm_transmissions/show_by_order.json

@@ -0,0 +1,20 @@
+{
+  "date_created": "2022-08-04T19:52:32Z",
+  "date_modified": "2022-08-04T19:52:32Z",
+  "document_order_id": "0c272b3d-3c8c-43ab-beff-f5964835a591",
+  "documents": [
+    {
+      "date_modified": "2022-08-04T19:52:32Z",
+      "document_id": "string",
+      "edm_filename": "string",
+      "file_id": "string",
+      "path": "string",
+      "status": 1,
+      "template_data": {
+        "external_id": "28489213"
+      }
+    }
+  ],
+  "status": 1,
+  "transmission_id": "7829e171-4d39-4270-8969-7729038953d2"
+}

data/spec/support/routes/edm_transmissions.rb

@@ -14,6 +14,9 @@ module Fake
         base.get("/#{base.version}/documents/edm/:transmission_id") do
           json_response 200, 'edm_transmissions/show.json'
         end
+        base.get("/#{base.version}/documents/edm/:order_id/status") do
+          json_response 200, 'edm_transmissions/show_by_order.json'
+        end
       end
 
       def post_routes(base)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 6.13.0
+  version: 6.13.1
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-20 00:00:00.000000000 Z
+date: 2022-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -381,6 +381,7 @@ files:
 - spec/support/fixtures/documents_orders_none.json
 - spec/support/fixtures/edm_transmissions/create.json
 - spec/support/fixtures/edm_transmissions/show.json
+- spec/support/fixtures/edm_transmissions/show_by_order.json
 - spec/support/fixtures/error.json
 - spec/support/fixtures/esign_templates.json
 - spec/support/fixtures/invalid_order_id.json