finapps 6.10.1 → 6.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b42aeaed6c32c359360c5f40a432723036e7118029003cd6b0d0e2fccad644fd
-  data.tar.gz: 720c838e5da2710309dc6be29e640ba6238c101244145a4eb20b06d765c4387b
+  metadata.gz: d55e0e0252d632b2a68bdf279f4a4e33181bcf1d8be6ca5513399e0cb34fd08b
+  data.tar.gz: 311a8cbe50f22112ddbf0360567ad10ef36967d4247d973b6275c2054ba67a82
 SHA512:
-  metadata.gz: 6b6a365b8057aebefb8431f93e660b133deda0ae94829aa2fdc98d4f59001c9b1cd803af75b44de83bb5c574d940dacb25e13b1e40ff93b2f76893a7bf3001e6
-  data.tar.gz: 7f09473a81677c621c2ebc86e15e346a4d3c5418e3e845c2ac16cf8237c247ccb5aa2b70e46744b1bad3d6f4bb5784be1e9bcca7ecb806dc3fe663e6f050e60d
+  metadata.gz: 2e24379649d976509c222127152ddf7d98cd5fcbcffc0a3ed5700295b418685c21bf2a51e7e91804c8ff066fa1e1e0da155762710dfbbb12061bc23d1458fa68
+  data.tar.gz: df2ab06514a0a5bc3fac7b0e880e370d321fe2261f522945dc00f0ab656d289b91609b45274c4a743e0b795c8139e236e5c54311dc4e0e96cf7d3985dd1ef414

data/lib/finapps/rest/operators.rb

@@ -67,10 +67,11 @@ module FinApps
       end
 
       def term_array(term)
-        [
-          {email: term},
-          {last_name: term}
-        ]
+        if term.include?('@')
+          [{email: term}]
+        else
+          [{last_name: term}]
+        end
       end
 
       def role_filter(role)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '6.10.1'
+  VERSION = '6.10.2'
 end

data/spec/rest/locations_spec.rb

@@ -7,6 +7,26 @@ RSpec.describe FinApps::REST::Locations do
 
   let(:id) { :id }
 
+  params = {name: 'Quick Mart Non-Urgent Care', state: {code: 'MD'}}
+
+  RSpec::Matchers.define :have_keys do |*keys|
+    match {|actual| keys.all? {|key| actual.key? key } }
+  end
+
+  RSpec.shared_examples 'a request to a not found resource' do
+    it_behaves_like 'a failed request'
+    it('returns a 404 error') do
+      expect(subject[ERROR_MESSAGES].first)
+        .to(eq('the server responded with status 404'))
+    end
+  end
+
+  RSpec.shared_examples 'a successful API request returning an empty body' do
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+    it { expect(subject[RESULTS]).to be_nil }
+  end
+
   describe '#list' do
     subject(:list) { described_class.new(client).list filter }
 
@@ -14,9 +34,7 @@ RSpec.describe FinApps::REST::Locations do
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
-    it { expect(list[RESULTS]).to all(have_key(:id)) }
-    it { expect(list[RESULTS]).to all(have_key(:name)) }
-    it { expect(list[RESULTS]).to all(have_key(:state)) }
+    it { expect(list[RESULTS]).to all(have_keys(:id, :name, :state)) }
 
     context 'when the JMESPath filter is invalid' do
       let(:filter) { 'invalid' }
@@ -25,32 +43,14 @@ RSpec.describe FinApps::REST::Locations do
     end
   end
 
-  describe '#create' do
-    subject(:create) { described_class.new(client).create(params) }
-
-    let(:params) { {name: 'Quick Mart Urgent Care', state: {code: 'MD'}} }
-
-    it_behaves_like 'an API request'
-    it_behaves_like 'a successful request'
-    it { expect(create[RESULTS]).to be_nil }
-  end
-
-  RSpec.shared_examples 'a request to a not found resource' do
-    it_behaves_like 'a failed request'
-    it('returns a 404 error') do
-      expect(subject[ERROR_MESSAGES].first)
-        .to(eq('the server responded with status 404'))
-    end
-  end
-
   describe '#show' do
     subject(:show) { described_class.new(client).show(id) }
 
-    it_behaves_like 'an API request'
-    it_behaves_like 'a successful request'
-    it { expect(show[RESULTS]).to have_key(:id) }
-    it { expect(show[RESULTS]).to have_key(:name) }
-    it { expect(show[RESULTS]).to have_key(:state) }
+    context 'when the location exists' do
+      it_behaves_like 'an API request'
+      it_behaves_like 'a successful request'
+      it { expect(show[RESULTS]).to have_keys(:id, :name, :state) }
+    end
 
     context 'when id does not match any location' do
       let(:id) { 'not_found' }
@@ -59,14 +59,18 @@ RSpec.describe FinApps::REST::Locations do
     end
   end
 
+  describe '#create' do
+    subject(:create) { described_class.new(client).create(params) }
+
+    it_behaves_like 'a successful API request returning an empty body'
+  end
+
   describe '#update' do
     subject(:update) { described_class.new(client).update(id, params) }
 
-    let(:params) { {name: 'Quick Mart Non-Urgent Care', state: {code: 'MD'}} }
-
-    it_behaves_like 'an API request'
-    it_behaves_like 'a successful request'
-    it { expect(update[RESULTS]).to be_nil }
+    context 'when the location exists' do
+      it_behaves_like 'a successful API request returning an empty body'
+    end
 
     context 'when id does not match any location' do
       let(:id) { 'not_found' }
@@ -78,9 +82,9 @@ RSpec.describe FinApps::REST::Locations do
   describe '#destroy' do
     subject(:destroy) { described_class.new(client).destroy(id) }
 
-    it_behaves_like 'an API request'
-    it_behaves_like 'a successful request'
-    it { expect(destroy[RESULTS]).to be_nil }
+    context 'when the location exists' do
+      it_behaves_like 'a successful API request returning an empty body'
+    end
 
     context 'when id does not match any location' do
       let(:id) { 'not_found' }

data/spec/rest/operators_spec.rb

@@ -25,12 +25,21 @@ RSpec.describe FinApps::REST::Operators do
         end
       end
 
-      context 'with searchTerm' do
+      context 'with email searchTerm' do
+        let(:params) { {searchTerm: 'term@example.com'} }
+
+        it_behaves_like 'a filtereable GET index request', {
+          '$or': [
+            {email: 'term@example.com'}
+          ]
+        }
+      end
+
+      context 'with non email searchTerm' do
         let(:params) { {searchTerm: 'le term'} }
 
         it_behaves_like 'a filtereable GET index request', {
           '$or': [
-            {email: 'le term'},
             {last_name: 'le term'}
           ]
         }
@@ -65,7 +74,7 @@ RSpec.describe FinApps::REST::Operators do
         it 'builds a full filter and query and sends the request' do
           list
 
-          filter = {'$or': [{email: 't'}, {last_name: 't'}], role: {'$in': [2]}}
+          filter = {'$or': [{last_name: 't'}], role: {'$in': [2]}}
           expect(WebMock).to have_requested(:get, "#{versioned_api_path}/operators"\
                                                   "?filter=#{ERB::Util.url_encode filter.to_json}"\
                                                   '&page=2&requested=25&sort=date_created')

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-if ENV['COVERAGE'] == 'true'
+if ENV.fetch('COVERAGE', nil) == 'true'
   require 'simplecov'
   require 'simplecov-console'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 6.10.1
+  version: 6.10.2
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-13 00:00:00.000000000 Z
+date: 2022-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -483,65 +483,65 @@ signing_key:
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/spec_helper.rb
-- spec/spec_helpers/api_request.rb
-- spec/spec_helpers/client.rb
-- spec/rest/query/screenings_spec.rb
+- spec/support/documents_uploads_routes.rb
+- spec/support/fake_api.rb
+- spec/support/routes/query_screenings.rb
+- spec/support/routes/locations.rb
+- spec/support/routes/states.rb
+- spec/support/routes/actors.rb
+- spec/support/routes/screening_metadatas.rb
+- spec/support/screenings_routes.rb
+- spec/rest/order_assignments_spec.rb
 - spec/rest/query/base_spec.rb
-- spec/rest/portfolios_available_consumers_spec.rb
-- spec/rest/documents_orders_notifications_spec.rb
-- spec/rest/portfolios_alerts_spec.rb
-- spec/rest/version_spec.rb
+- spec/rest/query/screenings_spec.rb
 - spec/rest/alert_occurrences_spec.rb
-- spec/rest/products_spec.rb
 - spec/rest/operator_change_password_email_spec.rb
 - spec/rest/consumers_spec.rb
-- spec/rest/screenings_spec.rb
-- spec/rest/order_notifications_spec.rb
-- spec/rest/tenant_app_settings_spec.rb
-- spec/rest/order_reports_spec.rb
 - spec/rest/documents_uploads_spec.rb
 - spec/rest/operators_spec.rb
 - spec/rest/portfolios_spec.rb
-- spec/rest/locations_spec.rb
-- spec/rest/client_spec.rb
+- spec/rest/alert_definitions_spec.rb
+- spec/rest/consumers_portfolios_spec.rb
+- spec/rest/plaid/plaid_institution_logos_spec.rb
+- spec/rest/plaid/plaid_consumer_institutions_spec.rb
+- spec/rest/plaid/plaid_account_permissions_spec.rb
+- spec/rest/plaid/plaid_accounts_spec.rb
+- spec/rest/plaid/plaid_webhooks_spec.rb
 - spec/rest/actors_spec.rb
-- spec/rest/documents_orders_spec.rb
+- spec/rest/client_spec.rb
+- spec/rest/signed_documents_downloads_spec.rb
+- spec/rest/tenant_app_settings_spec.rb
+- spec/rest/operators_login_tokens_spec.rb
+- spec/rest/order_tokens_spec.rb
 - spec/rest/consumer_login_tokens_spec.rb
+- spec/rest/products_spec.rb
+- spec/rest/password_resets_spec.rb
 - spec/rest/documents_upload_types_spec.rb
 - spec/rest/tenant_settings_spec.rb
-- spec/rest/screening_metadatas_spec.rb
-- spec/rest/order_tokens_spec.rb
-- spec/rest/order_refreshes_spec.rb
+- spec/rest/order_reports_spec.rb
+- spec/rest/locations_spec.rb
 - spec/rest/operators_password_resets_spec.rb
-- spec/rest/order_assignments_spec.rb
-- spec/rest/alert_definitions_spec.rb
-- spec/rest/signed_documents_downloads_spec.rb
-- spec/rest/operators_login_tokens_spec.rb
-- spec/rest/verix/verix_metadata_spec.rb
-- spec/rest/verix/verix_records_spec.rb
-- spec/rest/verix/verix_pdf_documents_spec.rb
-- spec/rest/verix/verix_documents_spec.rb
-- spec/rest/password_resets_spec.rb
-- spec/rest/plaid/plaid_webhooks_spec.rb
-- spec/rest/plaid/plaid_account_permissions_spec.rb
-- spec/rest/plaid/plaid_institution_logos_spec.rb
-- spec/rest/plaid/plaid_accounts_spec.rb
-- spec/rest/plaid/plaid_consumer_institutions_spec.rb
-- spec/rest/states_spec.rb
+- spec/rest/sessions_spec.rb
+- spec/rest/portfolios_alerts_spec.rb
 - spec/rest/esign_templates_spec.rb
+- spec/rest/portfolios_available_consumers_spec.rb
+- spec/rest/portfolio_reports_spec.rb
+- spec/rest/version_spec.rb
+- spec/rest/verix/verix_documents_spec.rb
+- spec/rest/verix/verix_pdf_documents_spec.rb
+- spec/rest/verix/verix_records_spec.rb
+- spec/rest/verix/verix_metadata_spec.rb
 - spec/rest/portfolios_consumers_spec.rb
+- spec/rest/screenings_spec.rb
+- spec/rest/screening_metadatas_spec.rb
+- spec/rest/states_spec.rb
+- spec/rest/documents_orders_notifications_spec.rb
+- spec/rest/order_refreshes_spec.rb
 - spec/rest/order_statuses_spec.rb
-- spec/rest/portfolio_reports_spec.rb
-- spec/rest/sessions_spec.rb
-- spec/rest/consumers_portfolios_spec.rb
 - spec/rest/orders_spec.rb
+- spec/rest/documents_orders_spec.rb
+- spec/rest/order_notifications_spec.rb
 - spec/utils/query_builder_spec.rb
-- spec/support/screenings_routes.rb
-- spec/support/documents_uploads_routes.rb
-- spec/support/routes/screening_metadatas.rb
-- spec/support/routes/query_screenings.rb
-- spec/support/routes/states.rb
-- spec/support/routes/actors.rb
-- spec/support/routes/locations.rb
-- spec/support/fake_api.rb
+- spec/spec_helpers/client.rb
+- spec/spec_helpers/api_request.rb
+- spec/spec_helper.rb