finapps 5.0.7 → 5.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab24b272e6e171ea6c7ad7d9ca7959b6956ae5c8517038d5f840e5192eb986f1
-  data.tar.gz: fc9ec00111fabfe80f88bffd7dcc7fcb58f6295af88141b733c221c8e14bb31a
+  metadata.gz: 8649be674c821b90c09a46379fd7aef455ca72fe0132098dd31ee20cd0253aed
+  data.tar.gz: cbf53968080c0e7b5d3fc57dd407a8432eb8f6d6b458bdae3e79fde4b272cf26
 SHA512:
-  metadata.gz: 6d5b36a60fd530326606774e61b359a8b139413474b9154b10ea1eb3631d705487e8691b8c2688cc5a5766de3cde88662c6c741b5ad6066b81235c728136c10f
-  data.tar.gz: 12c432b8e6ee664fa19248860caa8bee028ea1d2af7c167474b3417879011576b922cee932d20e33cc69813b41676922d7bcceb0aa975cb3e346d98f68320322
+  metadata.gz: d6dacf98bbd260391a83a555f9ea40c03dfdda6ccc77ca8cf305ff0646f487baaa3b3c8b326410037c0b47f0b2a702f1e0b1936f3b69d6a23385d1cef927d6a2
+  data.tar.gz: 3c444a8a58f341b1e7b3ea173d4c777a11f448fc6a27015518ff0385ee61b5c87a0ffd7722db94e07109174c2bb9fcbd412046a05d8f8e88d09ade3c49f120a3

data/.gitignore

@@ -31,3 +31,8 @@ mkmf.log
 
 # vim swap files
 *.swp
+
+# node_modules
+node_modules/
+package.json
+yarn.lock

data/finapps.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.2'
+  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.3'
 
   spec.add_development_dependency 'bundler',                    '~> 2.0',   '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'

data/lib/finapps/rest/plaid/plaid_consumer_institutions.rb

@@ -7,9 +7,13 @@ module FinApps
         super(params, 'p/institution/consumer')
       end
 
+      def show(id)
+        super nil, "p/institution/consumer/#{id}"
+      end
+
       def list
         super 'p/institution/consumer'
       end
     end
   end
-end
+end

data/lib/finapps/rest/plaid/plaid_resources.rb

@@ -6,7 +6,7 @@ module FinApps
       protected
 
       def end_point
-        super.gsub!('plaid', 'p/')
+        super.gsub('plaid', 'p/')
       end
     end
   end

data/lib/finapps/rest/sessions.rb

@@ -15,12 +15,14 @@ module FinApps
         begin
           super params, path
         rescue FinAppsCore::ApiUnauthenticatedError
-          return [
-            nil,
+          return(
             [
-              "Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"
+              nil,
+              [
+                "Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"
+              ]
             ]
-          ]
+          )
         end
       end
 

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.7'
+  VERSION = '5.0.8'
 end

data/spec/rest/consumers_spec.rb

@@ -23,9 +23,7 @@ RSpec.describe FinApps::REST::Consumers,
       let(:create) { subject.create(email: 'email', password: 'password') }
 
       it { expect { create }.not_to raise_error }
-      it('results is a Hash') do
-        expect(results).to be_a(Hash)
-      end
+      it('results is a Hash') { expect(results).to be_a(Hash) }
       it('performs a post and returns the response') do
         expect(results).to have_key(:public_id)
       end
@@ -59,9 +57,7 @@ RSpec.describe FinApps::REST::Consumers,
       let(:error_messages) { show[1] }
 
       it { expect { show }.not_to raise_error }
-      it('results is a Hash') do
-        expect(results).to be_a(Hash)
-      end
+      it('results is a Hash') { expect(results).to be_a(Hash) }
       it('performs a get and returns the response') do
         expect(results).to have_key(:public_id)
       end
@@ -131,9 +127,7 @@ RSpec.describe FinApps::REST::Consumers,
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
-        it('results is a Hash') do
-          expect(results).to be_a(Hash)
-        end
+        it('results is a Hash') { expect(results).to be_a(Hash) }
         it('the public_id is on the results') do
           expect(results).to have_key(:public_id)
         end

data/spec/rest/order_tokens_spec.rb

@@ -23,9 +23,7 @@ RSpec.describe FinApps::REST::OrderTokens,
     context 'for valid token' do
       let(:show) { subject.show(:valid_token) }
       it { expect { show }.not_to raise_error }
-      it('results is a Hashie::Rash') do
-        expect(results).to be_a(Hash)
-      end
+      it('results is a Hash') { expect(results).to be_a(Hash) }
       it('results contains a consumer_id') do
         expect(results).to have_key(:consumer_id)
       end

data/spec/rest/plaid/plaid_consumer_institutions_spec.rb

@@ -9,68 +9,60 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
   let(:api_client) { client }
 
   RSpec.shared_examples 'an API request' do |_parameter|
-    # noinspection RubyBlockToMethodReference
-    it { expect { subject }.not_to raise_error }
+    it do
+      expect do
+        # noinspection RubyBlockToMethodReference
+        subject
+      end.not_to raise_error
+    end
     it('returns an array') { expect(subject).to be_a(Array) }
   end
 
-  describe '#create' do
-    subject(:create) do
-      FinApps::REST::PlaidConsumerInstitutions
-        .new(api_client)
-        .create(public_token: 'le-token')
+  RSpec.shared_examples 'a successful request' do |_parameter|
+    it('returns no error messages') do
+      expect(subject[ERROR_MESSAGES]).to be_empty
     end
+  end
 
-    context 'when valid tenant token is provided' do
-      it_behaves_like 'an API request'
+  RSpec.shared_examples 'a request that returns institution data' do |_parameter|
+    it('returns institution data') do
+      expect(subject[RESULTS]).to have_key(:_id)
+    end
+  end
 
-      it('performs a post and returns information about the institution') do
-        expect(create[RESULTS]).to have_key(:_id)
-      end
-      it('returns no error messages') do
-        expect(create[ERROR_MESSAGES]).to be_empty
-      end
+  describe '#create' do
+    subject(:create) do
+      FinApps::REST::PlaidConsumerInstitutions.new(api_client).create(
+        public_token: 'le-token'
+      )
     end
 
-    context 'when invalid tenant token is provided' do
-      let(:api_client) { client(:invalid_tenant_token) }
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+    it_behaves_like 'a request that returns institution data'
+  end
 
-      it_behaves_like 'an API request'
-      it('results is nil') { expect(create[RESULTS]).to be_nil }
-      it('error messages array is populated') do
-        expect(create[ERROR_MESSAGES].first.downcase).to eq('resource not found')
-      end
+  describe '#show' do
+    subject(:show) do
+      FinApps::REST::PlaidConsumerInstitutions.new(api_client).show(
+        :consumer_institution_id
+      )
     end
+
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+    it_behaves_like 'a request that returns institution data'
   end
 
   describe '#list' do
     subject(:list) do
-      FinApps::REST::PlaidConsumerInstitutions
-        .new(api_client)
-        .list
+      FinApps::REST::PlaidConsumerInstitutions.new(api_client).list
     end
 
-    context 'when valid tenant token is provided' do
-      it_behaves_like 'an API request'
-
-      it('returns an Array of institution data') do
-        result = list[RESULTS]
-        expect(result).to be_an(Array)
-        expect(result.first).to have_key(:_id)
-      end
-      it('returns no error messages') do
-        expect(list[ERROR_MESSAGES]).to be_empty
-      end
-    end
-
-    context 'when invalid tenant token is provided' do
-      let(:api_client) { client(:invalid_tenant_token) }
-
-      it_behaves_like 'an API request'
-      it('results is nil') { expect(list[RESULTS]).to be_nil }
-      it('error messages array is populated') do
-        expect(list[ERROR_MESSAGES].first.downcase).to eq('resource not found')
-      end
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+    it('returns an Array of institution data') do
+      expect(list[RESULTS].first).to have_key(:_id)
     end
   end
 end

data/spec/rest/sessions_spec.rb

@@ -45,12 +45,8 @@ RSpec.describe FinApps::REST::Sessions,
         { email: 'email@domain.com', password: 'valid_password' }
       end
 
-      it('results is a Hashie::Rash') do
-        expect(results).to be_a(Hash)
-      end
-      it('token value is in the result') do
-        expect(results).to have_key(:token)
-      end
+      it('results is a Hash') { expect(results).to be_a(Hash) }
+      it('token value is in the result') { expect(results).to have_key(:token) }
       it('error_messages is empty') { expect(error_messages).to be_empty }
     end
 
@@ -60,12 +56,8 @@ RSpec.describe FinApps::REST::Sessions,
         { email: 'email@domain.com', password: 'valid_password' }
       end
 
-      it('results is a Hashie::Rash') do
-        expect(results).to be_a(Hash)
-      end
-      it('token value is in the result') do
-        expect(results).to have_key(:token)
-      end
+      it('results is a Hash') { expect(results).to be_a(Hash) }
+      it('token value is in the result') { expect(results).to have_key(:token) }
       it('returns operator for operator path') do
         expect(results).to have_key(:role)
       end

data/spec/support/fake_api.rb

@@ -26,6 +26,9 @@ class FakeApi < Sinatra::Base
   end
 
   # plaid_institution_consumer
+  get("/#{version}/p/institution/consumer/:consumer_institution_id") do
+    json_response 200, 'plaid/institution/consumer/show.json'
+  end
   get("/#{version}/p/institution/consumer") do
     tenant_token = request.env['HTTP_X_TENANT_TOKEN']
     if tenant_token == 'invalid_tenant_token'

data/spec/support/fixtures/plaid/institution/consumer/show.json

@@ -0,0 +1,19 @@
+{
+  "_id": "5d435bb8c80c5c00010d88b1",
+  "status": 4,
+  "status_text": null,
+  "error": null,
+  "webhook": null,
+  "institution_name": "",
+  "plaid_institution_id": "",
+  "metrics": {
+    "available_products": null,
+    "billed_products": null,
+    "last_webhook": null,
+    "last_webhook_code": null,
+    "last_successful_transaction_update": null,
+    "last_failed_transaction_update": null
+  },
+  "created_date": "2019-08-01T21:38:00.261008261Z",
+  "modified_date": "2019-08-01T21:38:00.261008261Z"
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.7
+  version: 5.0.8
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-05 00:00:00.000000000 Z
+date: 2019-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -19,7 +19,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.2
+        version: 5.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.2
+        version: 5.0.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -385,6 +385,7 @@ files:
 - spec/support/fixtures/plaid/institution/consumer/add-missing-public-token.json
 - spec/support/fixtures/plaid/institution/consumer/add.json
 - spec/support/fixtures/plaid/institution/consumer/list.json
+- spec/support/fixtures/plaid/institution/consumer/show.json
 - spec/support/fixtures/plaid/webhook.json
 - spec/support/fixtures/portfolio.json
 - spec/support/fixtures/portfolio_reports.json