finapps 5.0.47 → 5.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 487960017ebcda19c22179e090cb9328708a57dd5e54e0d05cc27e5660251d57
-  data.tar.gz: 95abe37a2a66f36f973eb453d2302df92a9d1208c2ad5f20b4b6caf21737c358
+  metadata.gz: e65bb80fb054553a018a117ef278f51ca1f39cae1c51b32951c1c23b66456ae9
+  data.tar.gz: 98365bd10401bd230e3884d626f7a305bd331c02497445fa25484ba09ba14b42
 SHA512:
-  metadata.gz: 5df1695cc14dc3a96d47867786a7f564806b5f58d56511c9e08482e3e9ce4767ac03257c055f644b2517d25666a70d0b6312f43fd218607258c642d967061a98
-  data.tar.gz: 9f063fed1bafb02f77ed3b10230c77d757e0ae09c0f7d202f9d78d699dc1d7ba5f0809d59591f608c32aa9c81d86795b932ab5220d0adc13fcea07b2583c4d26
+  metadata.gz: e64cf1d45c0895165c6d7a47a8e762c3fba2c8925f16177dca3702853aff83834e9296be6942bc6025a7a22fc472dd4c44a9db9d7da079777a0c6e51e7c76a44
+  data.tar.gz: 3203972fa2e7001d4f099b8668368d263f253848e0b8d85ed6bba7dd9034c5344db5d15ca310f8daedeecc04d088a36c1332cb28f58460c6015cae1e2ae899da

data/.github/dependabot.yml

@@ -0,0 +1,7 @@
+version: 2
+updates:
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.github/workflows/{main.yaml → ci.yaml}

@@ -1,9 +1,16 @@
 name: Continuous Integration
 
-on: [push, pull_request]
-
+on: 
+  push: 
+    paths-ignore:
+      - ".github/**"
+      - ".VERSION"
+  pull_request:
+    paths-ignore:
+      - ".github/**"
+      - ".VERSION"
 jobs:
-  ci:
+  tests:
     if: "!contains(github.event.head_commit.message, 'skip ci')"
     runs-on: ubuntu-latest
 
@@ -11,26 +18,30 @@ jobs:
       fail-fast: true
 
     steps:
-      - uses: actions/checkout@v1
+      - name: Checkout source code
+        uses: actions/checkout@v2
 
       - name: Install required ruby
         uses: ruby/setup-ruby@v1
 
-      - uses: actions/cache@v2
+      - name: Setup cache key and directory for gems cache
+        uses: actions/cache@v2.1.4
         with:
           path: vendor/bundle
           key: ${{ runner.os  }}-gems-${{ hashFiles('**/Gemfile.lock')  }}
           restore-keys: |
             ${{ runner.os  }}-gems-
 
-      - name: Install gems
+      - name: Bundle install
         run: |
-          gem install -N bundler
           bundle config path vendor/bundle
-          bundle install --jobs 4 --retry 3
+          bundle config set jobs 4
+          bundle config set retry 3
+          bundle install
 
       - name: Run rubocop
-        run: bundle exec rubocop
+        run: | 
+          bundle exec rubocop --parallel
 
       - name: Run tests
         run: bundle exec rspec

data/.github/workflows/release.yml

@@ -2,53 +2,53 @@ name: Bump version and Release
 on:
   release:
     types: [published]
-          
+
 jobs:
   release:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
 
-    steps:
-    - uses: actions/checkout@master
-      with:
-        persist-credentials: false
-        fetch-depth: 0 # otherwise, you will failed to push refs to dest repo
+    steps: 
+      - name: Checkout source code
+        uses: actions/checkout@v2
+        with:
+          persist-credentials: false
+          fetch-depth: 0 # otherwise, you will fail to push refs to dest repo
+
+      - name: Install required ruby version
+        uses: ruby/setup-ruby@v1 
+
+      - name: Get version from latest tag
+        id: get_version
+        uses: battila7/get-version-action@v2
+
+      - name: Bump version   
+        run: |
+          gem install -N gem-release
+          git config --local user.email "action@github.com"
+          git config --local user.name "GitHub Action"
+          gem bump --skip-ci --version ${{ steps.get_version.outputs.version-without-v }}
 
-    - uses: actions/setup-ruby@v1
-      with: 
-        ruby-version: '2.6'
-        
-    - name: Get version from latest tag
-      id: get_version
-      uses: battila7/get-version-action@v2
+      - name: Push changes
+        uses: ad-m/github-push-action@master
+        with:
+          # GitHub Actions token does not support pushing to protected branches.
+          # github_token: ${{ secrets.GITHUB_TOKEN }}
+          #        
+          # A manually populated`PERSONAL_ACCESS_TOKEN` environment variable 
+          # with permissions to push to a protected branch must be used.
+          # not ideal - keep eyes open for a better solution
+          github_token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
 
-    - name: Bump version   
-      run: |
-        gem install -N gem-release
-        git config --local user.email "action@github.com"
-        git config --local user.name "GitHub Action"
-        gem bump --skip-ci --version ${{ steps.get_version.outputs.version-without-v }}
-        
-    - name: Push changes
-      uses: ad-m/github-push-action@master
-      with:
-        # GitHub Actions token does not support pushing to protected branches.
-        # github_token: ${{ secrets.GITHUB_TOKEN }}
-        #        
-        # A manually populated`PERSONAL_ACCESS_TOKEN` environment variable 
-        # with permissions to push to a protected branch must be used.
-        # not ideal - keep eyes open for a better solution
-        github_token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
-        
-    - name: Release gem to rubygems.org    
-      run: |
-        set +x
-        mkdir -p ~/.gem
-        cat << EOF > ~/.gem/credentials
-        ---
-        :rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}
-        EOF
-        chmod 0600 ~/.gem/credentials
-        set -x
-        gem release
+      - name: Release gem to rubygems.org    
+        run: |
+          set +x
+          mkdir -p ~/.gem
+          cat << EOF > ~/.gem/credentials
+          ---
+          :rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}
+          EOF
+          chmod 0600 ~/.gem/credentials
+          set -x
+          gem release

data/.rubocop.yml

@@ -48,7 +48,7 @@ Metrics/ClassLength:
     - app/controllers/orders_controller.rb
     - app/models/order.rb
 Metrics/BlockLength:
-  ExcludedMethods: ['describe', 'context']
+  IgnoredMethods: ['describe', 'context']
   Exclude:
     - config/environments/**/**
     - Guardfile

data/.ruby-version

@@ -1 +1 @@
-ruby-2.6.3
+ruby-2.7.2

data/Guardfile

@@ -17,7 +17,7 @@
 #
 # and, you'll have to watch "config/Guardfile" instead of "Guardfile"
 
-# Note: The cmd option is now required due to the increasing number of ways
+# NOTE: The cmd option is now required due to the increasing number of ways
 #       rspec may be run, below are examples of the most common uses.
 #  * bundler: 'bundle exec rspec'
 #  * bundler binstubs: 'bin/rspec'

data/finapps.gemspec

@@ -20,19 +20,20 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.13'
+  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.15'
 
   spec.add_development_dependency 'bundler',                    '~> 2.0',   '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
   spec.add_development_dependency 'guard',                      '~> 2.16',  '>= 2.16.1'
   spec.add_development_dependency 'guard-rspec',                '~> 4.7',   '>= 4.7.3'
   spec.add_development_dependency 'rake',                       '~> 13.0',  '>= 13.0.1'
-  spec.add_development_dependency 'rspec',                      '~> 3.9',   '>= 3.9.0'
-  spec.add_development_dependency 'rubocop',                    '~> 0.87',  '>= 0.87.0'
-  spec.add_development_dependency 'rubocop-performance',        '~> 1.7',   '>= 1.7.0'
-  spec.add_development_dependency 'rubocop-rspec',              '~> 1.41',  '>= 1.41.0'
-  spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.8'
-  spec.add_development_dependency 'webmock',                    '~> 3.8',   '>= 3.8.0'
+  spec.add_development_dependency 'rspec',                      '~> 3.10',  '>= 3.10.0'
+  spec.add_development_dependency 'rubocop',                    '~> 1.9',   '>= 1.9.1'
+  spec.add_development_dependency 'rubocop-performance',        '~> 1.9',   '>= 1.9.2'
+  spec.add_development_dependency 'rubocop-rake',               '~> 0.5',   '>= 0.5.1'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 2.2',   '>= 2.2.0'
+  spec.add_development_dependency 'sinatra',                    '~> 2.1',   '>= 2.1.0'
+  spec.add_development_dependency 'webmock',                    '~> 3.11',  '>= 3.11.2'
 
   spec.extra_rdoc_files = %w[README.md LICENSE.txt]
   spec.rdoc_options = %w[--line-numbers --inline-source --title finapps-ruby --main README.md]

data/lib/finapps/rest/client.rb

@@ -83,7 +83,7 @@ module FinApps
 
       def camelize(term)
         string = term.to_s
-        string = string.sub(/^[a-z\d]*/) { $&.capitalize }
+        string = string.sub(/^[a-z\d]*/) { Regexp.last_match(0).capitalize }
         string.gsub(%r{(?:_|(/))([a-z\d]*)}) do
           Regexp.last_match(2).capitalize.to_s
         end

data/lib/finapps/rest/consumers.rb

@@ -62,9 +62,10 @@ module FinApps
 
       def with_space_search(term)
         [
-          {"email": term},
-          {"first_name": term},
-          {"last_name": term}
+          {external_id: term},
+          {email: term},
+          {first_name: term},
+          {last_name: term}
         ]
       end
 
@@ -72,8 +73,8 @@ module FinApps
         search_arr = []
         if /\s/.match?(term)
           term.split.each do |t|
-            search_arr.append("first_name": t)
-            search_arr.append("last_name": t)
+            search_arr.append(first_name: t)
+            search_arr.append(last_name: t)
           end
         end
         search_arr

data/lib/finapps/rest/documents_orders.rb

@@ -90,22 +90,21 @@ module FinApps
       end
 
       def with_space_search(term)
-        [
-          {"applicant.email": term},
-          {"applicant.first_name": term},
-          {"applicant.last_name": term},
-          {
-            "reference_no": {
-              "$regex": "^#{term}", "$options": 'i'
-            }
-          }
-        ]
+        [{"applicant.email": term},
+         {"applicant.first_name": term},
+         {"applicant.last_name": term},
+         {"applicant.external_id": term},
+         {
+           reference_no: {
+             "$regex": "^#{term}", "$options": 'i'
+           }
+         }]
       end
 
       def tag_query(tag)
         return {} unless tag
 
-        {"tag": tag.empty? ? nil : tag}
+        {tag: tag.empty? ? nil : tag}
       end
 
       def status_query(status)
@@ -117,7 +116,7 @@ module FinApps
       def consumer_query(consumer)
         return {} unless consumer
 
-        {"consumer_id": consumer.empty? ? nil : consumer}
+        {consumer_id: consumer.empty? ? nil : consumer}
       end
     end
   end

data/lib/finapps/rest/operators.rb

@@ -64,14 +64,14 @@ module FinApps
       end
 
       def search_query(term)
-        {"last_name": term}
+        {last_name: term}
       end
 
       def role_query(role)
         if role.is_a?(Array)
-          {"role": {"$in": role.map(&:to_i)}}
+          {role: {"$in": role.map(&:to_i)}}
         else
-          {"role": role.to_i}
+          {role: role.to_i}
         end
       end
     end

data/lib/finapps/rest/orders.rb

@@ -81,7 +81,7 @@ module FinApps
       end
 
       def search_query_object(term)
-        [{"public_id": {"$regex": "^#{term}", "$options": 'i'}},
+        [{public_id: {"$regex": "^#{term}", "$options": 'i'}},
          {"assignment.last_name": term},
          {"applicant.first_name": term},
          {"applicant.last_name": term},
@@ -95,9 +95,9 @@ module FinApps
       def status_query(status)
         if status
           if status.is_a?(Array)
-            {"status": {"$in": status.map(&:to_i)}}
+            {status: {"$in": status.map(&:to_i)}}
           else
-            {"status": status.to_i}
+            {status: status.to_i}
           end
         else
           {}
@@ -115,7 +115,7 @@ module FinApps
 
       def consumer_query(consumer)
         if consumer
-          {"consumer_id": consumer.empty? ? nil : consumer}
+          {consumer_id: consumer.empty? ? nil : consumer}
         else
           {}
         end
@@ -125,8 +125,8 @@ module FinApps
         if !search_term && !nil_or_empty?(relation)
           {
             "$or": [
-              {"public_id": {"$in": relation}},
-              {"original_order_id": {"$in": relation}}
+              {public_id: {"$in": relation}},
+              {original_order_id: {"$in": relation}}
             ]
           }
         else

data/lib/finapps/rest/screenings.rb

@@ -14,6 +14,18 @@ module FinApps
         super(nil, path)
       end
 
+      def tenant_schemas
+        path = 'schemas'
+        send_request path, :get
+      end
+
+      def last(consumer_id)
+        not_blank(consumer_id, :consumer_id)
+
+        path = "#{end_point}/#{ERB::Util.url_encode(consumer_id)}/consumer"
+        send_request_for_id path, :get, nil
+      end
+
       def create(params)
         not_blank(params, :params)
         super params
@@ -34,6 +46,12 @@ module FinApps
         super params, path
       end
 
+      def destroy(id)
+        not_blank(id, :session_id)
+
+        super
+      end
+
       private
 
       def build_filter(params)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.47'
+  VERSION = '5.4.0'
 end

data/spec/rest/consumers_spec.rb

@@ -118,11 +118,14 @@ RSpec.describe FinApps::REST::Consumers do
 
         it 'builds query and sends proper request' do
           list
-          url = "#{versioned_api_path}/consumers?"\
-            'filter=%7B%22$or%22:%5B%7B%22email%22:%22term%22%7D,' \
-            '%7B%22first_name%22:%22term%22%7D,'\
-            '%7B%22last_name%22:%22term%22%7D%5D%7D&page=2&requested=25' \
-            '&sort=date_created'
+          filter = '{"$or":['\
+            '{"external_id":"term"},'\
+            '{"email":"term"},'\
+            '{"first_name":"term"},'\
+            '{"last_name":"term"}'\
+            ']}'
+          query = "?filter=#{filter}&page=2&requested=25&sort=date_created"
+          url = "#{versioned_api_path}/consumers#{query}"
           expect(WebMock).to have_requested(:get, url)
         end
 
@@ -138,13 +141,18 @@ RSpec.describe FinApps::REST::Consumers do
 
           it 'treats space as start of a new query for first and last name' do
             list
-            url = "#{versioned_api_path}/consumers?"\
-              'filter=%7B%22$or%22:%5B%7B%22email%22:%22Two%20terms%22%7D,'\
-              '%7B%22first_name%22:%22Two%20terms%22%7D,'\
-              '%7B%22last_name%22:%22Two%20terms%22%7D,%7B%22first_name%22:'\
-              '%22Two%22%7D,%7B%22last_name%22:%22Two%22%7D,'\
-              '%7B%22first_name%22:%22terms%22%7D,%7B%22last_name%22:'\
-              '%22terms%22%7D%5D%7D&page=2&requested=25&sort=date_created'
+            filter = '{"$or":['\
+              '{"external_id":"Two terms"},'\
+              '{"email":"Two terms"},'\
+              '{"first_name":"Two terms"},'\
+              '{"last_name":"Two terms"},'\
+              '{"first_name":"Two"},'\
+              '{"last_name":"Two"},'\
+              '{"first_name":"terms"},'\
+              '{"last_name":"terms"}'\
+              ']}'
+            query = "?filter=#{filter}&page=2&requested=25&sort=date_created"
+            url = "#{versioned_api_path}/consumers#{query}"
             expect(WebMock).to have_requested(:get, url)
           end
         end

data/spec/rest/documents_orders_spec.rb

@@ -52,33 +52,30 @@ RSpec.describe FinApps::REST::DocumentsOrders do
             "#{versioned_api_path}/documents/orders?"\
             'filter=%7B%22$or%22:%5B%7B%22applicant.email%22:'\
             '%22term%22%7D,%7B%22applicant.first_name%22:%22term%22%7D,'\
-            '%7B%22applicant.last_name%22:'\
-            '%22term%22%7D,%7B%22reference_no%22:%7B%22$regex%22:%22%5Eterm%22,'\
-            '%22$options%22:%22i%22%7D%7D%5D,'\
-            '%22consumer_id%22:%22valid_consumer_id%22%7D&'\
-            'page=2&requested=25&sort=tag '
+            '%7B%22applicant.last_name%22:%22term%22%7D,'\
+            '%7B%22applicant.external_id%22:%22term%22%7D,%7B%22reference_no%22:'\
+            '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,'\
+            '%22consumer_id%22:%22valid_consumer_id%22%7D&page=2&requested=25&sort=tag'
 
           expect(WebMock).to have_requested(:get, url)
         end
 
         context 'with search term containing spaces' do
-          let(:params) { {"searchTerm": 'Blue Jay', "page": 2} }
+          let(:params) { {searchTerm: 'Blue Jay', page: 2} }
 
           it 'builds query and sends proper request' do
             list
             url =
               "#{versioned_api_path}/documents/orders?"\
               'filter=%7B%22$or%22:%5B%7B%22applicant.email%22:'\
-              '%22Blue%20Jay%22%7D,'\
-              '%7B%22applicant.first_name%22:%22Blue%20Jay%22%7D,'\
-              '%7B%22applicant.last_name%22:'\
-              '%22Blue%20Jay%22%7D,'\
-              '%7B%22reference_no%22:%7B%22$regex%22:%22%5EBlue%20Jay%22,'\
-              '%22$options%22:'\
-              '%22i%22%7D%7D,%7B%22applicant.first_name%22:%22Blue%22%7D,'\
-              '%7B%22applicant.last_name%22:%22Blue%22%7D,'\
-              '%7B%22applicant.first_name%22:%22Jay%22%7D,'\
-              '%7B%22applicant.last_name%22:%22Jay%22%7D%5D%7D&page=2'
+              '%22Blue%20Jay%22%7D,%7B%22applicant.first_name%22:'\
+              '%22Blue%20Jay%22%7D,%7B%22applicant.last_name%22:'\
+              '%22Blue%20Jay%22%7D,%7B%22applicant.external_id%22:'\
+              '%22Blue%20Jay%22%7D,%7B%22reference_no%22:%7B%22$regex%22:'\
+              '%22%5EBlue%20Jay%22,%22$options%22:%22i%22%7D%7D,'\
+              '%7B%22applicant.first_name%22:%22Blue%22%7D,%7B%22'\
+              'applicant.last_name%22:%22Blue%22%7D,%7B%22applicant.first_name%22:'\
+              '%22Jay%22%7D,%7B%22applicant.last_name%22:%22Jay%22%7D%5D%7D&page=2'
 
             expect(WebMock).to have_requested(:get, url)
           end
@@ -174,17 +171,17 @@ RSpec.describe FinApps::REST::DocumentsOrders do
     context 'with valid params' do
       let(:params) do
         {
-          "applicant": {
-            "email": 'validemail@financialapps.com',
-            "first_name": 'Emily',
-            "last_name": 'Macs',
-            "role": 'patient'
+          applicant: {
+            email: 'validemail@financialapps.com',
+            first_name: 'Emily',
+            last_name: 'Macs',
+            role: 'patient'
           },
-          "esign_documents": [
+          esign_documents: [
             'temp-id'
           ],
-          "reference_no": 'REFNO',
-          "tag": 'new'
+          reference_no: 'REFNO',
+          tag: 'new'
         }
       end
 
@@ -200,13 +197,13 @@ RSpec.describe FinApps::REST::DocumentsOrders do
     context 'with invalid params' do
       let(:params) do
         {
-          "applicant": {
-            "email": 'validemail@financialapps.com',
-            "first_name": 'Emily',
-            "last_name": 'Macs',
-            "role": 'patient'
+          applicant: {
+            email: 'validemail@financialapps.com',
+            first_name: 'Emily',
+            last_name: 'Macs',
+            role: 'patient'
           },
-          "reference_no": 'REFNO'
+          reference_no: 'REFNO'
         }
       end
 
@@ -236,7 +233,7 @@ RSpec.describe FinApps::REST::DocumentsOrders do
       let(:id) { :valid_order_id }
 
       context 'with valid params' do
-        let(:params) { {"tag": 'pending'} }
+        let(:params) { {tag: 'pending'} }
 
         it_behaves_like 'an API request'
         it_behaves_like 'a successful request'
@@ -244,7 +241,7 @@ RSpec.describe FinApps::REST::DocumentsOrders do
       end
 
       context 'with invalid params' do
-        let(:params) { {"tag": 'invalid'} }
+        let(:params) { {tag: 'invalid'} }
 
         it_behaves_like 'an API request'
         it('results is nil') { expect(results).to be_nil }

data/spec/rest/screenings_spec.rb

@@ -6,12 +6,12 @@ require 'rest/api_request'
 RSpec.describe FinApps::REST::Screenings do
   include SpecHelpers::Client
 
+  let(:results) { subject[0] }
+  let(:error_messages) { subject[1] }
+
   describe '#list' do
     subject(:list) { described_class.new(client).list(params) }
 
-    let(:results) { list[0] }
-    let(:error_messages) { list[1] }
-
     context 'with valid params' do
       let(:params) do
         {
@@ -76,12 +76,26 @@ RSpec.describe FinApps::REST::Screenings do
     end
   end
 
+  describe '#tenant_schemas' do
+    subject(:tenant_schemas) { described_class.new(client).tenant_schemas }
+
+    it_behaves_like 'an API request'
+    it_behaves_like 'a successful request'
+    it 'performs a get and returns the response' do
+      expect(results[0]).to have_key(:external_url)
+    end
+
+    it 'sends proper request' do
+      tenant_schemas
+      url = "#{versioned_api_path}/schemas"
+
+      expect(WebMock).to have_requested(:get, url)
+    end
+  end
+
   describe '#show' do
     subject(:show) { described_class.new(client).show(id) }
 
-    let(:results) { show[0] }
-    let(:error_messages) { show[1] }
-
     context 'with valid id' do
       let(:id) { :valid_id }
 
@@ -106,19 +120,43 @@ RSpec.describe FinApps::REST::Screenings do
     end
   end
 
+  describe '#last' do
+    subject(:last) { described_class.new(client).last(consumer_id) }
+
+    context 'with valid consumer_id' do
+      let(:consumer_id) { :valid_consumer_id }
+
+      it_behaves_like 'an API request'
+      it_behaves_like 'a successful request'
+      it('results have an :s_id node') do
+        expect(results).to have_key(:s_id)
+      end
+    end
+
+    context 'with invalid consumer_id' do
+      let(:consumer_id) { :invalid_consumer_id }
+
+      it { expect(results).to be_nil }
+      it { expect(error_messages).not_to be_empty }
+    end
+
+    context 'when missing consumer_id' do
+      let(:consumer_id) { nil }
+
+      it_behaves_like 'a request that raises an error'
+    end
+  end
+
   describe '#create' do
     subject(:create) { described_class.new(client).create(params) }
 
-    let(:results) { create[0] }
-    let(:error_messages) { create[1] }
-
     context 'with valid params' do
       let(:params) do
         {
-          "email": 'validemail@financialapps.com',
-          "first_name": 'Geo',
-          "last_name": 'Metric',
-          "public_id": '1234'
+          email: 'validemail@financialapps.com',
+          first_name: 'Geo',
+          last_name: 'Metric',
+          public_id: '1234'
         }
       end
 
@@ -132,7 +170,7 @@ RSpec.describe FinApps::REST::Screenings do
     end
 
     context 'with invalid params' do
-      let(:params) { {"params": 'invalid'} }
+      let(:params) { {params: 'invalid'} }
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
@@ -153,14 +191,12 @@ RSpec.describe FinApps::REST::Screenings do
     subject(:update) { described_class.new(client).update(id, params) }
 
     let(:params) { {} }
-    let(:results) { update[0] }
-    let(:error_messages) { update[1] }
 
     context 'with valid session id' do
       let(:id) { :valid_id }
 
       context 'with valid params' do
-        let(:params) { {"question_id": '1234'} }
+        let(:params) { {question_id: '1234'} }
 
         it_behaves_like 'an API request'
         it_behaves_like 'a successful request'
@@ -170,7 +206,7 @@ RSpec.describe FinApps::REST::Screenings do
       end
 
       context 'with invalid params' do
-        let(:params) { {"question_id": 'invalid'} }
+        let(:params) { {question_id: 'invalid'} }
 
         it_behaves_like 'an API request'
         it('results is nil') { expect(results).to be_nil }
@@ -183,7 +219,7 @@ RSpec.describe FinApps::REST::Screenings do
 
     context 'with invalid session id' do
       let(:id) { :invalid_id }
-      let(:params) { {"question_id": '1234'} }
+      let(:params) { {question_id: '1234'} }
 
       it_behaves_like 'an API request'
       it('results is nil') { expect(results).to be_nil }
@@ -195,4 +231,38 @@ RSpec.describe FinApps::REST::Screenings do
       end
     end
   end
+
+  describe '#destroy' do
+    subject(:destroy) { described_class.new(client).destroy(id) }
+
+    context 'with valid session id' do
+      let(:id) { :valid_id }
+
+      it_behaves_like 'an API request'
+      it_behaves_like 'a successful request'
+      it('results is nil') { expect(results).to be_nil }
+      it('error_messages is empty') { expect(error_messages).to be_empty }
+    end
+
+    context 'when missing session id' do
+      let(:id) { nil }
+
+      it_behaves_like 'a request that raises an error'
+    end
+
+    context 'with invalid session id' do
+      let(:id) { :invalid_id }
+
+      it_behaves_like 'an API request'
+      it('results is nil') { expect(results).to be_nil }
+
+      it('error_messages is not empty') do
+        expect(error_messages).not_to be_empty
+      end
+
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('session not found')
+      end
+    end
+  end
 end

data/spec/support/fake_api.rb

@@ -2,9 +2,9 @@
 
 require 'sinatra/base'
 require_relative 'documents_uploads_routes'
+require_relative 'screenings_routes'
 
 module Fake
-  # rubocop:disable Metrics/ClassLength
   # the FakeApi class is used to mock API requests while testing.
   class FakeApi < Sinatra::Base
     def self.version
@@ -278,33 +278,7 @@ module Fake
     get("/#{version}/documents/upload_types") { json_response 200, 'upload_types.json' }
 
     # screenings
-    get("/#{version}/screenings") { json_response 200, 'screening_list.json' }
-    get("/#{version}/screenings/invalid_id/resume") do
-      json_response 404, 'resource_not_found.json'
-    end
-    get("/#{version}/screenings/valid_id/resume") { json_response 200, 'screening.json' }
-    put("/#{version}/screenings/invalid_id") do
-      json_response 404, 'resource_not_found.json'
-    end
-    put("/#{version}/screenings/valid_id") do
-      request.body.rewind
-      request_payload = JSON.parse request.body.read
-      if request_payload['question_id'] == 'invalid'
-        json_response 400, 'screening_invalid_update.json'
-      else
-        json_response 200, 'screening.json'
-      end
-    end
-
-    post("/#{version}/screenings") do
-      request.body.rewind
-      request_payload = JSON.parse request.body.read
-      if request_payload.key? 'email'
-        json_response 201, 'screening.json'
-      else
-        json_response 400, 'invalid_request_body.json'
-      end
-    end
+    include ScreeningsRoutes
 
     # consumers
     get("/#{version}/consumers") do
@@ -528,6 +502,10 @@ module Fake
 
     private
 
+    def resource_not_found
+      json_response 404, 'resource_not_found.json'
+    end
+
     def json_response(response_code, file_name)
       http_response :json, response_code, file_name
     end
@@ -546,5 +524,4 @@ module Fake
       File.open("#{File.dirname(__FILE__)}/fixtures/#{file_name}").read
     end
   end
-  # rubocop:enable Metrics/ClassLength
 end

data/spec/support/fixtures/screenings/last_session.json

@@ -0,0 +1,13 @@
+{
+  "s_id": "ee8d7a39-5bf2-4e80-9e03-2f88897c4ebd",
+  "date_created": "2021-02-05T21:23:50.368Z",
+  "date_modified": "2021-02-05T21:23:50.368Z",
+  "consumer": {
+    "public_id": "368bf4ac-cd8c-4059-62a7-f19a9d7501df",
+    "email": "christopher+1612473370669@financialapps.com",
+    "first_name": "Dayna",
+    "last_name": "Langosh"
+  },
+  "operator_id": "5d2afdf9-11fc-425b-704d-d74ca7626de8",
+  "progress": 0
+}

data/spec/support/fixtures/screenings/session_not_found_with_id.json

@@ -0,0 +1,5 @@
+{
+  "messages": [
+    "session not found with consumer id (invalid_consumer_id)"
+    ]
+}

data/spec/support/fixtures/screenings/tenant_schemas.json

@@ -0,0 +1,8 @@
+[
+    {
+        "id": "6058c9e67d4ee100015d55e2",
+        "name": "Florida Family Medicaid Eligibility",
+        "description": "Screens applicants for Potential Family Medicaid Eligibility in the State of Florida.",
+        "external_url": ""
+    }
+]

data/spec/support/fixtures/session_not_found.json

@@ -0,0 +1,5 @@
+{
+  "messages": [
+    "session not found"
+  ]
+}

data/spec/support/screenings_routes.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+module Fake
+  module ScreeningsRoutes
+    class << self
+      def included(base)
+        resource = "/#{base.version}/screenings"
+
+        list_routes base, resource
+        resume_routes base, resource
+        update_routes base, resource
+        destroy_routes base, resource
+        create_routes base, resource
+      end
+
+      # rubocop:disable Metrics/MethodLength
+      def list_routes(base, resource)
+        base.get(resource) { json_response 200, 'screening_list.json' }
+        base.get(resource.gsub('screenings', 'schemas')) do
+          json_response 200, 'screenings/tenant_schemas.json'
+        end
+        base.get("#{resource}/:consumer_id/consumer") do
+          if params[:consumer_id] == 'invalid_consumer_id'
+            json_response 404, 'session_not_found.json'
+          else
+            json_response 200, 'screenings/last_session.json'
+          end
+        end
+      end
+      # rubocop:enable Metrics/MethodLength
+
+      def resume_routes(base, resource)
+        base.get("#{resource}/:session_id/resume") do
+          return resource_not_found if params[:session_id] == 'invalid_id'
+
+          json_response 200, 'screening.json'
+        end
+      end
+
+      def update_routes(base, resource)
+        base.put("#{resource}/:session_id") do
+          return resource_not_found if params[:session_id] == 'invalid_id'
+
+          request.body.rewind
+          request_payload = JSON.parse request.body.read
+          if request_payload['question_id'] == 'invalid'
+            json_response 400, 'screening_invalid_update.json'
+          else
+            json_response 200, 'screening.json'
+          end
+        end
+      end
+
+      def create_routes(base, resource)
+        base.post(resource) do
+          request.body.rewind
+          request_payload = JSON.parse request.body.read
+          if request_payload.key? 'email'
+            json_response 201, 'screening.json'
+          else
+            json_response 400, 'invalid_request_body.json'
+          end
+        end
+      end
+
+      def destroy_routes(base, resource)
+        base.delete("#{resource}/:session_id") do
+          if params[:session_id] == 'valid_id'
+            status 200
+          else
+            json_response 404, 'session_not_found.json'
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.47
+  version: 5.4.0
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-19 00:00:00.000000000 Z
+date: 2021-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -19,7 +19,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.13
+        version: 5.0.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.13
+        version: 5.0.15
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -134,122 +134,142 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.10.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.87.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.87'
+        version: '1.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.87.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.87'
+        version: '1.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.7.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.9'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.9'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.9.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.41.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.41'
+        version: '2.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.41.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.41'
+        version: '2.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.8
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.8
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.8.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.11'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.11.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.8.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.11'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.11.2
 description: A simple library for communicating with the FinApps REST API.
 email:
 - erich@financialapps.com
@@ -260,8 +280,9 @@ extra_rdoc_files:
 - LICENSE.txt
 files:
 - ".codeclimate.yml"
+- ".github/dependabot.yml"
 - ".github/release-drafter.yml"
-- ".github/workflows/main.yaml"
+- ".github/workflows/ci.yaml"
 - ".github/workflows/release-drafter.yml"
 - ".github/workflows/release.yml"
 - ".github/workflows/verify-pr-labeled.yml"
@@ -424,6 +445,10 @@ files:
 - spec/support/fixtures/screening.json
 - spec/support/fixtures/screening_invalid_update.json
 - spec/support/fixtures/screening_list.json
+- spec/support/fixtures/screenings/last_session.json
+- spec/support/fixtures/screenings/session_not_found_with_id.json
+- spec/support/fixtures/screenings/tenant_schemas.json
+- spec/support/fixtures/session_not_found.json
 - spec/support/fixtures/sign_url.json
 - spec/support/fixtures/signed_document.pdf
 - spec/support/fixtures/single_consumer_subscribe_error.json
@@ -439,6 +464,7 @@ files:
 - spec/support/fixtures/verix/metadata.json
 - spec/support/fixtures/verix/record/create.json
 - spec/support/fixtures/verix/record/list.json
+- spec/support/screenings_routes.rb
 - spec/utils/query_builder_spec.rb
 - tags
 homepage: https://github.com/finapps/ruby-client
@@ -466,55 +492,56 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/order_assignments_spec.rb
-- spec/rest/documents_uploads_spec.rb
-- spec/rest/portfolio_reports_spec.rb
+- spec/spec_helpers/client.rb
+- spec/support/screenings_routes.rb
+- spec/support/fake_api.rb
+- spec/support/documents_uploads_routes.rb
 - spec/rest/alert_definitions_spec.rb
-- spec/rest/order_notifications_spec.rb
-- spec/rest/verix/verix_documents_spec.rb
-- spec/rest/verix/verix_records_spec.rb
-- spec/rest/verix/verix_metadata_spec.rb
-- spec/rest/verix/verix_pdf_documents_spec.rb
-- spec/rest/api_request.rb
-- spec/rest/documents_upload_types_spec.rb
-- spec/rest/portfolios_consumers_spec.rb
-- spec/rest/esign_templates_spec.rb
-- spec/rest/operators_spec.rb
-- spec/rest/sessions_spec.rb
-- spec/rest/documents_orders_spec.rb
-- spec/rest/version_spec.rb
-- spec/rest/products_spec.rb
-- spec/rest/signed_documents_downloads_spec.rb
-- spec/rest/portfolios_available_consumers_spec.rb
-- spec/rest/plaid/plaid_account_permissions_spec.rb
-- spec/rest/plaid/plaid_accounts_spec.rb
-- spec/rest/plaid/plaid_webhooks_spec.rb
-- spec/rest/plaid/plaid_consumer_institutions_spec.rb
-- spec/rest/plaid/plaid_institution_logos_spec.rb
-- spec/rest/tenant_app_settings_spec.rb
+- spec/rest/documents_orders_notifications_spec.rb
 - spec/rest/order_reports_spec.rb
-- spec/rest/orders_spec.rb
-- spec/rest/client_spec.rb
-- spec/rest/screenings_spec.rb
 - spec/rest/consumers_spec.rb
-- spec/rest/order_statuses_spec.rb
-- spec/rest/password_resets_spec.rb
-- spec/rest/documents_orders_notifications_spec.rb
+- spec/rest/documents_uploads_spec.rb
+- spec/rest/portfolios_available_consumers_spec.rb
 - spec/rest/alert_occurrences_spec.rb
+- spec/rest/screenings_spec.rb
 - spec/rest/portfolios_alerts_spec.rb
+- spec/rest/products_spec.rb
+- spec/rest/tenant_app_settings_spec.rb
+- spec/rest/plaid/plaid_consumer_institutions_spec.rb
+- spec/rest/plaid/plaid_webhooks_spec.rb
+- spec/rest/plaid/plaid_institution_logos_spec.rb
+- spec/rest/plaid/plaid_account_permissions_spec.rb
+- spec/rest/plaid/plaid_accounts_spec.rb
 - spec/rest/order_refreshes_spec.rb
+- spec/rest/order_assignments_spec.rb
+- spec/rest/order_tokens_spec.rb
+- spec/rest/documents_orders_spec.rb
+- spec/rest/signed_documents_downloads_spec.rb
+- spec/rest/portfolios_consumers_spec.rb
+- spec/rest/version_spec.rb
+- spec/rest/documents_upload_types_spec.rb
+- spec/rest/password_resets_spec.rb
+- spec/rest/order_statuses_spec.rb
+- spec/rest/operators_spec.rb
+- spec/rest/portfolio_reports_spec.rb
+- spec/rest/order_notifications_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/esign_templates_spec.rb
+- spec/rest/sessions_spec.rb
+- spec/rest/api_request.rb
+- spec/rest/verix/verix_documents_spec.rb
+- spec/rest/verix/verix_pdf_documents_spec.rb
+- spec/rest/verix/verix_records_spec.rb
+- spec/rest/verix/verix_metadata_spec.rb
 - spec/rest/tenant_settings_spec.rb
 - spec/rest/portfolios_spec.rb
-- spec/rest/order_tokens_spec.rb
-- spec/rest/consumers_portfolios_spec.rb
+- spec/rest/client_spec.rb
 - spec/rest/operators_password_resets_spec.rb
-- spec/support/fake_api.rb
-- spec/support/documents_uploads_routes.rb
+- spec/rest/consumers_portfolios_spec.rb
 - spec/spec_helper.rb
 - spec/utils/query_builder_spec.rb
-- spec/spec_helpers/client.rb