finapps 5.0.34 → 5.0.43

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6958de8a43a73230709100da8c2ddc2c2eef53d2ae74f546c37dbab8d6790b6a
-  data.tar.gz: 4af6e7780029881e968ef5551d3b24c965471a65080b9b45fda47ceb0e57d424
+  metadata.gz: 25bea095f4796915e3b73d50300279a31fd052ca797da34c91a41078f9eecc2b
+  data.tar.gz: 2f4123341bbc2703a26d8ad361428fb050a06c797390d7b57f2b67f07bef90de
 SHA512:
-  metadata.gz: 06c98f429646d29272d6a5b4d7f3f9d9bb38ca20e9e5d4fbce6db76d86200eab81acb64476170f05c705eee82c4cfa44f83f4f3b783777ccb13e962b458be7c3
-  data.tar.gz: fdaa7e5508c7d0f7929f15d8a68ba4137180ce56b1e4be46dcd83d7230d1f2d796d40ef1949d082309e55d7e9a78433ae927f9ec13785ec49dc80d345e8cfb6a
+  metadata.gz: 03c8eccc181f51654a07bad7769ce759707d6f6a54a21a806ce0b924ef7bce7ee17c1f27751a86f9659d83e6e7005988dd48bad3d51127bc1957f6764a392116
+  data.tar.gz: 01205c7a1e01a4267d5dd9ad4e10789872a2e6bf47e29c354ed2c9939c806e01bdfa00b1a1c1c36012397cbc6b235760c99486f8b3f71f17c912ad6e458cf059

data/.github/release-drafter.yml

@@ -0,0 +1,49 @@
+name-template: 'version $RESOLVED_VERSION'
+tag-template: 'v$RESOLVED_VERSION'
+categories:
+  - title: 'Added'
+    labels: 'enhancement'
+  - title: 'Changed'
+    labels: 'change' 
+  - title: 'Deprecated'
+    labels: 'deprecated' 
+  - title: 'Removed'
+    labels: 'removed'     
+  - title: 'Fixed'
+    labels: 'bug'
+  - title: 'Security'
+    label: 'dependencies'
+  - title: 'Documentation updates'
+    label: 'documentation'
+  - title: 'Maintenance'
+    labels: 'internal'  
+      
+change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
+
+version-resolver:
+  major:
+    labels:
+      - 'major'
+  minor:
+    labels:
+      - 'minor'
+  patch:
+    labels:
+      - 'patch'
+  default: patch
+  
+exclude-labels:
+  - reverted
+  - no-changelog
+  - skip-changelog
+  - invalid
+  
+template: |
+  ## [$RESOLVED_VERSION](https://github.com/finapps/ruby-client/compare/$PREVIOUS_TAG...$RESOLVED_VERSION)
+  $CHANGES
+
+replacers:
+  - search: '/CVE-(\d{4})-(\d+)/g'
+    replace: 'https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-$1-$2'
+  - search: '@dependabot-preview'
+    replace: '@dependabot'

data/.github/workflows/main.yaml

@@ -1,15 +1,10 @@
-name: Main
+name: Continuous Integration
 
-on:
-  push:
-    branches:
-      - master
-    pull_request:
-      branches:
-        - master
+on: [push, pull_request]
 
 jobs:
   ci:
+    if: "!contains(github.event.head_commit.message, 'skip ci')"
     runs-on: ubuntu-latest
 
     strategy:
@@ -23,7 +18,7 @@ jobs:
         with:
           ruby-version: '2.6'
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         with:
           path: vendor/bundle
           key: ${{ runner.os  }}-gems-${{ hashFiles('**/Gemfile.lock')  }}
@@ -32,7 +27,7 @@ jobs:
 
       - name: Install gems
         run: |
-          gem install bundler
+          gem install -N bundler
           bundle config path vendor/bundle
           bundle install --jobs 4 --retry 3
 

data/.github/workflows/release-drafter.yml

@@ -0,0 +1,15 @@
+name: Release Drafter
+
+on:
+  push:
+    branches:
+      - master
+
+jobs:
+  update_release_draft:
+    if: "!contains(github.event.head_commit.message, 'skip ci')"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: release-drafter/release-drafter@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/.github/workflows/release.yml

@@ -0,0 +1,54 @@
+name: Bump version and Release
+on:
+  release:
+    types: [published]
+          
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+
+    steps:
+    - uses: actions/checkout@master
+      with:
+        persist-credentials: false
+        fetch-depth: 0 # otherwise, you will failed to push refs to dest repo
+
+    - uses: actions/setup-ruby@v1
+      with: 
+        ruby-version: '2.6'
+        
+    - name: Get version from latest tag
+      id: get_version
+      uses: battila7/get-version-action@v2
+
+    - name: Bump version   
+      run: |
+        gem install -N gem-release
+        git config --local user.email "action@github.com"
+        git config --local user.name "GitHub Action"
+        gem bump --skip-ci --version ${{ steps.get_version.outputs.version-without-v }}
+        
+    - name: Push changes
+      uses: ad-m/github-push-action@master
+      with:
+        # GitHub Actions token does not support pushing to protected branches.
+        # github_token: ${{ secrets.GITHUB_TOKEN }}
+        #        
+        # A manually populated`PERSONAL_ACCESS_TOKEN` environment variable 
+        # with permissions to push to a protected branch must be used.
+        # not ideal - keep eyes open for a better solution
+        github_token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
+        
+    - name: Release gem to rubygems.org    
+      run: |
+        set +x
+        mkdir -p ~/.gem
+        cat << EOF > ~/.gem/credentials
+        ---
+        :rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}
+        EOF
+        chmod 0600 ~/.gem/credentials
+        set -x
+        gem release

data/.github/workflows/verify-pr-labeled.yml

@@ -0,0 +1,14 @@
+name: "Require PR labels"
+
+on:
+  pull_request:
+    types: [opened, labeled, unlabeled, synchronize]
+jobs:
+  label:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: mheap/github-action-required-labels@v1
+        with:
+          mode: exactly
+          count: 1
+          labels: "bug, change, enhancement"       

data/.rubocop.yml

@@ -10,6 +10,7 @@ AllCops:
     - "vendor/**/*"
     - "bin/**/*"
   CacheRootDirectory: tmp
+  NewCops: enable
 
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
@@ -69,6 +70,8 @@ Naming/PredicateName:
 
 RSpec/FilePath:
   Enabled: false
+Gemspec/RequiredRubyVersion:
+  Enabled: false
     
 Style/RedundantRegexpCharacterClass:
   Enabled: true
@@ -138,18 +141,8 @@ Style/OneLineConditional:
   Description: Favor the ternary operator(?:) over if/then/else/end constructs.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
   Enabled: false
-Style/ExponentialNotation:
-  Enabled: true
-Style/HashEachMethods:
-  Enabled: true
-Style/HashTransformKeys:
-  Enabled: true
-Style/HashTransformValues:
-  Enabled: true
-Style/RedundantFetchBlock:
-  Enabled: true
-Style/SlicingWithRange:
-  Enabled: true
+Style/OptionalBooleanParameter:
+  Enabled: false
 
 RSpec/NestedGroups:
   Max: 5

data/.rubocop_todo.yml

@@ -6,115 +6,24 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 119
-
-# Offense count: 1
-# Configuration parameters: IgnoredMethods.
-Metrics/AbcSize:
-  Max: 16
-
 # Offense count: 1
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
+# finapps.gemspec - leaving as is intentionally
 Metrics/BlockLength:
   Max: 28
 
 # Offense count: 1
 # Configuration parameters: CountComments.
+# fake_api.rb - leaving as is intentionally
 Metrics/ClassLength:
-  Max: 431
-
-# Offense count: 3
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/MethodLength:
-  Max: 16
-
-# Offense count: 29
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/rest/client_spec.rb'
-    - 'spec/rest/consumers_spec.rb'
-    - 'spec/rest/documents_orders_notifications_spec.rb'
-    - 'spec/rest/operators_password_resets_spec.rb'
-    - 'spec/rest/operators_spec.rb'
-    - 'spec/rest/order_notifications_spec.rb'
-    - 'spec/rest/order_tokens_spec.rb'
-    - 'spec/rest/orders_spec.rb'
-    - 'spec/rest/portfolios_consumers_spec.rb'
-    - 'spec/rest/sessions_spec.rb'
-
-# Offense count: 6
-RSpec/DescribeMethod:
-  Exclude:
-    - 'spec/rest/consumers_spec.rb'
-    - 'spec/rest/operators_password_resets_spec.rb'
-    - 'spec/rest/operators_spec.rb'
-    - 'spec/rest/order_tokens_spec.rb'
-    - 'spec/rest/products_spec.rb'
-    - 'spec/rest/sessions_spec.rb'
+  Max: 442
 
 # Offense count: 5
 # Configuration parameters: Max.
+# Leaving as is intentionally - url being tested takes up as many lines
 RSpec/ExampleLength:
   Exclude:
     - 'spec/rest/consumers_spec.rb'
     - 'spec/rest/documents_orders_spec.rb'
     - 'spec/rest/orders_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: .
-# SupportedStyles: have_received, receive
-RSpec/MessageSpies:
-  EnforcedStyle: receive
-
-# Offense count: 13
-RSpec/MultipleExpectations:
-  Max: 3
-
-# Offense count: 114
-# Configuration parameters: IgnoreSharedExamples.
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/rest/client_spec.rb'
-    - 'spec/rest/consumers_spec.rb'
-    - 'spec/rest/documents_orders_spec.rb'
-    - 'spec/rest/order_reports_spec.rb'
-    - 'spec/rest/order_statuses_spec.rb'
-    - 'spec/rest/order_tokens_spec.rb'
-    - 'spec/rest/orders_spec.rb'
-    - 'spec/rest/password_resets_spec.rb'
-    - 'spec/rest/plaid/plaid_consumer_institutions_spec.rb'
-    - 'spec/rest/sessions_spec.rb'
-    - 'spec/rest/signed_documents_downloads_spec.rb'
-    - 'spec/rest/verix/verix_documents_spec.rb'
-    - 'spec/rest/verix/verix_pdf_documents_spec.rb'
-    - 'spec/rest/version_spec.rb'
-
-# Offense count: 6
-RSpec/RepeatedExample:
-  Exclude:
-    - 'spec/rest/signed_documents_downloads_spec.rb'
-    - 'spec/rest/verix/verix_documents_spec.rb'
-    - 'spec/rest/verix/verix_pdf_documents_spec.rb'
-
-# Offense count: 2
-RSpec/RepeatedExampleGroupBody:
-  Exclude:
-    - 'spec/rest/client_spec.rb'
-
-# Offense count: 4
-RSpec/RepeatedExampleGroupDescription:
-  Exclude:
-    - 'spec/rest/client_spec.rb'
-
-# Offense count: 1
-RSpec/SubjectStub:
-  Exclude:
-    - 'spec/rest/orders_spec.rb'

data/README.md

@@ -3,6 +3,7 @@ FinApps Ruby-Client
 ===================
 
 [![Gem Version](https://img.shields.io/gem/v/finapps.svg)](https://rubygems.org/gems/finapps)
+![Main](https://github.com/finapps/ruby-client/workflows/Main/badge.svg)
 [![Build Status](https://travis-ci.org/finapps/ruby-client.svg?branch=master)](https://travis-ci.org/finapps/ruby-client)
 [![Code Climate](https://codeclimate.com/github/finapps/ruby-client/badges/gpa.svg)](https://codeclimate.com/github/finapps/ruby-client)
 [![Test Coverage](https://codeclimate.com/github/finapps/ruby-client/badges/coverage.svg)](https://codeclimate.com/github/finapps/ruby-client/coverage)

data/RELEASES.md

@@ -1,3 +1,23 @@
+## [5.0.36] - 2020-08-05
+
+### Changed
+* Add upload endpoints to support dashboard ([#309][i309])
+
+[i309]: https://github.com/finapps/tenant-dashboard-react/issues/309
+
+[5.0.36]: https://github.com/finapps/ruby-client/compare/5.0.35...5.0.36
+
+## [5.0.35] - 2020-07-09
+
+### Changed
+* Change code to match rubocop suggestions ([#232][i232])
+* Add support for first name order search with space ([#404][i404])
+
+[i232]: https://github.com/finapps/ruby-client/issues/232
+[i404]: https://github.com/finapps/tenant-dashboard-react/issues/404
+
+[5.0.35]: https://github.com/finapps/ruby-client/compare/5.0.34...5.0.35
+
 ## [5.0.32] - 2020-06-11
 
 ### Fixed

data/finapps.gemspec

@@ -24,7 +24,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler',                    '~> 2.0',   '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
-  spec.add_development_dependency 'gem-release',                '~> 2.1',   '>= 2.1.1'
   spec.add_development_dependency 'guard',                      '~> 2.16',  '>= 2.16.1'
   spec.add_development_dependency 'guard-rspec',                '~> 4.7',   '>= 4.7.3'
   spec.add_development_dependency 'rake',                       '~> 13.0',  '>= 13.0.1'

data/lib/finapps.rb

@@ -30,7 +30,9 @@ require 'finapps/rest/portfolios_consumers'
 require 'finapps/rest/consumers_portfolios'
 require 'finapps/rest/portfolio_reports'
 require 'finapps/rest/documents_orders'
+require 'finapps/rest/documents_uploads'
 require 'finapps/rest/esign_templates'
+require 'finapps/rest/documents_upload_types'
 require 'finapps/rest/signed_documents_downloads'
 require 'finapps/rest/documents_orders_notifications'
 

data/lib/finapps/rest/client.rb

@@ -13,6 +13,8 @@ module FinApps
         consumers_portfolios
         documents_orders
         documents_orders_notifications
+        documents_upload_types
+        documents_uploads
         esign_templates
         orders
         order_assignments
@@ -60,17 +62,18 @@ module FinApps
         if RESOURCES.include? symbol
           class_name = camelize(symbol.to_s)
           variable = "@#{class_name.downcase}"
-          unless instance_variable_defined? variable
-            klass =
-              Object.const_get('FinApps').const_get('REST').const_get class_name
-            instance_variable_set(variable, klass.new(self))
-          end
+          set_variable(class_name, variable) unless instance_variable_defined? variable
           instance_variable_get(variable)
         else
           super
         end
       end
 
+      def set_variable(class_name, variable)
+        klass = Object.const_get('FinApps').const_get('REST').const_get class_name
+        instance_variable_set(variable, klass.new(self))
+      end
+
       def respond_to_missing?(method_sym, include_private = false)
         RESOURCES.include?(method_sym) ? true : super
       end

data/lib/finapps/rest/documents_orders.rb

@@ -33,7 +33,7 @@ module FinApps
 
       def destroy(id)
         not_blank(id, :order_id)
-        super(id, "documents/orders/#{id}")
+        super(nil, "documents/orders/#{id}")
       end
 
       def show_signing_url(order_id, signature_id)

data/lib/finapps/rest/documents_upload_types.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class DocumentsUploadTypes < FinAppsCore::REST::Resources
+      def list
+        super('documents/upload_types')
+      end
+    end
+  end
+end