finapps 5.0.32 → 5.0.38

data/lib/finapps/rest/alert_definitions.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def list(params = nil)
         return super END_POINT if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(END_POINT, params)
       end

data/lib/finapps/rest/alert_occurrences.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def list(params = nil)
         return super END_POINT if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(END_POINT, params)
       end

data/lib/finapps/rest/client.rb

@@ -13,6 +13,8 @@ module FinApps
         consumers_portfolios
         documents_orders
         documents_orders_notifications
+        documents_upload_types
+        documents_uploads
         esign_templates
         orders
         order_assignments
@@ -60,17 +62,18 @@ module FinApps
         if RESOURCES.include? symbol
           class_name = camelize(symbol.to_s)
           variable = "@#{class_name.downcase}"
-          unless instance_variable_defined? variable
-            klass =
-              Object.const_get('FinApps').const_get('REST').const_get class_name
-            instance_variable_set(variable, klass.new(self))
-          end
+          set_variable(class_name, variable) unless instance_variable_defined? variable
           instance_variable_get(variable)
         else
           super
         end
       end
 
+      def set_variable(class_name, variable)
+        klass = Object.const_get('FinApps').const_get('REST').const_get class_name
+        instance_variable_set(variable, klass.new(self))
+      end
+
       def respond_to_missing?(method_sym, include_private = false)
         RESOURCES.include?(method_sym) ? true : super
       end

data/lib/finapps/rest/consumers.rb

@@ -15,7 +15,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -62,15 +62,15 @@ module FinApps
 
       def with_space_search(term)
         [
-          { "email": term },
-          { "first_name": term },
-          { "last_name": term }
+          {"email": term},
+          {"first_name": term},
+          {"last_name": term}
         ]
       end
 
       def name_search(term)
         search_arr = []
-        if term.match(/\s/)
+        if /\s/.match?(term)
           term.split.each do |t|
             search_arr.append("first_name": t)
             search_arr.append("last_name": t)

data/lib/finapps/rest/consumers_portfolios.rb

@@ -11,7 +11,7 @@ module FinApps
         path = "consumers/#{ERB::Util.url_encode(id)}/portfolios"
         return super path if params.nil?
 
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/documents_orders.rb

@@ -10,7 +10,7 @@ module FinApps
       def list(params = nil)
         path = 'documents/orders'
         return super(path) if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end
@@ -33,7 +33,7 @@ module FinApps
 
       def destroy(id)
         not_blank(id, :order_id)
-        super(id, "documents/orders/#{id}")
+        super(nil, "documents/orders/#{id}")
       end
 
       def show_signing_url(order_id, signature_id)
@@ -46,23 +46,22 @@ module FinApps
       private
 
       def build_filter(params)
-        search_query(params[:searchTerm]).merge(consumer_query(params[:consumer])).merge(tag_query(params[:tag]))
+        search_query(params[:searchTerm])
+          .merge(consumer_query(params[:consumer]))
+          .merge(tag_query(params[:tag]))
+          .merge(status_query(params[:status]))
       end
 
       def search_query(term)
-        if term
-          query = with_space_search(term).concat(name_search(term))
-          {
-            "$or": query
-          }
-        else
-          {}
-        end
+        return {} unless term
+
+        query = with_space_search(term).concat(name_search(term))
+        {"$or": query}
       end
 
       def name_search(term)
         search_arr = []
-        if term.match(/\s/)
+        if /\s/.match?(term)
           term.split.each do |t|
             search_arr.append("applicant.first_name": t)
             search_arr.append("applicant.last_name": t)
@@ -73,9 +72,9 @@ module FinApps
 
       def with_space_search(term)
         [
-          { "applicant.email": term },
-          { "applicant.first_name": term },
-          { "applicant.last_name": term },
+          {"applicant.email": term},
+          {"applicant.first_name": term},
+          {"applicant.last_name": term},
           {
             "reference_no": {
               "$regex": "^#{term}", "$options": 'i'
@@ -85,19 +84,21 @@ module FinApps
       end
 
       def tag_query(tag)
-        if tag
-          { "tag": tag.empty? ? nil : tag }
-        else
-          {}
-        end
+        return {} unless tag
+
+        {"tag": tag.empty? ? nil : tag}
+      end
+
+      def status_query(status)
+        return {} unless status
+
+        {status: status}
       end
 
       def consumer_query(consumer)
-        if consumer
-          { "consumer_id": consumer.empty? ? nil : consumer }
-        else
-          {}
-        end
+        return {} unless consumer
+
+        {"consumer_id": consumer.empty? ? nil : consumer}
       end
     end
   end

data/lib/finapps/rest/documents_upload_types.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class DocumentsUploadTypes < FinAppsCore::REST::Resources
+      def list
+        super('documents/upload_types')
+      end
+    end
+  end
+end

data/lib/finapps/rest/documents_uploads.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class DocumentsUploads < FinAppsCore::REST::Resources
+      def show(consumer_id, doc_id, thumbnail = false)
+        not_blank(consumer_id, :consumer_id)
+        not_blank(doc_id, :doc_id)
+
+        path =
+          "consumers/#{ERB::Util.url_encode(consumer_id)}/"\
+        "documents/#{ERB::Util.url_encode(doc_id)}?thumbnail=#{thumbnail}"
+        super(nil, path)
+      end
+
+      def destroy(order_id, doc_id)
+        not_blank(order_id, :order_id)
+        not_blank(doc_id, :doc_id)
+        super(nil, "documents/orders/#{order_id}/#{doc_id}")
+      end
+    end
+  end
+end

data/lib/finapps/rest/operators.rb

@@ -9,7 +9,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -36,7 +36,7 @@ module FinApps
       def update_password(params)
         # update password for current operator, need authorization session in header
         not_blank(params, :params)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
 
         path = "#{end_point}/password/change"
 
@@ -64,14 +64,14 @@ module FinApps
       end
 
       def search_query(term)
-        { "last_name": term }
+        {"last_name": term}
       end
 
       def role_query(role)
         if role.is_a?(Array)
-          { "role": { "$in": role.map(&:to_i) } }
+          {"role": {"$in": role.map(&:to_i)}}
         else
-          { "role": role.to_i }
+          {"role": role.to_i}
         end
       end
     end

data/lib/finapps/rest/operators_password_resets.rb

@@ -22,7 +22,7 @@ module FinApps
       private
 
       def validates_email(params)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless email_exists? params
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless email_exists? params
       end
 
       def email_exists?(params)

data/lib/finapps/rest/order_assignments.rb

@@ -6,7 +6,7 @@ module FinApps
       def update(id, orders_array)
         not_blank(id, :operator_id)
         not_blank(orders_array, :params)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless orders_array.is_a? Array
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless orders_array.is_a? Array
 
         path = "operators/#{ERB::Util.url_encode(id)}/assign"
         super orders_array, path

data/lib/finapps/rest/order_reports.rb

@@ -6,7 +6,7 @@ module FinApps
       def show(id, format)
         not_blank(id, :id)
         not_blank(format, :format)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: format' unless accepted_format?(format)
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: format' unless accepted_format?(format)
 
         path =
           "orders/#{ERB::Util.url_encode(id)}/report.#{ERB::Util.url_encode(format)}"

data/lib/finapps/rest/orders.rb

@@ -28,7 +28,7 @@ module FinApps
       #
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -63,30 +63,41 @@ module FinApps
       end
 
       def search_query(term)
-        if term
-          {
-            "$or": [
-              { "public_id": { "$regex": "^#{term}", "$options": 'i' } },
-              { "applicant.last_name": term },
-              { "assignment.last_name": term },
-              {
-                "requestor.reference_no": {
-                  "$regex": "^#{term}", "$options": 'i'
-                }
-              }
-            ]
-          }
-        else
-          {}
+        return {} unless term
+
+        query = search_query_object(term).concat(consumer_name_query(term))
+        {"$or": query}
+      end
+
+      def consumer_name_query(term)
+        search_arr = []
+        if /\s/.match?(term)
+          term.split.each do |t|
+            search_arr.append("applicant.first_name": t)
+            search_arr.append("applicant.last_name": t)
+          end
         end
+        search_arr
+      end
+
+      def search_query_object(term)
+        [{"public_id": {"$regex": "^#{term}", "$options": 'i'}},
+         {"assignment.last_name": term},
+         {"applicant.first_name": term},
+         {"applicant.last_name": term},
+         {
+           "requestor.reference_no": {
+             "$regex": "^#{term}", "$options": 'i'
+           }
+         }]
       end
 
       def status_query(status)
         if status
           if status.is_a?(Array)
-            { "status": { "$in": status.map(&:to_i) } }
+            {"status": {"$in": status.map(&:to_i)}}
           else
-            { "status": status.to_i }
+            {"status": status.to_i}
           end
         else
           {}
@@ -96,7 +107,7 @@ module FinApps
       def assignment_query(assignment)
         # translate "" to null assignment
         if assignment
-          { "assignment.operator_id": assignment.empty? ? nil : assignment }
+          {"assignment.operator_id": assignment.empty? ? nil : assignment}
         else
           {}
         end
@@ -104,7 +115,7 @@ module FinApps
 
       def consumer_query(consumer)
         if consumer
-          { "consumer_id": consumer.empty? ? nil : consumer }
+          {"consumer_id": consumer.empty? ? nil : consumer}
         else
           {}
         end
@@ -114,8 +125,8 @@ module FinApps
         if !search_term && !nil_or_empty?(relation)
           {
             "$or": [
-              { "public_id": { "$in": relation } },
-              { "original_order_id": { "$in": relation } }
+              {"public_id": {"$in": relation}},
+              {"original_order_id": {"$in": relation}}
             ]
           }
         else

data/lib/finapps/rest/plaid/plaid_consumer_institutions.rb

@@ -9,7 +9,7 @@ module FinApps
         super(params, 'p/institution/consumer')
       end
 
-      def show(id, options = { show_accounts: false })
+      def show(id, options = {show_accounts: false})
         results, error_messages = super(nil, "p/institution/consumer/#{id}")
 
         if error_messages.empty? && options[:show_accounts]

data/lib/finapps/rest/portfolio_reports.rb

@@ -9,7 +9,7 @@ module FinApps
         path = 'portfolio/reports'
 
         return super path if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/portfolios.rb

@@ -7,7 +7,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end

data/lib/finapps/rest/portfolios_available_consumers.rb

@@ -12,7 +12,7 @@ module FinApps
           "portfolios/#{ERB::Util.url_encode(portfolio_id)}/consumers/available"
         return super path if params.nil?
 
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/portfolios_consumers.rb

@@ -11,7 +11,7 @@ module FinApps
         path = build_path(portfolio_id)
         return super path if params.nil?
 
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/sessions.rb

@@ -8,21 +8,14 @@ module FinApps
 
       def create(params, path = nil)
         return super nil, path if path == LOGOUT
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
 
         path ||= CONSUMER_LOGIN
 
         begin
           super params, path
         rescue FinAppsCore::ApiUnauthenticatedError
-          (
-            [
-              nil,
-              [
-                "Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"
-              ]
-            ]
-          )
+          login_error(path)
         end
       end
 
@@ -36,6 +29,15 @@ module FinApps
         params.key?(:email) && params[:email] && params.key?(:password) &&
           params[:password]
       end
+
+      def login_error(path)
+        [
+          nil,
+          [
+            "Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"
+          ]
+        ]
+      end
     end
   end
 end