finapps 5.0.29 → 5.0.34

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f24fb86c099693e3d0f4ffb075bbaadd4886e9c165680b192a86bc79b6e6b82
-  data.tar.gz: 65255650d2ac2cf388f83b9be35b9b9d838ae4c2d85d850e2b25352c73e95227
+  metadata.gz: 6958de8a43a73230709100da8c2ddc2c2eef53d2ae74f546c37dbab8d6790b6a
+  data.tar.gz: 4af6e7780029881e968ef5551d3b24c965471a65080b9b45fda47ceb0e57d424
 SHA512:
-  metadata.gz: 254d4ceb173bb18759b6aed0c6b1fd3144656e516376b7c559bdc1e9836d0782d227e35508ac032b8fb3d03d268b171e8f357ceb6c191fc1d57a9e68bca9829d
-  data.tar.gz: 15a9340a7550212b940e16fb22890cd8ff22a99b1bc05bac3cd46435acd1f2aefa93d4118418c47c3abd2e720a27091c39b3f6b9b1376e002f49ade74f546df9
+  metadata.gz: 06c98f429646d29272d6a5b4d7f3f9d9bb38ca20e9e5d4fbce6db76d86200eab81acb64476170f05c705eee82c4cfa44f83f4f3b783777ccb13e962b458be7c3
+  data.tar.gz: fdaa7e5508c7d0f7929f15d8a68ba4137180ce56b1e4be46dcd83d7230d1f2d796d40ef1949d082309e55d7e9a78433ae927f9ec13785ec49dc80d345e8cfb6a

data/.codeclimate.yml

@@ -12,7 +12,8 @@ plugins:
     enabled: true
     config:
       languages:
-      - ruby
+        ruby:
+          mass_threshold: 30
 
 ratings:
   paths:

data/.github/workflows/main.yaml

@@ -0,0 +1,43 @@
+name: Main
+
+on:
+  push:
+    branches:
+      - master
+    pull_request:
+      branches:
+        - master
+
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: true
+
+    steps:
+      - uses: actions/checkout@v1
+
+      - name: Use Ruby 2.6
+        uses: actions/setup-ruby@v1
+        with:
+          ruby-version: '2.6'
+
+      - uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os  }}-gems-${{ hashFiles('**/Gemfile.lock')  }}
+          restore-keys: |
+            ${{ runner.os  }}-gems-
+
+      - name: Install gems
+        run: |
+          gem install bundler
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+
+      - name: Run rubocop
+        run: bundle exec rubocop
+
+      - name: Run tests
+        run: bundle exec rspec

data/.rubocop.yml

@@ -1,26 +1,59 @@
+inherit_from: .rubocop_todo.yml
+
+require: 
+  - rubocop-rspec
+  - rubocop-performance
+
 AllCops:
-  DisplayCopNames: true
+  TargetRubyVersion: 2.6
   Exclude:
-  - "finapps.gemspec"
-  UseCache: false
+    - "vendor/**/*"
+    - "bin/**/*"
+  CacheRootDirectory: tmp
 
-# Commonly used screens these days easily fit more than 80 characters.
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceInsideBlockBraces:
+  # The space here provides no real gain in readability while consuming
+  # horizontal space that could be used for a better parameter name.
+  # Also {| differentiates better from a hash than { | does.
+  SpaceBeforeBlockParameters: false
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+Layout/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: leading
+  SupportedStyles:
+  - leading
+  - trailing
 Layout/LineLength:
-  Max: 120
+  Max: 110
 
-Style/CollectionMethods:
-  Description: Preferred collection methods.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+Lint/DeprecatedOpenSSLConstant:
   Enabled: true
-  PreferredMethods:
-    collect: map
-    collect!: map!
-    find: detect
-    find_all: select
-    reduce: inject
-Style/OptionHash:
-  Description: Don't use option hashes when you can use keyword arguments.
-  Enabled: false
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+
+Metrics/ClassLength:
+  Exclude:
+    - app/controllers/orders_controller.rb
+    - app/models/order.rb
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+  Exclude:
+    - config/environments/**/**
+    - Guardfile
+    - config/routes.rb
+    - config/Guardfile
+
 Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
@@ -33,54 +66,94 @@ Naming/PredicateName:
   - is_
   Exclude:
   - spec/**/*
-Metrics/AbcSize:
-  Description: A calculated magnitude based on number of assignments, branches, and
-    conditions.
-  Enabled: false
-  Max: 15
-Metrics/BlockLength:
-  ExcludedMethods: ['describe', 'context']
-Metrics/ClassLength:
-  Description: Avoid classes longer than 100 lines of code.
-  Enabled: false
-  CountComments: false
-  Max: 100
-Metrics/ModuleLength:
-  CountComments: false
-  Max: 100
-  Description: Avoid modules longer than 100 lines of code.
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Description: A complexity metric that is strongly correlated to the number of test
-    cases needed to validate a method.
-  Enabled: false
-  Max: 6
-Metrics/MethodLength:
-  Description: Avoid methods longer than 10 lines of code.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
+
+RSpec/FilePath:
   Enabled: false
-  CountComments: false
-  Max: 10
-Metrics/ParameterLists:
-  Description: Avoid parameter lists longer than three or four parameters.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#too-many-params
+    
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/CollectionMethods:
+  Description: Preferred collection methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+  Enabled: true
+  PreferredMethods:
+    collect: map
+    collect!: map!
+    find: detect
+    find_all: select
+    reduce: inject
+Style/GuardClause:
+  Description: Check for conditionals that can be replaced with guard clauses
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
+  Enabled: true
+  MinBodyLength: 1
+Style/OptionHash:
+  Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
-  Max: 5
-  CountKeywordArgs: true
-Metrics/PerceivedComplexity:
-  Description: A complexity metric geared towards measuring complexity for a human
-    reader.
+Style/PercentLiteralDelimiters:
+  Description: Use `%`-literal delimiters consistently
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
   Enabled: false
-  Max: 7
+  PreferredDelimiters:
+    "%": "()"
+    "%i": "()"
+    "%q": "()"
+    "%Q": "()"
+    "%r": "{}"
+    "%s": "()"
+    "%w": "()"
+    "%W": "()"
+    "%x": "()"
+Style/SignalException:
+  Description: Checks for proper usage of fail and raise.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
+  Enabled: true
+  EnforcedStyle: semantic
+  SupportedStyles:
+  - only_raise
+  - only_fail
+  - semantic
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
 Style/Documentation:
   Description: Document classes and non-namespace modules.
   Enabled: false
-Style/EmptyLiteral:
-  Description: Prefer literals to Array.new/Hash.new/String.new.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
-  Enabled: false
-Style/VariableInterpolation:
-  Description: Don't interpolate global, instance and class variables directly in
-    strings.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
+Style/OneLineConditional:
+  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
   Enabled: false
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+RSpec/NestedGroups:
+  Max: 5
+RSpec/DescribeClass:
+  Exclude:
+    - spec/system/*
+    - spec/factories_spec.rb

data/.rubocop_todo.yml

@@ -0,0 +1,120 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-06-24 14:28:46 UTC using RuboCop version 0.86.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 119
+
+# Offense count: 1
+# Configuration parameters: IgnoredMethods.
+Metrics/AbcSize:
+  Max: 16
+
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 28
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 431
+
+# Offense count: 3
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 16
+
+# Offense count: 29
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_notifications_spec.rb'
+    - 'spec/rest/operators_password_resets_spec.rb'
+    - 'spec/rest/operators_spec.rb'
+    - 'spec/rest/order_notifications_spec.rb'
+    - 'spec/rest/order_tokens_spec.rb'
+    - 'spec/rest/orders_spec.rb'
+    - 'spec/rest/portfolios_consumers_spec.rb'
+    - 'spec/rest/sessions_spec.rb'
+
+# Offense count: 6
+RSpec/DescribeMethod:
+  Exclude:
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/operators_password_resets_spec.rb'
+    - 'spec/rest/operators_spec.rb'
+    - 'spec/rest/order_tokens_spec.rb'
+    - 'spec/rest/products_spec.rb'
+    - 'spec/rest/sessions_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_spec.rb'
+    - 'spec/rest/orders_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 13
+RSpec/MultipleExpectations:
+  Max: 3
+
+# Offense count: 114
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_spec.rb'
+    - 'spec/rest/order_reports_spec.rb'
+    - 'spec/rest/order_statuses_spec.rb'
+    - 'spec/rest/order_tokens_spec.rb'
+    - 'spec/rest/orders_spec.rb'
+    - 'spec/rest/password_resets_spec.rb'
+    - 'spec/rest/plaid/plaid_consumer_institutions_spec.rb'
+    - 'spec/rest/sessions_spec.rb'
+    - 'spec/rest/signed_documents_downloads_spec.rb'
+    - 'spec/rest/verix/verix_documents_spec.rb'
+    - 'spec/rest/verix/verix_pdf_documents_spec.rb'
+    - 'spec/rest/version_spec.rb'
+
+# Offense count: 6
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/rest/signed_documents_downloads_spec.rb'
+    - 'spec/rest/verix/verix_documents_spec.rb'
+    - 'spec/rest/verix/verix_pdf_documents_spec.rb'
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupBody:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+
+# Offense count: 4
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectStub:
+  Exclude:
+    - 'spec/rest/orders_spec.rb'

data/.tmuxinator.yml

@@ -11,6 +11,7 @@ windows:
           - git pull
           - git status
           - bundle
+          - bundle outdated
   - 
     guard: 
       layout: even-horizontal

data/.travis.yml

@@ -1,5 +1,7 @@
-sudo: false
 language: ruby
+os: ["linux"]
+dist: "xenial"
+
 cache:
   bundler: true
 

data/RELEASES.md

@@ -1,3 +1,34 @@
+## [5.0.32] - 2020-06-11
+
+### Fixed
+* Argument error resulting from space search ([#225][i225])
+
+[i225]: https://github.com/finapps/ruby-client/issues/225
+
+[5.0.32]: https://github.com/finapps/ruby-client/compare/5.0.31...5.0.32
+
+## [5.0.31] - 2020-06-11
+
+### Changed
+* Consumer and Doc-order search to query names on spaces ([#224][i224])
+
+[i224]: https://github.com/finapps/ruby-client/issues/224
+
+[5.0.31]: https://github.com/finapps/ruby-client/compare/5.0.30...5.0.31
+
+## [5.0.30] - 2020-05-28
+
+### Added
+* New esign endpoints ([#222][i222])
+
+### Changed
+* Search query for documents orders ([#221][i221])
+
+[i221]: https://github.com/finapps/ruby-client/issues/221
+[i222]: https://github.com/finapps/ruby-client/issues/222
+
+[5.0.30]: https://github.com/finapps/ruby-client/compare/5.0.29...5.0.30
+
 ## [5.0.29] - 2020-05-08
 
 ### Added