finapps 4.0.3 → 4.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad0c3cd173051fb6054b894661f943949eb6a6259d3525cc5516908213559179
-  data.tar.gz: 899a589e42dbdb6e3101c85a761ed1036d3ff1f3b0e0ce317e95b9f8bc9f4956
+  metadata.gz: 2dd7ec5866071e303e8dc2fdb02e9acc9cc26ba2d0a8588bc346bd53817f8318
+  data.tar.gz: e3f9567ee09fdb348430f781036ab8cc6abf988bb03584475927a81c89bd2551
 SHA512:
-  metadata.gz: 8323282a9818b87ae24aaa149bfb4508d20286bd139945c7ae6a9f41d2410bf7a653f6a856aa50335f432309cf5b82d83666165a259155d46c6129329a945db9
-  data.tar.gz: 945b146c4329e4d01c4684acb6c590ed5786d66445b918ba810923ceb9c85ddea51cc2dc33c6504d843e8cfb4c48e57812bfd3da7aba3ee700d8a9ca1d9f63a5
+  metadata.gz: fdda1bd5546f283f62bb75431e22e7bd221d1171ab84f8011e5d1fad65704656769ba6bb9e47faabc2627b427da2cc94c74ec388053c0a4d519a36e89f4a9e25
+  data.tar.gz: baae39702afd10e7ad5900f781e7ca0df5d6219bda8c20e4d0f5bbb8ec22ec4749e47ae63fefe83a9a543aff53214d2dbbcfdf751f0e46c86be9a3b965a7e3e3

data/.rubocop.yml

@@ -1,23 +1,23 @@
 Rails:
-  Enabled: false
+  Enabled: true
 
 AllCops:
   DisplayCopNames: true
   Exclude:
-    - "vendor/**/*"
-    - "db/schema.rb"
-    - "bin/**/*"
-    - "finapps.gemspec"
+  - "vendor/**/*"
+  - "db/schema.rb"
+  - "bin/**/*"
+  - "finapps_core.gemspec"
   UseCache: false
 
 # Commonly used screens these days easily fit more than 80 characters.
 Metrics/LineLength:
   Max: 120
 
-# No space makes the method definition shorter and differentiates
-# from a regular assignment.
-Layout/SpaceAroundEqualsInParameterDefault:
-  EnforcedStyle: no_space
+# Re-enable this when the following is resolved:
+# https://github.com/rubocop-hq/rubocop/issues/5953
+Style/AccessModifierDeclarations:
+  Enabled: false
 
 Layout/SpaceInsideBlockBraces:
   # The space here provides no real gain in readability while consuming
@@ -25,12 +25,6 @@ Layout/SpaceInsideBlockBraces:
   # Also {| differentiates better from a hash than { | does.
   SpaceBeforeBlockParameters: false
 
-# No trailing space differentiates better from the block:
-# foo} means hash, foo } means block.
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-
 Style/CollectionMethods:
   Description: Preferred collection methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
@@ -41,47 +35,10 @@ Style/CollectionMethods:
     find: detect
     find_all: select
     reduce: inject
-Layout/DotPosition:
-  Description: Checks the position of the dot in multi-line method calls.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
-  Enabled: true
-  EnforcedStyle: leading
-  SupportedStyles:
-  - leading
-  - trailing
-Style/FileName:
-  Description: Use snake_case for source file names.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
-  Enabled: false
-  Exclude: []
-Style/GuardClause:
-  Description: Check for conditionals that can be replaced with guard clauses
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
-  Enabled: false
-  MinBodyLength: 1
-Style/IfUnlessModifier:
-  Description: Favor modifier if/unless usage when you have a single-line body.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
-  Enabled: false
-  MaxLineLength: 80
 Style/OptionHash:
   Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
-Style/PercentLiteralDelimiters:
-  Description: Use `%`-literal delimiters consistently
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
-  Enabled: false
-  PreferredDelimiters:
-    "%": "()"
-    "%i": "()"
-    "%q": "()"
-    "%Q": "()"
-    "%r": "{}"
-    "%s": "()"
-    "%w": "()"
-    "%W": "()"
-    "%x": "()"
-Style/PredicateName:
+Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
   Enabled: true
@@ -93,55 +50,6 @@ Style/PredicateName:
   - is_
   Exclude:
   - spec/**/*
-Style/RaiseArgs:
-  Description: Checks the arguments passed to raise/fail.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#exception-class-messages
-  Enabled: false
-  EnforcedStyle: exploded
-  SupportedStyles:
-  - compact
-  - exploded
-Style/SignalException:
-  Description: Checks for proper usage of fail and raise.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
-  Enabled: false
-  EnforcedStyle: semantic
-  SupportedStyles:
-  - only_raise
-  - only_fail
-  - semantic
-Style/SingleLineBlockParams:
-  Description: Enforces the names of some block params.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#reduce-blocks
-  Enabled: false
-  Methods:
-  - reduce:
-    - a
-    - e
-  - inject:
-    - a
-    - e
-Style/SingleLineMethods:
-  Description: Avoid single-line methods.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-single-line-methods
-  Enabled: false
-  AllowIfMethodIsEmpty: true
-Style/StringLiterals:
-  Description: Checks if uses of quotes match the configured preference.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
-  Enabled: true
-  EnforcedStyle: single_quotes
-  SupportedStyles:
-  - single_quotes
-  - double_quotes
-Style/StringLiteralsInInterpolation:
-  Description: Checks if uses of quotes inside expressions in interpolated strings
-    match the configured preference.
-  Enabled: true
-  EnforcedStyle: single_quotes
-  SupportedStyles:
-  - single_quotes
-  - double_quotes
 Metrics/AbcSize:
   Description: A calculated magnitude based on number of assignments, branches, and
     conditions.
@@ -181,75 +89,19 @@ Metrics/PerceivedComplexity:
     reader.
   Enabled: false
   Max: 7
-Lint/AssignmentInCondition:
-  Description: Don't use assignment in conditions.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition
-  Enabled: false
-  AllowSafeAssignment: true
-Style/InlineComment:
-  Description: Avoid inline comments.
-  Enabled: false
-Style/AccessorMethodName:
-  Description: Check the naming of accessor methods for get_/set_.
-  Enabled: false
-Style/Alias:
-  Description: Use alias_method instead of alias.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#alias-method
-  Enabled: false
 Style/Documentation:
   Description: Document classes and non-namespace modules.
   Enabled: false
-Style/DoubleNegation:
-  Description: Checks for uses of double negation (!!).
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-bang-bang
-  Enabled: false
-Style/EachWithObject:
-  Description: Prefer `each_with_object` over `inject` or `reduce`.
-  Enabled: false
 Style/EmptyLiteral:
   Description: Prefer literals to Array.new/Hash.new/String.new.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
   Enabled: false
-Style/ModuleFunction:
-  Description: Checks for usage of `extend self` in modules.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#module-function
-  Enabled: false
-Style/OneLineConditional:
-  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
-  Enabled: false
-Style/PerlBackrefs:
-  Description: Avoid Perl-style regex back references.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-perl-regexp-last-matchers
-  Enabled: false
-Style/Send:
-  Description: Prefer `Object#__send__` or `Object#public_send` to `send`, as `send`
-    may overlap with existing methods.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#prefer-public-send
-  Enabled: false
-Style/SpecialGlobalVars:
-  Description: Avoid Perl-style global variables.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-cryptic-perlisms
-  Enabled: false
 Style/VariableInterpolation:
   Description: Don't interpolate global, instance and class variables directly in
     strings.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
   Enabled: false
-Style/WhenThen:
-  Description: Use when x then ... for one-line cases.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#one-line-cases
-  Enabled: false
-Lint/EachWithObjectArgument:
-  Description: Check for immutable argument given to each_with_object.
-  Enabled: true
 Lint/HandleExceptions:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
-  Enabled: false
-Lint/LiteralInCondition:
-  Description: Checks of literals used in conditions.
-  Enabled: false
-Lint/LiteralInInterpolation:
-  Description: Checks for literals used in interpolation.
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-ruby-2.4.2
+ruby-2.5.1

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.4.2
+  - 2.5.1
 before_install:
   - "echo 'gem: --no-ri --no-rdoc' > ~/.gemrc"
   - gem update --system

data/finapps.gemspec

@@ -1,7 +1,6 @@
-# coding: utf-8
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'finapps/version'
 Gem::Specification.new do |spec|
@@ -21,17 +20,17 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 3.0',   '>= 3.0.6'
+  spec.add_runtime_dependency     'finapps_core',               '~> 4.0',   '>= 4.0.0'
 
-  spec.add_development_dependency 'bundler',                    '~> 1.15',  '>= 1.15.4'
-  spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.8'
-  spec.add_development_dependency 'gem-release',                '~> 0.7',   '>= 0.7.4'
-  spec.add_development_dependency 'rake',                       '~> 12.1',  '>= 12.1.0'
-  spec.add_development_dependency 'rspec',                      '~> 3.5',   '>= 3.5.0'
-  spec.add_development_dependency 'rubocop',                    '~> 0.49.1'
-  spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.0'
-  spec.add_development_dependency 'webmock',                    '~> 3.0',   '>= 3.0.1'
+  spec.add_development_dependency 'bundler',                    '~> 1.16',  '>= 1.16.6'
+  spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
+  spec.add_development_dependency 'gem-release',                '~> 2.0',   '>= 2.0.1'
+  spec.add_development_dependency 'rake',                       '~> 12.3',  '>= 12.3.1'
+  spec.add_development_dependency 'rspec',                      '~> 3.8',   '>= 3.8.0'
+  spec.add_development_dependency 'rubocop',                    '~> 0.59',  '>= 0.59.2'
+  spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.4'
+  spec.add_development_dependency 'webmock',                    '~> 3.4',   '>= 3.4.2'
 
-  spec.extra_rdoc_files = %w(README.md LICENSE.txt)
-  spec.rdoc_options = %w(--line-numbers --inline-source --title finapps-ruby --main README.md)
+  spec.extra_rdoc_files = %w[README.md LICENSE.txt]
+  spec.rdoc_options = %w[--line-numbers --inline-source --title finapps-ruby --main README.md]
 end

data/lib/finapps.rb

@@ -2,8 +2,6 @@
 
 require 'faraday'
 require 'faraday_middleware'
-require 'typhoeus'
-require 'typhoeus/adapters/faraday'
 
 require 'finapps_core'
 

data/lib/finapps/rest/client.rb

@@ -6,7 +6,7 @@ require_relative './version'
 module FinApps
   module REST
     class Client < FinAppsCore::REST::BaseClient # :nodoc:
-      RESOURCES = %i(
+      RESOURCES = %i[
         institutions
         institutions_forms
         orders
@@ -30,12 +30,12 @@ module FinApps
         user_institutions_forms
         user_institutions_statuses
         version
-      ).freeze
+      ].freeze
 
       # @param [String] tenant_token
       # @param [Hash] options
       # @return [FinApps::REST::Client]
-      def initialize(tenant_token, options={}, logger=nil)
+      def initialize(tenant_token, options = {}, logger = nil)
         not_blank(tenant_token, :tenant_token)
 
         merged_options = options.merge(tenant_token: tenant_token)
@@ -56,7 +56,7 @@ module FinApps
         end
       end
 
-      def respond_to_missing?(method_sym, include_private=false)
+      def respond_to_missing?(method_sym, include_private = false)
         RESOURCES.include?(method_sym) ? true : super
       end
 
@@ -65,7 +65,7 @@ module FinApps
       def camelize(term)
         string = term.to_s
         string = string.sub(/^[a-z\d]*/) { $&.capitalize }
-        string.gsub!(%r{(?:_|(/))([a-z\d]*)}) { $2.capitalize.to_s }
+        string.gsub!(%r{(?:_|(/))([a-z\d]*)}) { Regexp.last_match(2).capitalize.to_s }
         string
       end
     end

data/lib/finapps/rest/operators.rb

@@ -7,9 +7,10 @@ module FinApps
     class Operators < FinAppsCore::REST::Resources
       include FinApps::Utils::QueryBuilder
 
-      def list(params=nil)
+      def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params' unless params.is_a? Hash
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+
         super build_query_path(end_point, params)
       end
 
@@ -19,7 +20,7 @@ module FinApps
         super id
       end
 
-      def create(params, path=nil)
+      def create(params, path = nil)
         not_blank(params, :params)
         super params, path
       end
@@ -35,7 +36,8 @@ module FinApps
       def update_password(params)
         # update password for current operator, need authorization session in header
         not_blank(params, :params)
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params.' unless validates params
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
+
         path = "#{end_point}/password/change"
 
         create params, path
@@ -60,11 +62,11 @@ module FinApps
       end
 
       def search_query(term)
-        {"last_name": term}
+        { "last_name": term }
       end
 
       def role_query(role)
-        role.is_a?(Array) ? {"role": {"$in": role.map(&:to_i)}} : {"role": role.to_i}
+        role.is_a?(Array) ? { "role": { "$in": role.map(&:to_i) } } : { "role": role.to_i }
       end
     end
   end

data/lib/finapps/rest/operators_password_resets.rb

@@ -3,7 +3,7 @@
 module FinApps
   module REST
     class OperatorsPasswordResets < FinAppsCore::REST::Resources
-      def create(params, path=nil)
+      def create(params, path = nil)
         not_blank(params, :params)
         validates_email(params) if path.nil?
 
@@ -22,9 +22,11 @@ module FinApps
       private
 
       def validates_email(params)
-        unless params.key?(:email) && params[:email]
-          raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params.'
-        end
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless email_exists? params
+      end
+
+      def email_exists?(params)
+        params.key?(:email) && params[:email]
       end
     end
   end

data/lib/finapps/rest/order_assignments.rb

@@ -6,7 +6,7 @@ module FinApps
       def update(id, orders_array)
         not_blank(id, :operator_id)
         not_blank(orders_array, :params)
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params' unless orders_array.is_a? Array
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless orders_array.is_a? Array
 
         path = "operators/#{ERB::Util.url_encode(id)}/assign"
         super orders_array, path

data/lib/finapps/rest/order_reports.rb

@@ -6,7 +6,7 @@ module FinApps
       def show(id, format)
         not_blank(id, :id)
         not_blank(format, :format)
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: format' unless accepted_format?(format)
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: format' unless accepted_format?(format)
 
         path = "orders/#{ERB::Util.url_encode(id)}/report.#{ERB::Util.url_encode(format)}"
         super nil, path
@@ -15,7 +15,7 @@ module FinApps
       private
 
       def accepted_format?(format)
-        %i(json html pdf).include? format.to_sym
+        %i[json html pdf].include? format.to_sym
       end
     end
   end

data/lib/finapps/rest/orders.rb

@@ -18,19 +18,24 @@ module FinApps
       end
 
       # GET /v3/list/orders?page=1&requested=25&sort=-date
+      # @param [Hash] params
+      # Optional keys:
       # :page - page number requested
       # :requested - number of results per page requested
       # :sort - sort order
       # :filter - mongo object to filter
       #     descending - append "-" before option for descending sort
-      def list(params=nil) # params hash with optional keys [:page, :sort, :requested]
+      #
+      def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params' unless params.is_a? Hash
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+
         super build_query_path(end_point, params)
       end
 
-      def update(id, params, path=nil)
+      def update(id, params, path = nil)
         return super nil, path if path
+
         not_blank(id, :id)
         not_blank(params, :params)
         # Params array need matching Institution ids & Account ids
@@ -63,33 +68,33 @@ module FinApps
       def search_query(term)
         {
           "$or": [
-            {"public_id": {
+            { "public_id": {
               "$regex": "^#{term}",
               "$options": 'i'
-            }},
-            {"applicant.last_name": term},
-            {"assignment.last_name": term},
-            {"requestor.reference_no": {
+            } },
+            { "applicant.last_name": term },
+            { "assignment.last_name": term },
+            { "requestor.reference_no": {
               "$regex": "^#{term}",
               "$options": 'i'
-            }}
+            } }
           ]
         }
       end
 
       def status_query(status)
-        status.is_a?(Array) ? {"status": {"$in": status.map(&:to_i)}} : {"status": status.to_i}
+        status.is_a?(Array) ? { "status": { "$in": status.map(&:to_i) } } : { "status": status.to_i }
       end
 
       def assignment_query(assignment)
-        {"assignment.operator_id": assignment.empty? ? nil : assignment} # translate "" to null assignment
+        { "assignment.operator_id": assignment.empty? ? nil : assignment } # translate "" to null assignment
       end
 
       def relation_query(relation)
         {
           "$or": [
-            {"public_id": {"$in": relation}},
-            {"original_order_id": {"$in": relation}}
+            { "public_id": { "$in": relation } },
+            { "original_order_id": { "$in": relation } }
           ]
         }
       end

data/lib/finapps/rest/sessions.rb

@@ -5,9 +5,10 @@ module FinApps
     class Sessions < FinAppsCore::REST::Resources # :nodoc:
       LOGOUT = 'logout'
 
-      def create(params, path=nil)
+      def create(params, path = nil)
         return super nil, path if path == LOGOUT
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params.' unless validates params
+        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
+
         path ||= 'login'
 
         super params, path

data/lib/finapps/utils/query_builder.rb

@@ -8,7 +8,7 @@ module FinApps
         page = "page=#{params[:page].to_i}" if params[:page]
         requested = "requested=#{params[:requested].to_i}" if params[:requested]
         sort = "sort=#{ERB::Util.url_encode(params[:sort])}" if params[:sort]
-        filter = "filter=#{ERB::Util.url_encode(filter_obj.to_json)}" if filter_obj && !filter_obj.empty?
+        filter = "filter=#{ERB::Util.url_encode(filter_obj.to_json)}" unless filter_obj.empty?
         query_join(root_url, [page, requested, sort, filter])
       end
 

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '4.0.3'
+  VERSION = '4.0.4'
 end

data/spec/rest/consumers_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject(:users) { FinApps::REST::Consumers.new(client) }
-  missing_public_id = 'Missing argument: public_id'
+  missing_public_id = ': public_id'
 
   describe '#create' do
     let(:results) { create[0] }

data/spec/rest/operators_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     end
 
     context 'when including valid params' do
-      let(:params) { {page: 2, sort: 'date_created', requested: 25, searchTerm: 'term', role: 2} }
+      let(:params) { { page: 2, sort: 'date_created', requested: 25, searchTerm: 'term', role: 2 } }
 
       it { expect { list }.not_to raise_error }
       it('performs a get and returns the response') { expect(results).to respond_to(:records) }
@@ -160,7 +160,7 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     end
 
     context 'with valid params' do
-      let(:valid_params) { {password: 'valid password', password_confirm: 'valid_password'} }
+      let(:valid_params) { { password: 'valid password', password_confirm: 'valid_password' } }
       let(:update_password) { subject.update_password(valid_params) }
 
       it { expect { update_password }.not_to raise_error }

data/spec/rest/order_tokens_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Clie
     let(:error_messages) { show[ERROR_MESSAGES] }
 
     context 'when missing token' do
-      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, 'Missing argument: token') }
+      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, ': token') }
     end
 
     context 'for valid token' do

data/spec/rest/orders_spec.rb

@@ -32,7 +32,7 @@ RSpec.describe FinApps::REST::Orders do
 
     context 'when valid params are provided' do
       subject { FinApps::REST::Orders.new(client).create(valid_params) }
-      let(:valid_params) { {applicant: 'valid', institutions: 'valid', product: 'valid'} }
+      let(:valid_params) { { applicant: 'valid', institutions: 'valid', product: 'valid' } }
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
@@ -45,7 +45,7 @@ RSpec.describe FinApps::REST::Orders do
 
     context 'when invalid params are provided' do
       subject { FinApps::REST::Orders.new(client).create(invalid_params) }
-      let(:invalid_params) { {applicant: 'valid'} }
+      let(:invalid_params) { { applicant: 'valid' } }
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
@@ -69,7 +69,7 @@ RSpec.describe FinApps::REST::Orders do
 
     context 'when invalid params are provided' do
       subject { FinApps::REST::Orders.new(client).list(invalid_params) }
-      let(:invalid_params) { %w(this is an array) }
+      let(:invalid_params) { %w[this is an array] }
 
       it { expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError) }
     end
@@ -77,8 +77,8 @@ RSpec.describe FinApps::REST::Orders do
     context 'when including valid params' do
       subject { FinApps::REST::Orders.new(client).list(params) }
       let(:params) do
-        {page: 2, sort: 'status', requested: 25, searchTerm: 'term', status: %w(1 7),
-         assignment: 'valid_operator', relation: ['valid_order_id']}
+        { page: 2, sort: 'status', requested: 25, searchTerm: 'term', status: %w[1 7],
+          assignment: 'valid_operator', relation: ['valid_order_id'] }
       end
 
       it { expect { subject }.not_to raise_error }

data/spec/rest/password_resets_spec.rb

@@ -28,8 +28,8 @@ RSpec.describe FinApps::REST::PasswordResets do
   end
 
   describe '#update' do
-    let(:valid_params) { {token: 'valid_token'} }
-    let(:invalid_params) { {token: 'invalid_token'} }
+    let(:valid_params) { { token: 'valid_token' } }
+    let(:invalid_params) { { token: 'invalid_token' } }
 
     context 'when missing id' do
       subject { FinApps::REST::PasswordResets.new(client).update(nil, :params) }

data/spec/rest/sessions_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client
     end
 
     context 'for invalid credentials' do
-      let(:credentials) { {email: 'email@domain.com', password: 'invalid_password'} }
+      let(:credentials) { { email: 'email@domain.com', password: 'invalid_password' } }
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
@@ -33,7 +33,7 @@ RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client
     end
 
     context 'for valid credentials' do
-      let(:credentials) { {email: 'email@domain.com', password: 'valid_password'} }
+      let(:credentials) { { email: 'email@domain.com', password: 'valid_password' } }
 
       it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
       it('token value is in the result') { expect(results).to respond_to(:token) }
@@ -42,7 +42,7 @@ RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client
 
     context 'for valid credentials & path argument' do
       let(:create) { subject.create(credentials, 'operators/login') }
-      let(:credentials) { {email: 'email@domain.com', password: 'valid_password'} }
+      let(:credentials) { { email: 'email@domain.com', password: 'valid_password' } }
 
       it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
       it('token value is in the result') { expect(results).to respond_to(:token) }

data/spec/rest/tenant_app_settings_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe FinApps::REST::TenantAppSettings do
     end
 
     context 'when valid params are provided' do
-      let(:params) { {pdf_statement_months: 2} }
+      let(:params) { { pdf_statement_months: 2 } }
 
       it { expect { update }.not_to raise_error }
       it('performs put and returns no content') { expect(update[RESULTS]).to be_nil }
@@ -33,7 +33,7 @@ RSpec.describe FinApps::REST::TenantAppSettings do
     end
 
     context 'when invalid params are provided' do
-      let(:params) { {pdf_statement_months: nil} }
+      let(:params) { { pdf_statement_months: nil } }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(update[RESULTS]).to be_nil }

data/spec/rest/tenant_settings_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe FinApps::REST::TenantSettings do
     end
 
     context 'when valid params are provided' do
-      let(:params) { {iav_default_product: 'valid'} }
+      let(:params) { { iav_default_product: 'valid' } }
 
       it { expect { update }.not_to raise_error }
       it('performs put and returns no content') { expect(update[RESULTS]).to be_nil }
@@ -33,7 +33,7 @@ RSpec.describe FinApps::REST::TenantSettings do
     end
 
     context 'when invalid params are provided' do
-      let(:params) { {bad_params: true} }
+      let(:params) { { bad_params: true } }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(update[RESULTS]).to be_nil }

data/spec/spec_helper.rb

@@ -36,8 +36,8 @@ RSpec.configure do |config|
   WebMock.disable_net_connect!(allow: 'codeclimate.com')
 end
 
-VALID_CREDENTIALS = {identifier: '49fb918d-7e71-44dd-7378-58f19606df2a',
-                     token:      'hohoho='}.freeze
+VALID_CREDENTIALS = { identifier: '49fb918d-7e71-44dd-7378-58f19606df2a',
+                      token:      'hohoho=' }.freeze
 
 RESULTS = 0
 ERROR_MESSAGES = 1

data/spec/support/fake_api.rb

@@ -64,7 +64,7 @@ class FakeApi < Sinatra::Base
   post('/v3/orders') do
     request.body.rewind
     request_payload = JSON.parse request.body.read
-    if %w(applicant institutions product).all? {|s| request_payload.key? s }
+    if %w[applicant institutions product].all? {|s| request_payload.key? s }
       json_response 200, 'order_token.json'
     else
       json_response 400, 'invalid_request_body.json'

data/spec/utils/query_builder_spec.rb

@@ -3,7 +3,7 @@
 class FakeClass
   include FinApps::Utils::QueryBuilder
 
-  def build_filter(p); end
+  def build_filter(param); end
 end
 
 RSpec.describe FinApps::Utils::QueryBuilder do
@@ -13,9 +13,9 @@ RSpec.describe FinApps::Utils::QueryBuilder do
     let(:end_point) { 'orders' }
 
     context 'with full params' do
-      let(:params) { {page: '1', requested: '20', sort: '-date', random: 'random'} }
+      let(:params) { { page: '1', requested: '20', sort: '-date', random: 'random' } }
       it 'calls #build_filter and returns correct string' do
-        allow(subject).to receive(:build_filter) { {role: 2} }
+        allow(subject).to receive(:build_filter) { { role: 2 } }
         expect(subject).to receive(:build_filter).with(params)
         correct_string = 'orders?page=1&requested=20&sort=-date&filter=%7B%22role%22%3A2%7D'
         expect(subject.build_query_path(end_point, params)).to eq(correct_string)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 4.0.3
+  version: 4.0.4
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-12 00:00:00.000000000 Z
+date: 2018-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -16,40 +16,40 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.6
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.6
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '1.16'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.15.4
+        version: 1.16.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '1.16'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.15.4
+        version: 1.16.6
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -59,7 +59,7 @@ dependencies:
         version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.8
+        version: 1.0.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -69,81 +69,87 @@ dependencies:
         version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.8
+        version: 1.0.9
 - !ruby/object:Gem::Dependency
   name: gem-release
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.4
+        version: 2.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.4
+        version: 2.0.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: '12.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.1.0
+        version: 12.3.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: '12.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.1.0
+        version: 12.3.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.8'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: 3.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.8'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: 3.8.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: '0.59'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.59.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: '0.59'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.59.2
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -153,7 +159,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.0.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -163,27 +169,27 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.0.4
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: 3.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: 3.4.2
 description: A simple library for communicating with the FinApps REST API.
 email:
 - erich@financialapps.com
@@ -322,36 +328,36 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/operators_password_resets_spec.rb
-- spec/rest/products_spec.rb
-- spec/rest/statements_spec.rb
-- spec/rest/version_spec.rb
-- spec/rest/user_institutions_forms_spec.rb
-- spec/rest/consumers_spec.rb
-- spec/rest/orders_spec.rb
-- spec/rest/order_tokens_spec.rb
-- spec/rest/institutions_forms_spec.rb
+- spec/spec_helper.rb
+- spec/spec_helpers/client.rb
+- spec/utils/query_builder_spec.rb
+- spec/support/fake_api.rb
 - spec/rest/tenant_app_settings_spec.rb
-- spec/rest/operators_spec.rb
-- spec/rest/user_institutions_statuses_spec.rb
+- spec/rest/order_reports_spec.rb
 - spec/rest/client_spec.rb
-- spec/rest/tenant_settings_spec.rb
 - spec/rest/user_institutions_spec.rb
-- spec/rest/consumer_institution_refreshes_spec.rb
-- spec/rest/password_resets_spec.rb
-- spec/rest/order_reports_spec.rb
-- spec/rest/institutions_spec.rb
+- spec/rest/consumers_spec.rb
 - spec/rest/order_statuses_spec.rb
-- spec/rest/order_refreshes_spec.rb
 - spec/rest/order_notifications_spec.rb
+- spec/rest/operators_password_resets_spec.rb
+- spec/rest/institutions_forms_spec.rb
+- spec/rest/operators_spec.rb
+- spec/rest/version_spec.rb
+- spec/rest/statements_spec.rb
 - spec/rest/order_assignments_spec.rb
+- spec/rest/order_refreshes_spec.rb
+- spec/rest/user_institutions_statuses_spec.rb
+- spec/rest/order_tokens_spec.rb
+- spec/rest/products_spec.rb
 - spec/rest/sessions_spec.rb
-- spec/support/fake_api.rb
-- spec/utils/query_builder_spec.rb
-- spec/spec_helpers/client.rb
-- spec/spec_helper.rb
+- spec/rest/password_resets_spec.rb
+- spec/rest/consumer_institution_refreshes_spec.rb
+- spec/rest/user_institutions_forms_spec.rb
+- spec/rest/institutions_spec.rb
+- spec/rest/tenant_settings_spec.rb
+- spec/rest/orders_spec.rb