finapps 2.2.5 → 2.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f93286a09de0aef183aaa9de0e098e0b0748a8f6
-  data.tar.gz: 52b7526d608956c8e4740446929f45b01beb9985
+  metadata.gz: 5eea1024ec978abcab4190e471f049c2ffa58464
+  data.tar.gz: d2d6032dfbd8616f0b68e279572da536550bd09d
 SHA512:
-  metadata.gz: e0fc54810448b27dadaac4c0bcb96e7efe4b29b3edb025a2c7f4e59f19a6b5e0be82087728fe113bc2e0ee3403c7a00c84792e6363ec30fd9eb559f0f7409892
-  data.tar.gz: 6a8399c02192fc9531cebb39ddfc22a4e32d70092af6664a7670dd5055471c6dd28705e77a6750642349260c4fffc3663005ced0aea01ee5d760586cb049941d
+  metadata.gz: 9411cc800f1ba4e7ac2032ac24928c6f828be674195330573cc36c46e98b7be155d9e69418d0cf6ebd68059ecd75a5e61d5b756484656f70cdce8785da8cf9cb
+  data.tar.gz: 0f54d4ffbf29334e37bd5e17e27efc25e567a1bf4b449b9703ea6269453084d7d00993a1e9d73dc35ed5d0133fd0fb04e4810bd96d7447d4e1b8a71f973a7bc8

data/lib/finapps/rest/orders.rb

@@ -23,11 +23,12 @@ module FinApps
       #     date - the date of the order
       #     status - the status of the order
       # :asc - sort order true for asc false for desc
-      def list(params=nil) # params hash with optional keys [:page, :requested, :sort, :asc]
-        return super 'list/orders/1/10000/date/false' if params.nil?
-        raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params' unless params.is_a? Hash
-
-        super build_path(params)
+      def list # (params=nil) # params hash with optional keys [:page, :requested, :sort, :asc]
+        super 'orders?page=1&requested=500&sort=-date'
+        # TODO: change to support https://github.com/finapps/api/blob/develop/misc/docs/iav.md#get-list-of-orders
+        # return super 'orders?page=1&requested=500&sort=-date' # if params.nil?
+        # raise FinAppsCore::InvalidArgumentsError.new 'Invalid argument: params' unless params.is_a? Hash
+        # super build_path(params)
       end
 
       def update(id, params)
@@ -42,18 +43,20 @@ module FinApps
         super params, path
       end
 
-      private
-
-      def build_path(p)
-        page = p[:page] || 1
-        requested = p[:requested] || 100
-        sort = p[:sort] || 'date'
-        asc = p[:asc] || false
-        end_point = 'list/orders'
-        path = end_point.dup
-        [page, requested, sort, asc].each_with_index {|a| path << "/#{ERB::Util.url_encode(a)}" }
-        path
-      end
+      # private
+      #
+      # def build_path(p)
+      #   # TODO: change to support https://github.com/finapps/api/blob/develop/misc/docs/iav.md#get-list-of-orders
+      #
+      #   page = p[:page] || 1
+      #   requested = p[:requested] || 100
+      #   sort = p[:sort] || 'date'
+      #   asc = p[:asc]
+      #   end_point = 'orders'
+      #   path = end_point.dup
+      #   [page, requested, sort, asc].each_with_index {|a| path << "/#{ERB::Util.url_encode(a)}" }
+      #   path
+      # end
     end
   end
 end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.2.5'
+  VERSION = '2.2.6'
 end

data/spec/rest/order_statuses_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe FinApps::REST::OrderStatuses do
 
   RESULTS = 0
   ERROR_MESSAGES = 1
-  
+
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::OrderStatuses.new(client).show(nil) }
@@ -24,7 +24,9 @@ RSpec.describe FinApps::REST::OrderStatuses do
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
-      it('error messages array is populated') { expect(subject[ERROR_MESSAGES].first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(subject[ERROR_MESSAGES].first.downcase).to eq('resource not found')
+      end
     end
   end
 end

data/spec/rest/order_tokens_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Clie
 
   RESULTS = 0
   ERROR_MESSAGES = 1
-  
+
   describe '#show' do
     subject(:order_tokens) { FinApps::REST::OrderTokens.new(client) }
     let(:results) { show[RESULTS] }

data/spec/rest/orders_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::Orders do
   include SpecHelpers::Client
-  
+
   RESULTS = 0
   ERROR_MESSAGES = 1
 
@@ -49,7 +49,9 @@ RSpec.describe FinApps::REST::Orders do
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
-      it('error messages array is populated') { expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid request body') }
+      it('error messages array is populated') do
+        expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid request body')
+      end
     end
   end
 
@@ -57,7 +59,7 @@ RSpec.describe FinApps::REST::Orders do
     context 'when missing params' do
       # use defaults
 
-      subject { FinApps::REST::Orders.new(client).list(nil) }
+      subject { FinApps::REST::Orders.new(client).list }
       it { expect { subject }.not_to raise_error }
 
       it('returns an array') { expect(subject).to be_a(Array) }
@@ -65,16 +67,16 @@ RSpec.describe FinApps::REST::Orders do
       it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
     end
 
-    context 'when including partial params' do
-      subject { FinApps::REST::Orders.new(client).list(params) }
-      let(:params) { {page: 2, sort: 'status'} }
-
-      it { expect { subject }.not_to raise_error }
-      it('returns an array') { expect(subject).to be_a(Array) }
-      it('performs a get and returns the response') { expect(subject[RESULTS]).to respond_to(:orders) }
-      it('each order contains a consumer_id') { expect(subject[RESULTS].orders).to all(respond_to(:consumer_id)) }
-      it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
-    end
+    # context 'when including partial params' do
+    #   subject { FinApps::REST::Orders.new(client).list(params) }
+    #   let(:params) { {page: 2, sort: 'status'} }
+    #
+    #   it { expect { subject }.not_to raise_error }
+    #   it('returns an array') { expect(subject).to be_a(Array) }
+    #   it('performs a get and returns the response') { expect(subject[RESULTS]).to respond_to(:orders) }
+    #   it('each order contains a consumer_id') { expect(subject[RESULTS].orders).to all(respond_to(:consumer_id)) }
+    #   it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
+    # end
   end
 
   describe '#update' do

data/spec/rest/user_institutions_forms_spec.rb

@@ -26,7 +26,9 @@ RSpec.describe FinApps::REST::UserInstitutionsForms do
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULT]).to be_nil }
-      it('error messages array is populated') { expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid institution id') }
+      it('error messages array is populated') do
+        expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid institution id')
+      end
     end
   end
 end

data/spec/rest/user_institutions_statuses_spec.rb

@@ -27,7 +27,9 @@ RSpec.describe FinApps::REST::UserInstitutionsStatuses do
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULT]).to be_nil }
-      it('error messages array is populated') { expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid user institution id') }
+      it('error messages array is populated') do
+        expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid user institution id')
+      end
     end
   end
 

data/spec/support/fake_api.rb

@@ -17,7 +17,7 @@ class FakeApi < Sinatra::Base
   post('/v2/orders/valid_token') { json_response 200, 'order_token.json' }
   post('/v2/orders/invalid_token') { json_response 404, 'resource_not_found.json' }
   get('/v2/orders/valid_id') { json_response 200, 'order.json' }
-  get('/v2/list/orders/:page/:requested/:sort/:asc') { json_response 200, 'orders.json' }
+  get('/v2/orders') { json_response 200, 'orders.json' }
   get('/v2/orders/valid_id/report.:format') { json_response 200, 'order_report.json' }
   get('/v2/orders/invalid_id/report.:format') { json_response 404, 'resource_not_found.json' }
   get('/v2/orders/valid_id/status') { json_response 200, 'order_status.json' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.2.5
+  version: 2.2.6
 platform: ruby
 authors:
 - Erich Quintero