finapps 2.2.18 → 2.2.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c589e3db135efac7608182b06253c4486ffb2d41
-  data.tar.gz: 9dda7d435559e4331224a543bfb65311edd34294
+  metadata.gz: 3d89d6d589716009d0126ae2e39742ccfd67000b
+  data.tar.gz: 91a56bf9f76cf109f13e1740d1459baaf3c445e8
 SHA512:
-  metadata.gz: 3b76819e08295bd3960a7a16e3b98bd598f10610eeabb891d52d2fdf81ba4a533a55756ee29bf4170abf3eda7d21dfea5de50f0d28d0d7f263ff69319223e822
-  data.tar.gz: 55d096c4eaf472daa1440cfd8fe8b44500452c1a6a998a5a98d3ffcc5c8c375ca1115360a0e1cd98bc4d253285efb6e69175f8d873ac6f9b189fd40834bd87d3
+  metadata.gz: 54303fd65a238d89cb79d365163c61c81789e82b26b8211bab7f22b0b5f63af02a4a259f7d122cf0caa431399da2a46c4bdf9088da6c08a293c26d9d16a1e81f
+  data.tar.gz: 235816aaef1ac0ee4b4a0ba28c41b7302cf2ee8a6a90ac514e8b4e447c1417934a79cc354fa902e367059acb27f2095036a24783f8d5df69bc34372337bbc3f6

data/finapps.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 2.0',   '>= 2.0.17'
+  spec.add_runtime_dependency     'finapps_core',               '~> 2.0',   '>= 2.0.19'
 
   spec.add_development_dependency 'bundler',                    '~> 1.14',  '>= 1.14.3'
   spec.add_development_dependency 'gem-release',                '~> 0.7',   '>= 0.7.4'

data/lib/finapps.rb

@@ -27,8 +27,4 @@ require 'finapps/rest/operators_password_resets'
 require 'finapps/rest/products'
 require 'finapps/utils/query_builder'
 
-# require 'finapps/rest/configuration'
-# require 'finapps/rest/credentials'
-# require 'finapps/rest/connection'
-# require 'finapps/rest/base_client'
 require 'finapps/rest/client'

data/lib/finapps/rest/institutions.rb

@@ -2,23 +2,29 @@
 module FinApps
   module REST
     class Institutions < FinAppsCore::REST::Resources
+      ROUTING_NUMBER_LENGTH = 9
+
       def list(search_term)
-        not_blank(search_term, :search_term)
-        # API errors when search_term is blank, maybe it shouldn't
+        not_blank(search_term, :search_term) # API errors when search_term is blank, maybe it shouldn't
 
         path = "#{end_point}/search/#{ERB::Util.url_encode(search_term)}"
         super path
       end
 
-      def show(routing_number)
-        not_blank(routing_number, :routing_number)
+      def show(id)
+        digits = remove_non_digits id
+        not_blank(digits, :id)
 
-        path = "#{end_point}/routing/#{remove_non_digits routing_number}"
-        super routing_number, path
+        path = "#{end_point}/#{search_type digits}/#{digits}"
+        super digits, path
       end
 
       private
 
+      def search_type(digits)
+        digits.length >= ROUTING_NUMBER_LENGTH ? :routing : :site
+      end
+
       def remove_non_digits(value)
         value.to_s.gsub(/\D/, '')
       end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.2.18'
+  VERSION = '2.2.19'
 end

data/spec/rest/institutions_spec.rb

@@ -21,8 +21,8 @@ RSpec.describe FinApps::REST::Institutions do
   end
 
   describe '#show' do
-    context 'when routing_number is missing' do
-      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    context 'when id is missing' do
+      it { expect { subject.show('') }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
     context 'when proper routing_number is provided' do
@@ -37,5 +37,19 @@ RSpec.describe FinApps::REST::Institutions do
       it('includes a site_id on the results') { expect(show[RESULTS]).to respond_to(:site_id) }
       it('includes a org_display_name on the results') { expect(show[RESULTS]).to respond_to(:org_display_name) }
     end
+
+
+    context 'when proper site_id is provided' do
+      # A site_id has less than 9 digits
+      let(:show) { subject.show('5') }
+
+      it { expect { show }.not_to raise_error }
+      it('returns no error messages') { expect(show[ERROR_MESSAGES]).to be_empty }
+      it('returns a hash on the results') { expect(show[RESULTS]).to be_a(Hash) }
+      it('includes a base_url on the results') { expect(show[RESULTS]).to respond_to(:base_url) }
+      it('includes a display_name on the results') { expect(show[RESULTS]).to respond_to(:display_name) }
+      it('includes a site_id on the results') { expect(show[RESULTS]).to respond_to(:site_id) }
+      it('includes a org_display_name on the results') { expect(show[RESULTS]).to respond_to(:org_display_name) }
+    end
   end
 end

data/spec/support/fake_api.rb

@@ -52,6 +52,8 @@ class FakeApi < Sinatra::Base
   post('/v2/institutions/site/valid_site_id/add') { json_response 200, 'institution_add.json' }
   get('/v2/institutions/search/:search_term') { json_response 200, 'institutions_search_list.json' }
   get('/v2/institutions/routing/:routing_number') { json_response 200, 'institutions_routing_number.json' }
+  get('/v2/institutions/site/:site_id') { json_response 200, 'institutions_routing_number.json' }
+
 
   # user institutions
   get('/v2/institutions/consumer/valid_id/status') { json_response 200, 'user_institution_status.json' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.2.18
+  version: 2.2.19
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-25 00:00:00.000000000 Z
+date: 2017-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -19,7 +19,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.17
+        version: 2.0.19
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.17
+        version: 2.0.19
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement