finapps 2.2.17 → 2.2.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2060081ac7ed6cd7f597e3b6e2319d5132245e47
-  data.tar.gz: 4085a14172157f3474b7499ed6ce5f550ac05dd8
+  metadata.gz: c589e3db135efac7608182b06253c4486ffb2d41
+  data.tar.gz: 9dda7d435559e4331224a543bfb65311edd34294
 SHA512:
-  metadata.gz: 45af42879afbbc05f45b4d40f205cbf7c8ef8bac952cc9c924011b283cf3aebacd07413d36779ba0c76f4687ab6c17af7aef516ac15651b745bf49d14df74328
-  data.tar.gz: 6d3a2a5eff6ff4c3f744eaead1966ab1ad12a66eeef019ffd13cee59b0bc2ae94389fa40052191ce0d5947fb6457ba153e356f8553e32bdcbca4672edd35157d
+  metadata.gz: 3b76819e08295bd3960a7a16e3b98bd598f10610eeabb891d52d2fdf81ba4a533a55756ee29bf4170abf3eda7d21dfea5de50f0d28d0d7f263ff69319223e822
+  data.tar.gz: 55d096c4eaf472daa1440cfd8fe8b44500452c1a6a998a5a98d3ffcc5c8c375ca1115360a0e1cd98bc4d253285efb6e69175f8d873ac6f9b189fd40834bd87d3

data/lib/finapps.rb

@@ -20,6 +20,7 @@ require 'finapps/rest/user_institutions'
 require 'finapps/rest/user_institutions_forms'
 require 'finapps/rest/order_reports'
 require 'finapps/rest/order_statuses'
+require 'finapps/rest/order_notifications'
 require 'finapps/rest/password_resets'
 require 'finapps/rest/operators'
 require 'finapps/rest/operators_password_resets'

data/lib/finapps/rest/client.rb

@@ -9,6 +9,7 @@ module FinApps
         institutions
         institutions_forms
         orders
+        order_notifications
         order_reports
         order_statuses
         order_tokens

data/lib/finapps/rest/order_notifications.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+module FinApps
+  module REST
+    class OrderNotifications < FinAppsCore::REST::Resources
+      def update(id)
+        not_blank(id, :id)
+
+        path = "orders/#{ERB::Util.url_encode(id)}/notify"
+        super nil, path
+      end
+    end
+  end
+end

data/lib/finapps/rest/orders.rb

@@ -28,7 +28,8 @@ module FinApps
         super build_query_path(end_point, params)
       end
 
-      def update(id, params)
+      def update(id, params, path=nil)
+        return super nil, path if path
         not_blank(id, :id)
         not_blank(params, :params)
         # Params array need matching Institution ids & Account ids
@@ -39,6 +40,13 @@ module FinApps
 
         super params, path
       end
+
+      def destroy(id)
+        not_blank(id, :id)
+
+        path = "#{end_point}/#{ERB::Util.url_encode(id)}/cancel"
+        update nil, nil, path
+      end
     end
   end
 end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.2.17'
+  VERSION = '2.2.18'
 end

data/spec/rest/client_spec.rb

@@ -27,6 +27,10 @@ RSpec.describe FinApps::REST::Client do
       it { expect(subject.sessions).to be_an_instance_of(FinApps::REST::Sessions) }
     end
 
+    describe '#order_statuses' do
+      it { expect(subject.order_notifications).to be_an_instance_of(FinApps::REST::OrderNotifications) }
+    end
+
     describe '#order_statuses' do
       it { expect(subject.order_statuses).to be_an_instance_of(FinApps::REST::OrderStatuses) }
     end

data/spec/rest/order_notifications_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+require 'spec_helpers/client'
+
+RSpec.describe FinApps::REST::OrderNotifications do
+  include SpecHelpers::Client
+
+  describe '#update' do
+    subject(:orders) { FinApps::REST::OrderNotifications.new(client) }
+
+    context 'when missing id' do
+      let(:update) { subject.update(nil) }
+      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
+
+    context 'when invalid id is provided' do
+      let(:update) { subject.update(:invalid_id) }
+      let(:results) { update[RESULTS] }
+      let(:error_messages) { update[ERROR_MESSAGES] }
+
+      it { expect { update }.not_to raise_error }
+      it('results is nil') { expect(results).to be_nil }
+      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+    end
+
+    context 'for valid id' do
+      let(:update) { subject.update(:valid_id) }
+      let(:results) { update[RESULTS] }
+      let(:error_messages) { update[ERROR_MESSAGES] }
+
+      it { expect { update }.not_to raise_error }
+      it('results is nil') { expect(results).to be_nil }
+      it('error_messages array is empty') { expect(error_messages).to eq([]) }
+    end
+  end
+end

data/spec/rest/orders_spec.rb

@@ -133,4 +133,33 @@ RSpec.describe FinApps::REST::Orders do
       it('error messages array is populated') { expect(error_messages.first.downcase).to eq('invalid request body') }
     end
   end
+
+  describe '#destroy' do
+    subject(:orders) { FinApps::REST::Orders.new(client) }
+
+    context 'when missing id' do
+      let(:destroy) { subject.destroy(nil) }
+      it('returns missing argument error') { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
+
+    context 'when invalid id is provided' do
+      let(:destroy) { subject.destroy(:invalid_id) }
+      let(:results) { destroy[RESULTS] }
+      let(:error_messages) { destroy[ERROR_MESSAGES] }
+
+      it { expect { destroy }.not_to raise_error }
+      it('results is nil') { expect(results).to be_nil }
+      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+    end
+
+    context 'for valid id' do
+      let(:destroy) { subject.destroy(:valid_id) }
+      let(:results) { destroy[RESULTS] }
+      let(:error_messages) { destroy[ERROR_MESSAGES] }
+
+      it { expect { destroy }.not_to raise_error }
+      it('results is nil') { expect(results).to be_nil }
+      it('error_messages array is empty') { expect(error_messages).to eq([]) }
+    end
+  end
 end

data/spec/support/fake_api.rb

@@ -22,6 +22,10 @@ class FakeApi < Sinatra::Base
   get('/v2/orders/invalid_id/report.:format') { json_response 404, 'resource_not_found.json' }
   get('/v2/orders/valid_id/status') { json_response 200, 'order_status.json' }
   get('/v2/orders/invalid_id/status') { json_response 404, 'resource_not_found.json' }
+  put('/v2/orders/valid_id/cancel') { status 204 }
+  put('/v2/orders/invalid_id/cancel') { json_response 404, 'resource_not_found.json' }
+  put('/v2/orders/valid_id/notify') { status 204 }
+  put('/v2/orders/invalid_id/notify') { json_response 404, 'resource_not_found.json' }
   put('/v2/orders/invalid_id') { json_response 404, 'resource_not_found.json' }
   put('/v2/orders/valid_id') do
     request.body.rewind

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.2.17
+  version: 2.2.18
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-22 00:00:00.000000000 Z
+date: 2017-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -239,6 +239,7 @@ files:
 - lib/finapps/rest/institutions_forms.rb
 - lib/finapps/rest/operators.rb
 - lib/finapps/rest/operators_password_resets.rb
+- lib/finapps/rest/order_notifications.rb
 - lib/finapps/rest/order_reports.rb
 - lib/finapps/rest/order_statuses.rb
 - lib/finapps/rest/order_tokens.rb
@@ -259,6 +260,7 @@ files:
 - spec/rest/institutions_spec.rb
 - spec/rest/operators_password_resets_spec.rb
 - spec/rest/operators_spec.rb
+- spec/rest/order_notifications_spec.rb
 - spec/rest/order_reports_spec.rb
 - spec/rest/order_statuses_spec.rb
 - spec/rest/order_tokens_spec.rb
@@ -350,6 +352,7 @@ test_files:
 - spec/rest/order_reports_spec.rb
 - spec/rest/institutions_spec.rb
 - spec/rest/order_statuses_spec.rb
+- spec/rest/order_notifications_spec.rb
 - spec/rest/sessions_spec.rb
 - spec/support/fake_api.rb
 - spec/utils/query_builder_spec.rb