finapps 2.2.10 → 2.2.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 70220a731dd2c12887ace4b6d14c1456d56177a1
-  data.tar.gz: 9066dcd39edf4269383677d0b252b8f8b564ae36
+  metadata.gz: a9345f2ee1b07ebc04aaafd850699f01d7410c75
+  data.tar.gz: 7f1363fcc09f46ad078f900eccde69d9a007ec74
 SHA512:
-  metadata.gz: fa575512298a0cf92d92470394bbe3040948b7b239f728f10ad660f91686ed8227dc7035b7428c02ed4ce97b24baa5e8c26ed58b76bc663d3aa62999976042f8
-  data.tar.gz: 49cebe455ebe88dc8383a472f6baa60a3e9fa8181f0379f185a29d64fd5bb38cbf07d66aa52dd924b5750478ac2520164ce15b1818b3213982cfe92937f0d1dd
+  metadata.gz: 9e0fbdf8e8b2307aaf9a897316c619fc7500969095393605bf8d16537e4b84c5405a797b86d233d2338d803e61f80d8fa73c6abd08c474eb34fd02cd4557cefd
+  data.tar.gz: ef218718b47c393cb40a14513dfb14e2e9be8295bef9a7ebe97cb271965c7a5da2986062e5fa1f8ad0f9bb5d128e8bd00f1d56211610c91f5c99a57f18c97606

data/lib/finapps/rest/institutions.rb

@@ -9,6 +9,19 @@ module FinApps
         path = "#{end_point}/search/#{ERB::Util.url_encode(search_term)}"
         super path
       end
+
+      def show(routing_number)
+        not_blank(routing_number, :routing_number)
+
+        path = "#{end_point}/routing/#{remove_non_digits routing_number}"
+        super routing_number, path
+      end
+
+      private
+
+      def remove_non_digits(value)
+        value.to_s.gsub(/\D/, '')
+      end
     end
   end
 end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.2.10'
+  VERSION = '2.2.11'
 end

data/spec/rest/institutions_spec.rb

@@ -2,10 +2,9 @@
 require 'spec_helpers/client'
 RSpec.describe FinApps::REST::Institutions do
   include SpecHelpers::Client
+  subject(:institutions) { FinApps::REST::Institutions.new(client) }
 
   describe '#list' do
-    subject(:institutions) { FinApps::REST::Institutions.new(client) }
-
     context 'when search_term is missing' do
       let(:list) { subject.list(nil) }
       it { expect { list }.to raise_error(FinAppsCore::MissingArgumentsError) }
@@ -20,4 +19,23 @@ RSpec.describe FinApps::REST::Institutions do
       it('returns no error messages') { expect(list[1]).to be_empty }
     end
   end
+
+  describe '#show' do
+    context 'when routing_number is missing' do
+      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
+
+    context 'when proper routing_number is provided' do
+      # An ABA routing transit number (ABA RTN) is a nine digit code
+      let(:show) { subject.show('999999999') }
+
+      it { expect { show }.not_to raise_error }
+      it('returns no error messages') { expect(show[ERROR_MESSAGES]).to be_empty }
+      it('returns a hash on the results') { expect(show[RESULTS]).to be_a(Hash) }
+      it('includes a base_url on the results') { expect(show[RESULTS]).to respond_to(:base_url) }
+      it('includes a display_name on the results') { expect(show[RESULTS]).to respond_to(:display_name) }
+      it('includes a site_id on the results') { expect(show[RESULTS]).to respond_to(:site_id) }
+      it('includes a org_display_name on the results') { expect(show[RESULTS]).to respond_to(:org_display_name) }
+    end
+  end
 end

data/spec/support/fake_api.rb

@@ -47,6 +47,7 @@ class FakeApi < Sinatra::Base
   get('/v2/institutions/site/invalid_site_id/form') { json_response 400, 'invalid_institution_id.json' }
   post('/v2/institutions/site/valid_site_id/add') { json_response 200, 'institution_add.json' }
   get('/v2/institutions/search/:search_term') { json_response 200, 'institutions_search_list.json' }
+  get('/v2/institutions/routing/:routing_number') { json_response 200, 'institutions_routing_number.json' }
 
   # user institutions
   get('/v2/institutions/consumer/valid_id/status') { json_response 200, 'user_institution_status.json' }

data/spec/support/fixtures/institutions_routing_number.json

@@ -0,0 +1,6 @@
+{
+  "base_url": "https://www.citibank.co.th",
+  "display_name": "CITIBANK (Thailand)",
+  "site_id": 20638,
+  "org_display_name": "Citigroup Inc"
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.2.10
+  version: 2.2.11
 platform: ruby
 authors:
 - Erich Quintero
@@ -273,6 +273,7 @@ files:
 - spec/support/fixtures/error.json
 - spec/support/fixtures/institution_add.json
 - spec/support/fixtures/institution_login_form.json
+- spec/support/fixtures/institutions_routing_number.json
 - spec/support/fixtures/institutions_search_list.json
 - spec/support/fixtures/invalid_institution_id.json
 - spec/support/fixtures/invalid_request_body.json