finapps 2.0.4 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae51d63eabbc06265ec732daaabdca386e3b1b79
-  data.tar.gz: 616025325958098e835789d0f39c9cbdf223a115
+  metadata.gz: c1467952204aa017d2c08fe58cdae31a62b57aa4
+  data.tar.gz: 6e0a321efe02addaf8731dfdff3de8ba59c9cd90
 SHA512:
-  metadata.gz: e36a7872196a1ea55ee82f37cbf999f1ffce1c1954a2ae7742d24dda678f3a6913d7e9ed6c26d18c004a4ca0fbb49c369714cd618e7d6e2f74da4be7b2e6831a
-  data.tar.gz: e0c3104cd52a91e73952fca3a021aa457e62ed70d50ef4c5340e0c9416bd744238dd72210e49cb6d40852b3482094ec993305247705154b8466a4c499961f798
+  metadata.gz: 4a2a307d85c1e7d4aa958444f7d2e2b790f074f20eee1e2836f21fbb9e61ff13d5ced6fd8522a720ff1575805d94a4199fe83a58fd5e59a2f15c4a7980f65446
+  data.tar.gz: 5c0dd965c386d2e827086ca559d48d394a4bd9b6f4f4e1189e0a65498475baa7daed195211835ca152c45404b32061ec319d9e7f940f9fcaa1e78964676c9b87

data/lib/finapps/middleware/tenant_authentication.rb

@@ -7,7 +7,7 @@ module FinApps
 
       def initialize(app, options={})
         super(app)
-        @header_value = "#{options[:identifier].strip}=#{options[:token].strip}"
+        @header_value = "#{options[:identifier].to_s.strip}=#{options[:token].to_s.strip}"
       end
 
       def call(env)

data/lib/finapps/rest/client.rb

@@ -21,6 +21,10 @@ module FinApps
       def users
         @users ||= FinApps::REST::Users.new self
       end
+
+      def orders
+        @orders ||= FinApps::REST::Orders.new self
+      end
     end
   end
 end

data/lib/finapps/rest/orders.rb

@@ -0,0 +1,10 @@
+module FinApps
+  module REST
+    class Orders < FinApps::REST::Resources # :nodoc:
+      def show(id)
+        raise MissingArgumentsError.new 'Missing argument: params.' if id.blank?
+        super
+      end
+    end
+  end
+end

data/lib/finapps/rest/resources.rb

@@ -1,23 +1,38 @@
 module FinApps
   module REST
     class Resources # :nodoc:
+      require 'erb'
+
       attr_reader :client
 
       # @param [FinApps::REST::Client] client
       # @return [FinApps::REST::Resources]
       def initialize(client)
+        raise MissingArgumentsError.new 'Missing argument: client.' if client.blank?
         @client = client
       end
 
-      def create(params, endpoint)
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
-
-        path = Defaults::END_POINTS[endpoint]
-        logger.debug "#{name}##{__method__} => path: #{path} params: #{params}"
-
+      def create(params={}, path=nil)
+        path = self.class.name.split('::').last.downcase if path.nil?
+        logger.debug "#{self.class.name}##{__method__} => path: #{path} params: #{params}"
         results, error_messages = client.send_request(path, :post, params)
         [results, error_messages]
       end
+
+      def show(id, path=nil)
+        if path.nil?
+          path = "#{self.class.name.split('::').last.downcase}/:id".sub ':id', ERB::Util.url_encode(id)
+        end
+        logger.debug "#{self.class.name}##{__method__} => path: #{path}"
+        results, error_messages = client.send_request(path, :get)
+        [results, error_messages]
+      end
+
+      private
+
+      def logger
+        client.logger
+      end
     end
   end
 end

data/lib/finapps/rest/users.rb

@@ -1,15 +1,20 @@
 module FinApps
   module REST
     class Users < FinApps::REST::Resources # :nodoc:
-      require 'erb'
-      include FinApps::REST::Defaults
+      END_POINTS = {
+        list:    nil,
+        create:  'users/new',
+        show:    'users/:public_id',
+        update:  'user',
+        destroy: 'users/:public_id'
+      }.freeze
 
       # @param [String] public_id
       # @return [FinApps::REST::User, Array<String>]
       def show(public_id)
         raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
 
-        end_point = Defaults::END_POINTS[:users_show]
+        end_point = END_POINTS[:show]
         path = end_point.sub ':public_id', ERB::Util.url_encode(public_id)
 
         logger.debug "##{__method__} => path: #{path}"
@@ -18,19 +23,13 @@ module FinApps
         [results, error_messages]
       end
 
-      # @param [Hash] params
-      # @return [FinApps::REST::User, Array<String>]
-      def create(params)
-        super(params, :users_create)
-      end
-
       # @param [Hash] params
       # @return [Array<String>]
       def update(params)
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__} => params: #{params}"
 
-        end_point = Defaults::END_POINTS[:users_update]
+        end_point = END_POINTS[:update]
         path = end_point
 
         logger.debug "##{__method__} => path: #{path}"
@@ -45,7 +44,7 @@ module FinApps
         raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
         logger.debug "##{__method__} => public_id: #{public_id}"
 
-        end_point = Defaults::END_POINTS[:users_delete]
+        end_point = END_POINTS[:delete]
         logger.debug "##{__method__} => end_point: #{end_point}"
 
         path = end_point.sub ':public_id', ERB::Util.url_encode(public_id)

data/lib/finapps/version.rb

@@ -1,3 +1,3 @@
 module FinApps
-  VERSION = '2.0.4'.freeze
+  VERSION = '2.0.5'.freeze
 end

data/lib/finapps.rb

@@ -20,6 +20,7 @@ require 'finapps/rest/resource'
 require 'finapps/rest/resources'
 
 require 'finapps/rest/users'
+require 'finapps/rest/orders'
 
 require 'finapps/rest/configuration'
 require 'finapps/rest/connection'

data/spec/rest/client_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe FinApps::REST::Client do
   context 'an instance of Client' do
     subject { FinApps::REST::Client.new(:company_identifier, :company_token) }
 
-    %i(users).each do |method|
+    %i(users orders).each do |method|
       it "responds to #{method}" do
         expect(subject).to respond_to(method)
       end
@@ -22,10 +22,14 @@ RSpec.describe FinApps::REST::Client do
       it { expect(subject.users).to be_an_instance_of(FinApps::REST::Users) }
     end
 
+    describe '#orders' do
+      it { expect(subject.orders).to be_an_instance_of(FinApps::REST::Orders) }
+    end
+
     # [:users, :institutions, :user_institutions, :transactions, :categories,
     # :budget_models, :budget_calculation, :budgets, :cashflows,
     # :alert, :alert_definition, :alert_preferences, :alert_settings, :rule_sets]
-    [:users].each do |method|
+    %i(users orders).each do |method|
       it "memoizes the result of #{method}" do
         first = subject.send(method)
         second = subject.send(method)

data/spec/rest/orders_spec.rb

@@ -0,0 +1,19 @@
+RSpec.describe FinApps::REST::Orders do
+  describe '#show' do
+    let(:client) { FinApps::REST::Client.new :company_identifier, :company_token }
+
+    context 'when missing params' do
+      subject { FinApps::REST::Orders.new(client).show(nil) }
+      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError) }
+    end
+
+    context 'when valid params are provided' do
+      subject { FinApps::REST::Orders.new(client).show(:id) }
+
+      it { expect { subject }.not_to raise_error }
+      it('returns an array') { expect(subject).to be_a(Array) }
+      it('performs a post and returns the response') { expect(subject[0]).to respond_to(:public_id) }
+      it('returns no error messages') { expect(subject[1]).to be_empty }
+    end
+  end
+end

data/spec/rest/resources_spec.rb

@@ -0,0 +1,35 @@
+RSpec.describe FinApps::REST::Resources do
+  let(:client) { FinApps::REST::Client.new :company_identifier, :company_token }
+  describe '#new' do
+    context 'when client is nil' do
+      subject { FinApps::REST::Resources.new(nil) }
+      it { expect { subject }.to raise_error(FinApps::MissingArgumentsError, 'Missing argument: client.') }
+    end
+
+    context 'when client param is set' do
+      subject { FinApps::REST::Resources.new(client) }
+      it { expect { subject }.not_to raise_error }
+      it('assigns @client') { expect(subject.client).to eq(client) }
+    end
+  end
+
+  describe '#create' do
+    context 'when valid params are provided' do
+      subject { FinApps::REST::Resources.new(client) }
+      it { expect { subject.create }.not_to raise_error }
+      it('returns an array') { expect(subject.create).to be_a(Array) }
+      it('performs a post and returns the response') { expect(subject.create[0]).to respond_to(:public_id) }
+      it('returns no error messages') { expect(subject.create[1]).to be_empty }
+    end
+  end
+
+  describe '#show' do
+    context 'when valid params are provided' do
+      subject { FinApps::REST::Resources.new(client).show(:id) }
+      it { expect { subject }.not_to raise_error }
+      it('returns an array') { expect(subject).to be_a(Array) }
+      it('performs a post and returns the response') { expect(subject[0]).to respond_to(:public_id) }
+      it('returns no error messages') { expect(subject[1]).to be_empty }
+    end
+  end
+end

data/spec/support/fake_api.rb

@@ -1,6 +1,13 @@
 require 'sinatra/base'
 
 class FakeApi < Sinatra::Base
+  # resource
+  post('/v2/resources') { json_response 201, 'resource.json' }
+  get('/v2/resources/:id') { json_response 200, 'resource.json' }
+
+  # orders
+  get('/v2/orders/:id') { json_response 200, 'resource.json' }
+
   # users
   get('/users/:id') { json_response 200, 'user.json' }
 

data/spec/support/fixtures/resource.json

@@ -0,0 +1,3 @@
+{
+  "public_id":"83e6c55a-9883-40bb-45f9-fc70d70731c9"
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.0.5
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-07 00:00:00.000000000 Z
+date: 2016-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -261,6 +261,7 @@ files:
 - lib/finapps/rest/configuration.rb
 - lib/finapps/rest/connection.rb
 - lib/finapps/rest/defaults.rb
+- lib/finapps/rest/orders.rb
 - lib/finapps/rest/resource.rb
 - lib/finapps/rest/resources.rb
 - lib/finapps/rest/users.rb
@@ -271,10 +272,13 @@ files:
 - spec/rest/base_client_spec.rb
 - spec/rest/client_spec.rb
 - spec/rest/configuration_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/resources_spec.rb
 - spec/spec_helper.rb
 - spec/support/fake_api.rb
 - spec/support/fixtures/error.json
 - spec/support/fixtures/relevance_ruleset_names.json
+- spec/support/fixtures/resource.json
 - spec/support/fixtures/user.json
 homepage: https://github.com/finapps/ruby-client
 licenses:
@@ -310,6 +314,8 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/fake_api.rb
 - spec/middleware/tenant_authentication_spec.rb
+- spec/rest/resources_spec.rb
 - spec/rest/client_spec.rb
+- spec/rest/orders_spec.rb
 - spec/rest/base_client_spec.rb
 - spec/rest/configuration_spec.rb