finapps 2.0.30 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e61830b719532ffe68a3133e861514c0080918ff
-  data.tar.gz: 81d526e72235f792beca947b2647e702cf3d3e92
+  metadata.gz: 5096a6b1981fc503ff5718b188c8b54f960db534
+  data.tar.gz: 28f39fcf4370f57c640d9b7bb555585fa1fc6455
 SHA512:
-  metadata.gz: 468d231c40ff6a9f766b2537d104b04483ae7ccbd199871cbb5f844136f01c2b13a26265aa53f8a5652b8c983febe25030f921a88fccd5b461a4a46b4a634b48
-  data.tar.gz: 2c26b47ada9b8cec80d034e67717ba28ed19a86c9cc6f536a74eaf5bdfc9a3aac3606b2f663b75b7b2bc82763077dc143d4f124e909e3d490d16a06d29a0d1f3
+  metadata.gz: 25f29fe1caafca96681e176dba45ce2cd941eb83a357a635ee66f93a41238cadb4a07fccb14b6b22b6d3ab3d83b6546dd5848e3a775d582f73a10a49d0d7b3b8
+  data.tar.gz: 374ea976bc0ed5e4ccb93b390b618f64858f8353c19565b7fbcd44bc201efa701e51e41c0888e43f784ba69261939a1fbd5c09c9a46b2be3c4b5201bbc315196

data/finapps.gemspec

@@ -4,6 +4,7 @@ lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'finapps/version'
 
+# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |spec|
   spec.name = 'finapps'
   spec.version = FinApps::VERSION

data/lib/finapps/error.rb

@@ -8,5 +8,10 @@ module FinApps # :nodoc:
   # Raised whenever a required argument is missing.
   class MissingArgumentsError < Error; end
 
-  %i(InvalidArgumentsError MissingArgumentsError).each {|const| Error.const_set(const, FinApps.const_get(const)) }
+  # Raised whenever there is a session timeout at the API.
+  class ApiSessionTimeoutError < Error; end
+
+  %i(InvalidArgumentsError MissingArgumentsError ApiSessionTimeoutError).each do |const|
+    Error.const_set(const, FinApps.const_get(const))
+  end
 end

data/lib/finapps/middleware/middleware.rb

@@ -5,6 +5,7 @@ module FinApps
   module Middleware
     autoload :AcceptJson, 'finapps/middleware/request/accept_json'
     autoload :UserAgent, 'finapps/middleware/request/user_agent'
+    autoload :NoEncodingBasicAuthentication, 'finapps/middleware/request/no_encoding_basic_authentication'
     autoload :TenantAuthentication, 'finapps/middleware/request/tenant_authentication'
     autoload :CustomLogger, 'finapps/middleware/response/custom_logger'
 
@@ -12,6 +13,7 @@ module FinApps
       Faraday::Request.register_middleware \
         accept_json: -> { AcceptJson },
         user_agent: -> { UserAgent },
+        no_encoding_basic_authentication: -> { NoEncodingBasicAuthentication },
         tenant_authentication: -> { TenantAuthentication }
       Faraday::Response.register_middleware \
         custom_logger: -> { CustomLogger }

data/lib/finapps/middleware/request/no_encoding_basic_authentication.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+module FinApps
+  module Middleware
+    class NoEncodingBasicAuthentication < ::Faraday::Request.load_middleware(:authorization)
+      def self.header(value)
+        sanitized = value.delete("\n")
+        super(:Basic, sanitized)
+      end
+    end
+  end
+end

data/lib/finapps/middleware/response/raise_error.rb

@@ -7,10 +7,13 @@ module FinApps
 
       SUCCESS_STATUSES = 200..299
       CONNECTION_FAILED_STATUS = 407
+      API_SESSION_TIMEOUT = 419
 
       def on_complete(env)
-        if SUCCESS_STATUSES.include? env[:status]
-          # do nothing
+        return if SUCCESS_STATUSES.include?(env[:status])
+
+        if env[:status] == API_SESSION_TIMEOUT
+          raise(FinApps::Error::ApiSessionTimeoutError, 'Api Session Timed out')
         elsif env[:status] == CONNECTION_FAILED_STATUS
           raise(Faraday::Error::ConnectionFailed, '407 "Proxy Authentication Required"')
         else

data/lib/finapps/rest/base_client.rb

@@ -73,9 +73,13 @@ module FinApps
       end
 
       def execute_request(path, method, params)
-        error_messages = []
+        errors = []
+
         begin
           response = execute_method path, method, params
+
+        rescue FinApps::ApiSessionTimeoutError => error
+          handle_error(error)
         rescue FinApps::InvalidArgumentsError => error
           handle_error error
         rescue FinApps::MissingArgumentsError => error
@@ -83,10 +87,10 @@ module FinApps
         rescue Faraday::Error::ConnectionFailed => error
           handle_error error
         rescue Faraday::Error::ClientError => error
-          error_messages = handle_client_error error
+          errors = handle_client_error(error)
         end
 
-        [response, error_messages]
+        [response, errors]
       end
 
       def handle_error(error)
@@ -95,7 +99,7 @@ module FinApps
       end
 
       def handle_client_error(error)
-        logger.warn "#{self.class}##{__method__} => Faraday::Error::ClientError, #{error}"
+        logger.warn "#{self.class}##{__method__} => #{error.class.name}, #{error}"
         error.response.present? && error.response[:error_messages] ? error.response[:error_messages] : [error.message]
       end
 

data/lib/finapps/rest/connection.rb

@@ -18,7 +18,7 @@ module FinApps
           conn.request :retry
           conn.request :multipart
           conn.request :url_encoded
-          conn.request :basic_auth, config.user_identifier, config.user_token if config.valid_user_credentials?
+          conn.request :no_encoding_basic_authentication, config.user_token if config.valid_user_credentials?
 
           conn.use FinApps::Middleware::RaiseError
           conn.response :rashify

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.0.30'
+  VERSION = '2.1.1'
 end

data/spec/middleware/request/no_encoding_basic_authentication_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+RSpec.describe FinApps::Middleware::NoEncodingBasicAuthentication do
+  let(:valid_credentials) { VALID_CREDENTIALS }
+
+  describe '.header' do
+    it 'does not encode the values' do
+      actual_token = FinApps::Middleware::NoEncodingBasicAuthentication.header(valid_credentials[:token])
+      expect(actual_token).to eq("Basic #{valid_credentials[:token]}")
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.30
+  version: 2.1.1
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-12 00:00:00.000000000 Z
+date: 2016-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -254,6 +254,7 @@ files:
 - lib/finapps/error.rb
 - lib/finapps/middleware/middleware.rb
 - lib/finapps/middleware/request/accept_json.rb
+- lib/finapps/middleware/request/no_encoding_basic_authentication.rb
 - lib/finapps/middleware/request/tenant_authentication.rb
 - lib/finapps/middleware/request/user_agent.rb
 - lib/finapps/middleware/response/custom_logger.rb
@@ -283,6 +284,7 @@ files:
 - spec/core_extensions/hash/compact_spec.rb
 - spec/core_extensions/object/is_integer_spec.rb
 - spec/middleware/request/accept_json_spec.rb
+- spec/middleware/request/no_encoding_basic_authentication_spec.rb
 - spec/middleware/request/tenant_authentication_spec.rb
 - spec/middleware/request/user_agent_spec.rb
 - spec/middleware/response/raise_error_spec.rb
@@ -361,6 +363,7 @@ specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
 - spec/support/fake_api.rb
+- spec/middleware/request/no_encoding_basic_authentication_spec.rb
 - spec/middleware/request/user_agent_spec.rb
 - spec/middleware/request/tenant_authentication_spec.rb
 - spec/middleware/request/accept_json_spec.rb