finapps 2.0.22 → 2.0.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6e7a13dcc72709dbb7f506225ab60f81c6fff823
-  data.tar.gz: 24fe49d526c5c7e4d3f26fa3b9f550338499eecd
+  metadata.gz: 5be4f8c24c61d16ba7c0faabfd7a8447457fbc9a
+  data.tar.gz: 260a063e09e7d8e7a23bfb9cf4e69b1d74dea3e0
 SHA512:
-  metadata.gz: 5e8371cef6f4f43074e58edc6e6929187214f1d0e3b8e853915c0fcfae27b12dac9887889917fb4898df9828c8599ab9c4b7c9a197cc656d493aaddc1cd16e1c
-  data.tar.gz: 1ee1d1761b9e7494ec27789e203e693830ed2b957bcee6e4fafc8a7615236e3379bcabe36d69c341150ee76de4e532cc66f52d30f5dc1766edb64d222572e05e
+  metadata.gz: 71a91753140914e0a7e01caceedcc11b3b5eb25997c8a46160c97706d23f511fa5dc5707de9762372ed52450ca10a94181c1788115092a7b8a4ea9a2ba372981
+  data.tar.gz: 6a1347b053c179e48f16b70c8785ccc8dfb5911371c40714ef2d963e4ad504d3ab14a0ebd5366742c7eb2648c2e8f4bf3d0a4989847af0d5fbd0ed92bdcea186

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/lib/finapps/rest/base_client.rb

@@ -48,6 +48,24 @@ module FinApps
         [result, error_messages]
       end
 
+      # Defines methods to perform HTTP GET, POST, PUT and DELETE requests.
+      # Returns a hash obtained from parsing the JSON object in the response body.
+      #
+      def method_missing(method_id, *arguments, &block)
+        if %i(get post put delete).include? method_id
+          connection.send(method_id) do |req|
+            req.url arguments.first
+            req.body = arguments[1] unless method_id == :get
+          end
+        else
+          super
+        end
+      end
+
+      def respond_to_missing?(method_sym, include_private=false)
+        [:get, :post, :put, :delete].include?(method_sym) ? true : super
+      end
+
       private
 
       def empty?(response)
@@ -78,7 +96,7 @@ module FinApps
 
       def handle_client_error(error)
         logger.warn "#{self.class}##{__method__} => Faraday::Error::ClientError, #{error}"
-        error.response[:error_messages] || [error.message]
+        error.response.present? && error.response[:error_messages] ? error.response[:error_messages] : [error.message]
       end
 
       def execute_method(path, method, params)
@@ -95,24 +113,6 @@ module FinApps
           raise FinApps::InvalidArgumentsError.new "Method not supported: #{method}."
         end
       end
-
-      # Defines methods to perform HTTP GET, POST, PUT and DELETE requests.
-      # Returns a hash obtained from parsing the JSON object in the response body.
-      #
-      def method_missing(method_id, *arguments, &block)
-        if %i(get post put delete).include? method_id
-          connection.send(method_id) do |req|
-            req.url arguments.first
-            req.body = arguments[1] unless method_id == :get
-          end
-        else
-          super
-        end
-      end
-
-      def respond_to_missing?(method_name, include_private=false)
-        %i(get post put delete).include? method_name ? true : super
-      end
     end
   end
 end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.0.22'
+  VERSION = '2.0.23'
 end

data/spec/rest/base_client_spec.rb

@@ -39,12 +39,19 @@ RSpec.describe FinApps::REST::BaseClient do
   end
 
   describe '#send_request' do
+    it 'should raise FinApps::InvalidArgumentsError if method is NOT supported' do
+      expect { subject.send_request('fake_path', :option) }.to raise_error(FinApps::InvalidArgumentsError,
+                                                                           'Method not supported: option.')
+    end
+
     it 'should raise FinApps::MissingArgumentsError if method is NOT provided' do
-      expect { subject.send_request(nil, :get) }.to raise_error(FinApps::MissingArgumentsError)
+      expect { subject.send_request(nil, :get) }.to raise_error(FinApps::MissingArgumentsError,
+                                                                'Missing argument: path.')
     end
 
     it 'should raise FinApps::MissingArgumentsError if path is NOT provided' do
-      expect { subject.send_request('fake_path', nil) }.to raise_error(FinApps::MissingArgumentsError)
+      expect { subject.send_request('fake_path', nil) }.to raise_error(FinApps::MissingArgumentsError,
+                                                                       'Missing argument: method.')
     end
 
     context 'when method and path are provided' do
@@ -102,4 +109,12 @@ RSpec.describe FinApps::REST::BaseClient do
       it { expect { subject.unsupported }.to raise_error(NoMethodError) }
     end
   end
+
+  describe '#respond_to_missing?' do
+    context 'for supported methods' do
+      [:get, :post, :put, :delete].each do |method|
+        it("responds to #{method}") { expect(subject).to respond_to(method) }
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.22
+  version: 2.0.23
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-18 00:00:00.000000000 Z
+date: 2016-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -235,6 +235,7 @@ extra_rdoc_files:
 files:
 - ".codeclimate.yml"
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-gemset"