finapps 2.0.13 → 2.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2987098824b52fede2e1a57d407bc402a6811e6
-  data.tar.gz: ed685e787f5a304be08d50a13ccc79467b93380e
+  metadata.gz: 049e5b0cf3c762597409c561552dfb6eca8d6bdd
+  data.tar.gz: f9606a4cb061d6bff60a8906433dd83ea58ef0b7
 SHA512:
-  metadata.gz: 7efb0ddf292db6de0ed56592d88e691ba37bc704dfa4afa3eb2dea6144e23b73d697f4c4bbd8426fa6198a19ca947ec31f6a75faec05010f755d439b37c8db97
-  data.tar.gz: 935e7f9909363169f09717e1ab384a56ef34bbec5663aa9b64f0e00030b9ce2d2c4176c3f8af03e043e63f12e2195cc2ad62e89a5bd5e50d97c69c911ffd94ca
+  metadata.gz: 2f906883bfa5c26c1f2bb08d74857a42b03f1de1e75463828d83c1ca91b6c4a2fe590dd3c198bff991313571e97cb1bd9d5b4702ffe90911550786b3688cd0f4
+  data.tar.gz: 458ea6bd78d194e2205653389b7d427e2963f3ee3b3332e28a41211a92ec453deaacc2439e81e4a00e13c6528c9befec256d7adfa34f55c74a43f7f1557440e2

data/lib/finapps/middleware/response/raise_error.rb

@@ -4,21 +4,17 @@ module FinApps
     class RaiseError < Faraday::Response::Middleware # :nodoc:
       using ObjectExtensions
       using StringExtensions
-      include FinApps::Utils::Loggeable
 
-      CLIENT_ERROR_STATUSES = 400...600
+      SUCCESS_STATUSES = 200..299
+      CONNECTION_FAILED_STATUS = 407
 
       def on_complete(env)
-        case env[:status]
-        when 407
-          # mimic the behavior that we get with proxy requests with HTTPS
-          raise Faraday::Error::ConnectionFailed, '407 "Proxy Authentication Required"'
-        when CLIENT_ERROR_STATUSES
-          raise Faraday::Error::ClientError, response_values(env)
+        if SUCCESS_STATUSES.include? env[:status]
+          # do nothing
+        elsif env[:status] == CONNECTION_FAILED_STATUS
+          raise(Faraday::Error::ConnectionFailed, '407 "Proxy Authentication Required"')
         else
-          # 200..206 Success codes
-          # all good!
-          logger.debug "##{__method__} => Status code: [#{env[:status]}]"
+          raise(Faraday::Error::ClientError, response_values(env))
         end
       end
 
@@ -36,13 +32,17 @@ module FinApps
       def error_messages(body)
         return nil if body.blank?
         body = parse_string(body) if body.is_a?(String)
-        body.is_a?(Hash) && body.key?('messages') ? body['messages'] : nil
+        has_message_key?(body) ? body['messages'] : nil
+      end
+
+      def has_message_key?(body)
+        body.respond_to?(:key?) && body.key?('messages')
       end
 
       def parse_string(body)
         ::JSON.parse(body)
       rescue ::JSON::ParserError
-        logger.error "##{__method__} => Unable to parse JSON response."
+        # logger.error "##{__method__} => Unable to parse JSON response."
       end
     end
   end

data/lib/finapps/rest/connection.rb

@@ -23,7 +23,7 @@ module FinApps
           conn.use FinApps::Middleware::RaiseError
           conn.response :rashify
           conn.response :json, content_type: /\bjson$/
-          conn.response :logger, logger, bodies: (ENV['RSPEC'] != 'true')
+          conn.response :logger, logger, bodies: (ENV['SILENT_LOG_BODIES'] != 'true')
 
           # Adapter (ensure that the adapter is always last.)
           conn.adapter :typhoeus

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.0.13'
+  VERSION = '2.0.14'
 end

data/spec/spec_helper.rb

@@ -4,8 +4,6 @@ if ENV['CODECLIMATE_REPO_TOKEN']
   CodeClimate::TestReporter.start
 end
 
-ENV['RSPEC'] = 'true'
-
 require 'bundler/setup'
 Bundler.setup
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.13
+  version: 2.0.14
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-19 00:00:00.000000000 Z
+date: 2016-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday