finapps 2.0.11 → 2.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9685b0a3f9fad48a9bd328149950e69d9ceece8
-  data.tar.gz: 499cd1b6b4e58d8cc0c80d3bbee9ea7b47b187e4
+  metadata.gz: 892658d99508ced4e79d11b2b61897f7c795b381
+  data.tar.gz: b839df6e00c6ad1720ed2a36fc53008c3fb9c6ed
 SHA512:
-  metadata.gz: 221ed36e938139757128972a2a1b249249bd9fc06aa2c1d75717af2d80a58a68db4dfb81377ba90e260c83f6b21cdfc72d37483a0a9df1739a2d689996caebf7
-  data.tar.gz: f6c5e89211c89c172c42f5aebb35e7fdd1b5350b894e49c72ba3b3b3d83771c14ea7c59ce2c153969f48dcc90817e1cdf788d92083b36205d1cd2a90888cd1c9
+  metadata.gz: cfa0c2e7fd724240be7ca119f996b70bb53bac454f21e1883b3a6b892e9ea628a0bc714c3eda3106a356aa69c01d6832f32dfd7b8f95880c478c32c923cfa9c8
+  data.tar.gz: 96ad3e2ddd0d94b881bf604316ada36e8abad77eed58692a11a95fd350dd62f05482855a9b46b84ee55ce3d7d677e90113a3fd68bdaa7f8a3629319d6fa3c232

data/lib/core_extensions/object/is_integer.rb

@@ -5,8 +5,6 @@ module ObjectExtensions
       Integer(self)
     rescue
       false
-    else
-      true
     end
   end
 end

data/lib/finapps.rb

@@ -22,6 +22,7 @@ require 'finapps/rest/defaults'
 require 'finapps/rest/resources'
 
 require 'finapps/rest/users'
+require 'finapps/rest/order_tokens'
 require 'finapps/rest/orders'
 
 require 'finapps/rest/configuration'

data/lib/finapps/rest/client.rb

@@ -24,6 +24,10 @@ module FinApps
         @users ||= FinApps::REST::Users.new self
       end
 
+      def order_tokens
+        @order_tokens ||= FinApps::REST::OrderTokens.new self
+      end
+
       def orders
         @orders ||= FinApps::REST::Orders.new self
       end

data/lib/finapps/rest/connection.rb

@@ -23,7 +23,7 @@ module FinApps
           conn.use FinApps::Middleware::RaiseError
           conn.response :rashify
           conn.response :json, content_type: /\bjson$/
-          conn.response :logger, logger, bodies: true
+          conn.response :logger, logger, bodies: (ENV['RSPEC'] != 'true')
 
           # Adapter (ensure that the adapter is always last.)
           conn.adapter :typhoeus

data/lib/finapps/rest/order_tokens.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+module FinApps
+  module REST
+    class OrderTokens < FinApps::REST::Resources # :nodoc:
+      using ObjectExtensions
+      using StringExtensions
+
+      def show(token)
+        raise MissingArgumentsError.new 'Missing argument: token.' if token.blank?
+
+        create nil, "orders/#{ERB::Util.url_encode(token)}"
+      end
+    end
+  end
+end

data/lib/finapps/rest/resources.rb

@@ -14,16 +14,14 @@ module FinApps
       end
 
       def create(params={}, path=nil)
-        path = self.class.name.split('::').last.downcase if path.nil?
+        path = end_point if path.nil?
         logger.debug "#{self.class.name}##{__method__} => path: #{path} params: #{params}"
         results, error_messages = client.send_request(path, :post, params)
         [results, error_messages]
       end
 
       def show(id, path=nil)
-        if path.nil?
-          path = "#{self.class.name.split('::').last.downcase}/:id".sub ':id', ERB::Util.url_encode(id)
-        end
+        path = "#{end_point}/:id".sub ':id', ERB::Util.url_encode(id) if path.nil?
         logger.debug "#{self.class.name}##{__method__} => path: #{path}"
         results, error_messages = client.send_request(path, :get)
         [results, error_messages]
@@ -34,6 +32,10 @@ module FinApps
       def logger
         client.logger
       end
+
+      def end_point
+        self.class.name.split('::').last.downcase
+      end
     end
   end
 end

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.0.11'
+  VERSION = '2.0.12'
 end

data/spec/rest/client_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe FinApps::REST::Client do
   context 'an instance of Client' do
     subject { FinApps::REST::Client.new(:company_identifier, :company_token) }
 
-    %i(users orders).each do |method|
+    %i(users orders order_tokens).each do |method|
       it "responds to #{method}" do
         expect(subject).to respond_to(method)
       end
@@ -23,6 +23,10 @@ RSpec.describe FinApps::REST::Client do
       it { expect(subject.users).to be_an_instance_of(FinApps::REST::Users) }
     end
 
+    describe '#order_tokens' do
+      it { expect(subject.order_tokens).to be_an_instance_of(FinApps::REST::OrderTokens) }
+    end
+
     describe '#orders' do
       it { expect(subject.orders).to be_an_instance_of(FinApps::REST::Orders) }
     end
@@ -30,7 +34,7 @@ RSpec.describe FinApps::REST::Client do
     # [:users, :institutions, :user_institutions, :transactions, :categories,
     # :budget_models, :budget_calculation, :budgets, :cashflows,
     # :alert, :alert_definition, :alert_preferences, :alert_settings, :rule_sets]
-    %i(users orders).each do |method|
+    %i(users orders order_tokens).each do |method|
       it "memoizes the result of #{method}" do
         first = subject.send(method)
         second = subject.send(method)

data/spec/rest/order_tokens_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Client object' do
+  describe '#show' do
+    client = FinApps::REST::Client.new :company_identifier, :company_token
+    subject(:order_tokens) { FinApps::REST::OrderTokens.new(client) }
+
+    context 'when missing token' do
+      it { expect { subject.show(nil) }.to raise_error(FinApps::MissingArgumentsError, 'Missing argument: token.') }
+    end
+
+    context 'for valid token' do
+      let(:show) { subject.show(:valid_token) }
+      let(:results) { show[0] }
+      let(:error_messages) { show[1] }
+
+      it { expect { show }.not_to raise_error }
+      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Rash) }
+      it('error_messages array is empty') { expect(error_messages).to eq([]) }
+    end
+
+    context 'for invalid token' do
+      let(:show) { subject.show(:invalid_token) }
+      let(:results) { show[0] }
+      let(:error_messages) { show[1] }
+
+      it { expect { show }.not_to raise_error }
+      it('results is nil') { expect(results).to be_nil }
+      it('error messages array is populated') { expect(error_messages.first).to eq('resource not found') }
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,6 +4,8 @@ if ENV['CODECLIMATE_REPO_TOKEN']
   CodeClimate::TestReporter.start
 end
 
+ENV['RSPEC'] = 'true'
+
 require 'bundler/setup'
 Bundler.setup
 

data/spec/support/fake_api.rb

@@ -8,6 +8,8 @@ class FakeApi < Sinatra::Base
   get('/v2/resources/:id') { json_response 200, 'resource.json' }
 
   # orders
+  post('/v2/orders/invalid_token') { json_response 404, 'order_token_invalid.json' }
+  post('/v2/orders/valid_token') { json_response 200, 'order_token.json' }
   get('/v2/orders/:id') { json_response 200, 'resource.json' }
 
   # users
@@ -16,6 +18,7 @@ class FakeApi < Sinatra::Base
   # relevance
   get('/v2/relevance/ruleset/names') { json_response 200, 'relevance_ruleset_names.json' }
 
+  # errors
   get('/v2/client_error') { json_response 400, 'error.json' }
   get('/v2/server_error') { status 500 }
   get('/v2/proxy_error') { status 407 }

data/spec/support/fixtures/order_token.json

@@ -0,0 +1,67 @@
+{
+  "public_id": "ead38f03-96e4-4c62-42fd-281d96170e41",
+  "user_id": "62356939-5837-48cc-4a3a-87cbe58daa0e",
+  "applicant": {
+    "first_name": "John",
+    "last_name": "Smith",
+    "ssn": "",
+    "dob": "",
+    "email": "erich@financialapps.com",
+    "mobile_phone": "",
+    "work_phone": "",
+    "home_phone": "",
+    "address": "",
+    "address2": "",
+    "city": "",
+    "state": "",
+    "zip": "33021",
+    "employer": {
+      "name": "",
+      "poistion": "",
+      "length_months": 0,
+      "pay_cycle": "",
+      "type": "",
+      "start_date": "0001-01-01T00:00:00Z",
+      "end_date": "0001-01-01T00:00:00Z",
+      "pay_amt_gross": 0,
+      "pay_amt_net": 0
+    },
+    "previous_employers": [],
+    "annual_income": 0,
+    "monthly_income": 0,
+    "weekly_income": 0,
+    "net_income": 0,
+    "marital_status": "",
+    "dependents": 0
+  },
+  "institutions": [
+    {
+      "name": "DAG",
+      "account_type": "",
+      "routing_no": "99999999",
+      "account_no": "1",
+      "name_on_account": "John Smith",
+      "account_nickname": "",
+      "account_address": "",
+      "shared": false,
+      "site_id": 16441
+    }
+  ],
+  "product": {
+    "public_id": "77777777-6ac6-4183-a671-6e75ca5989a5",
+    "code": "PROD2"
+  },
+  "requestor": {
+    "company_id": "",
+    "company_name": "",
+    "broker": "",
+    "processor": "",
+    "phone": "",
+    "email": "",
+    "reference_no": ""
+  },
+  "webhook": "",
+  "status": 2,
+  "date": "2016-07-12T19:33:33.655Z",
+  "date_modified": "2016-07-12T19:33:33.655Z"
+}

data/spec/support/fixtures/order_token_invalid.json

@@ -0,0 +1,5 @@
+{
+  "messages": [
+    "resource not found"
+  ]
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.11
+  version: 2.0.12
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-18 00:00:00.000000000 Z
+date: 2016-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -261,6 +261,7 @@ files:
 - lib/finapps/rest/connection.rb
 - lib/finapps/rest/credentials.rb
 - lib/finapps/rest/defaults.rb
+- lib/finapps/rest/order_tokens.rb
 - lib/finapps/rest/orders.rb
 - lib/finapps/rest/resources.rb
 - lib/finapps/rest/users.rb
@@ -276,11 +277,14 @@ files:
 - spec/rest/client_spec.rb
 - spec/rest/configuration_spec.rb
 - spec/rest/credentials_spec.rb
+- spec/rest/order_tokens_spec.rb
 - spec/rest/orders_spec.rb
 - spec/rest/resources_spec.rb
 - spec/spec_helper.rb
 - spec/support/fake_api.rb
 - spec/support/fixtures/error.json
+- spec/support/fixtures/order_token.json
+- spec/support/fixtures/order_token_invalid.json
 - spec/support/fixtures/relevance_ruleset_names.json
 - spec/support/fixtures/resource.json
 - spec/support/fixtures/user.json
@@ -324,6 +328,7 @@ test_files:
 - spec/rest/resources_spec.rb
 - spec/rest/client_spec.rb
 - spec/rest/orders_spec.rb
+- spec/rest/order_tokens_spec.rb
 - spec/rest/base_client_spec.rb
 - spec/rest/configuration_spec.rb
 - spec/core_extensions/object/is_integer_spec.rb