finapps 2.0.10 → 2.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcf4ea9c9605ea437a7c813888251d0ade6c48ff
-  data.tar.gz: 4566ea877d76bfd844191fa425dc520bb72a63d1
+  metadata.gz: e9685b0a3f9fad48a9bd328149950e69d9ceece8
+  data.tar.gz: 499cd1b6b4e58d8cc0c80d3bbee9ea7b47b187e4
 SHA512:
-  metadata.gz: 1370d0de8ce5510d1defe65b08caf38c7a10d0ed507d38040ff3e6a5e6e75b2b4f7582ff02728c660c1082a271f0a9d3e09fa59e3dc9458779ff741cbf669cbb
-  data.tar.gz: 240d6213a3f48f1eb9395c9050754f74dc4eeabb4a8e2697fa92901ebf61c50a6d8a100c1f2d32d3abf8ba7913c9358f4c380f404f4d09e496c38bc6975b7c23
+  metadata.gz: 221ed36e938139757128972a2a1b249249bd9fc06aa2c1d75717af2d80a58a68db4dfb81377ba90e260c83f6b21cdfc72d37483a0a9df1739a2d689996caebf7
+  data.tar.gz: f6c5e89211c89c172c42f5aebb35e7fdd1b5350b894e49c72ba3b3b3d83771c14ea7c59ce2c153969f48dcc90817e1cdf788d92083b36205d1cd2a90888cd1c9

data/lib/finapps/rest/base_client.rb

@@ -15,6 +15,10 @@ module FinApps
         @logger = logger
       end
 
+      def user_credentials?
+        config.valid_user_credentials?
+      end
+
       # Returns an initialized Faraday connection object.
       #
       # @return Faraday::Connection.

data/lib/finapps/rest/configuration.rb

@@ -17,6 +17,10 @@ module FinApps
         raise FinApps::InvalidArgumentsError.new "Invalid argument. {timeout: #{timeout}}" unless timeout.integer?
       end
 
+      def valid_user_credentials?
+        FinApps::REST::Credentials.new(user_identifier, user_token).valid?
+      end
+
       private
 
       def valid_host?

data/lib/finapps/rest/connection.rb

@@ -18,9 +18,7 @@ module FinApps
           conn.request :retry
           conn.request :multipart
           conn.request :url_encoded
-          if FinApps::REST::Credentials.new(config.user_identifier, config.user_token).valid?
-            conn.request :basic_auth, config.user_identifier, config.user_token
-          end
+          conn.request :basic_auth, config.user_identifier, config.user_token if config.valid_user_credentials?
 
           conn.use FinApps::Middleware::RaiseError
           conn.response :rashify

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.0.10'
+  VERSION = '2.0.11'
 end

data/spec/core_extensions/hash/compact_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+RSpec.describe HashExtensions do
+  context 'when refining hash' do
+    using HashExtensions
+
+    subject { {a: true, b: false, c: nil} }
+
+    describe '#compact' do
+      it 'returns a hash with non nil values' do
+        expect(subject.compact).to eq(a: true, b: false)
+        expect(subject).to eq(a: true, b: false, c: nil)
+      end
+    end
+    describe '#compact!' do
+      it 'replaces current hash with non nil values' do
+        expect(subject.compact!).to eq(a: true, b: false)
+        expect(subject).to eq(a: true, b: false)
+      end
+    end
+  end
+end

data/spec/core_extensions/object/is_integer_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+RSpec.describe ObjectExtensions do
+  context 'when refining Object' do
+    using ObjectExtensions
+
+    describe '#integer?' do
+      context 'for integers' do
+        subject { 1 + rand(10) }
+        it { expect(subject.integer?).to eq(true) }
+      end
+      context 'for non integers' do
+        subject { rand }
+        it { expect(subject.integer?).to eq(false) }
+      end
+    end
+  end
+end

data/spec/rest/base_client_spec.rb

@@ -16,6 +16,16 @@ RSpec.describe FinApps::REST::BaseClient do
     end
   end
 
+  describe '#user_credentials?' do
+    context 'when user credentials were not set' do
+      it { expect(subject.user_credentials?).to eq(false) }
+    end
+    context 'when user credentials were set' do
+      subject { FinApps::REST::BaseClient.new(valid_tenant_options.merge(user_identifier: 1, user_token: 2)) }
+      it { expect(subject.user_credentials?).to eq(true) }
+    end
+  end
+
   describe '#connection' do
     it 'created a Faraday connection object' do
       expect(subject.connection).to be_a(Faraday::Connection)

data/spec/rest/configuration_spec.rb

@@ -25,4 +25,15 @@ RSpec.describe FinApps::REST::Configuration do
       end
     end
   end
+
+  describe '#valid_user_credentials??' do
+    context 'when user credentials were not set' do
+      subject { FinApps::REST::Configuration.new(host: nil) }
+      it { expect(subject.valid_user_credentials?).to eq(false) }
+    end
+    context 'when user credentials were set' do
+      subject { FinApps::REST::Configuration.new(user_identifier: 1, user_token: 2) }
+      it { expect(subject.valid_user_credentials?).to eq(true) }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.10
+  version: 2.0.11
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-17 00:00:00.000000000 Z
+date: 2016-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -267,6 +267,8 @@ files:
 - lib/finapps/utils/loggeable.rb
 - lib/finapps/version.rb
 - lib/tasks/releaser.rake
+- spec/core_extensions/hash/compact_spec.rb
+- spec/core_extensions/object/is_integer_spec.rb
 - spec/middleware/accept_json_spec.rb
 - spec/middleware/tenant_authentication_spec.rb
 - spec/middleware/user_agent_spec.rb
@@ -308,19 +310,21 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/middleware/accept_json_spec.rb
-- spec/middleware/tenant_authentication_spec.rb
+- spec/spec_helper.rb
+- spec/support/fake_api.rb
 - spec/middleware/user_agent_spec.rb
-- spec/rest/base_client_spec.rb
-- spec/rest/client_spec.rb
-- spec/rest/configuration_spec.rb
+- spec/middleware/tenant_authentication_spec.rb
+- spec/middleware/accept_json_spec.rb
 - spec/rest/credentials_spec.rb
-- spec/rest/orders_spec.rb
 - spec/rest/resources_spec.rb
-- spec/spec_helper.rb
-- spec/support/fake_api.rb
+- spec/rest/client_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/base_client_spec.rb
+- spec/rest/configuration_spec.rb
+- spec/core_extensions/object/is_integer_spec.rb
+- spec/core_extensions/hash/compact_spec.rb