finapps 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b747f71ddb18cd525077bbb01db22eb846e0e12
-  data.tar.gz: 1a8fbe7e0d3b9d37fdbc55443e239db2303306db
+  metadata.gz: 3985c324f7f63672244fa139b5ab8c792021badf
+  data.tar.gz: c9c613457ba255f6bafbfdb2d3481b4f7570717a
 SHA512:
-  metadata.gz: bb218d57823afe544d4cc36ada1276ca3857a86c34fa42f5cf047980a606c859888f419c21d7590a9902f4b31646f7db932e1763b3f118a3c5b5a4c9cbb6ef25
-  data.tar.gz: 20914eaf113fe0905878ac655c7edd39df188b271533c62f250040e2ea4e44cbe49b1327ff723f940473fd20187bd7f29c795c9b09aefa26f4d984178b6ceb3a
+  metadata.gz: f57568f879da5059b2f153356da3a8564c07b09876ce0db2d102017d98fea6a9e3d8c773dbcfc2a34ee79eb25789806b4b0d20a3394418d93f65198696013650
+  data.tar.gz: 85cae203cff3418ddd3be3b6870ac193281f536d98d79c279aa55ea816160953348e0b13b8b7a47b8e53ee05757d32af3a8e23eac5a22ac80c2b195fd227ef42

data/lib/finapps/rest/alert.rb

@@ -19,8 +19,7 @@ module FinApps
         path = path.sub ':read', ERB::Util.url_encode(read)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        result, error_messages = @client.send_request(path, :get)
-
+        result, error_messages = client.send_request(path, :get)
         return result, error_messages
       end
 
@@ -39,8 +38,7 @@ module FinApps
         path = path.sub ':read', ERB::Util.url_encode(read)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        _, error_messages = @client.send_request(path, :put)
-
+        _, error_messages = client.send_request(path, :put)
         error_messages
       end
 
@@ -55,8 +53,7 @@ module FinApps
         path = end_point.sub ':alert_id', ERB::Util.url_encode(alert_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        _, error_messages = @client.send_request(path, :delete)
-
+        _, error_messages = client.send_request(path, :delete)
         error_messages
       end
 

data/lib/finapps/rest/alert_definition.rb

@@ -6,6 +6,7 @@ module FinApps
     class AlertDefinition < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Returns a list of alert definitions for current tenant.
       # @return [Hash, Array<String>]
       def list
         end_point = Defaults::END_POINTS[:alert_definition_list]
@@ -14,16 +15,11 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        result, error_messages = @client.send(path, :get)
-=======
-        result, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        result, error_messages = client.send_request(path, :get)
         return result, error_messages
       end
 
+      # Shows a single alert definition matching the given alert name.
       # @return [Hash, Array<String>]
       def show(alert_name)
         raise MissingArgumentsError.new 'Missing argument: alert_name.' if alert_name.blank?
@@ -35,16 +31,10 @@ module FinApps
         path = end_point.sub ':alert_name', ERB::Util.url_encode(alert_name)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        result, error_messages = @client.send(path, :get)
-=======
-        result, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        result, error_messages = client.send_request(path, :get)
         return result, error_messages
       end
 
     end
   end
-end
+end

data/lib/finapps/rest/alert_preferences.rb

@@ -6,6 +6,7 @@ module FinApps
     class AlertPreferences < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Shows alert preferences for a given user
       # @return [Hash, Array<String>]
       def show
         end_point = Defaults::END_POINTS[:alert_preferences_show]
@@ -14,16 +15,11 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        result, error_messages = @client.send(path, :get)
-=======
-        result, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        result, error_messages = client.send_request(path, :get)
         return result, error_messages
       end
 
+      # Updates alert preferences for a given user
       # @return [Hash, Array<String>]
       def update(params)
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
@@ -35,16 +31,10 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        _, error_messages = @client.send(path, :put, params.compact)
-=======
-        _, error_messages = @client.send_request(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        _, error_messages = client.send_request(path, :put, params.compact)
         error_messages
       end
 
     end
   end
-end
+end

data/lib/finapps/rest/alert_settings.rb

@@ -6,6 +6,7 @@ module FinApps
     class AlertSettings < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Shows alert settings for a given user.
       # @return [Hash, Array<String>]
       def show
         end_point = Defaults::END_POINTS[:alert_settings_show]
@@ -14,16 +15,11 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        result, error_messages = @client.send(path, :get)
-=======
-        result, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        result, error_messages = client.send_request(path, :get)
         return result, error_messages
       end
 
+      # Updates alert settings for a given user.
       # @return [Hash, Array<String>]
       def update(params)
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
@@ -35,16 +31,10 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        _, error_messages = @client.send(path, :put, params.compact)
-=======
-        _, error_messages = @client.send_request(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        _, error_messages = client.send_request(path, :put, params.compact)
         error_messages
       end
 
     end
   end
-end
+end

data/lib/finapps/rest/budget_calculation.rb

@@ -6,13 +6,14 @@ module FinApps
     class BudgetCalculation < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Creates a new Budget Calculation for the given user, using a budget template
+      # matching budget_model_id and teh given income amount.
       # @param [String] budget_model_id
       # @param [Number] income
       # @return [Array<Hash>, Array<String>]
       def create(budget_model_id, income)
         raise MissingArgumentsError.new 'Missing argument: budget_model_id.' if budget_model_id.blank?
         logger.debug "##{__method__.to_s} => budget_model: #{budget_model_id}"
-
         raise MissingArgumentsError.new 'Missing argument: income.' if income.blank?
         logger.debug "##{__method__.to_s} => income: #{income}"
 
@@ -22,16 +23,11 @@ module FinApps
         path = end_point.sub(':budget_model_id', ERB::Util.url_encode(budget_model_id)).sub(':income', ERB::Util.url_encode(income))
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        budget_calculation, error_messages = @client.send(path, :get)
-=======
-        budget_calculation, error_messages = @client.send_request(path, :get)
-        logger.debug "##{__method__.to_s} => Completed"
-
->>>>>>> develop
+        budget_calculation, error_messages = client.send_request(path, :get)
         return budget_calculation, error_messages
       end
 
+      # Shows the Budget Calculation for the given user.
       # @return [Array<Hash>, Array<String>]
       def show
         end_point = Defaults::END_POINTS[:budget_calculation_show]
@@ -40,16 +36,10 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        budget_calculation, error_messages = @client.send(path, :get)
-=======
-        budget_calculation, error_messages = @client.send_request(path, :get)
-        logger.debug "##{__method__.to_s} => Completed"
-
->>>>>>> develop
+        budget_calculation, error_messages = client.send_request(path, :get)
         return budget_calculation, error_messages
       end
 
     end
   end
-end
+end

data/lib/finapps/rest/budget_models.rb

@@ -6,21 +6,17 @@ module FinApps
     class BudgetModels < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Lists all budget models.
       # @return [Array<Hash>, Array<String>]
       def list
         path = Defaults::END_POINTS[:budget_models_list]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        budget_models, error_messages = @client.send(path, :get)
-=======
-        budget_models, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        budget_models, error_messages = client.send_request(path, :get)
         return budget_models, error_messages
       end
 
+      # Shows a budget model matching a given budget_model_id
       # @param [Integer] budget_model_id
       def show(budget_model_id)
         raise MissingArgumentsError.new 'Missing argument: budget_model_id.' if budget_model_id.blank?
@@ -32,13 +28,7 @@ module FinApps
         path = end_point.sub ':budget_model_id', ERB::Util.url_encode(budget_model_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        budget_model, error_messages = @client.send(path, :get) { |r| BudgetModel.new(r.body) }
-=======
-        budget_model, error_messages = @client.send_request(path, :get) { |r| BudgetModel.new(r.body) }
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        budget_model, error_messages = client.send_request(path, :get) { |r| BudgetModel.new(r.body) }
         return budget_model, error_messages
       end
 
@@ -49,4 +39,4 @@ module FinApps
     end
 
   end
-end
+end

data/lib/finapps/rest/budgets.rb

@@ -6,13 +6,13 @@ module FinApps
     class Budgets < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Shows budget results for a given date range.
       # @param [Date] start_date
       # @param [Date] end_date
       # @return [Hash, Array<String>]
       def show(start_date, end_date)
         raise MissingArgumentsError.new 'Missing argument: start_date.' if start_date.blank?
         logger.debug "##{__method__.to_s} => start_date: #{start_date}"
-
         raise MissingArgumentsError.new 'Missing argument: end_date.' if end_date.blank?
         logger.debug "##{__method__.to_s} => end_date: #{end_date}"
 
@@ -24,7 +24,7 @@ module FinApps
         path = end_point.sub(':start_date', ERB::Util.url_encode(start_date)).sub(':end_date', ERB::Util.url_encode(end_date))
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        result, error_messages = @client.send_request(path, :get)
+        result, error_messages = client.send_request(path, :get)
         if result.present? && error_messages.blank?
           categories = result_categories(result)
           raise 'Category results-set for budget is not an array.' unless categories.respond_to?(:each)
@@ -36,6 +36,7 @@ module FinApps
         return budget, error_messages
       end
 
+      # Updates the budget parameters.
       # @param [Hash] params
       # @return [Array<Hash>, Array<String>]
       def update(params={})
@@ -44,13 +45,7 @@ module FinApps
         end_point = Defaults::END_POINTS[:budget_update]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
-<<<<<<< HEAD
-        budget, error_messages = @client.send(end_point, :put, params)
-=======
-        budget, error_messages = @client.send_request(end_point, :put, params)
-        logger.debug "##{__method__.to_s} => Completed"
-
->>>>>>> develop
+        budget, error_messages = client.send_request(end_point, :put, params)
         return budget, error_messages
       end
 
@@ -105,4 +100,4 @@ module FinApps
     end
 
   end
-end
+end

data/lib/finapps/rest/cashflows.rb

@@ -12,7 +12,6 @@ module FinApps
       def show(start_date, end_date)
         raise MissingArgumentsError.new 'Missing argument: start_date.' if start_date.blank?
         logger.debug "##{__method__.to_s} => start_date: #{start_date}"
-
         raise MissingArgumentsError.new 'Missing argument: end_date.' if end_date.blank?
         logger.debug "##{__method__.to_s} => end_date: #{end_date}"
 
@@ -29,7 +28,7 @@ module FinApps
         path = end_point.sub(':start_date', ERB::Util.url_encode(start_date)).sub(':end_date', ERB::Util.url_encode(end_date))
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        result, error_messages = @client.send_request(path, :get)
+        result, error_messages = client.send_request(path, :get)
         if result.present? && error_messages.blank?
 
           summary = extract_value(result, 'summary')
@@ -85,4 +84,4 @@ module FinApps
     end
 
   end
-end
+end

data/lib/finapps/rest/categories.rb

@@ -3,6 +3,7 @@ module FinApps
     class Categories < FinApps::REST::Resources
       include FinApps::REST::Defaults
 
+      # Lists all categories.
       # @return [Array<Hash>, Array<String>]
       def list
         end_point = Defaults::END_POINTS[:categories_list]
@@ -11,16 +12,10 @@ module FinApps
         path = end_point
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        categories, error_messages = @client.send(path, :get)
-=======
-        categories, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        categories, error_messages = client.send_request(path, :get)
         return categories, error_messages
       end
 
     end
   end
-end
+end

data/lib/finapps/rest/client.rb

@@ -5,26 +5,22 @@ module FinApps
       include FinApps::Logging
       include FinApps::REST::Connection
 
+      attr_reader :config, :company_credentials
+
       # @param [String] company_identifier
       # @param [String] company_token
       # @param [Hash] options
       # @return [FinApps::REST::Client]
       def initialize(company_identifier, company_token, options = {})
         @config = DEFAULTS.merge! options
-        logger_config @config
+        logger_config config
 
         @company_credentials = {:company_identifier => company_identifier, :company_token => company_token}
         @company_credentials.validate_required_strings!
-
-        logger.debug "##{__method__.to_s} => Completed"
       end
 
-<<<<<<< HEAD
-        set_up_resources
-        logger.debug "##{__method__.to_s} => All resources initialized"
-=======
       def connection
-        @connection ||= set_up_connection(@company_credentials, @config)
+        @connection ||= set_up_connection(self.company_credentials, @config)
       end
 
       def users
@@ -81,7 +77,6 @@ module FinApps
 
       def rule_sets
         @rule_sets ||= FinApps::REST::Relevance::Rulesets.new self
->>>>>>> develop
       end
 
       # Performs HTTP GET, POST, UPDATE and DELETE requests.
@@ -92,15 +87,7 @@ module FinApps
       # @param [String] method
       # @param [Proc] proc
       # @return [Hash,Array<String>]
-<<<<<<< HEAD
-      def send(path, method, params = {}, &proc)
-        raise MissingArgumentsError.new 'Missing argument: method.' if method.blank?
-        result, error_messages = nil, nil
-=======
       def send_request(path, method, params = {}, &proc)
-        logger.debug "##{__method__.to_s} => Started"
->>>>>>> develop
-
         raise FinApps::REST::MissingArgumentsError.new 'Missing argument: path.' if path.blank?
         raise FinApps::REST::MissingArgumentsError.new 'Missing argument: method.' if method.blank?
 
@@ -140,6 +127,7 @@ module FinApps
         ensure
           logger.debug "##{__method__.to_s} => Failed, error_messages: #{error_messages.pretty_inspect}" if error_messages.present?
         end
+
         return result, error_messages
       end
 
@@ -147,11 +135,12 @@ module FinApps
       # @param [String] user_token
       def user_credentials!(user_identifier, user_token)
         {:user_identifier => user_identifier, :user_token => user_token}.validate_required_strings!
-        logger.debug "##{__method__.to_s} => Credentials passed validation. Attempting to set user credentials on current connection."
 
         @config[:user_identifier] = user_identifier
         @config[:user_token] = user_token
-        @connection = set_up_connection(@company_credentials, @config)
+
+        logger.debug "##{__method__.to_s} => Attempting to set user credentials on current connection."
+        @connection = set_up_connection(company_credentials, config)
       end
 
       private
@@ -166,16 +155,7 @@ module FinApps
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => GET path:#{path}"
-<<<<<<< HEAD
-        @connection.get { |req| req.url path }
-=======
-        response = connection.get do |req|
-          req.url path
-        end
-
-        logger.debug "##{__method__.to_s} => Completed"
-        response
->>>>>>> develop
+        connection.get { |req| req.url path }
       end
 
       # Performs an HTTP POST request.
@@ -189,11 +169,7 @@ module FinApps
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => POST path:#{path} params:#{skip_sensitive_data params }"
-<<<<<<< HEAD
-        @connection.post do |req|
-=======
-        response = connection.post do |req|
->>>>>>> develop
+        connection.post do |req|
           req.url path
           req.body = params
         end
@@ -210,11 +186,7 @@ module FinApps
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => PUT path:#{path} params:#{skip_sensitive_data(params)}"
-<<<<<<< HEAD
-        @connection.put do |req|
-=======
-        response = connection.put do |req|
->>>>>>> develop
+        connection.put do |req|
           req.url path
           req.body = params
         end
@@ -231,38 +203,12 @@ module FinApps
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => DELETE path:#{path} params:#{skip_sensitive_data(params)}"
-<<<<<<< HEAD
-        @connection.delete do |req|
-=======
-        response = connection.delete do |req|
->>>>>>> develop
+        connection.delete do |req|
           req.url path
           req.body = params
         end
       end
 
-<<<<<<< HEAD
-      # Initialize resources.
-      #
-      def set_up_resources
-        @users ||= FinApps::REST::Users.new self
-        @institutions ||= FinApps::REST::Institutions.new self
-        @user_institutions ||= FinApps::REST::UserInstitutions.new self
-        @transactions ||= FinApps::REST::Transactions.new self
-        @categories ||= FinApps::REST::Categories.new self
-        @budget_models ||= FinApps::REST::BudgetModels.new self
-        @budget_calculation ||= FinApps::REST::BudgetCalculation.new self
-        @budgets ||= FinApps::REST::Budgets.new self
-        @cashflows ||= FinApps::REST::Cashflows.new self
-        @alert ||= FinApps::REST::Alert.new self
-        @alert_definition ||= FinApps::REST::AlertDefinition.new self
-        @alert_settings ||= FinApps::REST::AlertSettings.new self
-        @alert_preferences ||= FinApps::REST::AlertPreferences.new self
-        @rule_sets ||= FinApps::REST::Relevance::Rulesets.new self
-      end
-
-=======
->>>>>>> develop
     end
   end
-end
+end

data/lib/finapps/rest/institutions.rb

@@ -18,13 +18,7 @@ module FinApps
         path = end_point.sub ':search_term', ERB::Util.url_encode(term)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        institutions, error_messages = @client.send(path, :get)
-=======
-        institutions, error_messages = @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        institutions, error_messages = client.send_request(path, :get)
         return institutions, error_messages
       end
 
@@ -39,13 +33,7 @@ module FinApps
         path = end_point.sub ':site_id', ERB::Util.url_encode(site_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        institution, error_messages = @client.send(path, :get) { |r| Institution.new(r.body) }
-=======
-        institution, error_messages = @client.send_request(path, :get) { |r| Institution.new(r.body) }
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        institution, error_messages = client.send_request(path, :get) { |r| Institution.new(r.body) }
         return institution, error_messages
       end
 
@@ -56,4 +44,4 @@ module FinApps
     end
 
   end
-end
+end

data/lib/finapps/rest/resources.rb

@@ -5,6 +5,8 @@ module FinApps
       include FinApps::REST::Defaults
       include FinApps::Logging
 
+      attr_reader :client
+
       # @param [FinApps::REST::Client] client
       # @return [FinApps::REST::Resources]
       def initialize(client)

data/lib/finapps/rest/transactions.rb

@@ -13,29 +13,19 @@ module FinApps
         path = end_point.sub ':transaction_id', ERB::Util.url_encode(transaction_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        transaction, error_messages = @client.send(path, :get)
-=======
-        transaction, error_messages =  @client.send_request(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        transaction, error_messages = client.send_request(path, :get)
         return transaction, error_messages
       end
 
       # @param [Hash] params
       # @return [Array<Hash>, Array<String>]
       def search(params={})
-        path = Defaults::END_POINTS[:transactions_list]
-        logger.debug "##{__method__.to_s} => path: #{path}"
+        end_point = Defaults::END_POINTS[:transactions_list]
 
-<<<<<<< HEAD
-        transactions, error_messages = @client.send(path, :post, params.compact)
-=======
-        transactions, error_messages = @client.send_request(path, :post, params.compact)
+        path = end_point
+        logger.debug "##{__method__.to_s} => path: #{path}"
 
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        transactions, error_messages = client.send_request(path, :post, params.compact)
         return transactions, error_messages
       end
 
@@ -45,17 +35,11 @@ module FinApps
         path = Defaults::END_POINTS[:transactions_update]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-<<<<<<< HEAD
-        _, error_messages = @client.send(path, :put, params.compact)
-=======
-        _, error_messages = @client.send_request(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
->>>>>>> develop
+        _, error_messages = client.send_request(path, :put, params.compact)
         error_messages
       end
 
     end
 
   end
-end
+end

data/lib/finapps/rest/user_institutions.rb

@@ -10,8 +10,7 @@ module FinApps
         path = Defaults::END_POINTS[:user_institutions_list]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institutions, error_messages = @client.send_request(path, :get)
-
+        user_institutions, error_messages = client.send_request(path, :get)
         return user_institutions, error_messages
       end
 
@@ -29,8 +28,7 @@ module FinApps
         path = end_point.sub ':site_id', ERB::Util.url_encode(site_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institution, error_messages = @client.send_request(path, :post, :parameters => parameters)
-
+        user_institution, error_messages = client.send_request(path, :post, :parameters => parameters)
         return user_institution, error_messages
       end
 
@@ -45,8 +43,7 @@ module FinApps
         path = end_point.sub ':user_institution_id', ERB::Util.url_encode(user_institution_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institution, error_messages = @client.send_request(path, :get)
-
+        user_institution, error_messages = client.send_request(path, :get)
         return user_institution, error_messages
       end
 
@@ -60,8 +57,7 @@ module FinApps
         path = end_point.sub ':user_institution_id', ERB::Util.url_encode(user_institution_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institution, error_messages = @client.send_request(path, :get)
-
+        user_institution, error_messages = client.send_request(path, :get)
         return user_institution, error_messages
       end
 
@@ -75,8 +71,7 @@ module FinApps
         path = end_point.sub ':user_institution_id', ERB::Util.url_encode(user_institution_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institution, error_messages = @client.send_request(path, :get)
-
+        user_institution, error_messages = client.send_request(path, :get)
         return user_institution, error_messages
       end
 
@@ -93,8 +88,7 @@ module FinApps
         path = end_point.sub ':user_institution_id', ERB::Util.url_encode(user_institution_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institution, error_messages = @client.send_request(path, :put, :parameters => parameters)
-
+        user_institution, error_messages = client.send_request(path, :put, :parameters => parameters)
         return user_institution, error_messages
       end
 
@@ -111,8 +105,7 @@ module FinApps
         path = end_point.sub ':user_institution_id', ERB::Util.url_encode(user_institution_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institution, error_messages = @client.send_request(path, :put, :parameters => parameters)
-
+        user_institution, error_messages = client.send_request(path, :put, :parameters => parameters)
         return user_institution, error_messages
       end
 
@@ -120,8 +113,7 @@ module FinApps
         path = Defaults::END_POINTS[:user_institutions_refresh]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user_institutions, error_messages = @client.send_request(path, :get)
-
+        user_institutions, error_messages = client.send_request(path, :get)
         return user_institutions, error_messages
       end
 
@@ -136,8 +128,7 @@ module FinApps
         path = end_point.sub ':user_institution_id', ERB::Util.url_encode(user_institution_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        _, error_messages = @client.send_request(path, :delete)
-
+        _, error_messages = client.send_request(path, :delete)
         error_messages
       end
 

data/lib/finapps/rest/users.rb

@@ -19,82 +19,63 @@ module FinApps
         path = end_point.sub ':public_id', ERB::Util.url_encode(public_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user, error_messages = @client.send_request(path, :get) { |r| User.new(r.body) }
-
+        user, error_messages = client.send_request(path, :get) { |r| User.new(r.body) }
         return user, error_messages
       end
 
       # @param [Hash] params
       # @return [FinApps::REST::User, Array<String>]
       def create(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
         end_point = Defaults::END_POINTS[:users_create]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
-        user, error_messages = @client.send_request(end_point, :post, params) { |r| User.new(r.body) }
-        logger.debug "##{__method__.to_s} => Completed"
-
+        user, error_messages = client.send_request(end_point, :post, params) { |r| User.new(r.body) }
         return user, error_messages
       end
 
       # @param [Hash] params
       # @return [Array<String>]
       def update(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
         path = Defaults::END_POINTS[:users_update]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        _, error_messages = @client.send_request(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
+        _, error_messages = client.send_request(path, :put, params.compact)
         error_messages
       end
 
       # @param [Hash] params
       # @return [FinApps::REST::User, Array<String>]
       def update_password(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
         path = Defaults::END_POINTS[:users_update_password]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        user, error_messages = @client.send_request(path, :put, params.compact) { |r| User.new(r.body) }
-        logger.debug "##{__method__.to_s} => Completed"
-
+        user, error_messages = client.send_request(path, :put, params.compact) { |r| User.new(r.body) }
         return user, error_messages
       end
 
       # @param [Hash] params
       # @return [FinApps::REST::User, Array<String>]
       def login(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
         end_point = Defaults::END_POINTS[:users_login]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
-        user, error_messages = @client.send_request(end_point, :post, params) { |r| User.new(r.body) }
-        logger.debug "##{__method__.to_s} => Completed"
-
+        user, error_messages = client.send_request(end_point, :post, params) { |r| User.new(r.body) }
         return user, error_messages
       end
 
       # @param [String] public_id
       # @return [Array<String>]
       def delete(public_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
         logger.debug "##{__method__.to_s} => public_id: #{public_id}"
 
@@ -104,9 +85,7 @@ module FinApps
         path = end_point.sub ':public_id', ERB::Util.url_encode(public_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        _, error_messages = @client.send_request(path, :delete)
-        logger.debug "##{__method__.to_s} => Completed"
-
+        _, error_messages = client.send_request(path, :delete)
         error_messages
       end
 

data/lib/finapps/version.rb

@@ -1,3 +1,3 @@
 module FinApps
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Erich Quintero