finalist 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c16358bc0a05975770702b6234cbb3c03f457fb4a1fd5ec707e0c87106247b50
-  data.tar.gz: 8da986b8a9c507c4dfb5bf200d3b92e59ac2cc7a1925f8202e49d8968cab87b3
+  metadata.gz: 95b4f9fc3ce3038564d8cd5c1bcc745b3b55d2e960e9eb4411ede7da1bdd2e80
+  data.tar.gz: d1812c39cea0d783f131c5c954bc09245a63c3fdfd85589d8d432d09e16d9c76
 SHA512:
-  metadata.gz: 2884650dd911c2667fa754e6fe6a35834b6704ea7081803ba5a34d7e0585899572fe351da5854cf57fac1d7fecbbc87227ff8b80586d74a51c5fc3214c31ed02
-  data.tar.gz: 01bd8655ba387ef3a885adfa44e9b345f49d8b5af7fed03a7369652114284fc295d18dcdadc01d11f04423f6c234c2fddbd3ebfcce4ceaeb71a794b3be6dfd8c
+  metadata.gz: 402f63f49c8785369a4d3756e84c7f8583959081c6757064c0bbb9ba14336a75b321ee4c8ab0e969eb2bd3773fe130335e5ee00daa836eb8d146a950328790af
+  data.tar.gz: 9646b7ba0b27596b54a2e9e1ba4062f0a8aad7c73be6fc6707f63b9dc102c66456c7c80c9de3deb9a5d9951378c77a82139753d7f94039c16d9b7064209322bf

data/README.md

@@ -1,9 +1,14 @@
 # Finalist
 [![Build Status](https://travis-ci.org/joker1007/finalist.svg?branch=master)](https://travis-ci.org/joker1007/finalist)
+[![Gem Version](https://badge.fury.io/rb/finalist.svg)](https://badge.fury.io/rb/finalist)
 
 Finalist adds `final` method modifier.
 `final` forbids method override.
 
+This gem is pseudo static code analyzer by `method_added` and `singleton_method_added` and `included` and `extended`.
+
+it detect final violation when class(module) is defined, not runtime.
+
 Simple case is following.
 
 ```ruby
@@ -15,7 +20,7 @@ class A1
 end
 
 class A2 < A1
-  def foo
+  def foo # => raise
   end
 end
 ```
@@ -25,6 +30,11 @@ This case raises `Finalist::OverrideFinalMethodError` at `def foo in A2 class`.
 This gem supports other cases.
 (see [finalist_spec.rb](https://github.com/joker1007/finalist/blob/master/spec/finalist_spec.rb))
 
+### My similar gems
+
+- [overrider](https://github.com/joker1007/overrider) (`override` implementation)
+- [abstriker](https://github.com/joker1007/abstriker) (`abstract` implementation)
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/finalist.rb

@@ -1,6 +1,26 @@
 require "finalist/version"
 require "set"
 
+using Module.new {
+  refine Object do
+    def verify_final_method(meth, detect_type)
+      super_method = meth.super_method
+      while super_method
+        if Finalist.finalized_methods[super_method.owner]&.member?(super_method.name)
+          backtrace = caller(1)
+          backtrace_start_pos = backtrace.rindex { |b| b.index(__FILE__) }
+          backtrace = backtrace.drop(backtrace_start_pos + 1)
+          raise Finalist::OverrideFinalMethodError.new(
+            "#{super_method.owner}##{super_method.name} at #{super_method.source_location.join(":")} is overrided\n  by #{meth.owner}##{meth.name} at #{meth.source_location.join(":")}",
+            meth.owner, super_method.owner, meth, detect_type
+          ).tap { |ex| ex.set_backtrace(backtrace) }
+        end
+        super_method = super_method.super_method
+      end
+    end
+  end
+}
+
 module Finalist
   class OverrideFinalMethodError < StandardError
     attr_reader :override_class, :origin_class, :unbound_method, :detect_type
@@ -41,7 +61,61 @@ module Finalist
     @finalized_methods ||= {}
   end
 
+  private
+
+  def method_added(symbol)
+    super
+
+    return if Finalist.disabled?
+
+    verify_final_method(instance_method(symbol), :method_added)
+  end
+
+  def singleton_method_added(symbol)
+    super
+
+    return if Finalist.disabled?
+
+    verify_final_method(singleton_class.instance_method(symbol), :singleton_method_added)
+  end
+
   module ModuleMethods
+    def include(mod)
+      super
+
+      ancestors.drop(1).each do |mod|
+        Finalist.finalized_methods[mod]&.each do |final_method_name|
+          meth =
+            begin
+              instance_method(final_method_name)
+            rescue NoMethodError
+              nil
+            end
+
+          verify_final_method(meth, :include) if meth
+        end
+      end
+    end
+
+    def extend(mod)
+      super
+
+      singleton_class.ancestors.drop(1).each do |mod|
+        Finalist.finalized_methods[mod]&.each do |final_method_name|
+          meth =
+            begin
+              singleton_class.instance_method(final_method_name)
+            rescue NoMethodError
+              nil
+            end
+
+          verify_final_method(meth, :extend) if meth
+        end
+      end
+    end
+
+    private
+
     def included(base)
       super
 
@@ -50,17 +124,15 @@ module Finalist
       base.extend(Finalist)
 
       base.ancestors.drop(1).each do |mod|
-        Finalist.finalized_methods[mod]&.each do |fmeth_name|
-          if meth = base.instance_method(fmeth_name)
-            super_method = meth.super_method
-            while super_method
-              if Finalist.finalized_methods[super_method.owner]&.member?(super_method.name)
-                raise OverrideFinalMethodError.new("#{super_method} at #{super_method.source_location.join(":")} is overrided\n  by #{meth} at #{meth.source_location.join(":")}", base, super_method.owner, meth, :included)
-              end
-
-              super_method = super_method.super_method
+        Finalist.finalized_methods[mod]&.each do |final_method_name|
+          meth =
+            begin
+              meth = base.instance_method(final_method_name)
+            rescue NoMethodError
+              nil
             end
-          end
+
+          verify_final_method(meth, :included) if meth
         end
       end
     end
@@ -71,66 +143,46 @@ module Finalist
 
         return if Finalist.disabled?
 
-        meth = singleton_class.instance_method(symbol)
-        super_method = meth.super_method
-        while super_method
-          if Finalist.finalized_methods[super_method.owner]&.member?(super_method.name)
-            raise OverrideFinalMethodError.new("#{super_method} at #{super_method.source_location.join(":")} is overrided\n  by #{meth} at #{meth.source_location.join(":")}", singleton_class, super_method.owner, meth, :extended_singleton_method_added)
+        meth =
+          begin
+            singleton_class.instance_method(symbol)
+          rescue NoMethodError
+            nil
           end
-          super_method = super_method.super_method
-        end
+
+        verify_final_method(meth, :extended_singleton_method_added) if meth
       end
 
       base.singleton_class.ancestors.drop(1).each do |mod|
-        Finalist.finalized_methods[mod]&.each do |fmeth_name|
-          if meth = base.singleton_class.instance_method(fmeth_name)
-            super_method = meth.super_method
-            while super_method
-              if Finalist.finalized_methods[super_method.owner]&.member?(super_method.name)
-                raise OverrideFinalMethodError.new("#{super_method} at #{super_method.source_location.join(":")} is overrided\n  by #{meth} at #{meth.source_location.join(":")}", base.singleton_class, super_method.owner, meth, :extended)
-              end
-              super_method = super_method.super_method
+        Finalist.finalized_methods[mod]&.each do |final_method_name|
+          meth =
+            begin
+              base.singleton_class.instance_method(final_method_name)
+            rescue NoMethodError
+              nil
             end
-          end
+
+          verify_final_method(meth, :extended) if meth
         end
       end
     end
   end
 
   module SyntaxMethods
+    private
+
     def final(symbol)
       method_set = Finalist.finalized_methods[self] ||= Set.new
+      instance_method(symbol)
       method_set.add(symbol)
+      symbol
     end
-  end
-
-  def method_added(symbol)
-    super
-
-    return if Finalist.disabled?
-
-    meth = instance_method(symbol)
-    super_method = meth.super_method
-    while super_method
-      if Finalist.finalized_methods[super_method.owner]&.member?(super_method.name)
-        raise OverrideFinalMethodError.new("#{super_method} at #{super_method.source_location.join(":")} is overrided\n  by #{meth} at #{meth.source_location.join(":")}", self, super_method.owner, meth, :method_added)
-      end
-      super_method = super_method.super_method
-    end
-  end
 
-  def singleton_method_added(symbol)
-    super
-
-    return if Finalist.disabled?
-
-    meth = singleton_class.instance_method(symbol)
-    super_method = meth.super_method
-    while super_method
-      if Finalist.finalized_methods[super_method.owner]&.member?(super_method.name)
-        raise OverrideFinalMethodError.new("#{super_method} at #{super_method.source_location.join(":")} is overrided\n  by #{meth} at #{meth.source_location.join(":")}", self, super_method.owner, meth, :singleton_method_added)
-      end
-      super_method = super_method.super_method
+    def final_singleton_method(symbol)
+      method_set = Finalist.finalized_methods[self.singleton_class] ||= Set.new
+      singleton_class.instance_method(symbol)
+      method_set.add(symbol)
+      symbol
     end
   end
 end

data/lib/finalist/version.rb

@@ -1,3 +1,3 @@
 module Finalist
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finalist
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - joker1007
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2018-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler