final 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f7914e66cf69af464eda26e6289e3f05c6a078349e2b9fe91ad4e0a20dec5ca
-  data.tar.gz: 5146a6c91f11149bb18071978f68f422ae60a748c0f5fa563ff73c66f4558ffb
+  metadata.gz: aabc866fcda14e6047d044a3bb77869df800f498db345807bd0793b187b1447a
+  data.tar.gz: 7dda6307af254464c9d1912b5a62adaaccd1990d8146d0f4f837d40716cec416
 SHA512:
-  metadata.gz: 832ed6846121c6c19d486f44a34f08b33cc69bed9999628b1a5655f97d211f8773c87f4f60c604f3d709fb951f63307948c9b33bdd00e11c388071896dc8d232
-  data.tar.gz: 58990ef4509fd12f0e73a6374485684076fcec5891181b5052ef24abebe9cb91a18fb38fbbe2a0a6311274a5c2ea9cec9205c9f96a29123413d85d67c1629ce6
+  metadata.gz: 49e0dafa040f9742dfe7a4b534048f4f9010b86afa4095d60c2584cf4ce78efc99d2829a59b18a257fd91e9e42d66e829f13594f6e1c3333d75b7f102f268d62
+  data.tar.gz: 14623815a23bc30fa4e27f4e21294869df88e8f21f1e267bafbd5d7ed61bddbeacb8b6a974bd0837760176750f9ae988520c3aae482036fcc3e00cca19367cd9

data/{CHANGES → CHANGES.md}

@@ -1,22 +1,28 @@
-== 0.3.0 - 16-Sep-2020
+## 0.3.1 - 7-Jun-2021
+* Some internal refactoring to avoid string based instance_eval, plus
+  added some memoization. Thanks go to Okura Masafumi for the patch.
+* Removed test-unit as a dev dependency, which I had apparently left
+  in the last release by mistake.
+
+## 0.3.0 - 16-Sep-2020
 * Switched from test-unit to rspec, and made corresponding updates.
 
-== 0.2.1 - 1-Jun-2020
+## 0.2.1 - 1-Jun-2020
 * Added a LICENSE file to distro as required by the Apache-2.0 license.
 
-== 0.2.0 - 8-Jan-2019
+## 0.2.0 - 8-Jan-2019
 * Changed license to Apache-2.0.
 * The VERSION constant is now FINAL_VERSION since this is a module.
 * Added some metadata to the gemspec.
 * Updated the cert, should be good for about 10 years.
 
-== 0.1.2 - 6-Dec-2015
+## 0.1.2 - 6-Dec-2015
 * This gem is now signed.
 * The gem related tasks in the Rakefile now assume Rubygems 2.x.
 
-== 0.1.1 - 8-Oct-2014
+## 0.1.1 - 8-Oct-2014
 * Updated gemspec, removed references to RubyForge, etc.
 * Updated Rakefile for Rubygems 2.x.
 
-== 0.1.0 - 8-Apr-2011
+## 0.1.0 - 8-Apr-2011
   * Initial release

data/{MANIFEST → MANIFEST.md}

@@ -1,7 +1,7 @@
-* CHANGES
+* CHANGES.md
 * LICENSE
-* README
-* MANIFEST
+* MANIFEST.md
+* README.md
 * Rakefile
 * final.gemspec
 * certs/djberg96_pub.pem

data/README.md

@@ -0,0 +1,69 @@
+[![Ruby](https://github.com/djberg96/final/actions/workflows/ruby.yml/badge.svg)](https://github.com/djberg96/final/actions/workflows/ruby.yml)
+
+## Description
+A Ruby module that can make your classes final. A final class cannot
+be subclassed, and its instance methods cannot be redefined.
+
+## Installation
+`gem install final`
+
+## Synopsis
+```ruby
+require 'final'
+
+class Alpha
+  include Final
+
+  def foo
+    puts "Hello"
+  end
+end
+
+# Error! You cannot subclass Alpha.
+class Beta < Alpha; end
+
+# Error! You cannot redefine an existing method.
+class Alpha
+  def foo
+    puts "Hi"
+  end
+end
+
+# Not an error. You can add new methods to an existing class.
+class Alpha
+  def bar
+    puts "World"
+  end
+end
+```
+
+## Developer's Notes
+This library is merely a proof of concept that was published as the result
+of a tweet made by James Edward Gray II, where he commented that Ruby core
+classes should never be subclassed. Knowing that static languages like Java
+implement the "final" keyword as a way to prevent subclassing, I wanted to
+see if something similar could be done for Ruby. Turns out it can.
+
+I do not, however, necessarily advocate actually using this library in
+production code. Freezing a class this way is contrary to the very nature
+of Ruby and dynamic languages in general. If you're going to use it, you had
+better have a very good reason for doing so!
+
+## Caveats
+Only instance methods are prevented from redefinition. Singleton methods are
+not final. This change may happen in a future release.
+
+## License
+Apache-2.0
+
+## Copyright
+(C) 2003-2021 Daniel J. Berger
+All Rights Reserved.
+
+## Warranty
+This package is provided "as is" and without any express or
+implied warranties, including, without limitation, the implied
+warranties of merchantability and fitness for a particular purpose.
+
+## Author
+Daniel J. Berger

data/Rakefile

@@ -8,9 +8,9 @@ namespace :gem do
   desc 'Build the final gem'
   task :create => [:clean] do
     require 'rubygems/package'
-    spec = eval(IO.read('final.gemspec'))
+    spec = Gem::Specification.load('final.gemspec')
     spec.signing_key = File.join(Dir.home, '.ssh', 'gem-private_key.pem')
-    Gem::Package.build(spec, true)
+    Gem::Package.build(spec)
   end
 
   desc "Install the final gem"

data/final.gemspec

@@ -2,7 +2,7 @@ require 'rubygems'
 
 Gem::Specification.new do |spec|
   spec.name       = 'final'
-  spec.version    = '0.3.0'
+  spec.version    = '0.3.1'
   spec.license    = 'Apache-2.0'
   spec.author     = 'Daniel J. Berger'
   spec.email      = 'djberg96@gmail.com'
@@ -12,15 +12,13 @@ Gem::Specification.new do |spec|
   spec.files      = Dir['**/*'].reject{ |f| f.include?('git') }
   spec.cert_chain = Dir['certs/*']
 
-  spec.extra_rdoc_files = ['README', 'CHANGES', 'MANIFEST']
-
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.9"
+  spec.add_development_dependency('rake')
+  spec.add_development_dependency('rspec', '~> 3.9')
 
   spec.metadata = {
     'homepage_uri'      => 'https://github.com/djberg96/final',
     'bug_tracker_uri'   => 'https://github.com/djberg96/final/issues',
-    'changelog_uri'     => 'https://github.com/djberg96/final/blob/master/CHANGES',
+    'changelog_uri'     => 'https://github.com/djberg96/final/blob/main/CHANGES.md',
     'documentation_uri' => 'https://github.com/djberg96/final/wiki',
     'source_code_uri'   => 'https://github.com/djberg96/final',
     'wiki_uri'          => 'https://github.com/djberg96/final/wiki'
@@ -30,7 +28,4 @@ Gem::Specification.new do |spec|
     The final library enables you to declare your classes as final. This
     prevents your class from being subclassed or having its methods redefined.
   EOF
-
-  spec.add_development_dependency('rake')
-  spec.add_development_dependency('test-unit', '>= 2.2.0')
 end

data/lib/final.rb

@@ -6,32 +6,31 @@ module Final
   class Error < RuntimeError; end
 
   # The version of the final library.
-  FINAL_VERSION = '0.3.0'.freeze
+  FINAL_VERSION = '0.3.1'.freeze
 
   def self.included(mod)
-    # Store already defined methods.
-    mod.instance_eval("@final_methods = []")
-
-    # Internal accessor used in the method_added definition.
-    def mod.final_methods
-      @final_methods
-    end
+    mod.instance_eval do
+      # Store already defined methods.
+      def final_methods
+        @final_methods ||= []
+      end
 
-    # Prevent subclassing, except implicity subclassing from Object.
-    def mod.inherited(sub)
-      raise Error, "cannot subclass #{self}" unless self == Object
-    end
+      # Prevent subclassing, except implicity subclassing from Object.
+      def inherited(_sub)
+        raise Error, "cannot subclass #{self}" unless self == Object
+      end
 
-    # Prevent methods from being redefined.
-    #--
-    # There's still going to be a method redefinition warning. Gosh, it
-    # sure would be nice if we could disable warnings.
-    #
-    def mod.method_added(sym)
-      if final_methods.include?(sym)
-        raise Error, "method '#{sym}' already defined"
-      else
-        final_methods << sym
+      # Prevent methods from being redefined.
+      #--
+      # There's still going to be a method redefinition warning. Gosh, it
+      # sure would be nice if we could disable warnings.
+      #
+      def method_added(sym)
+        if final_methods.include?(sym)
+          raise Error, "method '#{sym}' already defined"
+        else
+          final_methods << sym
+        end
       end
     end
   end

data/spec/final_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Final do
   end
 
   example "version constant returns expected version number" do
-    expect(Final::FINAL_VERSION).to eq('0.3.0')
+    expect(Final::FINAL_VERSION).to eq('0.3.1')
     expect(Final::FINAL_VERSION).to be_frozen
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: final
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Daniel J. Berger
@@ -35,7 +35,7 @@ cert_chain:
   ORVCZpRuCPpmC8qmqxUnARDArzucjaclkxjLWvCVHeFa9UP7K3Nl9oTjJNv+7/jM
   WZs4eecIcUc4tKdHxcAJ0MO/Dkqq7hGaiHpwKY76wQ1+8xAh
   -----END CERTIFICATE-----
-date:
+date: 2021-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -65,65 +65,31 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: test-unit
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.2.0
 description: |2
       The final library enables you to declare your classes as final. This
       prevents your class from being subclassed or having its methods redefined.
 email: djberg96@gmail.com
 executables: []
 extensions: []
-extra_rdoc_files:
-- README
-- CHANGES
-- MANIFEST
+extra_rdoc_files: []
 files:
+- CHANGES.md
+- Gemfile
 - LICENSE
-- CHANGES
-- MANIFEST
-- spec
-- spec/final_spec.rb
-- README
+- MANIFEST.md
+- README.md
 - Rakefile
-- certs
 - certs/djberg96_pub.pem
-- lib
-- lib/final.rb
-- Gemfile
 - final.gemspec
+- lib/final.rb
+- spec/final_spec.rb
 homepage: https://github.com/djberg96/final
 licenses:
 - Apache-2.0
 metadata:
   homepage_uri: https://github.com/djberg96/final
   bug_tracker_uri: https://github.com/djberg96/final/issues
-  changelog_uri: https://github.com/djberg96/final/blob/master/CHANGES
+  changelog_uri: https://github.com/djberg96/final/blob/main/CHANGES.md
   documentation_uri: https://github.com/djberg96/final/wiki
   source_code_uri: https://github.com/djberg96/final
   wiki_uri: https://github.com/djberg96/final/wiki
@@ -142,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.15
 signing_key:
 specification_version: 4
 summary: An implementation of 'final' for Ruby

data/README

@@ -1,65 +0,0 @@
-= Description
-  A Ruby module that can make your classes final. A final class cannot
-  be subclassed, and its instance methods cannot be redefined.
-
-= Installation
-  gem install final
-
-= Synopsis
-  require 'final'
-
-  class Alpha
-    include Final
-
-    def foo
-      puts "Hello"
-    end
-  end
-
-  # Error! You cannot subclass Alpha.
-  class Beta < Alpha; end
-
-  # Error! You cannot redefine an existing method.
-  class Alpha
-    def foo
-      puts "Hi"
-    end
-  end
-
-  # Not an error. You can add new methods to an existing class.
-  class Alpha
-    def bar
-      puts "World"
-    end
-  end
-
-= Developer's Notes
-  This library is merely a proof of concept that was published as the result
-  of a tweet made by James Edward Gray II, where he commented that Ruby core
-  classes should never be subclassed. Knowing that static languages like Java
-  implement the "final" keyword as a way to prevent subclassing, I wanted to
-  see if something similar could be done for Ruby. Turns out it can.
-
-  I do not, however, necessarily advocate actually using this library in
-  production code. Freezing a class this way is contrary to the very nature
-  of Ruby and dynamic languages in general. If you're going to use it, you had
-  better have a very good reason for doing so!
-
-= Caveats
-  Only instance methods are prevented from redefinition. Singleton methods are
-  not final. This change may happen in a future release.
-
-= License
-  Apache-2.0
-
-= Copyright
-  (C) 2003-2019 Daniel J. Berger
-  All Rights Reserved.
-
-= Warranty
-  This package is provided "as is" and without any express or
-  implied warranties, including, without limitation, the implied
-  warranties of merchantability and fitness for a particular purpose.
-
-= Author
-  Daniel J. Berger