fin 0.1.0 → 0.1.2

data/spec/fin/models/order_spec.rb

@@ -2,66 +2,47 @@ require 'spec_helper'
 require 'fin/models/shared_examples'
 
 describe Fin::Order do
+  let(:model_class_id) { 14 }
 
-  it_behaves_like 'model'
+  shared_examples_for 'order_with_set_properties' do
 
-  describe '#new with empty initializer' do
-    subject { Fin::Order.new }
-
-    its (:repl_id) {should == nil}
-    its (:rev) {should == nil}
-    its (:isin_id) {should == nil}
-    its (:isin) {should == nil}
-    its (:price) {should == nil}
-    its (:volume) {should == nil}
-    its (:dir) {should == nil}
-    its (:buysell) {should == nil}
-    its (:moment) {should == nil}
-    its (:book) {should == nil}
-  end
-
-  describe '#new with opts' do
-    subject { Fin::Order.new :isin => 1234567,
-                                :repl_id => 12,
-                                :rev => 123,
-                                :price => 1234,
-                                :volume => 12345,
-                                :buysell => 1,
-                                :moment => 'time',
-                                :book => 123456
-    }
+    it_behaves_like 'model'
+    it_behaves_like 'price_as_integer'
 
-    its (:repl_id) {should == 12}
-    its (:rev) {should == 123}
-    its (:isin_id) {should == 1234567}
-    its (:isin) {should == 1234567}
-    its (:price) {should == 1234}
-    its (:volume) {should == 12345}
-    its (:dir) {should == 1}
-    its (:buysell) {should == 1}
-    its (:moment) {should == 'time'}
-    its (:book) {should == 123456}
-
-    describe '#to_s, #inspect' do
+    describe '#to_s' do
       it 'is just right' do
         subject.to_s.should == "12:1234>12345+"
-        subject.inspect.should == "12:1234>12345+"
-      end
-    end
-
-    describe '#price=' do
-      it 'converts given price to Integer if it is integer' do
-        subject.price = 1313.0
-        subject.price.should == 1313
-        subject.price.should be_an Integer
       end
     end
 
     describe '#index' do
-      it 'should be equal to replId' do
+      it 'should be equal to repl_id' do
         subject.index.should == subject.repl_id
       end
     end
   end
+
+  describe '#new with empty initializer' do
+    let(:property_hash) { {} }
+    subject { Fin::Order.new }
+
+    it_behaves_like 'model'
+
+    it 'has all nil properties' do
+      subject.class.attribute_types.each { |prop, _| subject.send(prop).should == nil }
+    end
+  end
+
+  describe '#new with opts' do
+    let(:property_hash) do
+      {:repl_id => 12,
+       :amount => 12345,
+       :price => 1234,
+       :dir => 1
+      }
+    end
+    subject { Fin::Order.new property_hash }
+    it_behaves_like 'order_with_set_properties'
+  end
 end
 

data/spec/fin/models/position_spec.rb

@@ -2,65 +2,14 @@ require 'spec_helper'
 require 'fin/models/shared_examples'
 
 describe Fin::Position do
+  let(:model_class_id) { 15 }
 
-  it_behaves_like 'model'
+  shared_examples_for 'position_with_set_properties' do
+    it_behaves_like 'model'
 
-  describe '#new with empty initializer' do
-    subject { Fin::Position.new }
-
-    its (:repl_id) {should == nil} # replId
-    its (:repl_rev) {should == nil} # replRev
-    its (:isin_id) {should == nil}
-    its (:client_code) {should == nil}
-    its (:open_qty) {should == nil}
-    its (:buys_qty) {should == nil}
-    its (:sells_qty) {should == nil}
-    its (:pos) {should == nil}
-    its (:net_volume_rur) {should == nil}
-    its (:last_deal_id) {should == nil}
-
-#    isin_id	    i4	���������� �������� ������������� �����������
-#    client_code	c7	��� �������
-#    open_qty	    i4	���������� ������� �� ������ ������
-#    buys_qty	    i4	���������� ��������� ���������� � ���� ������
-#    sells_qty	  i4	���������� ��������� ���������� � ���� ������
-#    pos	        i4	������� �������
-#    net_volume_rur	d26.2	�����-����� �����, � ������, �� ������� ���� ��������� ������.
-#             ������������� ����� � ������ ��������, ������������� � ������ �������������
-#    last_deal_id	  i8	������������� ��������� ������
-  end
-
-  describe '#new with opts' do
-    subject { Fin::Position.new :isin_id => 1234567,
-                                   :repl_id => 12,
-                                   :repl_rev => 123,
-                                   :client_code => 'fz1234',
-                                   :open_qty => 12345,
-                                   :buys_qty => 1212,
-                                   :sells_qty => 1213,
-                                   :pos => 12344,
-                                   :net_volume_rur => 123456,
-                                   :last_deal_id => 654321,
-
-    }
-
-    its (:isin_id) {should == 1234567}
-    its (:isin) {should == 1234567}
-    its (:id) {should == 12}
-    its (:rev) {should == 123}
-    its (:client_code) {should == 'fz1234'}
-    its (:open_qty) {should == 12345}
-
-    its (:buys_qty) {should == 1212}
-    its (:sells_qty) {should == 1213}
-    its (:pos) {should == 12344}
-    its (:net_volume_rur) {should == 123456}
-    its (:last_deal_id) {should == 654321}
-
-    describe '#to_s, #inspect' do
+    describe '#to_s' do
       it 'is just right' do
         subject.to_s.should == "12[1234567] 12344, open: 12345, buys: 1212, sells: 1213"
-        subject.inspect.should == "12[1234567] 12344, open: 12345, buys: 1212, sells: 1213"
       end
     end
 
@@ -70,5 +19,35 @@ describe Fin::Position do
       end
     end
   end
+
+  describe '#new with empty initializer' do
+    let(:property_hash) { {} }
+    subject { Fin::Position.new }
+
+    it_behaves_like 'model'
+
+    it 'has all nil properties' do
+      subject.class.attribute_types.each { |prop, _| subject.send(prop).should == nil }
+    end
+  end
+
+  describe '#new with opts' do
+    let(:property_hash) do
+      {:isin_id => 1234567,
+       :repl_id => 12,
+       :repl_rev => 123,
+       :client_code => 'fz1234',
+       :open_qty => 12345,
+       :buys_qty => 1212,
+       :sells_qty => 1213,
+       :pos => 12344,
+       :net_volume_rur => 123456,
+       :last_deal_id => 654321,
+
+      }
+    end
+    subject { Fin::Position.new property_hash }
+    it_behaves_like 'position_with_set_properties'
+  end
 end
 

data/spec/fin/models/quote_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+require 'fin/models/shared_examples'
+
+describe Fin::Quote do
+  let(:model_class_id) { 16 }
+
+  shared_examples_for 'quote_with_set_properties' do
+    it_behaves_like 'model'
+    it_behaves_like 'price_as_integer'
+
+    its (:book) {should == 123456}
+
+    describe '#to_s' do
+      it 'is just right' do
+        subject.to_s.should == "12:1234>12345+"
+      end
+    end
+
+    describe '#index' do
+      it 'should be equal to repl_id' do
+        subject.index.should == subject.repl_id
+      end
+    end
+  end
+
+  describe '#new with empty initializer' do
+    let(:property_hash) { {} }
+    subject { Fin::Quote.new }
+
+    its (:book) {should == nil}
+
+    it_behaves_like 'model'
+
+    it 'has all nil properties' do
+      subject.class.attribute_types.each { |prop, _| subject.send(prop).should == nil }
+    end
+  end
+
+  describe 'with properties' do
+    let(:property_hash) do
+      {:isin_id => 1234567,
+       :repl_id => 12,
+       :rev => 123,
+       :repl_act => 1,
+       :price => 1234.0,
+       :volume => 12345,
+       :buysell => 1,
+       :moment => 'time',
+       :book => 123456
+      }
+    end
+
+    context 'initialized with property options hash' do
+      subject { Fin::Quote.new property_hash }
+      it_behaves_like 'quote_with_set_properties'
+    end
+
+    context 'initialized with property array' do
+      subject { Fin::Quote.new 12,
+                               123,
+                               1,
+                               1234567,
+                               1234.0,
+                               12345,
+                               1,
+                               'time',
+                               :book => 123456
+      }
+
+      it_behaves_like 'quote_with_set_properties'
+    end
+  end
+end

data/spec/fin/models/shared_examples.rb

@@ -1,5 +1,86 @@
 shared_examples_for 'model' do
- it 'has index method' do
-   expect {subject.index }.to_not raise_error
- end
+  it 'has index method' do
+    expect { subject.index }.to_not raise_error
+  end
+
+  it 'has pre-defined replID, replRev, replAct properties' do
+    expect do
+      subject.replID
+      subject.repl_id
+      subject.replRev
+      subject.repl_rev
+      subject.rev
+      subject.replAct
+      subject.repl_act
+    end.to_not raise_error
+  end
+
+  context 'properties' do
+
+    it 'has all properties set correctly' do
+      property_hash.each { |prop, value| subject.send(prop).should == value }
+    end
+
+    context 'enumeration' do
+
+      specify { should be_kind_of Enumerable }
+
+      describe '#each' do
+        it 'enumerates through property names and respective values' do
+          @property_names = []
+          @property_values = []
+          subject.each do |name, value|
+            @property_names << name
+            @property_values << value
+          end
+          @property_values.size.should == subject.class.attribute_types.size
+          @property_names.should == subject.class.attribute_types.keys
+        end
+      end
+
+      describe '#each_property' do
+        it 'enumerates through property names and respective values' do
+          @property_names = []
+          @property_values = []
+          subject.each_property do |name, value|
+            @property_names << name
+            @property_values << value
+          end
+          @property_values.size.should == subject.class.attribute_types.size
+          @property_names.should == subject.class.attribute_types.keys
+        end
+      end
+    end
+  end
+
+  describe '#inspect' do
+    it 'lists all properties' do
+      subject.inspect.should == subject.map { |prop, value| "#{prop}=#{value}" }.join(',')
+    end
+  end
+
+  describe '.model_class_id' do
+    it 'is properly set' do
+      described_class.model_class_id.should == model_class_id
+    end
+
+    it 'is added to model classes list' do
+      id = described_class.model_class_id
+      Fin::Model.model_classes[id].should == described_class
+      described_class.model_classes[id].should == described_class
+    end
+  end
+end
+
+shared_examples_for 'price_as_integer' do
+  describe '#price_as_integer' do
+    it 'returns price as Integer if it is Integer' do
+      subject.price = 1313.0
+      subject.price.should == 1313.0
+      subject.price_as_integer.should == 1313
+      subject.price = 1313.5
+      subject.price.should == 1313.5
+      subject.price_as_integer.should == 1313.5
+    end
+  end
 end

data/spec/fin/order_list_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 require 'fin/shared_examples.rb'
 
-describe Fin::OrderList do
-  subject { Fin::OrderList.new }
-  let(:item_index) { @item.id }
+describe Fin::QuoteList do
+  subject { Fin::QuoteList.new }
+  let(:item_index) { @item.repl_id }
   let (:new_item_book_index) {new_item.price}
 
   before(:each) do
-    @item = Fin::Order.new :isin_id => 1234, :id => 0, :price => 20
-    @item1 = Fin::Order.new :isin_id => 1234, :id => 1, :price => 10
+    @item = Fin::Quote.new :isin_id => 1234, :repl_id => 0, :price => 20
+    @item1 = Fin::Quote.new :isin_id => 1234, :repl_id => 1, :price => 10
     @same_isin_item = @item1
-    @item2 = Fin::Order.new :isin_id => 5678, :id => 2, :price => 10
+    @item2 = Fin::Quote.new :isin_id => 5678, :repl_id => 2, :price => 10
     @diff_isin_item = @item2
-    @zero_price_item = Fin::Order.new :isin_id => 1234, :id => 3, :price => 0
-    @repeat_item = Fin::Order.new :isin_id => 1234, :id => 0, :price => 13
-    @repeat_zero_price_item = Fin::Order.new :isin_id => 1234, :id => 0, :price => 0
+    @zero_price_item = Fin::Quote.new :isin_id => 1234, :repl_id => 3, :price => 0
+    @repeat_item = Fin::Quote.new :isin_id => 1234, :repl_id => 0, :price => 13
+    @repeat_zero_price_item = Fin::Quote.new :isin_id => 1234, :repl_id => 0, :price => 0
   end
 
   it_behaves_like 'changed_list'
@@ -31,7 +31,7 @@ describe Fin::OrderList do
   describe 'adding item' do
     let(:expected_number_of_books) { 1 }
 
-    context 'to empty OrderList' do
+    context 'to empty QuoteList' do
       let(:new_item) { @item }
 
       it_behaves_like 'adding_item_to_books'
@@ -43,7 +43,7 @@ describe Fin::OrderList do
       end
     end
 
-    context 'to non-empty OrderList' do
+    context 'to non-empty QuoteList' do
       before(:each) do
         subject.add(@item).size.should == 1
       end
@@ -111,7 +111,7 @@ describe Fin::OrderList do
 
       it 'deletes item from the list' do
         subject.remove(unwanted_item)
-        subject[unwanted_item.id].should == nil
+        subject[unwanted_item.repl_id].should == nil
         subject.size.should == expected_size
       end
 

data/spec/fin/shared_examples.rb

@@ -340,7 +340,7 @@ shared_examples_for 'creating_books' do
     book = subject.books[new_item.isin_id]
     if new_item_book_index == 0
       case subject
-        when Fin::OrderList
+        when Fin::QuoteList
           new_item.book.should == nil
         else
           new_item.book.should == book

data/tasks/common.rake

@@ -2,7 +2,7 @@
 #task 'gem:release' => 'test:run'
 
 task :notes do
- puts 'Output annotations (TBD)'
+  puts 'Output annotations (TBD)'
 end
 
 #Bundler not ready for prime time just yet
@@ -15,4 +15,4 @@ end
 #    system "bundle install"
 #    puts
 #  end
-#end
+#end

data/tasks/spec.rake

@@ -6,7 +6,7 @@ namespace :spec do
   require 'rspec/core/rake_task'
 
   desc "Run all specs"
-  RSpec::Core::RakeTask.new(:spec){|task|}
+  RSpec::Core::RakeTask.new(:spec) { |task|}
 
   desc "Run specs with RCov"
   RSpec::Core::RakeTask.new(:rcov) do |task|