filterrific 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b450ac700cb2087731e8d30c8c4e94bc7f90df26
-  data.tar.gz: fce6b4218644562383de7f9a9bfdf9d71fd75c5f
+  metadata.gz: cdf8a79ceb47199242045fe675a29bae23a2c05a
+  data.tar.gz: 5f06c14fbc9c712bcf280cd51aaa2b6a45a5377d
 SHA512:
-  metadata.gz: 2137ab79b5a0bdd7d40d07046208ec8f5b3d73ad7f883f2ea3d5516c00c5c1fb5eb17c811b30bb6f4001549eb5168ec3b38b7038bbca925d87c969591c423b81
-  data.tar.gz: 4397b2c6d32ff3acc39fe4d3ea31f9d6799583b65c55a75bf7bf1e3f759eeb2b7ecd90d5ec853cfe9dc859085f0955b13fcbab3bebfc423a7bda8a8d278339e3
+  metadata.gz: ef082a1dea5d3c989cd65b032bef0931e5fb75a6d0758f1ee4729b04d019e6e887a4633e9691991da387e9b92bae0c839a868c997d3fcf7947203719ced90bb6
+  data.tar.gz: 8ec955b62c7a8054f9e91ab070a0cdc3154dc37f82fa2583f0df2f561bf31376a52dd74b1fb249021b89f13c571a5e09481f4ba7f636fd316f9ef90927d09227

data/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 Filterrific major versions match the Ruby on Rails major versions they work with.
 
+## [5.0.1] - Jan. 2, 2018
+
+* Changed all instances of #deep_stringify_keys back to #stringify_keys. This was changed in 5.0.0, but it shouldn't have been changed.
+
 ## [5.0.0] - Dec. 31, 2017
 
 * We're switching to a new versioning strategy for Filterrific: Filterrific major releases (the first number in the version) will be matched with the supported major version of Rails. Minor and path versions may diverge from Rails. That means for any version of Rails 5.x you will use the most current version of Filterrific 5.x.

data/README.md

@@ -43,9 +43,9 @@ Every commit to Filterrific is automatically tested against the following scenar
 |--------------------|---------------|--------------------------------|------------------------------------|--------------|
 | 5.x                | Rails 5.x     | MRI 2.0.0, 2.1.7, 2.2.3, 2.3.1 | mysql2, postgresql                 |[![Build Status](https://travis-ci.org/jhund/filterrific_demo.svg?branch=rails-5.x)](https://travis-ci.org/jhund/filterrific_demo)|
 | 4.x                | Rails 4.x     | MRI 2.0.0, 2.1.7, 2.2.3, 2.3.1 | mysql, mysql2, postgresql, sqlite3 |[![Build Status](https://travis-ci.org/jhund/filterrific_demo.svg?branch=rails-4.x)](https://travis-ci.org/jhund/filterrific_demo)|
-| 3.x                | Rails 3.2     | MRI 2.0.0, 2.1.7               | mysql, mysql2, postgresql, sqlite3 |[![Build Status](https://travis-ci.org/jhund/filterrific_demo.svg?branch=rails-3.x)](https://travis-ci.org/jhund/filterrific_demo)|
-| 2.x                | Rails 3.2     | MRI 1.9.3                      | mysql, mysql2, postgresql, sqlite3 | [N/A]
-| 1.x                | < 3.2         | MRI <= 1.9.3                   | mysql, mysql2, postgresql, sqlite3 | [N/A]
+| 3.x                | Rails 3.2     | MRI 2.0.0, 2.1.7               | mysql, mysql2, postgresql, sqlite3 | Not tested|
+| 2.x                | Rails 3.2     | MRI 1.9.3                      | mysql, mysql2, postgresql, sqlite3 | Not tested|
+| 1.x                | < 3.2         | MRI <= 1.9.3                   | mysql, mysql2, postgresql, sqlite3 | Not tested|
 
 ### Guidelines for submitting issues
 
@@ -85,4 +85,4 @@ If you think you've found a bug, or have a feature request, then create an issue
 
 ### Copyright
 
-Copyright (c) 2010 - 2017 Jo Hund. See [(MIT) LICENSE](https://github.com/jhund/filterrific/blob/master/MIT-LICENSE) for details.
+Copyright (c) 2010 - 2018 Jo Hund. See [(MIT) LICENSE](https://github.com/jhund/filterrific/blob/master/MIT-LICENSE) for details.

data/doc/scratchpad.md

@@ -2,12 +2,7 @@
 
 ## TODO
 
-* [x] Go to deep_stringify_keys (in ActionControllerExtension#initialize_filterrific)
-* [x] Lock Gemfile to correct version of Rails
-* [x] Add Rails major version check to filterrific.rb
-* [ ] In ParamSet#condition_filterrific_params: Why are we type casting integers?
-* [ ] add check that no filter_name conflicts with existing methods on included ActiveRecord class (See https://github.com/jhund/filterrific/issues/17)
-* [x] I think this is done: fix reset url, make controller method, helper method
+* add check that no filter_name conflicts with existing methods on included ActiveRecord class (See https://github.com/jhund/filterrific/issues/17)
 
 ## Travis
 
@@ -30,7 +25,6 @@ Ruby 1.8.7
 Ruby 1.9.3
 Ruby 2.0
 Ruby 2.1
-Ruby 2.2    No         No         No         No
 
 Each combination is also tested for postgres and mysql
 

data/lib/filterrific/action_controller_extension.rb

@@ -10,8 +10,9 @@ module Filterrific
   protected
 
     # @param model_class [Class]
-    # @param filterrific_params [Hash] typically the Rails request params under
-    #    the :filterrific key (params[:filterrific]), however can be any Hash.
+    # @param filterrific_params [ActionController::Params, Hash] typically the
+    #    Rails request params under the :filterrific key (params[:filterrific]),
+    #    however can be any Hash.
     # @param opts [Hash, optional]
     # @option opts [Array<String>, optional] :available_filters
     #   further restrict which of the filters specified in the model are
@@ -27,8 +28,8 @@ module Filterrific
     #   dynamic values.
     # @return [Filterrific::ParamSet]
     def initialize_filterrific(model_class, filterrific_params, opts = {})
-      f_params = (filterrific_params || {}).deep_stringify_keys
-      opts = opts.deep_stringify_keys
+      f_params = (filterrific_params || {}).stringify_keys
+      opts = opts.stringify_keys
       pers_id = if false == opts['persistence_id']
         nil
       else
@@ -57,7 +58,7 @@ module Filterrific
     # Computes filterrific params using a number of strategies. Limits params
     # to 'available_filters' if given via opts.
     # @param model_class [ActiveRecord::Base]
-    # @param filterrific_params [Hash]
+    # @param filterrific_params [ActionController::Params, Hash]
     # @param opts [Hash]
     # @param persistence_id [String, nil]
     def compute_filterrific_params(model_class, filterrific_params, opts, persistence_id)
@@ -66,7 +67,7 @@ module Filterrific
         (persistence_id && session[persistence_id].presence) || # then try session persisted params if persistence_id is present
         opts['default_filter_params'] || # then use passed in opts
         model_class.filterrific_default_filter_params # finally use model_class defaults
-      ).deep_stringify_keys
+      ).stringify_keys
       r.slice!(*opts['available_filters'].map(&:to_s))  if opts['available_filters']
       r
     end

data/lib/filterrific/active_record_extension.rb

@@ -98,7 +98,7 @@ module Filterrific
     def assign_filterrific_default_filter_params(opts)
       self.filterrific_default_filter_params = (
         opts['default_filter_params'] || {}
-      ).deep_stringify_keys
+      ).stringify_keys
     end
 
     def validate_filterrific_default_filter_params

data/lib/filterrific/version.rb

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
 
 module Filterrific
-  VERSION = "5.0.0"
+  VERSION = "5.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: filterrific
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - Jo Hund
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-30 00:00:00.000000000 Z
+date: 2018-01-03 00:00:00.000000000 Z
 dependencies: []
 description: Filterrific is a Rails Engine plugin that makes it easy to filter, search,
   and sort your ActiveRecord lists.
@@ -37,11 +37,9 @@ files:
 - lib/filterrific/action_view_extension.rb
 - lib/filterrific/active_record_extension.rb
 - lib/filterrific/engine.rb
-- lib/filterrific/engine_api.rb
 - lib/filterrific/has_reset_filterrific_url_mixin.rb
 - lib/filterrific/param_set.rb
 - lib/filterrific/version.rb
-- lib/filterrific_api.rb
 - spec/filterrific/action_controller_extension_spec.rb
 - spec/filterrific/action_view_extension_spec.rb
 - spec/filterrific/active_record_extension_spec.rb

data/lib/filterrific/engine_api.rb

@@ -1,26 +0,0 @@
-# -*- coding: utf-8 -*-
-
-require 'filterrific/param_set'
-
-require 'filterrific/action_controller_extension'
-require 'filterrific/active_record_extension'
-
-module Filterrific
-  class EngineApi < ::Rails::Engine
-
-TODO: Since this is API only, I don't think we need an engine!
-    # It's an engine so that we can add javascript and image assets
-    # to the asset pipeline.
-
-    isolate_namespace Filterrific
-
-    ActiveSupport.on_load :action_controller do
-      include Filterrific::ActionControllerExtension
-    end
-
-    ActiveSupport.on_load :active_record do
-      extend Filterrific::ActiveRecordExtension
-    end
-
-  end
-end

data/lib/filterrific_api.rb

@@ -1,7 +0,0 @@
-# -*- coding: utf-8 -*-
-
-require 'filterrific/version'
-require 'filterrific/engine_api'
-
-module Filterrific
-end