filterable-by 0.6.2 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a92cb2cde41910a93ed81348238f61031c3e5c8071ab2b118bfceb25307a8c14
-  data.tar.gz: 231b7712b1fe257b34ab63d8a3dc362304c45318984c3eb1a2c8cf004ef2ee44
+  metadata.gz: d541006f941920a96920cf443f67353e4c410e1c4d8acb2364902a271e2dfec3
+  data.tar.gz: 3a9e964d67aaca1a133c61c3aee729c8c71a2e918f00dcecac9f86eec2c68430
 SHA512:
-  metadata.gz: 8ca4f69341eaa58f296280b703398c5ce6ad1dcd6551758322c36a03db7f2b9af7e37defeb96c205a5a1520f40e154d4ebd2f5c6110591ccb1505f55f99ac870
-  data.tar.gz: 10691ed7dc8e33b7c6920e8a8e6e670b854bc51d6155baa0923d0cfe363ec2fb8824ed79f3cc635cc9b68f824e3c1951ea32cda8e320e0f40b5ad12fbfa37c2f
+  metadata.gz: 99d8c2a9440c69950cf5175f713180fffd5f8e801e9ce52568cf3ae908fe18fb0c0f2dfa11a9e4a095351b9a5e70df8c54ed305ec175400f550a3f4d9277d82a
+  data.tar.gz: 06ba1b5090fb7425259764e550c8b5d26c82f0f67c8e54205ac3281f1e47ad070c8a89a398e55cd9406eba6c83a47d892b2480d8a47c66d77b345657a067607e

data/.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ["2.7", "3.0", "3.1"]
+        ruby-version: ["2.7", "3.0", "3.1", "3.2"]
         gemfiles: ["Gemfile", "Gemfile.rails6"]
     env:
       BUNDLE_GEMFILE: ${{ matrix.gemfile }}

data/Gemfile

@@ -1,2 +1,7 @@
 source 'http://rubygems.org'
 gemspec
+
+gem 'rake'
+gem 'rspec'
+gem 'rubocop-bsm'
+gem 'sqlite3'

data/Gemfile.lock

@@ -1,77 +1,84 @@
 PATH
   remote: .
   specs:
-    filterable-by (0.6.2)
+    filterable-by (0.6.4)
       activerecord
       activesupport
 
 GEM
   remote: http://rubygems.org/
   specs:
-    activemodel (7.0.2.3)
-      activesupport (= 7.0.2.3)
-    activerecord (7.0.2.3)
-      activemodel (= 7.0.2.3)
-      activesupport (= 7.0.2.3)
-    activesupport (7.0.2.3)
+    activemodel (7.0.4.2)
+      activesupport (= 7.0.4.2)
+    activerecord (7.0.4.2)
+      activemodel (= 7.0.4.2)
+      activesupport (= 7.0.4.2)
+    activesupport (7.0.4.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     ast (2.4.2)
-    concurrent-ruby (1.1.10)
+    concurrent-ruby (1.2.0)
     diff-lcs (1.5.0)
-    i18n (1.10.0)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    minitest (5.15.0)
+    json (2.6.3)
+    mini_portile2 (2.8.1)
+    minitest (5.17.0)
     parallel (1.22.1)
-    parser (3.1.1.0)
+    parser (3.2.0.0)
       ast (~> 2.4.1)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.2.1)
+    regexp_parser (2.6.2)
     rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.0)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.26.1)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.0)
+    rubocop (1.44.1)
+      json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.2.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.16.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.24.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.16.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.24.1)
       parser (>= 3.1.1.0)
-    rubocop-bsm (0.6.0)
+    rubocop-bsm (0.6.1)
       rubocop (~> 1.0)
       rubocop-performance
       rubocop-rake
       rubocop-rspec
-    rubocop-performance (1.13.3)
+    rubocop-capybara (2.17.0)
+      rubocop (~> 1.41)
+    rubocop-performance (1.15.2)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.9.0)
-      rubocop (~> 1.19)
+    rubocop-rspec (2.18.1)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
     ruby-progressbar (1.11.0)
-    sqlite3 (1.4.2)
-    tzinfo (2.0.4)
+    sqlite3 (1.6.0)
+      mini_portile2 (~> 2.8.0)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.1.0)
+    unicode-display_width (2.4.2)
 
 PLATFORMS
   ruby
@@ -85,4 +92,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.3.6
+   2.3.9

data/Gemfile.rails6

@@ -2,3 +2,7 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'activerecord', '~> 6.1'
+gem 'rake'
+gem 'rspec'
+gem 'rubocop-bsm'
+gem 'sqlite3'

data/Gemfile.rails6.lock

@@ -1,79 +1,84 @@
 PATH
   remote: .
   specs:
-    filterable-by (0.6.1)
+    filterable-by (0.6.4)
       activerecord
       activesupport
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.1.4.7)
-      activesupport (= 6.1.4.7)
-    activerecord (6.1.4.7)
-      activemodel (= 6.1.4.7)
-      activesupport (= 6.1.4.7)
-    activesupport (6.1.4.7)
+    activemodel (6.1.7.2)
+      activesupport (= 6.1.7.2)
+    activerecord (6.1.7.2)
+      activemodel (= 6.1.7.2)
+      activesupport (= 6.1.7.2)
+    activesupport (6.1.7.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
     ast (2.4.2)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.2.0)
     diff-lcs (1.5.0)
-    i18n (1.10.0)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    minitest (5.15.0)
-    parallel (1.21.0)
-    parser (3.1.1.0)
+    json (2.6.3)
+    minitest (5.17.0)
+    parallel (1.22.1)
+    parser (3.2.0.0)
       ast (~> 2.4.1)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.2.1)
+    regexp_parser (2.6.2)
     rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.0)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.0)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
-    rubocop (1.26.0)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.0)
+    rubocop (1.44.1)
+      json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.2.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.16.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.24.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.16.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.24.1)
       parser (>= 3.1.1.0)
-    rubocop-bsm (0.6.0)
+    rubocop-bsm (0.6.1)
       rubocop (~> 1.0)
       rubocop-performance
       rubocop-rake
       rubocop-rspec
-    rubocop-performance (1.13.3)
+    rubocop-capybara (2.17.0)
+      rubocop (~> 1.41)
+    rubocop-performance (1.15.2)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.9.0)
-      rubocop (~> 1.19)
+    rubocop-rspec (2.18.1)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
     ruby-progressbar (1.11.0)
-    sqlite3 (1.4.2)
-    tzinfo (2.0.4)
+    sqlite3 (1.6.0-x86_64-linux)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.1.0)
-    zeitwerk (2.5.4)
+    unicode-display_width (2.4.2)
+    zeitwerk (2.6.6)
 
 PLATFORMS
   x86_64-linux

data/filterable-by.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'filterable-by'
-  s.version     = '0.6.2'
+  s.version     = '0.6.4'
   s.authors     = ['Dimitrij Denissenko']
   s.email       = ['dimitrij@blacksquaremedia.com']
   s.summary     = 'Generate white-listed filter scopes from URL parameter values'
@@ -9,7 +9,6 @@ Gem::Specification.new do |s|
   s.license     = 'MIT'
 
   s.files         = `git ls-files -z`.split("\x0").reject {|f| f.match(%r{^spec/}) }
-  s.test_files    = `git ls-files -z -- spec/*`.split("\x0")
   s.require_paths = ['lib']
   s.required_ruby_version = '>= 2.7'
 
@@ -17,9 +16,5 @@ Gem::Specification.new do |s|
   s.add_dependency 'activesupport'
 
   s.add_development_dependency 'bundler'
-  s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec'
-  s.add_development_dependency 'rubocop-bsm'
-  s.add_development_dependency 'sqlite3'
   s.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/filterable_by.rb

@@ -4,40 +4,56 @@ require 'set'
 
 module ActiveRecord
   module FilterableBy
-    def self.normalize(value)
-      case value
-      when String, Numeric
-        value
-      when Array
-        value.select {|v| normalize(v) }
+    class << self
+      def normalize(value)
+        case value
+        when String, Numeric
+          value
+        when Array
+          value.select {|v| normalize(v) }
+        end
       end
-    end
 
-    def self.merge(scope, unscoped, hash, name, **opts, &block)
-      key = name
-      positive = normalize(hash[key]) if hash.key?(key)
-      if positive.present?
-        sub = block.arity == 2 ? yield(unscoped, positive, **opts) : yield(positive, **opts)
-        return nil unless sub
+      def merge(scope, unscoped, hash, name, **opts, &block)
+        key = name
+        positive = normalize(hash[key]) if hash.key?(key)
+        if positive.present?
+          sub = eval_scope(scope, unscoped, positive, **opts, &block)
+          return nil unless sub
+
+          scope = scope.merge(sub)
+        end
+
+        key = "#{name}_not"
+        negative = normalize(hash[key]) if hash.key?(key)
+        if negative.present?
+          sub = eval_scope(scope, unscoped, negative, **opts, &block)
+          return nil unless sub
 
-        scope = scope.merge(sub)
+          scope = scope.merge(invert_where(sub))
+        end
+
+        scope
       end
 
-      key = "#{name}_not"
-      negative = normalize(hash[key]) if hash.key?(key)
-      if negative.present?
-        sub = block.arity == 2 ? yield(unscoped, negative, **opts) : yield(negative, **opts)
-        return nil unless sub
+      private
 
-        if sub.respond_to?(:invert_where)
-          sub = sub.invert_where
+      def eval_scope(scope, unscoped, value, **opts, &block)
+        if block.arity == 2
+          scope.instance_exec(unscoped, value, **opts, &block)
         else
-          sub.where_clause = sub.where_clause.invert
+          scope.instance_exec(value, **opts, &block)
         end
-        scope = scope.merge(sub)
       end
 
-      scope
+      def invert_where(scope)
+        if scope.respond_to?(:invert_where!)
+          scope.invert_where!
+        else
+          scope.where_clause = scope.where_clause.invert
+        end
+        scope
+      end
     end
 
     module ClassMethods
@@ -58,7 +74,7 @@ module ActiveRecord
         end
 
         names.each do |name|
-          _filterable_by_config[name.to_s] = block
+          _filterable_by_config[name.to_s] = block || ->(value, **) { where(name.to_sym => value) }
         end
       end
 
@@ -74,7 +90,6 @@ module ActiveRecord
         return scope unless hash.respond_to?(:key?) && hash.respond_to?(:[])
 
         _filterable_by_config.each do |name, block|
-          block = ->(value, **) { where(name.to_sym => value) } if block.nil?
           scope = FilterableBy.merge(scope, unscoped, hash, name, **opts, &block)
           break unless scope
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: filterable-by
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.4
 platform: ruby
 authors:
 - Dimitrij Denissenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-05 00:00:00.000000000 Z
+date: 2023-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -52,62 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-bsm
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: ActiveRecord plugin
 email:
 - dimitrij@blacksquaremedia.com
@@ -128,8 +72,6 @@ files:
 - filterable-by.gemspec
 - lib/filterable-by.rb
 - lib/filterable_by.rb
-- spec/active_record/filterable_by_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/bsm/filterable-by
 licenses:
 - MIT
@@ -154,6 +96,4 @@ rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Generate white-listed filter scopes from URL parameter values
-test_files:
-- spec/active_record/filterable_by_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/spec/active_record/filterable_by_spec.rb

@@ -1,104 +0,0 @@
-require 'spec_helper'
-
-describe ActiveRecord::FilterableBy do
-  let(:alice) { AUTHORS[:alice] }
-  let(:bob)   { AUTHORS[:bob] }
-
-  let(:apost) { POSTS[:alices] }
-  let(:bpost) { POSTS[:bobs] }
-
-  it 'has config' do
-    expect(Comment.send(:_filterable_by_config).count).to eq(5)
-    expect(Rating.send(:_filterable_by_config).count).to eq(4)
-    expect(Post.send(:_filterable_by_config).count).to eq(2)
-  end
-
-  it 'ignores bad inputs' do
-    expect(Comment.filter_by.count).to eq(4)
-    expect(Comment.filter_by(nil).count).to eq(4)
-    expect(Comment.filter_by(nil, extra: true).count).to eq(4)
-    expect(Comment.filter_by('bad').count).to eq(4)
-
-    expect(Comment.filter_by('author_id' => '').count).to eq(4)
-    expect(Comment.filter_by('author_id' => []).count).to eq(4)
-  end
-
-  it 'generates simple scopes' do
-    expect(Comment.filter_by('author_id' => alice.id).pluck(:title)).to match_array(%w[AA AB])
-    expect(Comment.filter_by('author_id' => bob.id).pluck(:title)).to match_array(%w[BA BB])
-    expect(Comment.filter_by('author_id' => [alice.id, '']).pluck(:title)).to match_array(%w[AA AB])
-
-    expect(Comment.filter_by('post_id' => apost.id).pluck(:title)).to match_array(%w[AA BA])
-    expect(Comment.filter_by('post_id' => bpost.id).pluck(:title)).to match_array(%w[AB BB])
-
-    expect(Comment.filter_by('post_author_id' => alice.id).pluck(:title)).to match_array(%w[AA BA])
-    expect(Comment.filter_by('post_author_id' => bob.id).pluck(:title)).to match_array(%w[AB BB])
-
-    expect(Rating.filter_by('author_id' => alice.id).count).to eq(0)
-    expect(Rating.filter_by('author_id' => bob.id).count).to eq(1)
-
-    expect(Post.filter_by('author_id' => bob.id).count).to eq(1)
-  end
-
-  it 'generates combined scopes' do
-    expect(Comment.filter_by('author_id' => alice.id, 'post_id' => apost.id).pluck(:title)).to match_array(['AA'])
-    expect(Comment.filter_by('author_id' => alice.id, 'post_id' => bpost.id).pluck(:title)).to match_array(['AB'])
-    expect(Comment.filter_by('author_id' => bob.id, 'post_id' => apost.id).pluck(:title)).to match_array(['BA'])
-    expect(Comment.filter_by('author_id' => bob.id, 'post_id' => bpost.id).pluck(:title)).to match_array(['BB'])
-
-    scope = Comment.filter_by('author_id' => [alice.id, bob.id], 'post_id' => bpost.id)
-    expect(scope.pluck(:title)).to match_array(%w[AB BB])
-  end
-
-  it 'generates negated scopes' do
-    expect(Comment.filter_by('author_id_not' => alice.id).pluck(:title)).to match_array(%w[BA BB])
-    expect(Comment.filter_by('author_id_not' => [alice.id, bob.id]).pluck(:title)).to match_array(%w[])
-    expect(Comment.filter_by('post_id_not' => apost.id).pluck(:title)).to match_array(%w[AB BB])
-    expect(Comment.filter_by('post_author_id_not' => alice.id).pluck(:title)).to match_array(%w[AB BB])
-    expect(Comment.filter_by('author_id' => bob.id, 'post_id_not' => bpost.id).pluck(:title)).to match_array(['BA'])
-  end
-
-  it 'combines with other scopes' do
-    scope = Comment.where(author_id: alice.id).filter_by('post_id' => apost.id)
-    expect(scope.pluck(:title)).to match_array(['AA'])
-
-    expect(alice.posts.filter_by('post_id' => apost.id).count).to be(1)
-    expect(alice.posts.filter_by('author_id' => alice.id).count).to be(1)
-    expect(alice.posts.filter_by('author_id_not' => bob.id).count).to be(1)
-    expect(alice.posts.filter_by('author_id' => bob.id).count).to be_zero
-    expect(alice.posts.filter_by('author_id_not' => alice.id).count).to be_zero
-  end
-
-  it 'allows custom options' do
-    scope = Post.filter_by({ 'only' => 'me' }, user_id: alice.id)
-    expect(scope).to match_array([apost])
-
-    scope = Post.filter_by({ 'only' => '??' }, user_id: alice.id)
-    expect(scope.count).to eq(2)
-
-    scope = Post.filter_by({ 'only' => 'me' })
-    expect(scope.count).to eq(0)
-  end
-
-  it 'allows custom options from params' do
-    filter = { 'only' => 'me' }
-    expect(Post.filter_by(filter, user_id: alice.id)).to match_array([apost])
-    expect(Post.filter_by(filter).count).to eq(0)
-  end
-
-  it 'ignores invalid scopes' do
-    expect(Comment.filter_by('invalid' => 1).count).to eq(4)
-    expect(Post.filter_by('post_id' => bpost.id).count).to eq(2)
-    expect(Rating.filter_by('post_author_id' => bob.id).count).to eq(1)
-  end
-
-  it 'supports deprecated scoping' do
-    expect(Comment.filter_by('deprecated' => alice.id).pluck(:title)).to match_array(%w[AA AB])
-    expect(Comment.filter_by('deprecated_with_opts' => alice.id).pluck(:title)).to match_array(%w[AA AB])
-    expect(Comment.filter_by('deprecated_not' => alice.id).pluck(:title)).to match_array(%w[BA BB])
-  end
-
-  it 'supports abstract classes' do
-    expect(Post.filter_by('author_id' => bob.id).count).to eq(1)
-  end
-end

data/spec/spec_helper.rb

@@ -1,87 +0,0 @@
-ENV['RACK_ENV'] ||= 'test'
-require 'filterable-by'
-require 'rspec'
-
-ActiveRecord::Base.configurations = { 'test' => { 'adapter' => 'sqlite3', 'database' => ':memory:' } }
-ActiveRecord::Base.establish_connection :test
-
-ActiveRecord::Base.connection.instance_eval do
-  create_table :authors do |_|
-    # no columns
-  end
-  create_table :posts do |t|
-    t.integer :author_id, null: false
-  end
-  create_table :feedbacks do |t|
-    t.string  :type, null: false
-    t.string  :title
-    t.integer :stars, null: false, default: 0
-    t.integer :post_id, null: false
-    t.integer :author_id, null: false
-  end
-end
-
-class Author < ActiveRecord::Base
-  has_many :posts
-end
-
-class AbstractPost < ActiveRecord::Base
-  self.abstract_class = true
-  filterable_by :author_id
-end
-
-class Post < AbstractPost
-  belongs_to :author
-
-  filterable_by :only do |value, **opts|
-    case value
-    when 'me'
-      where(author_id: opts[:user_id]) if opts[:user_id]
-    else
-      all
-    end
-  end
-end
-
-class Feedback < ActiveRecord::Base
-  belongs_to :author
-  belongs_to :post
-
-  filterable_by :post_id, :author_id
-
-  ActiveSupport::Deprecation.silence do
-    filterable_by :deprecated do |scope, value|
-      scope.where(author_id: value)
-    end
-    filterable_by :deprecated_with_opts do |scope, value, **_opts|
-      scope.where(author_id: value)
-    end
-  end
-end
-
-class Comment < Feedback
-  filterable_by :post_author_id do |value|
-    joins(:post).where(Post.arel_table[:author_id].eq(value))
-  end
-end
-
-class Rating < Feedback
-end
-
-AUTHORS = {
-  alice: Author.create!,
-  bob: Author.create!,
-}.freeze
-
-POSTS = {
-  alices: Post.create!(author_id: AUTHORS[:alice].id),
-  bobs: Post.create!(author_id: AUTHORS[:bob].id),
-}.freeze
-
-COMMENTS = {
-  alice_on_alice: Comment.create!(title: 'AA', post_id: POSTS[:alices].id, author_id: AUTHORS[:alice].id),
-  bob_on_alice: Comment.create!(title: 'BA', post_id: POSTS[:alices].id, author_id: AUTHORS[:bob].id),
-  alice_on_bob: Comment.create!(title: 'AB', post_id: POSTS[:bobs].id, author_id: AUTHORS[:alice].id),
-  bob_on_bob: Comment.create!(title: 'BB', post_id: POSTS[:bobs].id, author_id: AUTHORS[:bob].id),
-  boa_rating: Rating.create!(stars: 5, post_id: POSTS[:alices].id, author_id: AUTHORS[:bob].id),
-}.freeze