filter_decrufter 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd9c4f9c59da12771bbf12d09fadb5ce6fe282a3
-  data.tar.gz: 115f66febd38a0cefc999919eccb2ae03a2f09af
+  metadata.gz: fecce40a8c9791aef1700866251dc72175bfb7b2
+  data.tar.gz: 6980da08ea0c95878f145ef12ff2ab14e8834dd6
 SHA512:
-  metadata.gz: 25fa82579c3e2c0daf3b620b1fd1800632cc20a1108dac15bc359e7d38a0082b40dd49aa3ca8a8e068bebdbdb0de274e59005d0d1fb2620888378a8059bdf4ca
-  data.tar.gz: a469df57be33490c3dcc4ea499085a3f61b215815a6859b8954da39d38f73e7c04382360599594ee64188de23636a4bee50f55ff0105d124f2f2aab2a407a4bd
+  metadata.gz: a9bfb7bc2c13ce2cdc3156aeead413c9e63b70d1bf8486f143e81765bb0c52ba09f0735aea3cc26a79009847f720acf3ed2fcec54ea7ff5a21b239ae445e0217
+  data.tar.gz: 49d8d4df671c32e541df18b3f53b6493ad0e5a3000d7ffa92fae57b58a584cb77a2d060ebd468837e012a3d2ed2b9eaec7759609fc72e5be8f84ac26a2980f77

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.0.4 (2015-02-27)
+
+* [FIXED] Check for before|after|around_action for Rails 4.2
+
 ## 0.0.3 (2015-02-18)
 
 * [FIXED] No longer reports all violations as being for before_filters

data/README.md

@@ -21,9 +21,10 @@ Run the task!
     Api::V1::WidgetsController before_filter 'find_widget' has an :only constraint with a non-existent action name 'show'
     EmployeesController after_filter 'set_name' has an :only constraint with a non-existent action name 'frobnicate'
 
-Tested with Rails 3.2.
+Tested with Rails 3.2, 4.0, and 4.2.
 
 # Credits
 
-* Tom Copeland - author
-* John Moon - design discussions
+* [Sandeep Kumar](https://whatpeoplethink.wordpress.com/) - Rails 4.2 support
+* [Tom Copeland](http://thomasleecopeland.com) - author
+* [John Moon](http://www.thinkandgrowentrepreneur.com/) - design discussions

data/lib/filter_decrufter/checker.rb

@@ -2,11 +2,11 @@ module FilterDecrufter
 
   class Hit
 
-    attr_accessor :controller_class, :before_filter_name, :options, :filter_type
+    attr_accessor :controller_class, :filter_name, :options, :filter_type
 
-    def initialize(controller_class, before_filter_name, options, filter_type)
+    def initialize(controller_class, filter_name, options, filter_type)
       @controller_class = controller_class
-      @before_filter_name = before_filter_name
+      @filter_name = filter_name
       @options = options
       @filter_type = filter_type
     end
@@ -58,7 +58,7 @@ module FilterDecrufter
       [hit.populated_only_except_options[name]].flatten.each do |action_syms|
         [action_syms].flatten.each do |action_name|
           if !hit.actions_include?(action_name)
-            puts "#{hit.controller_class} #{hit.filter_type} '#{hit.before_filter_name}' has an :#{name} constraint with a non-existent action name '#{action_name}'"
+            puts "#{hit.controller_class} #{hit.filter_type} '#{hit.filter_name}' has an :#{name} constraint with a non-existent action name '#{action_name}'"
           end
         end
       end
@@ -74,7 +74,7 @@ module FilterDecrufter
     end
 
     def check
-      [:before_filter, :around_filter, :after_filter].each {|s| patch_method(s) }
+      filter_method_names.each {|s| patch_method(s) }
       load_all_controllers
       show_report
       nil
@@ -82,6 +82,10 @@ module FilterDecrufter
 
     private
 
+    def filter_method_names
+      [:before, :around, :after].map {|s| ["#{s}_filter", "#{s}_action"]}.flatten.sort.map(&:to_sym)
+    end
+
     def show_report
       Report.instance.find_problems
     end

data/lib/filter_decrufter/version.rb

@@ -1,3 +1,3 @@
 module FilterDecrufter
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: filter_decrufter
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-23 00:00:00.000000000 Z
+date: 2015-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake