filter8 0.9 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 720eb0a7f14ad24804b6fa997fd683814a5c0560
-  data.tar.gz: ab82cedaa9c4fdf715eb401ff312e6091f65861f
+  metadata.gz: 57685dda9e2022d2831ca7942075900e85a136c0
+  data.tar.gz: 383734db67b7cc6abe723b67e8237a5ccf6a3e35
 SHA512:
-  metadata.gz: febb61d5262767ce53f9c650d66856f7f95a5e01261a7a680a563f7425e9708b45c6723335193fb358a67c3464ef1c542591d38227b0938fc13bfe07bc7e57fd
-  data.tar.gz: ac2ac322dd474d1d943ea1f8a0f95a74615a18688d1302f15b01f0a976caeb6a0244013242f2a8836950350a6b5e1e105b098d1357245e82f57d9a64102800ef
+  metadata.gz: a494a030518a205856b76a44d5bc8ab3ac63bcf00c5d23d7709158f58cac047b59b75e8412470f0980e4c644443203c11dc097009d8653ef35ed904beab5e8c6
+  data.tar.gz: 676dae7dcdd6db734b8cafcbe03a320a1a2a7b6d3b57d4e0fd3993a901e7d81ed929cbba69f86e680e9398d823e998dc71915f1d98b5ef752f118c3156be9609

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    filter8 (0.1)
+    filter8 (0.9.2)
       faraday
 
 GEM

data/filter8.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name                      = "filter8"
-  s.version                   = "0.9"
-  s.default_executable        = "hola"
+  s.version                   = "0.9.2"
+  s.default_executable        = "filter8"
 
   s.authors                   = ["Tim Adler"]
   s.date                      = %q{2014-08-19}

data/lib/filter8/client.rb

@@ -27,7 +27,7 @@ module Filter8
 
       raise Exception.new("Filter8-API error (Status: #{response.status}): #{response.body}") if(response.status != 200)
 
-      JSON.parse response.body
+      Filter8::Result.new JSON.parse(response.body)
     end
 
     def nonce_param

data/lib/filter8/request.rb

@@ -5,11 +5,11 @@ module Filter8
     def initialize(content, options = {})
       if content.is_a? Hash
         @content = content[:content]
-        raise Exception.new("No value for 'content' given") if @content.nil?
         options = content.reject!{ |k| k == :content }
       else
         @content = content
       end
+      raise Exception.new("No value for 'content' given") if(@content.nil?||@content.empty?)
 
       options.each do |filter_name, filter_options|
         validate_filter_options(filter_name, filter_options)
@@ -27,7 +27,7 @@ module Filter8
     end
 
     def request_params
-      request_params = "content=#{self.content}"
+      request_params = "content=#{CGI.escape(self.content)}"
 
       Filter8::AVAILABLE_FILTERS.each do |filter_name|
         if self.respond_to?(filter_name) && !self.send(filter_name).nil?

data/spec/lib/filter8/client_spec.rb

@@ -39,8 +39,11 @@ describe Filter8::Client do
       client.send_request(filter8_request)
     end
 
-    it "will parse the response as JSON and return the result" do
-      expect(client.send_request(filter8_request)).to eq({ "test" => "response" })
+    it "will parse the response as JSON and return the result as a filter8-result" do
+      filter8_result = client.send_request(filter8_request)
+
+      expect(filter8_result).to be_a Filter8::Result
+      expect(filter8_result.json).to eq({ "test" => "response" })
     end
 
   end

data/spec/lib/filter8/request_spec.rb

@@ -22,6 +22,11 @@ describe Filter8::Request do
       expect{Filter8::Request.new(blacklist: "test")}.to raise_error
     end
 
+    it "will raise an error when onlyno content is given" do
+      expect{Filter8::Request.new(nil)}.to raise_error
+      expect{Filter8::Request.new("")}.to raise_error
+    end
+
     it "will allow valid filters as options" do
       request = Filter8::Request.new("fuck", blacklist: "test")
       expect(request.blacklist).to eq "test"
@@ -53,6 +58,10 @@ describe Filter8::Request do
       expect(Filter8::Request.new("fuck").request_params).to eq "content=fuck"
     end
 
+    it "escapes url-critical parameters nicely" do
+      expect(Filter8::Request.new("Leaders! Start a book club with a new release from #OrangeBooks & get a free ticket to Orange Tour 2014.").request_params).to eq "content=Leaders%21+Start+a+book+club+with+a+new+release+from+%23OrangeBooks+%26+get+a+free+ticket+to+Orange+Tour+2014."
+    end
+
     it "will return the correct parameters, when one option with a single value is given" do
       expect(Filter8::Request.new("fuck", blacklist: "test").request_params).to eq "content=fuck&blacklist=test"
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: filter8
 version: !ruby/object:Gem::Version
-  version: '0.9'
+  version: 0.9.2
 platform: ruby
 authors:
 - Tim Adler
@@ -14,70 +14,70 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 10.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 10.1.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.14.1
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: An unofficial ruby wrapper for Filter8 (http://filter8.com). An API to
@@ -87,8 +87,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
+- .gitignore
+- .rspec
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -114,12 +114,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []