filmbuff 0.1.1 → 0.1.2

data/History

@@ -1,3 +1,9 @@
+== 0.1.2 2011-03-07
+
+* minor enhancements
+  * Fixed locale support
+  * Added part about locale to README
+
 == 0.1.1 2011-03-06
 
 * minor enhancements

data/{readme.markdown → README.md}

@@ -41,9 +41,27 @@ If you know the movie's IMDb ID you can get the information as well:
     movie.rating => 8.3
     movie.genres => ["Adventure", "Comedy", "Family", "Fantasy", "Musical"]
 
+To retrieve information in a different language, set the instance variable locale to your wanted locale:
+
+    imdb.locale = "de_DE"
+    movie = imdb.find_by_id("tt0032138")
+    
+    movie.title => "Das zauberhafte Land"
+    movie.rating => 8.3
+    movie.genres => ["Abenteuer", "Komödie", "Familie", "Fantasy", "Musical"]
+
+Supported locales are
+
+- de_DE (German)
+- en_US (English) (Default)
+- es_ES (Spanish)
+- fr_FR (French)
+- it_IT (Italian)
+- pt_PT (Portuguese)
+
 ## Authors
 
-* [Kristoffer Sachse](http://github.com/sachse)
+* [Kristoffer Sachse](https://github.com/sachse)
 
 ## Contribute
 

data/lib/filmbuff/imdb.rb

@@ -1,6 +1,6 @@
 module FilmBuff
   class IMDb
-    attr_reader :locale
+    attr_accessor :locale
 
     include HTTParty
     include HTTParty::Icebox
@@ -10,7 +10,6 @@ module FilmBuff
     default_params = {
       "api" => "v1",
       "app_id" => "iphone1_1",
-      "locale" => @locale,
       "timestamp" => Time.now.utc.to_i,
       "sig" => "app1_1"
     }
@@ -20,26 +19,17 @@ module FilmBuff
     end
 
     public
-    def locale=(locale)
-      locales = %w[ de_DE en_US es_ES fr_FR it_IT pt_PT ]
-
-      if locales.include? locale
-        @locale = locale
-      else
-        raise "Unknown locale. Only the following are allowed:\n" <<
-        locales.join(", ")
-      end
-    end
-
     def find_by_id(imdb_id)
       result = self.class.get('/title/maindetails', :query => {
-        tconst: imdb_id
+        tconst: imdb_id, locale: @locale
       }).parsed_response
       Title.new(result["data"])
     end
 
     def find_by_title(title)
-      results = self.class.get('/find', :query => { q: title }).parsed_response
+      results = self.class.get('/find', :query => {
+        q: title, locale: @locale
+      }).parsed_response
       find_by_id(results["data"]["results"][0]["list"][0]["tconst"])
     end
   end

data/lib/filmbuff/version.rb

@@ -1,3 +1,3 @@
 module Filmbuff
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/filmbuff/imdb_spec.rb

@@ -12,29 +12,19 @@ describe FilmBuff::IMDb do
   end
 
   describe "#locale=" do
-    context "given valid locale" do
-      it "sets locale to the given value" do
-        @imdb.locale = "de_DE"
-        @imdb.locale.should == "de_DE"
-      end
-    end
-
-    context "given invalid locale" do
-      it "raises an exception" do
-        lambda { @imdb.locale = "da_DK" }.should raise_error StandardError
-      end
+    it "sets locale to the given value" do
+      @imdb.locale = "de_DE"
+      @imdb.locale.should == "de_DE"
     end
   end
 
   describe "#find_by_id" do
-    context "given valid ID" do
-      before(:all) do
-        @title = @imdb.find_by_id("tt0032138")
-      end
+    before(:all) do
+      @title = @imdb.find_by_id("tt0032138")
+    end
 
-      it "returns a Title" do
-        @title.instance_of?(FilmBuff::Title).should be_true
-      end
+    it "returns a Title" do
+      @title.instance_of?(FilmBuff::Title).should be_true
     end
   end
 

data/spec/filmbuff/title_spec.rb

@@ -1,51 +1,115 @@
+# -*- encoding: utf-8 -*-
 require File.expand_path(File.join(File.dirname(__FILE__), '../spec_helper'))
 
 describe FilmBuff::Title do
-  before(:all) do
-    @imdb = FilmBuff::IMDb.new
-    @title = @imdb.find_by_id("tt0032138")
-  end
+  context "given no locale" do
+    before(:all) do
+      @imdb = FilmBuff::IMDb.new
+      @title = @imdb.find_by_id("tt0032138")
+    end
 
-  it "has an IMDb ID" do
-    @title.imdb_id.should == "tt0032138"
-  end
+    it "has an IMDb ID" do
+      @title.imdb_id.should == "tt0032138"
+    end
 
-  it "has a title" do
-    @title.title.should == "The Wizard of Oz"
-  end
+    it "has a title" do
+      @title.title.should == "The Wizard of Oz"
+    end
 
-  it "has a tagline" do
-    @title.tagline.should == "\"The Wizard\" Musical Returns By " <<
-    "Unprecedented Demand! [UK re-release]"
-  end
+    it "has a tagline" do
+      @title.tagline.should == "\"The Wizard\" Musical Returns By " <<
+      "Unprecedented Demand! [UK re-release]"
+    end
 
-  it "has a plot" do
-    @title.plot.should == "Dorothy Gale is swept away to a magical land in " <<
-    "a tornado and embarks on a quest to see the Wizard who can help her " <<
-    "return home."
-  end
+    it "has a plot" do
+      @title.plot.should == "Dorothy Gale is swept away to a magical land in " <<
+      "a tornado and embarks on a quest to see the Wizard who can help her " <<
+      "return home."
+    end
 
-  it "has a runtime" do
-    @title.runtime.should == "101 min"
-  end
+    it "has a runtime" do
+      @title.runtime.should == "101 min"
+    end
 
-  it "has a rating" do
-    @title.rating.should be_a(Float)
-  end
+    it "has a rating" do
+      @title.rating.should be_a(Float)
+    end
 
-  it "has an amount of votes" do
-    @title.votes.should be_a(Integer)
-  end
+    it "has an amount of votes" do
+      @title.votes.should be_a(Integer)
+    end
 
-  it "has a poster URL" do
-    @title.poster_url.should match /http:\/\/ia.media-imdb.com\/images\/.*/
-  end
+    it "has a poster URL" do
+      @title.poster_url.should match /http:\/\/ia.media-imdb.com\/images\/.*/
+    end
+
+    it "has genres" do
+      @title.genres.should == %w[ Adventure Comedy Family Fantasy Musical]
+    end
 
-  it "has genres" do
-    @title.genres.should == %w[ Adventure Comedy Family Fantasy Musical]
+    it "has a release date" do
+      @title.release_date.should == DateTime.parse("1939-08-25")
+    end
   end
 
-  it "has a release date" do
-    @title.release_date.should == DateTime.parse("1939-08-25")
+  context "given locale" do
+    before(:all) do
+      @imdb = FilmBuff::IMDb.new
+    end
+
+    context "\"de_DE\"" do
+      before(:all) do
+        @imdb.locale = "de_DE"
+        @title = @imdb.find_by_id("tt0032138")
+      end
+
+      it "returns German information" do
+        @title.title.should == "Das zauberhafte Land"
+      end
+    end
+
+    context "\"es_ES\"" do
+      before(:all) do
+        @imdb.locale = "es_ES"
+        @title = @imdb.find_by_id("tt0032138")
+      end
+
+      it "returns Spanish information" do
+        @title.title.should == "El mago de Oz"
+      end
+    end
+
+    context "\"fr_FR\"" do
+      before(:all) do
+        @imdb.locale = "fr_FR"
+        @title = @imdb.find_by_id("tt0032138")
+      end
+
+      it "returns French information" do
+        @title.title.should == "Le magicien d'Oz"
+      end
+    end
+
+    context "\"it_IT\"" do
+      before(:all) do
+        @imdb.locale = "it_IT"
+        @title = @imdb.find_by_id("tt0032138")
+      end
+
+      it "returns Italian information" do
+        @title.title.should == "Il mago di Oz"
+      end
+    end
+
+    context "\"pt_PT\"" do
+      before(:all) do
+        @imdb.locale = "pt_PT"
+        @title = @imdb.find_by_id("tt0032138")
+      end
+
+      it "returns Spanish information" do
+        @title.title.should == "O Feiticeiro de Oz"
+      end
+    end
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: filmbuff
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Kristoffer Sachse
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-06 00:00:00 +01:00
+date: 2011-03-07 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -49,6 +49,7 @@ files:
 - Gemfile
 - History
 - LICENSE
+- README.md
 - Rakefile
 - filmbuff.gemspec
 - lib/filmbuff.rb
@@ -56,7 +57,6 @@ files:
 - lib/filmbuff/imdb.rb
 - lib/filmbuff/title.rb
 - lib/filmbuff/version.rb
-- readme.markdown
 - spec/filmbuff/imdb_spec.rb
 - spec/filmbuff/title_spec.rb
 - spec/filmbuff_spec.rb