filmaffinity 0.3.1 → 1.0.0

data/lib/filmaffinity.rb

@@ -1,15 +1,15 @@
-require "open-uri"
-require "nokogiri"
-
-require_relative "constants/constants"
-require_relative "filmaffinity/configuration"
-require_relative "filmaffinity/poster-manager"
-require_relative "filmaffinity/json-movies-parser"
-require_relative "filmaffinity/json-movie-parser"
-require_relative "filmaffinity/movie"
-require_relative "filmaffinity/search"
-require_relative "filmaffinity/top"
+require 'open-uri'
+require 'nokogiri'
 
+require_relative 'constants/constants'
+require_relative 'filmaffinity/configuration'
+require_relative 'filmaffinity/poster-manager'
+require_relative 'filmaffinity/json-movies-parser'
+require_relative 'filmaffinity/json-movie-parser'
+require_relative 'filmaffinity/movie'
+require_relative 'filmaffinity/search'
+require_relative 'filmaffinity/top'
+# Module FilmAffinity
 module FilmAffinity
   class << self
     attr_accessor :configuration

data/lib/filmaffinity/configuration.rb

@@ -4,6 +4,6 @@ class Configuration
 
   def initialize
     @imgur_id = nil
-    @language = "EN"
+    @language = 'EN'
   end
 end

data/lib/filmaffinity/json-movie-parser.rb

@@ -1,17 +1,17 @@
-require "json"
+require 'json'
 
 class JsonMovieParser
   def to_hash(movie)
     {
-      "title" => movie.title,
-      "rating" => movie.rating,
-      "director" => movie.director,
-      "year" => movie.year,
-      "duration" => movie.duration,
-      "country" => movie.country,
-      "script" => movie.script,
-      "cast" => movie.cast,
-      "sinopsis" => movie.sinopsis
+      'title' => movie.title,
+      'rating' => movie.rating,
+      'director' => movie.director,
+      'year' => movie.year,
+      'duration' => movie.duration,
+      'country' => movie.country,
+      'script' => movie.script,
+      'cast' => movie.cast,
+      'sinopsis' => movie.sinopsis
     }
   end
 

data/lib/filmaffinity/json-movies-parser.rb

@@ -3,8 +3,8 @@ class JsonMoviesParser
     hashes = []
     movies.each do |movie|
       hash = {
-        "id" => movie.id,
-        "title" => movie.title
+        'id' => movie.id,
+        'title' => movie.title
       }
       hashes << hash
     end

data/lib/filmaffinity/movie.rb

@@ -17,79 +17,109 @@ module FilmAffinity
     end
 
     def title
-      @title ||= document_html.at(Constants.tag(:title)).content.strip rescue nil
+      @title ||= document_html.at(Constants.tag(:title)).content.strip
+    rescue
+      nil
     end
 
     def year
-      document_html.at(Constants.tag(:year)).content[/\d+/].to_i rescue nil
+      document_html.at(Constants.tag(:year)).content[/\d+/].to_i
+    rescue
+      nil
     end
 
     def duration
-      document_html.at(Constants.tag(:duration)).content[/\d+/].to_i rescue nil
+      document_html.at(Constants.tag(:duration)).content[/\d+/].to_i
+    rescue
+      nil
     end
 
     def country
-      raw_country = document_html.at(Constants.tag(:country)).next_sibling.content rescue nil
+      raw_country = document_html.at(Constants.tag(:country)).next_sibling.content
       raw_country.gsub(/\A[[:space:]]+|[[:space:]]+\z/, '') if raw_country
+    rescue
+      nil
     end
 
     def director
-      raw_director = document_html.at(Constants.tag(:director)).content rescue nil
+      raw_director = document_html.at(Constants.tag(:director)).content
       raw_director.strip if raw_director
+    rescue
+      nil
     end
 
     def music
-      document_html.at(Constants.tag(:music)).next_sibling.next_sibling.content rescue nil
+      document_html.at(Constants.tag(:music)).next_sibling.next_sibling.content
+    rescue
+      nil
     end
 
     def company
-      document_html.at(Constants.tag(:company)).next_sibling.next_sibling.content rescue nil
+      document_html.at(Constants.tag(:company)).next_sibling.next_sibling.content
+    rescue
+      nil
     end
 
     def script
-      document_html.at(Constants.tag(:script)).next_sibling.next_sibling.content rescue nil
+      document_html.at(Constants.tag(:script)).next_sibling.next_sibling.content
+    rescue
+      nil
     end
 
     def photography
-      document_html.at(Constants.tag(:photography)).next_sibling.next_sibling.content rescue nil
+      document_html.at(Constants.tag(:photography)).next_sibling.next_sibling.content
+    rescue
+      nil
     end
 
     def cast
       actors = []
-      node = document_html.search(Constants.tag(:cast)) rescue []
+      node = document_html.search(Constants.tag(:cast))
       node.each do |actor|
         actors << actor.at(Constants.tag(:cast_each)).content.strip
       end
       actors
+    rescue
+      []
     end
 
     def genres
       genres = []
-      node = document_html.at(Constants.tag(:genre)).next_sibling.next_sibling rescue []
-      raw_genres = node.search("a")
+      node = document_html.at(Constants.tag(:genre)).next_sibling.next_sibling
+      raw_genres = node.search('a')
       raw_genres.each do |raw_genre|
         genres << raw_genre.content.strip
       end
       genres
+    rescue
+      []
     end
 
     def sinopsis
-      document_html.at(Constants.tag(:sinopsis)).content rescue nil
+      document_html.at(Constants.tag(:sinopsis)).content
+    rescue
+      nil
     end
 
     def rating
-      raw_rating = document_html.at(Constants.tag(:rating)).content.strip rescue nil
-      raw_rating.tr(",", ".").to_f if raw_rating
+      raw_rating = document_html.at(Constants.tag(:rating)).content.strip
+      raw_rating.tr(',', '.').to_f if raw_rating
+    rescue
+      nil
     end
 
     def poster
-      poster_url = document_html.at(Constants.tag(:poster))["src"] rescue nil
+      poster_url = document_html.at(Constants.tag(:poster))['src']
       @poster_manager.load_poster(poster_url) if poster_url
+    rescue
+      nil
     end
 
     def poster_big
-      poster_url = document_html.at(Constants.tag(:poster_big))["href"] rescue nil
+      poster_url = document_html.at(Constants.tag(:poster_big))['href']
       @poster_manager.load_poster(poster_url) if poster_url
+    rescue
+      nil
     end
 
     def to_json

data/lib/filmaffinity/poster-manager.rb

@@ -1,5 +1,5 @@
-require "open-uri"
-require "imgur"
+require 'open-uri'
+require 'imgur'
 
 class PosterManager
   def load_poster(posterurl)
@@ -9,7 +9,7 @@ class PosterManager
 
   def upload(posterurl, api_id)
     imgur = Imgur.new(api_id)
-    @dir = __dir__ + "/" + construct_name + ".jpg"
+    @dir = __dir__ + '/' + construct_name + '.jpg'
     save_img_locally(posterurl)
     local_image = Imgur::LocalImage.new(@dir)
     uploaded = imgur.upload(local_image)
@@ -19,7 +19,7 @@ class PosterManager
 
   def save_img_locally(posterurl)
     open(posterurl) do |f|
-      File.open(@dir, "wb") do |file|
+      File.open(@dir, 'wb') do |file|
         file.puts f.read
       end
     end

data/lib/filmaffinity/search.rb

@@ -1,6 +1,7 @@
-require "cgi"
+require 'cgi'
 
 module FilmAffinity
+  # Class Search
   class Search
     def initialize(query)
       @query = query
@@ -12,7 +13,7 @@ module FilmAffinity
     end
 
     def exact_match?
-      !document_html.at(".z-movie").nil?
+      !document_html.at('.z-movie').nil?
     end
 
     def document_html
@@ -31,9 +32,9 @@ module FilmAffinity
 
     def parse_movies
       movies = []
-      document_html.search(".movie-card.movie-card-1").each do |movie_card|
-        id = movie_card["data-movie-id"].to_i
-        title = movie_card.search(".mc-title a").first.content.strip
+      document_html.search('.movie-card.movie-card-1').each do |movie_card|
+        id = movie_card['data-movie-id'].to_i
+        title = movie_card.search('.mc-title a').first.content.strip
         movie = FilmAffinity::Movie.new id, title
         movies << movie
       end

data/lib/filmaffinity/top.rb

@@ -1,4 +1,5 @@
 module FilmAffinity
+  # Class Top
   class Top
     def initialize(options: {}, limit: 30)
       @options = options
@@ -15,7 +16,7 @@ module FilmAffinity
     end
 
     def generate_html(from)
-      params = {'from' => from}
+      params = { 'from' => from }
       url = URI.parse(Constants.urls[:top] % query_options)
       data = Net::HTTP.post_form(url, params)
       data.body
@@ -23,11 +24,11 @@ module FilmAffinity
 
     def query_options
       query_options = ''
-      query_options += "?"
+      query_options += '?'
       @options.each do |key, value|
         query_options += Constants.query_params[key] % value
       end
-      query_options.gsub(/\&$/, "")
+      query_options.gsub(/\&$/, '')
     end
 
     def movies_with_limit
@@ -46,9 +47,9 @@ module FilmAffinity
 
     def parse_movies(document_html)
       movies = []
-      document_html.search(".movie-card.movie-card-1").each_with_index do |movie_card, _index|
-        id = movie_card["data-movie-id"].to_i
-        title = movie_card.search(".mc-title a").first.content.strip
+      document_html.search('.movie-card.movie-card-1').each_with_index do |movie_card, _index|
+        id = movie_card['data-movie-id'].to_i
+        title = movie_card.search('.mc-title a').first.content.strip
         movie = FilmAffinity::Movie.new id, title
         movies << movie
       end

data/spec/filmaffinity/json-movie-parser_spec.rb

@@ -1,11 +1,12 @@
-require_relative "../spec_helper"
+require_relative '../spec_helper'
 
-describe "JsonMovieParser" do
-  describe "#to_hash" do
+describe 'JsonMovieParser' do
+  describe '#to_hash' do
     subject { JsonMovieParser.new }
-    it "return the right director for the given movie" do
-      hash = subject.to_hash FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)")
-      expect(hash["director"]).to eq("Peter Weir")
+    it 'return the right director for the given movie' do
+      movie = FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      hash = subject.to_hash movie
+      expect(hash['director']).to eq('Peter Weir')
     end
   end
 end

data/spec/filmaffinity/matchers/include-movie.rb

@@ -1,4 +1,4 @@
-require "rspec/expectations"
+require 'rspec/expectations'
 
 RSpec::Matchers.define :include_movie do |expected|
   match do |movies|

data/spec/filmaffinity/movie_spec.rb

@@ -1,242 +1,278 @@
-require_relative "../spec_helper"
+require_relative '../spec_helper'
 
-describe "FilmAffinity::Movie" do
-  context "english version" do
-    describe "#title" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889) }
-      it "should return an valid title when initializes with no title" do
-        expect(movie.title).to eq("The Truman Show")
+describe 'FilmAffinity::Movie' do
+  context 'english version' do
+    describe '#title' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889)
+      end
+      it 'should return an valid title when initializes with no title' do
+        expect(movie.title).to eq('The Truman Show')
       end
     end
 
-    describe "#rating" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Float" do
+    describe '#rating' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Float' do
         expect(movie.rating).to be_a(Float)
       end
     end
 
-    describe "#year" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Fixnum" do
+    describe '#year' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Fixnum' do
         expect(movie.year).to be_an(Fixnum)
       end
-      it "should return 1998" do
+      it 'should return 1998' do
         expect(movie.year).to eq(1998)
       end
     end
 
-    describe "#duration" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Fixnum" do
+    describe '#duration' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Fixnum' do
         expect(movie.duration).to be_a(Fixnum)
       end
-      it "should return 103" do
+      it 'should return 103' do
         expect(movie.duration).to eq(103)
       end
     end
 
-    describe "#country" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#country' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.country).to be_a(String)
       end
-      it "should return 'United States'" do
-        expect(movie.country).to eq("United States")
+      it 'should return "United States"' do
+        expect(movie.country).to eq('United States')
       end
     end
 
-    describe "#director" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#director' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.director).to be_a(String)
       end
-      it "should return 'Peter Weir'" do
-        expect(movie.director).to eq("Peter Weir")
+      it 'should return "Peter Weir"' do
+        expect(movie.director).to eq('Peter Weir')
       end
     end
 
-    describe "#script" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#script' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.script).to be_a(String)
       end
-      it "should return 'Andrew Niccol'" do
-        expect(movie.script).to eq("Andrew Niccol")
+      it 'should return "Andrew Niccol"' do
+        expect(movie.script).to eq('Andrew Niccol')
       end
     end
 
-    describe "#cast" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Array" do
+    describe '#cast' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Array' do
         expect(movie.cast).to be_an(Array)
       end
-      it "should to include the passed cast" do
+      it 'should to include the passed cast' do
         expected_cast = [
-          "Jim Carrey",
-          "Laura Linney",
-          "Noah Emmerich",
-          "Ed Harris"
+          'Jim Carrey',
+          'Laura Linney',
+          'Noah Emmerich',
+          'Ed Harris'
         ]
         expect(movie.cast).to include(*expected_cast)
       end
     end
 
-    describe "#company" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#company' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.company).to be_a(String)
       end
-      it "should return 'Paramount Pictures / Scott Rudin Productions'" do
-        expect(movie.company).to eq("Paramount Pictures / Scott Rudin Productions")
+      it 'should return "Paramount Pictures / Scott Rudin Productions"' do
+        expect(movie.company).to eq('Paramount Pictures / Scott Rudin Productions')
       end
     end
 
-    describe "#genres" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Array" do
+    describe '#genres' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Array' do
         expect(movie.genres).to be_an(Array)
       end
-      it "should to include the passed genres" do
-        expected_genres = [
-          "Drama",
-          "Comedy",
-          "Satire"
-        ]
+      it 'should to include the passed genres' do
+        expected_genres = %w(Drama Comedy Satire)
         expect(movie.genres).to include(*expected_genres)
       end
     end
 
-    describe "#poster" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#poster' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.poster).to be_a(String)
       end
-      it "should return a .jpg address" do
-        expect(movie.poster).to include(".jpg")
+      it 'should return a .jpg address' do
+        expect(movie.poster).to include('.jpg')
       end
     end
   end
 
-  context "spanish version" do
+  context 'spanish version' do
     before :all do
       FilmAffinity.configure do |config|
-        config.language = "ES"
+        config.language = 'ES'
       end
     end
 
-    describe "#title" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889) }
-      it "should return an valid title when initializes with no title" do
-        expect(movie.title).to eq("El show de Truman (Una vida en directo)")
+    describe '#title' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889)
+      end
+      it 'should return an valid title when initializes with no title' do
+        expect(movie.title).to eq('El show de Truman (Una vida en directo)')
       end
     end
 
-    describe "#rating" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Float" do
+    describe '#rating' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Float' do
         expect(movie.rating).to be_a(Float)
       end
     end
 
-    describe "#year" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Fixnum" do
+    describe '#year' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Fixnum' do
         expect(movie.year).to be_an(Fixnum)
       end
-      it "should return 1998" do
+      it 'should return 1998' do
         expect(movie.year).to eq(1998)
       end
     end
 
-    describe "#duration" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Fixnum" do
+    describe '#duration' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Fixnum' do
         expect(movie.duration).to be_a(Fixnum)
       end
-      it "should return 103" do
+      it 'should return 103' do
         expect(movie.duration).to eq(103)
       end
     end
 
-    describe "#country" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#country' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.country).to be_a(String)
       end
-      it "should return 'Estados Unidos'" do
-        expect(movie.country).to eq("Estados Unidos")
+      it 'should return "Estados Unidos"' do
+        expect(movie.country).to eq('Estados Unidos')
       end
     end
 
-    describe "#director" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#director' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.director).to be_a(String)
       end
-      it "should return 'Peter Weir'" do
-        expect(movie.director).to eq("Peter Weir")
+      it 'should return "Peter Weir"' do
+        expect(movie.director).to eq('Peter Weir')
       end
     end
 
-    describe "#script" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#script' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.script).to be_a(String)
       end
-      it "should return 'Andrew Niccol'" do
-        expect(movie.script).to eq("Andrew Niccol")
+      it 'should return "Andrew Niccol"' do
+        expect(movie.script).to eq('Andrew Niccol')
       end
     end
 
-    describe "#cast" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Array" do
+    describe '#cast' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Array' do
         expect(movie.cast).to be_an(Array)
       end
-      it "should to include the passed cast" do
+      it 'should to include the passed cast' do
         expected_cast = [
-          "Jim Carrey",
-          "Laura Linney",
-          "Noah Emmerich",
-          "Ed Harris"
+          'Jim Carrey',
+          'Laura Linney',
+          'Noah Emmerich',
+          'Ed Harris'
         ]
         expect(movie.cast).to include(*expected_cast)
       end
     end
 
-    describe "#company" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#company' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.company).to be_a(String)
       end
-      it "should return 'Paramount Pictures / Scott Rudin Productions'" do
-        expect(movie.company).to eq("Paramount Pictures / Scott Rudin Productions")
+      it 'should return "Paramount Pictures / Scott Rudin Productions"' do
+        expect(movie.company).to eq('Paramount Pictures / Scott Rudin Productions')
       end
     end
 
-    describe "#genres" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return an Array" do
+    describe '#genres' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return an Array' do
         expect(movie.genres).to be_an(Array)
       end
-      it "should to include the passed genres" do
-        expected_genres = [
-          "Drama",
-          "Comedia",
-          "Sátira"
-        ]
+      it 'should to include the passed genres' do
+        expected_genres = %w(Drama Comedia Sátira)
         expect(movie.genres).to include(*expected_genres)
       end
     end
 
-    describe "#poster" do
-      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
-      it "should return a String" do
+    describe '#poster' do
+      subject(:movie) do
+        FilmAffinity::Movie.new(504_889, 'El show de Truman (Una vida en directo)')
+      end
+      it 'should return a String' do
         expect(movie.poster).to be_a(String)
       end
-      it "should return a .jpg address" do
-        expect(movie.poster).to include(".jpg")
+      it 'should return a .jpg address' do
+        expect(movie.poster).to include('.jpg')
       end
     end
   end