filmaffinity 0.2.4 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2b29b693cc94f96db2f05370d4a03c0c8b3938d8
-  data.tar.gz: af3023f07dbabf1b2372fd53401c8143e56b8b11
+  metadata.gz: 52aaf0ced3b0eb4e2eec8f40a956a9491045e073
+  data.tar.gz: 11d38853476bce00f143ac5e3213970029dd34ec
 SHA512:
-  metadata.gz: 12916f6d182bca700f638dbd0b4116560978d0ea927136ce7466d320b817a71776945581ed2907fc34845329716cb81cf990819ee013b6c109aea1510e2e2282
-  data.tar.gz: 070b296f0ae33872d7f5696ddac89a73193cacbf9caca8286efe35794f1277f2cd6f17a8b3363e924e1fb97fb652833d9ded80dea5e3485a178d153dd9bb6b4f
+  metadata.gz: aa6e4c80f074223966f37466bcb6e315e33fb4a9c4cefef7cb8c550f15f23fadd112d8f2a7c43c3a9f11e094167272bc3d4d3dc353836d9ab11e14db358160fc
+  data.tar.gz: 41d399c3bdc3e920b78cd5314f621e2c67ba785b25face9d9e87f7e4d45ffde85fb1437fb6c3183881395cdb4c4971d7d8dc47dce471df02b643a57fa2c4919d

data/Gemfile

@@ -1,3 +1,3 @@
 source "https://rubygems.org/"
-
+gem 'pry-nav', group: [:development, :test]
 gemspec

data/Gemfile.lock

@@ -1,11 +1,27 @@
+PATH
+  remote: .
+  specs:
+    filmaffinity (0.2.4)
+      json (~> 1.8)
+      nokogiri (~> 1.6)
+
 GEM
   remote: https://rubygems.org/
   specs:
+    coderay (1.1.1)
     diff-lcs (1.2.5)
-    fakeweb (1.3.0)
+    json (1.8.3)
+    method_source (0.8.2)
     mini_portile2 (2.0.0)
     nokogiri (1.6.7.2)
       mini_portile2 (~> 2.0.0.rc2)
+    pry (0.10.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    pry-nav (0.2.4)
+      pry (>= 0.9.10, < 0.11.0)
+    rake (10.4.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
       rspec-expectations (~> 3.4.0)
@@ -19,14 +35,16 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.4.0)
     rspec-support (3.4.1)
+    slop (3.6.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  fakeweb
-  nokogiri
-  rspec
+  filmaffinity!
+  pry-nav
+  rake (~> 10.0)
+  rspec (~> 3.3)
 
 BUNDLED WITH
    1.11.2

data/README.md

@@ -1,15 +1,32 @@
-#FilmAffinity Scraper Gem
+# FilmAffinity Scraper Gem
+[![Gem Version](https://badge.fury.io/rb/filmaffinity.svg)](http://badge.fury.io/rb/filmaffinity)
 
 ## Description
 
-The filmaffinity gem allows you to easy access publicly available data from **Filmaffinity.com in spanish**.
+The filmaffinity gem allows you to easy access publicly available data from **Filmaffinity.com in english and spanish**.
+
+Also available as **REST API** at [heroku](https://filmaffinity-unofficial.herokuapp.com/).
 
 ## Features
 
 - Search movies for a title
 - Retrieve complete movie info
-- Retrieve the Top 30 of filmaffinity.com
-- Retrieve the Top with the given options
+- Retrieve the Top N of filmaffinity.com
+- Retrieve the Top N with the given options
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'filmaffinity'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install filmaffinity
 
 ## Documentation
 
@@ -129,7 +146,6 @@ The options hash could include:
 
    movie.genres, movie.country, movie.sinopsis...
 
-
 ## Contributors
 
 This gem is created and maintained by [Oriol Bellido](https://github.com/oricodes89) and [David Santos](https://github.com/davidsantosmerino)

data/filmaffinity.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |s|
   s.name        = 'filmaffinity'
-  s.version     = '0.2.4'
-  s.date        = '2016-04-05'
+  s.version     = '0.3.0'
+  s.date        = '2016-04-18'
   s.summary     = "filmaffinity"
   s.description = "Easily use Ruby or the command line to find information on Filmaffinity.com"
-  s.authors     = ["David Santos, Oriol Bellido"]
+  s.authors     = ["David Santos", "Oriol Bellido"]
   s.email       = 'dsantosmerino92@gmail.com'
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
@@ -14,6 +14,7 @@ Gem::Specification.new do |s|
   s.license       = 'MIT'
   s.add_dependency 'nokogiri', ' ~> 1.6'
   s.add_dependency 'json', ' ~> 1.8'
+  s.add_dependency 'imgur-api','~> 0'
   s.add_development_dependency 'rake', '~> 10.0'
   s.add_development_dependency 'rspec', '~> 3.3'
 end

data/lib/constants/constants.rb

@@ -1,4 +1,5 @@
 module Constants
+
   def self.query_params
     {
       :genre => "genre=%s&",
@@ -9,11 +10,92 @@ module Constants
       :no_tv => "notvse&",
     }
   end
+
   def self.urls
     {
-      :top => "http://www.filmaffinity.com/es/topgen.php%s",
-      :search_by_title => "http://www.filmaffinity.com/es/search.php?stext=%s&stype=title",
-      :movie => "http://www.filmaffinity.com/es/film%i.html"
+      :top => "http://www.filmaffinity.com/#{self.lang}/topgen.php%s",
+      :search_by_title => "http://www.filmaffinity.com/#{self.lang}/search.php?stext=%s&stype=title",
+      :movie => "http://www.filmaffinity.com/#{self.lang}/film%i.html"
     }
   end
+
+  def self.tags
+    {
+
+      :title => { :EN => '#main-title span',
+                  :ES => '#main-title span'
+      },
+
+      :year => { :EN => 'dd[itemprop="datePublished"]',
+                  :ES => 'dd[itemprop="datePublished"]'
+      },
+
+      :duration => { :EN => 'dd[itemprop="duration"]',
+                      :ES => 'dd[itemprop="duration"]'
+      },
+
+      :country => { :EN => '#country-img',
+                    :ES => '#country-img'
+      },
+
+      :director => { :EN => 'a[itemprop="url"]',
+                      :ES => 'a[itemprop="url"]'
+      },
+
+      :music => { :EN => 'dt:contains("Music")',
+                  :ES => 'dt:contains("Música")'
+      },
+
+      :company => { :EN => 'dt:contains("Producer")',
+                    :ES => 'dt:contains("Productora")'
+      },
+
+      :script => {:EN => 'dt:contains("Screenwriter")',
+                  :ES => 'dt:contains("Guión")'
+      },
+
+      :photography => { :EN => 'dt:contains("Cinematography")',
+                        :ES => 'dt:contains("Fotografía")'
+      },
+
+      :cast => { :EN => 'span[itemprop="actor"]',
+                  :ES => 'span[itemprop="actor"]'
+      },
+
+      :cast_each => { :EN => 'span[itemprop="name"]',
+                      :ES => 'span[itemprop="name"]'
+      },
+
+      :genre => { :EN => 'dt:contains("Genre")',
+                  :ES => 'dt:contains("Género")'
+      },
+
+      :sinopsis => { :EN => 'dd[itemprop="description"]',
+                      :ES => 'dd[itemprop="description"]'
+      },
+
+      :rating => { :EN => 'div[itemprop="ratingValue"]',
+                  :ES => 'div[itemprop="ratingValue"]'
+      },
+
+      :poster => { :EN => 'img[itemprop="image"]',
+                    :ES => 'img[itemprop="image"]'
+      },
+
+      :poster_big => { :EN => 'a[class="lightbox"]',
+                        :ES => 'a[class="lightbox"]'
+      }
+
+    }
+  end
+
+  def self.tag(type)
+    lang = FilmAffinity.configuration.language.to_sym
+    Constants.tags[type][lang]
+  end
+
+  def self.lang
+    FilmAffinity.configuration.language.downcase
+  end
+
 end

data/lib/filmaffinity.rb

@@ -2,8 +2,24 @@ require "open-uri"
 require "nokogiri"
 
 require_relative "constants/constants"
+require_relative "filmaffinity/configuration"
+require_relative "filmaffinity/poster-manager"
 require_relative "filmaffinity/json-movies-parser"
 require_relative "filmaffinity/json-movie-parser"
 require_relative "filmaffinity/movie"
 require_relative "filmaffinity/search"
 require_relative "filmaffinity/top"
+
+module FilmAffinity
+  class << self
+    attr_accessor :configuration
+  end
+
+  def self.configuration
+    @configuration ||= Configuration.new
+  end
+
+  def self.configure
+    yield(configuration)
+  end
+end

data/lib/filmaffinity/configuration.rb

@@ -0,0 +1,9 @@
+
+class Configuration
+  attr_accessor :imgur_id, :language
+
+  def initialize
+    @imgur_id = nil
+    @language = "EN"
+  end
+end

data/lib/filmaffinity/movie.rb

@@ -1,3 +1,4 @@
+
 module FilmAffinity
   class Movie
     attr_reader :id, :title
@@ -5,6 +6,7 @@ module FilmAffinity
       @id = id
       @title = title if title
       @json_parser = JsonMovieParser.new
+      @poster_manager = PosterManager.new
     end
 
     def document_html
@@ -16,55 +18,55 @@ module FilmAffinity
     end
 
     def title
-      @title ||= document_html.at('#main-title span').content.strip
+      @title ||= document_html.at(Constants.tag(:title)).content.strip
     end
 
     def year
-      document_html.at('dd[itemprop="datePublished"]').content[/\d+/].to_i
+      document_html.at(Constants.tag(:year)).content[/\d+/].to_i
     end
 
     def duration
-      document_html.at('dd[itemprop="duration"]').content[/\d+/].to_i
+      document_html.at(Constants.tag(:duration)).content[/\d+/].to_i
     end
 
     def country
-      raw_country = document_html.at("#country-img").next_sibling.content
+      raw_country = document_html.at(Constants.tag(:country)).next_sibling.content
       raw_country.gsub(/\A[[:space:]]+|[[:space:]]+\z/, '')
     end
 
     def director
-      raw_director = document_html.at('a[itemprop="url"]').content
+      raw_director = document_html.at(Constants.tag(:director)).content
       raw_director.strip
     end
 
-    def script
-      document_html.at('dt:contains("Guión")').next_sibling.next_sibling.content
+    def music
+      document_html.at(Constants.tag(:music)).next_sibling.next_sibling.content
     end
 
-    def music
-      document_html.at('dt:contains("Música")').next_sibling.next_sibling.content
+    def company
+      document_html.at(Constants.tag(:company)).next_sibling.next_sibling.content
+    end
+
+    def script
+      document_html.at(Constants.tag(:script)).next_sibling.next_sibling.content
     end
 
     def photography
-      document_html.at('dt:contains("Fotografía")').next_sibling.next_sibling.content
+      document_html.at((Constants.tag(:photography))).next_sibling.next_sibling.content
     end
 
     def cast
       actors = []
-      node = document_html.search('span[itemprop="actor"]')
+      node = document_html.search((Constants.tag(:cast)))
       node.each do |actor|
-        actors << actor.at('span[itemprop="name"]').content.strip
+        actors << actor.at((Constants.tag(:cast_each))).content.strip
       end
       actors
     end
 
-    def company
-      document_html.at('dt:contains("Productora")').next_sibling.next_sibling.content
-    end
-
     def genres
       genres = []
-      node = document_html.at('dt:contains("Género")').next_sibling.next_sibling
+      node = document_html.at(Constants.tag(:genre)).next_sibling.next_sibling
       raw_genres = node.search("a")
       raw_genres.each do |raw_genre|
         genres << raw_genre.content.strip
@@ -74,20 +76,27 @@ module FilmAffinity
     end
 
     def sinopsis
-      document_html.at('dd[itemprop="description"]').content
+      document_html.at(Constants.tag(:sinopsis)).content
     end
 
+
     def prizes
 
     end
 
     def rating
-      raw_rating = document_html.at('div[itemprop="ratingValue"]').content.strip
+      raw_rating = document_html.at(Constants.tag(:rating)).content.strip
       raw_rating.gsub(",",".").to_f
     end
 
     def poster
-      poster_url = document_html.at('img[itemprop="image"]')["src"]
+      poster_url = document_html.at(Constants.tag(:poster))["src"]
+      @poster_manager.load_poster(poster_url)
+    end
+
+    def poster_big
+      poster_url = document_html.at(Constants.tag(:poster_big))["href"]
+      @poster_manager.load_poster(poster_url)
     end
 
     def to_json

data/lib/filmaffinity/poster-manager.rb

@@ -0,0 +1,32 @@
+require "open-uri"
+require "imgur"
+
+
+class PosterManager
+  def load_poster(posterurl)
+    return posterurl unless FilmAffinity.configuration.imgur_id
+    upload(posterurl, FilmAffinity.configuration.imgur_id)
+  end
+
+  def upload(posterurl, api_id)
+    imgur = Imgur.new(api_id)
+    @dir = __dir__ + "/" + construct_name + ".jpg"
+    save_img_locally(posterurl)
+    local_image = Imgur::LocalImage.new(@dir)
+    uploaded = imgur.upload(local_image)
+    File.delete(@dir)
+    uploaded.link
+  end
+
+  def save_img_locally(posterurl)
+    open(posterurl) {|f|
+      File.open(@dir,"wb") do |file|
+        file.puts f.read
+      end
+    }
+  end
+
+  def construct_name
+    (0...8).map { (65 + rand(26)).chr }.join
+  end
+end

data/lib/filmaffinity/top.rb

@@ -1,20 +1,26 @@
+
+require "pry"
 module FilmAffinity
   class Top
-    def initialize options = {}
+    def initialize options: {}, limit: 30
       @options = options
+      @limit = limit
       @json_parser = JsonMoviesParser.new
     end
 
     def movies
-      @movies ||= parse_movies
+      @movies = movies_with_limit
     end
 
-    def document_html
-      @document_html ||= Nokogiri::HTML(self.generate_html)
+    def document_html from
+      @document_html = Nokogiri::HTML(self.generate_html(from))
     end
 
-    def generate_html
-      open(Constants.urls[:top] % query_options)
+    def generate_html from
+      params = {'from' => from}
+      url = URI.parse(Constants.urls[:top] % query_options)
+      data = Net::HTTP.post_form(url, params)
+      data.body
     end
 
     def query_options
@@ -26,9 +32,23 @@ module FilmAffinity
       query_options.gsub(/\&$/,"")
     end
 
-    def parse_movies
+    def movies_with_limit
+      collect_from do |from|
+        doc_obj = document_html from
+        parse_movies doc_obj
+      end
+    end
+
+    def collect_from collection = [], from = 0, &block
+      response = yield(from)
+      collection += response
+      last_position = collection.size
+      response.empty? || last_position >= @limit ? collection.flatten[0..@limit-1] : collect_from(collection,last_position,&block)
+    end
+
+    def parse_movies document_html
       movies = []
-      document_html.search(".movie-card.movie-card-1").each do |movie_card|
+      document_html.search(".movie-card.movie-card-1").each_with_index do |movie_card,index|
         id = movie_card["data-movie-id"].to_i
         title = movie_card.search(".mc-title a").first.content.strip
         movie = FilmAffinity::Movie.new id, title

data/spec/filmaffinity/movie_spec.rb

@@ -1,121 +1,243 @@
 require_relative "../spec_helper"
 
 describe "FilmAffinity::Movie" do
+  context "english version" do
+    describe "#title" do
+      subject(:movie) { FilmAffinity::Movie.new(504889) }
+      it "should return an valid title when initializes with no title" do
+        expect(movie.title).to eq("The Truman Show")
+      end
+    end
 
-  describe "#title" do
-    subject(:movie) { FilmAffinity::Movie.new(504889) }
-    it "should return an valid title when initializes with no title" do
-      expect(movie.title).to eq("El show de Truman (Una vida en directo)")
+    describe "#rating" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Float" do
+        expect(movie.rating).to be_a(Float)
+      end
     end
-  end
 
-  describe "#rating" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return an Float" do
-      expect(movie.rating).to be_a(Float)
+    describe "#year" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Fixnum" do
+        expect(movie.year).to be_an(Fixnum)
+      end
+      it "should return 1998" do
+        expect(movie.year).to eq(1998)
+      end
     end
-  end
 
-  describe "#year" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return an Fixnum" do
-      expect(movie.year).to be_an(Fixnum)
+    describe "#duration" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Fixnum" do
+        expect(movie.duration).to be_a(Fixnum)
+      end
+      it "should return 103" do
+        expect(movie.duration).to eq(103)
+      end
     end
-    it "should return 1998" do
-      expect(movie.year).to eq(1998)
+
+    describe "#country" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.country).to be_a(String)
+      end
+      it "should return 'United States'" do
+        expect(movie.country).to eq("United States")
+      end
     end
-  end
 
-  describe "#duration" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return an Fixnum" do
-      expect(movie.duration).to be_a(Fixnum)
+    describe "#director" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.director).to be_a(String)
+      end
+      it "should return 'Peter Weir'" do
+        expect(movie.director).to eq("Peter Weir")
+      end
     end
-    it "should return 103" do
-      expect(movie.duration).to eq(103)
+
+    describe "#script" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.script).to be_a(String)
+      end
+      it "should return 'Andrew Niccol'" do
+        expect(movie.script).to eq("Andrew Niccol")
+      end
     end
-  end
 
-  describe "#country" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return a String" do
-      expect(movie.country).to be_a(String)
+    describe "#cast" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Array" do
+        expect(movie.cast).to be_an(Array)
+      end
+      it "should to include the passed cast" do
+        expected_cast = [
+          "Jim Carrey",
+          "Laura Linney",
+          "Noah Emmerich",
+          "Ed Harris"
+        ]
+        expect(movie.cast).to include(*expected_cast)
+      end
     end
-    it "should return 'Estados Unidos'" do
-      expect(movie.country).to eq("Estados Unidos")
+
+    describe "#company" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.company).to be_a(String)
+      end
+      it "should return 'Paramount Pictures / Scott Rudin Productions'" do
+        expect(movie.company).to eq("Paramount Pictures / Scott Rudin Productions")
+      end
     end
-  end
 
-  describe "#director" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return a String" do
-      expect(movie.director).to be_a(String)
+    describe "#genres" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Array" do
+        expect(movie.genres).to be_an(Array)
+      end
+      it "should to include the passed genres" do
+        expected_genres = [
+          "Drama",
+          "Comedy",
+          "Satire"
+        ]
+        expect(movie.genres).to include(*expected_genres)
+      end
     end
-    it "should return 'Peter Weir'" do
-      expect(movie.director).to eq("Peter Weir")
+
+    describe "#poster" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.poster).to be_a(String)
+      end
+      it "should return a .jpg address" do
+        expect(movie.poster).to include(".jpg")
+      end
     end
   end
 
-  describe "#script" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return a String" do
-      expect(movie.script).to be_a(String)
+context "spanish version" do
+    before :all do
+      FilmAffinity.configure do |config|
+        config.language = "ES"
+      end
     end
-    it "should return 'Andrew Niccol'" do
-      expect(movie.script).to eq("Andrew Niccol")
+
+    describe "#title" do
+      subject(:movie) { FilmAffinity::Movie.new(504889) }
+      it "should return an valid title when initializes with no title" do
+        expect(movie.title).to eq("El show de Truman (Una vida en directo)")
+      end
     end
-  end
 
-  describe "#cast" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return an Array" do
-      expect(movie.cast).to be_an(Array)
+    describe "#rating" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Float" do
+        expect(movie.rating).to be_a(Float)
+      end
     end
-    it "should to include the passed cast" do
-      expected_cast = [
-        "Jim Carrey",
-        "Laura Linney",
-        "Noah Emmerich",
-        "Ed Harris"
-      ]
-      expect(movie.cast).to include(*expected_cast)
+
+    describe "#year" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Fixnum" do
+        expect(movie.year).to be_an(Fixnum)
+      end
+      it "should return 1998" do
+        expect(movie.year).to eq(1998)
+      end
     end
-  end
 
-  describe "#company" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return a String" do
-      expect(movie.company).to be_a(String)
+    describe "#duration" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Fixnum" do
+        expect(movie.duration).to be_a(Fixnum)
+      end
+      it "should return 103" do
+        expect(movie.duration).to eq(103)
+      end
     end
-    it "should return 'Paramount Pictures / Scott Rudin Productions'" do
-      expect(movie.company).to eq("Paramount Pictures / Scott Rudin Productions")
+
+    describe "#country" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.country).to be_a(String)
+      end
+      it "should return 'Estados Unidos'" do
+        expect(movie.country).to eq("Estados Unidos")
+      end
     end
-  end
 
-  describe "#genres" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return an Array" do
-      expect(movie.genres).to be_an(Array)
+    describe "#director" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.director).to be_a(String)
+      end
+      it "should return 'Peter Weir'" do
+        expect(movie.director).to eq("Peter Weir")
+      end
     end
-    it "should to include the passed genres" do
-      expected_genres = [
-        "Drama",
-        "Comedia",
-        "Sátira"
-      ]
-      expect(movie.genres).to include(*expected_genres)
+
+    describe "#script" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.script).to be_a(String)
+      end
+      it "should return 'Andrew Niccol'" do
+        expect(movie.script).to eq("Andrew Niccol")
+      end
     end
-  end
 
+    describe "#cast" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Array" do
+        expect(movie.cast).to be_an(Array)
+      end
+      it "should to include the passed cast" do
+        expected_cast = [
+          "Jim Carrey",
+          "Laura Linney",
+          "Noah Emmerich",
+          "Ed Harris"
+        ]
+        expect(movie.cast).to include(*expected_cast)
+      end
+    end
 
-  describe "#poster" do
-    subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
-    it "should return a String" do
-      expect(movie.poster).to be_a(String)
+    describe "#company" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.company).to be_a(String)
+      end
+      it "should return 'Paramount Pictures / Scott Rudin Productions'" do
+        expect(movie.company).to eq("Paramount Pictures / Scott Rudin Productions")
+      end
     end
-    it "should return the correct img url" do
-      expect(movie.poster).to eq("http://pics.filmaffinity.com/El_show_de_Truman_Una_vida_en_directo-130091557-main.jpg")
+
+    describe "#genres" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return an Array" do
+        expect(movie.genres).to be_an(Array)
+      end
+      it "should to include the passed genres" do
+        expected_genres = [
+          "Drama",
+          "Comedia",
+          "Sátira"
+        ]
+        expect(movie.genres).to include(*expected_genres)
+      end
     end
-  end
 
+    describe "#poster" do
+      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      it "should return a String" do
+        expect(movie.poster).to be_a(String)
+      end
+      it "should return a .jpg address" do
+        expect(movie.poster).to include(".jpg")
+      end
+    end
+  end
 end

data/spec/filmaffinity/top_spec.rb

@@ -1,4 +1,5 @@
 require_relative "../spec_helper"
+require "pry"
 
 describe "FilmAffinity::Top" do
 
@@ -6,8 +7,8 @@ describe "FilmAffinity::Top" do
     subject(:top) { FilmAffinity::Top.new }
 
     it "#create_document_html" do
-      document_html = top.document_html
-      expect(document_html).to be_an(Nokogiri::HTML::Document)
+      document_html = top.document_html 0
+      expect(document_html).to respond_to(:search)
     end
 
   end
@@ -28,13 +29,17 @@ describe "FilmAffinity::Top" do
           el_padrino_movie = FilmAffinity::Movie.new 809297, "El padrino"
           expect(movies).to include_movie(el_padrino_movie)
         end
+        it "should return 30 movies" do
+          movies = top.movies
+          expect(movies.size).to eq(30)
+        end
       end
       context "with options" do
         options = {
           :genre => "BE",
           :country => "DE"
         }
-        subject(:top) { FilmAffinity::Top.new options }
+        subject(:top) { FilmAffinity::Top.new options:options }
         it "should return an array" do
           movies = top.movies
           expect(movies).to be_an(Array)
@@ -48,6 +53,41 @@ describe "FilmAffinity::Top" do
           hijos_del_tercer_reich_movie = FilmAffinity::Movie.new 831118, "Hijos del Tercer Reich (TV)"
           expect(movies).to include_movie(hijos_del_tercer_reich_movie)
         end
+
+      end
+      context "with limit 60" do
+        limit = 60
+        subject(:top) { FilmAffinity::Top.new limit:limit }
+        it "should include 'American History X'" do
+          movies = top.movies
+          american_history_x = FilmAffinity::Movie.new 261972, "American History X"
+          expect(movies).to include_movie(american_history_x)
+        end
+        it "should NOT include 'Con la muerte en los talones'" do
+          movies = top.movies
+          con_la_muerte_en_los_talones = FilmAffinity::Movie.new 351704, "Con la muerte en los talones"
+          expect(movies).not_to include_movie(con_la_muerte_en_los_talones)
+        end
+        it "should return 60 movies" do
+          movies = top.movies
+          expect(movies.size).to eq(60)
+        end
+      end
+      context "with limit 132" do
+        limit = 132
+        subject(:top) { FilmAffinity::Top.new limit:limit }
+        it "should return 132 movies" do
+          movies = top.movies
+          expect(movies.size).to eq(132)
+        end
+      end
+      context "with limit 10" do
+        limit = 10
+        subject(:top) { FilmAffinity::Top.new limit:limit }
+        it "should return 10 movies" do
+          movies = top.movies
+          expect(movies.size).to eq(10)
+        end
       end
     end
 

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: filmaffinity
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.3.0
 platform: ruby
 authors:
-- David Santos, Oriol Bellido
+- David Santos
+- Oriol Bellido
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-05 00:00:00.000000000 Z
+date: 2016-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -38,6 +39,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: imgur-api
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,9 +95,11 @@ files:
 - filmaffinity.gemspec
 - lib/constants/constants.rb
 - lib/filmaffinity.rb
+- lib/filmaffinity/configuration.rb
 - lib/filmaffinity/json-movie-parser.rb
 - lib/filmaffinity/json-movies-parser.rb
 - lib/filmaffinity/movie.rb
+- lib/filmaffinity/poster-manager.rb
 - lib/filmaffinity/search.rb
 - lib/filmaffinity/top.rb
 - spec/filmaffinity/json-movie-parser_spec.rb