film_snob 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4297f9bda01f5ba16148980f7a5e70b0918521f6
-  data.tar.gz: db4a13c392ca6276bdf49c3c3dac0bb8fc3e8dfa
+  metadata.gz: 3025fad3bbbada894a2398cf004a184c5181faa8
+  data.tar.gz: c358d7f2ce46b156b7e39b18a97f279c634994b8
 SHA512:
-  metadata.gz: 35474ad186833e37f679299170eb2a804d2983dc60ef4d914ee946c42f5a2a087e44c7e64f816a1e187cff7b76e83e70c4a4a1679139dd54f48866fed9d2991c
-  data.tar.gz: 024c041c4a6a9ba807df8d503d831c3e16ab308724b025650a9c891aefd5e83056ea2413c26ae5b57919721ea98ba64d35ed8648a5cfdaf0883d82a4abd20a6e
+  metadata.gz: aab9cf9e456fa00244539cdcccd550bab0fb557096ded066e43428ed0f0a3f2b865aef62ea9b9f7705379decd7655762a48e20f4c307d44354f6e169937d520e
+  data.tar.gz: d072bee20078a497e5cfa877ec9544e0d3744fe7fbc825833b70a6346deb793629ea15aab0a9edc71babc593885d4486c3ebe04a65129c9ba6cb78039b4ff8d3

data/.travis.yml

@@ -8,10 +8,10 @@ rvm:
   - 2.1.3
   - 2.1.4
   - 2.1.5
+  - 2.2.0
 before_install: "gem install bundler -v 1.6"
 script:
-  - bundle exec rake
-  - bundle exec rubocop
+  - bundle exec rake ci
 sudo: false
 cache: bundler
 

data/README.md

@@ -59,11 +59,15 @@ The same methods work with all of these providers.
 
 ## Testing
 
-Run `rake` to run all of the rspecs.
+Run `rake spec` to run all of the tests.
 
 ## Code Style
 
-Run `rubocop` and try to keep the cops happy.
+Run `rake style` to confirm the codebase is looking stylish.
+
+## Continous Integration
+
+Run `rake ci` to run both the tests and the style checks, which will be run on Travis; both should pass to have a green build.
 
 ## Questions?
 

data/Rakefile

@@ -1,7 +1,10 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:style)
 
-task default: :spec
+task ci: [:spec, :style]
+task default: :ci
 

data/lib/film_snob/version.rb

@@ -1,4 +1,4 @@
 class FilmSnob
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end
 

data/lib/film_snob/video_sites/instagram.rb

@@ -10,28 +10,12 @@ class FilmSnob
     end
 
     def self.oembed_endpoint
-      "http://api.instagram.com/oembed"
+      "http://api.instagram.com/publicapi/oembed/"
     end
 
     def clean_url
       @clean_url ||= "http://instagram.com/p/#{id}"
     end
-
-    def html
-      # instagram's oembed response does not include html,
-      # so we need to construct it
-      # but first we need to ensure that the response was good
-      # which we do by checking for the presence of the title,
-      # which will raise an exception if it"s not present
-      title && constructed_html
-    end
-
-    private
-
-    def constructed_html
-      "<iframe src='//instagram.com/p/#{id}/embed/' width='612' height='710' " \
-      "frameborder='0' scrolling='no' allowtransparency='true'></iframe>"
-    end
   end
 end
 

data/lib/film_snob.rb

@@ -4,9 +4,15 @@ require "film_snob/exceptions"
 require "film_snob/deprecated"
 
 class FilmSnob
-  attr_reader :url
+  extend Deprecated, Forwardable
+
+  VIDEO_METHODS = [:site, :id, :clean_url, :title, :html]
 
-  extend Deprecated
+  def_delegators :video, *VIDEO_METHODS
+
+  deprecated_alias :watchable?, :embeddable?, removed_in: "v1.0.0"
+
+  attr_reader :url
 
   def initialize(url, options = {})
     @url = url
@@ -17,16 +23,6 @@ class FilmSnob
     !@video.nil?
   end
 
-  deprecated_alias :watchable?, :embeddable?, removed_in: "v1.0.0"
-
-  def method_missing(message)
-    if delegated_video_methods.include?(message)
-      video.send(message)
-    else
-      super
-    end
-  end
-
   private
 
   def video
@@ -36,9 +32,5 @@ class FilmSnob
       raise NotSupportedURLError, "#{url} is not a supported URL"
     end
   end
-
-  def delegated_video_methods
-    [:site, :id, :clean_url, :title, :html]
-  end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: film_snob
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Max Jacobson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-04 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -189,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Fetch embed codes for videos