fillparams 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b18bc3578e7921270361c42585ff4557ec7b44ac
-  data.tar.gz: 54ba40d324eed4527c37cfa372e051d2c35e82fc
+  metadata.gz: 40bc376f336e9f6c067ebe6a524d8d4ab7d7ea81
+  data.tar.gz: 5f889ec0330aee3cdca5ec9aaa4a7d356fbfaf29
 SHA512:
-  metadata.gz: 70e620ee44b7a7798a430eefea42eca8aa4224a58b54685dd3863f3782682573c048eddca170490b7bca3aba87c049e15ae409f06e20b63e166a62c074ccf0c7
-  data.tar.gz: eda5b7eff680cd9beb7408ca33b2bb43ca8795d30956b6f5e436516bd89f62d3de4b0b296b71c4a58c05670a6c7879a7891550aea638649e7f8eba66a0b3473f
+  metadata.gz: 8aaf09171ac516ba515c2d047b8224a6e68261dc26d7ceb174c3c22571415e2a2df9049dbae19270db6b49ed7a43cb6237cbc430c0cbc831128d946eae0f183c
+  data.tar.gz: b938892dca6c047f5898cc7e15d038e8feedb6bb753ad1d17c7e6d74bed7178046f0a7ea5aefb94e425c27263c4ba4aa80380a4ebe547d8a9fd5c71ae6100324

data/FillParams.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |spec|
   spec.name          = 'fillparams'
   spec.version       = FillParams::VERSION
   spec.authors       = ['Krzysztof Hasiński', 'Justyna Wojtczak']
-  spec.email         = ['krzysztof.hasinski+fillparams@gmail.com']
+  spec.email         = ['krzysztof.hasinski+fillparams@gmail.com', 'justine84+fillparams@gmail.com']
   spec.summary       = 'Parameters handler, for usage see github page'
   spec.description   = 'A gem for filling in parameters automatically'
   spec.homepage      = 'http://github.com/khasinski/fillparams'
@@ -22,4 +22,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'rspec-activemodel-mocks'
-end
+end

data/lib/FillParams/version.rb

@@ -1,3 +1,3 @@
 module FillParams
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/lib/parameter_filler.rb

@@ -51,8 +51,9 @@ class ParameterFiller
   end
 
   def fill_parameters(data, dist_data)
+    data ||= {}
     dist_data.each do |key, value|
-      if !data.has_key?(key) && !dist_data[key].is_a?(Hash)
+      unless data.has_key?(key) || dist_data[key].is_a?(Hash)
         data[key] = ask_for_param(key, value)
       end
       if dist_data[key].is_a?(Hash)

data/spec/foobar_spec.rb

@@ -1,8 +1,53 @@
 require 'spec_helper'
 describe ParameterFiller do
-  pending "write it"
-  it 'should be true' do
-    expect(1).to eq 1
+
+  def sample_dist_data
+    YAML.load(<<-EOF
+      NAME: value
+      string: abc
+      number: 1.23
+    EOF
+    )
   end
-end
 
+  let(:pf) { ParameterFiller.new('', false, false) }
+  context 'when the data is nil' do
+    let(:data){ nil }
+    it 'returns the same config as sample_dist_data' do
+      expect(pf.fill_parameters(data, sample_dist_data)).to eq sample_dist_data
+    end
+  end
+  context 'when the dist data is nil' do
+    let(:dist_data){ nil }
+    let(:data){ sample_dist_data }
+    it 'returns the same config as sample_dist_data' do
+      expect(pf.fill_parameters(data, sample_dist_data)).to eq sample_dist_data
+    end
+  end
+  context 'when the data is the same as sample data' do
+    let(:data){ sample_dist_data }
+    it 'returns the same config as sample_dist_data' do
+      expect(pf.fill_parameters(data, sample_dist_data)).to eq sample_dist_data
+    end
+  end
+  context 'when the data has additional key' do
+    let(:data){ sample_dist_data.merge('new_key'=> 'new_val') }
+    it 'returns the same config as data' do
+      expect(pf.fill_parameters(data, sample_dist_data)).to eq data
+    end
+  end
+  context 'when the dist data has additional key' do
+    let(:dist_data){ sample_dist_data.merge('new_key'=> 'new_val') }
+    let(:data){ sample_dist_data }
+    it 'returns the same config as dist_data' do
+      expect(pf.fill_parameters(data, dist_data)).to eq dist_data
+    end
+  end
+  context 'when both data and dist data have additional keys' do
+    let(:dist_data){ sample_dist_data.merge('new_key'=> 'new_val') }
+    let(:data){ sample_dist_data.merge('new_key2'=> 'new_val2') }
+    it 'returns data with this keys' do
+      expect(pf.fill_parameters(data, dist_data)).to eq dist_data.merge('new_key2'=> 'new_val2')
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fillparams
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Krzysztof Hasiński
@@ -70,6 +70,7 @@ dependencies:
 description: A gem for filling in parameters automatically
 email:
 - krzysztof.hasinski+fillparams@gmail.com
+- justine84+fillparams@gmail.com
 executables:
 - fillparams
 extensions: []