fillable-pdf 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2cdd748940498c34c3e4f19f91f83cfc47fcf34dda1d10eb07e05f7aef9c7d57
-  data.tar.gz: a98954a86876c759716a8919a24f54c175ec97eb0eddd19bc2b9aaa844bdd6cb
+  metadata.gz: 9ef1adfa571c40a68f117e48e73917ef837207c8c2888a449672f2fa07664873
+  data.tar.gz: fb5c2c786c58b1635c37534381ae5ac106aaa0694e7839ec73acdaa331c863d5
 SHA512:
-  metadata.gz: bb4104898a7feb6a16338aae323b3d1285f8fb5dd2458e48d5e936ca17ed27fc407289c68db0a466105bbe06fc1100cfd5a8cfa92873f6f6b731692ee385bfaf
-  data.tar.gz: 07430fe63ccbbec3e4c7c5191d6831b767320b87ed6ea0bd0542c11d41e10fe8c7883ce7d396fe7cc31f029d425fb87e055e3af01bd44358cf8d3b99010e17ca
+  metadata.gz: 86ad2b2c634818d159e2f7b710d2d38c5e726eecf9c809e8b19466cc2f842f8af9633b0900004b0f98031741a2680f5aff2bbf40f4448161d0590a2141630192
+  data.tar.gz: e940b9d5908efb0fae7b7975b0ec7878b78876fccc07c5a08c9a7e1575fa38e4829ae0a41290a791ac6e8d0d21dd97024e14c65700baf3e1f01d14b0ba7f02c7

data/README.md

@@ -12,8 +12,6 @@ FillablePDF is an extremely simple and lightweight utility that bridges iText an
 
 Supports **Ruby 2.4 → latest** and **JDK 8 → latest**, with the full Ruby/Java matrix tested daily in CI.
 
-[!["Buy Me A Coffee"](https://www.buymeacoffee.com/assets/img/custom_images/yellow_img.png)](https://www.buymeacoffee.com/vkononov)
-
 ## Known Issues
 
 1. Phusion Passenger's [smart spawning](https://www.phusionpassenger.com/library/indepth/ruby/spawn_methods/#the-smart-spawning-method) is not supported. Please see [Deployment with Phusion Passenger + Nginx](#deployment-with-phusion-passenger--nginx) for more information.

data/lib/fillable-pdf/version.rb

@@ -1,3 +1,3 @@
 class FillablePDF
-  VERSION = '1.1.3'
+  VERSION = '1.1.4'
 end

data/lib/fillable-pdf.rb

@@ -5,6 +5,7 @@ require_relative 'fillable-pdf/errors'
 require 'base64'
 require 'securerandom'
 require 'tmpdir'
+require 'tempfile'
 
 class FillablePDF # rubocop:disable Metrics/ClassLength
   include SuppressWarnings
@@ -295,15 +296,15 @@ class FillablePDF # rubocop:disable Metrics/ClassLength
   #
   def save(flatten: false)
     ensure_document_open
-    tmp_file = "#{Dir.tmpdir}/#{SecureRandom.uuid}"
-    save_as(tmp_file, flatten: flatten)
-    FileUtils.mv tmp_file, @file_path
+    write_document(@file_path, flatten: flatten)
     self
+  rescue StandardError => e
+    raise FileOperationError, "Failed to save file `#{@file_path}`: #{e.message}"
   end
 
   ##
   # Saves the filled out PDF document in a given path and flattens it if requested.
-  # If the path matches the current file path, it will call save() instead.
+  # The destination is replaced only after the document has been finalized.
   #
   #   @param [String] file_path the name of the PDF file or file path
   #   @param [Boolean] flatten true if PDF should be flattened, false otherwise
@@ -312,12 +313,7 @@ class FillablePDF # rubocop:disable Metrics/ClassLength
   #
   def save_as(file_path, flatten: false)
     ensure_document_open
-    if @file_path == file_path
-      save(flatten: flatten)
-      return self
-    end
-
-    File.open(file_path, 'wb') { |f| f.write(finalize(flatten: flatten)) && f.close }
+    write_document(file_path, flatten: flatten)
     self
   rescue StandardError => e
     raise FileOperationError, "Failed to save file `#{file_path}`: #{e.message}"
@@ -335,9 +331,12 @@ class FillablePDF # rubocop:disable Metrics/ClassLength
   #
   def save_as!(file_path, flatten: false)
     ensure_document_open
-    raise InvalidArgumentError, 'Cannot save_as! to the same file path. Use save() instead.' if @file_path == file_path
+    if same_source_file?(file_path)
+      raise InvalidArgumentError,
+            'Cannot save_as! to the same file path. Use save() instead.'
+    end
 
-    File.open(file_path, 'wb') { |f| f.write(finalize(flatten: flatten)) && f.close }
+    write_document(file_path, flatten: flatten)
     self
   rescue InvalidArgumentError
     raise
@@ -369,6 +368,29 @@ class FillablePDF # rubocop:disable Metrics/ClassLength
 
   private
 
+  def same_source_file?(file_path)
+    File.expand_path(@file_path.to_s) == File.expand_path(file_path.to_s) ||
+      (File.exist?(file_path) && File.identical?(@file_path, file_path))
+  end
+
+  # Keep the existing destination intact until finalization and writing succeed.
+  # Resolve symlinks so saving through one preserves the link itself.
+  def write_document(file_path, flatten:) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+    destination = File.expand_path(file_path.to_s)
+    destination = File.realpath(destination) if File.symlink?(destination)
+    mode = File.stat(destination).mode & 0o777 if File.exist?(destination)
+    temporary = Tempfile.new(['.fillable-pdf-', '.pdf'], File.dirname(destination))
+    temporary.binmode
+    temporary.write(finalize(flatten: flatten))
+    temporary.flush
+    temporary.fsync
+    temporary.chmod(mode) if mode
+    temporary.close
+    File.rename(temporary.path, destination)
+  ensure
+    temporary&.close!
+  end
+
   ##
   # Writes the contents of the modified fields to the previously opened PDF file.
   #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fillable-pdf
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Vadim Kononov
@@ -96,7 +96,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - JDK >= 8
-rubygems_version: 4.0.10
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Fill, read, flatten and edit PDF form fields in Ruby with the iText engine
 test_files: []