file_pipeline 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68c45fd6fc30e7bc3fab376fb64d9ca67af5951b17d01b190cecc577d5fe1695
-  data.tar.gz: c26978ed8f1c04aae72c5281349117c52d93ec013d38dbebfab3835b6c972978
+  metadata.gz: 228340816e7d09bd3f7eb9f5bac1b2c3ed0f1bf8912f4f8e963d04fcafcd167a
+  data.tar.gz: 2b9623501c37d0a70d2dbc22435b4af87d19f343f7750de38f4ea50b9677a2c9
 SHA512:
-  metadata.gz: 5005046aa0ce3ffd9989284e27c90f072edff43283496f22794faa8070d908a63587fbc4309246721f48d0890a51e04d83ccec4872a2802844d98185145363fe
-  data.tar.gz: 9b27df15157b517d4c59d4c0bc73e3b2813fac42bf6645001037e8b2d3b10ee49c82de094c1efbdbc6315dfcdc4dd1b9bf2360fbbaf48adf1cb735342978f340
+  metadata.gz: 7f738902aeb500a5cf05cff992da3eb30ef48e477a4001ef2380de412315638fb90822c1ba66f809e6fdfd1ce35e04d6ccc4a1061c574bfa5ff7abebdbfeef80
+  data.tar.gz: 6e231ba3deaabfa09166795aed6fa491ce54cb363a8a5893d4e32d70f18c5342835b85490df073e34b1df5e45dc1a9ca9b59eba28f0c094da9499477f3df1486

data/README.rdoc

@@ -384,11 +384,11 @@ The initializer can call +super+ and pass the +options+ hash and any
 defaults (a hash with default options). This will update the defaults with
 the actual options passed to +initialize+ and assign them to the
 {#options}[rdoc-ref:FilePipeline::FileOperations::FileOperation#options] 
-attribute.
+attribute. It will also transform any keys passed as strings into symbols.
 
 If the initializer does not call +super+, it _must_ assign the options to
 the <tt>@options</tt> instance variable or expose them through an
-<tt>#options</tt> getter method.
+<tt>#options</tt> getter method. It _should_ transform keys into symbols.
 
 If it calls +super+ but must ensure some options are always set to a
 specific value, those should be set after the call to +super+.

data/lib/file_pipeline/errors/failed_modification_error.rb

@@ -8,16 +8,32 @@ module FilePipeline
       # The file opration that caused the error.
       attr_reader :info
 
-      def initialize(msg = nil, info: nil)
+      # FIXME: should contain original file name file name!
+      def initialize(msg = nil, info: nil, file: nil)
+        @file = file
         @info = info
+
         if info.respond_to?(:operation) && info.respond_to?(:log)
           msg ||= "#{@info.operation&.name} with options"\
-                  " #{@info.operation&.options} failed, log: #{@info.log}"
+                  " #{@info.operation&.options} failed on #{file}."
+          if original_error
+            msg += "\nException raised by the operation:"\
+                   " #{original_error.inspect}. Backtrace:\n"
+            msg += original_backtrace if original_backtrace
+          end
         else
           msg ||= 'Operation failed' unless info
         end
         super msg
       end
+
+      def original_backtrace
+        original_error&.backtrace&.join("\n")
+      end
+
+      def original_error
+        @info.log.find { |item| item.is_a? Exception }
+      end
     end
   end
 end

data/lib/file_pipeline/file_operations/exif_manipulable.rb

@@ -28,6 +28,8 @@ module FilePipeline
         exif, = read_exif out_file
         values = exif.select { |tag| tags_to_delete.include? tag }
         values_to_delete = values.transform_values { nil }
+        return 'Info: nothing to delete.' if values.empty?
+
         log, = write_exif out_file, values_to_delete
         [log, values]
       end

data/lib/file_pipeline/file_operations/file_operation.rb

@@ -31,6 +31,7 @@ module FilePipeline
       # * +defaults+ - Default options for the subclass (hash).
       # * +opts+ - Options passed to the sublass initializer (hash).
       def initialize(opts, defaults = {})
+        opts.transform_keys!(&:to_sym)
         @options = defaults.update(opts)
       end
 

data/lib/file_pipeline/pipeline.rb

@@ -59,6 +59,12 @@ module FilePipeline
     def batch_apply(versioned_files)
       versioned_files.map { |file| Thread.new(file) { apply_to(file) } }
                      .map(&:value)
+    #--
+    # FIXME: This should obviously not just raise the same error again, but
+    #        rather do someting meaningful.
+    #++
+    rescue Errors::FailedModificationError => e
+      raise e
     end
 
     # Initializes the class for <tt>file_operation</tt> (a string in

data/lib/file_pipeline/versioned_file.rb

@@ -30,17 +30,13 @@ module FilePipeline
     # *Caveat* it can not be ruled out that buggy or malignant file operations
     # modify the original.
     #
-    #--
-    # FIXME: protect the original
-    #++
-    #
     # ===== Options
     #
     # <tt>target_suffix</ttm> is a string to be appended to the file that
     # will be written by #finalize (the last version) if #finalize is to
-    # preserve the original. It is recommended to use a UUID (_default_) to
-    # avoid clashes with other files in the directory.
-    def initialize(file, target_suffix: SecureRandom.uuid)
+    # preserve the original. It is recommended to use a randomized string
+    # (_default_) to avoid clashes with other files in the directory.
+    def initialize(file, target_suffix: SecureRandom.hex(4))
       raise Errors::MissingVersionFileError, file: file unless File.exist? file
 
       @original = file
@@ -72,8 +68,9 @@ module FilePipeline
     # Will move the file to #directory if it is in another directory.
     def <<(version_info)
       file, info = version_info
-      raise Errors::FailedModificationError, info: info if info&.failure
-
+      if info&.failure
+        raise Errors::FailedModificationError, info: info, file: original
+      end
       version = validate(file)
       @history[version] = info
       self

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: file_pipeline
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Martin Stein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-31 00:00:00.000000000 Z
+date: 2019-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_exiftool