file_blobs_rails 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc1739959bccd1657b2283239b10875b92ded4c2
-  data.tar.gz: fda8865e07e1a00d7141b956dbf9e8fa19d53df4
+  metadata.gz: 40111b879c3c7a2326df1c2780caa3735f3df649
+  data.tar.gz: 1400f0be44fa14a790097dfe459ccd81acc14a43
 SHA512:
-  metadata.gz: c53f96a7ec4701ffc194850ef355a5b8830a51742e184833e91427d49370836c2200b45685b361dc6bd92161af47cc5c5a400233f54807441c3c568d6ccc783b
-  data.tar.gz: 1de57330fe64125016df4aa73a9c849b6cb38a0bfbb47de6b05c73d2e84d71dec7f42dc1814f56eab715ae7bcd71a9f81a390f9a4f43d487b7a1f9aee77a4ec2
+  metadata.gz: f0876c5d2c137f48c0e95c685dbeea64bb99f5ebe6152b858f58c7b1c6ee20068e4899c033f4f6b082b0e4da0558a74164f637d35864ef156c29892786747572
+  data.tar.gz: 2503663b792555eaa2a76d26c4fdbf40c6f56f9c713b1973157595ba25d41c88121be5c15af6e7db6ab02c8040d26fb5fc36b573740d3498272d0ce96b6b1ad6

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.2.1

data/file_blobs_rails.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: file_blobs_rails 0.2.0 ruby lib
+# stub: file_blobs_rails 0.2.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "file_blobs_rails"
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]

data/lib/file_blobs_rails/active_record_extensions.rb

@@ -158,6 +158,13 @@ module ActiveRecordExtensions::ClassMethods
             # Slow path: we need to copy data across blob tables.
             self.#{attribute_name}_data = new_file.data
           end
+        elsif new_file.nil?
+          # Reset everything to nil.
+          self.#{attribute_name}_mime_type = nil
+          self.#{attribute_name}_original_name = nil
+          self.#{attribute_name}_data = nil
+        else
+          raise ArgumentError, "Invalid file_blob value: \#{new_file.inspect}"
         end
       end
 
@@ -170,8 +177,12 @@ module ActiveRecordExtensions::ClassMethods
         #       that the large FileBlob doesn't hang off of the object
         #       referencing it; this way, the blob's data can be
         #       garbage-collected by the Ruby VM as early as possible
-        blob = #{blob_model}.where(id: #{attribute_name}_blob_id).first!
-        blob.data
+        if blob_id = #{attribute_name}_blob_id
+          blob = #{blob_model}.where(id: blob_id).first!
+          blob.data
+        else
+          nil
+        end
       end
 
       # Convenience setter for the file's content.

data/test/file_blob_proxy_test.rb

@@ -97,4 +97,27 @@ class FileBlobProxyTest < ActiveSupport::TestCase
                  @message.attachment_blob.data
     assert_equal true, @message.attachment_blob.new_record?
   end
+
+  test 'proxy setter on the owner model with nil' do
+    @blob_owner.file = nil
+
+    assert_equal nil, @blob_owner.file_original_name
+    assert_equal nil, @blob_owner.file_blob_id
+    assert_equal nil, @blob_owner.file_size
+    assert_equal nil, @blob_owner.file_data
+    assert_equal nil, @blob_owner.file_blob
+  end
+
+  test 'proxy setter on the owner model with an invalid value' do
+    exception = assert_raise ArgumentError do
+      @blob_owner.file = [4, 2]
+    end
+    assert_equal 'Invalid file_blob value: [4, 2]', exception.message
+
+    assert_equal 'ruby.png', @blob_owner.file_original_name
+    assert_equal file_blob_id('files/ruby.png'), @blob_owner.file_blob_id
+    assert_equal file_blob_size('files/ruby.png'), @blob_owner.file_size
+    assert_equal file_blob_data('files/ruby.png'), @blob_owner.file_data
+    assert_equal file_blobs(:ruby_png), @blob_owner.file_blob
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: file_blobs_rails
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Victor Costan