file-temp 0.1.2 → 1.0.0

data/CHANGES

@@ -1,3 +1,7 @@
+= 1.0.0
+* Added security via umask().
+* Version bump to 1.0.0.
+
 = 0.1.2 - 6-Jun-2007
 * Gemspec fix (forgot the temp.h file - oops).
 * Added an extra test.

data/README

@@ -25,6 +25,9 @@
    Ruby's tempfile.rb is overwrought and susceptible to race conditions. This
    This library uses your system's native tmpfile() or mkstemp() functions
    instead of trying to handle race conditions manually via pure Ruby.
+   
+   This library is also more secure because it restricts file permission via
+   umask() for files created with mkstemp().
 
 = Other libraries
    I am aware of Cian Synnott's ruby-stemp project. However, I don't like the
@@ -40,7 +43,7 @@
    Ruby's
 
 = Copyright
-   (C) 2007 Daniel J. Berger
+   (C) 2007-2008 Daniel J. Berger
    All Rights Reserved
 
 = Warranty

data/ext/temp.c

@@ -1,5 +1,6 @@
 #include <ruby.h>
 #include <stdio.h>
+#include <sys/stat.h>
 
 #ifdef HAVE__SOPEN_S
 #include <share.h>
@@ -14,7 +15,7 @@
 #define P_tmpdir "/tmp"
 #endif
 
-#define VERSION "0.1.2"
+#define VERSION "1.0.0"
 
 VALUE cFileTemp;
 
@@ -59,16 +60,18 @@ static VALUE tempfile_init(int argc, VALUE* argv, VALUE self){
       if(!fptr)
          rb_sys_fail("tmpfile()");
 #endif
-      
       v_args[0] = INT2FIX(fileno(fptr));
    }
    else{
-      int fd;
+      int fd, omask;
       
       if(NIL_P(v_template))
          v_template = rb_str_new2("rb_file_temp_XXXXXX");
          
+      /* Set the umask to improve security */
+      omask = umask(077);
       fd = mkstemp(StringValuePtr(v_template));
+      umask(omask);
 
       if(fd < 0)
          rb_sys_fail("mkstemp()");
@@ -77,7 +80,7 @@ static VALUE tempfile_init(int argc, VALUE* argv, VALUE self){
    }
 
    /* This bit of explicitness is necessary for MS Windows */
-   v_args[1] = rb_str_new2("wb");
+   v_args[1] = rb_str_new2("wb+");
 
    return rb_call_super(2, v_args);
 }
@@ -105,13 +108,13 @@ void Init_temp(){
    rb_define_method(cFileTemp, "initialize", tempfile_init, -1);
 
    /* Singleton Methods */
-   rb_define_singleton_method(cFileTemp, "tmpnam", tempfile_tmpnam, 0);
+   rb_define_singleton_method(cFileTemp, "temp_name", tempfile_tmpnam, 0);
 
    /* Constants */
    
    /* ENV['P_tmpdir']: Your system's tmpdir */ 
    rb_define_const(cFileTemp, "TMPDIR", rb_str_new2(P_tmpdir));
    
-   /* 0.1.2: The version of this library */
+   /* 0.1.3: The version of this library */
    rb_define_const(cFileTemp, "VERSION", rb_str_new2(VERSION));
 }

data/test/tc_file_temp.rb

@@ -14,7 +14,13 @@ class TC_File_Temp < Test::Unit::TestCase
    end
 
    def test_file_temp_version
-      assert_equal('0.1.2', FileTemp::VERSION)
+      assert_equal('1.0.0', FileTemp::VERSION)
+   end
+
+   def test_file_temp_threaded
+      threads = []
+      assert_nothing_raised{ 100.times{ threads << Thread.new{ FileTemp.new }}}
+      assert_nothing_raised{ threads.join }
    end
 
    def test_file_temp_tmpdir

metadata

@@ -1,54 +1,61 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.4
-specification_version: 1
 name: file-temp
 version: !ruby/object:Gem::Version 
-  version: 0.1.2
-date: 2007-06-06 00:00:00 -06:00
-summary: An alternative way to generate tempfiles
-require_paths: 
-- lib
-email: djberg96@gmail.com
-homepage: http://www.rubyforge.org/projects/shards
-rubyforge_project: shards
-description: An alternative way to generate tempfiles
-autorequire: 
-default_executable: 
-bindir: bin
-has_rdoc: true
-required_ruby_version: !ruby/object:Gem::Version::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: 1.8.0
-  version: 
+  version: 1.0.0
 platform: ruby
-signing_key: 
-cert_chain: 
-post_install_message: 
 authors: 
 - Daniel J. Berger
-files: 
-- test/tc_file_temp.rb
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2008-04-12 00:00:00 -06:00
+default_executable: 
+dependencies: []
+
+description: An alternative way to generate tempfiles
+email: djberg96@gmail.com
+executables: []
+
+extensions: 
+- ext/extconf.rb
+extra_rdoc_files: 
 - CHANGES
-- MANIFEST
 - README
-- Rakefile
+- MANIFEST
 - ext/temp.c
-test_files: 
+files: 
 - test/tc_file_temp.rb
-rdoc_options: []
-
-extra_rdoc_files: 
 - CHANGES
-- README
 - MANIFEST
+- Rakefile
+- README
 - ext/temp.c
-executables: []
+has_rdoc: true
+homepage: http://www.rubyforge.org/projects/shards
+post_install_message: 
+rdoc_options: []
 
-extensions: 
-- ext/extconf.rb
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: 1.8.0
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
 requirements: []
 
-dependencies: []
-
+rubyforge_project: shards
+rubygems_version: 1.0.1
+signing_key: 
+specification_version: 2
+summary: An alternative way to generate tempfiles
+test_files: 
+- test/tc_file_temp.rb