filbunke 1.13.2 → 1.13.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2RhNGVjMjMzZmFmZGFkOWQzMGE3OTJmYjlkZTg2NzU3NDYxNzNkNg==
+    YjBmZGY5ZWY1MjM2ZjM4ZTZkYWMxZjg3OTJkMmExMTQ5MTNkNjdkNg==
   data.tar.gz: !binary |-
-    NWIzOGJiNzIwNzEwYjMxMWQwMzFkNTI4NjYzYmIzOWFkYjRkZmZiNA==
+    Yjk5ZTMzZmUxMzE3YzkxNzk4ZWNhMWUwZDU2NmYwMjFkZWNmZWMwNA==
 SHA512:
   metadata.gz: !binary |-
-    ZmViNTdlMWQxZjYwNGU3ZGFmODdkOWE3MzdhYzUxNTI0NDU4ZWVlMWYzNWI0
-    YzMyM2ZiM2M3Y2RkOTMzNWQ5MjQzM2UyZGJlYzkwNjRkZTc3YzcxZmFmMDNl
-    NmM3YjhhYTk1MjFkZmFjYzExODQzYmVjNzc5ZTE0NjQ2MjQ2OTY=
+    MzhiMmMyMzFiNzcxNTZlOTJjMjgzZTQ0ODRlNTE5YTZjYTExMTY2ZGM2OTA5
+    ZDZiMzJhZWVlN2EyOWMzZWJiNjQ1YjU1M2ZhMWYyOGNlY2YzMTk2NmJkZGFj
+    ZWQ3OWE3YTdjNTVkODc2ZjI1ZTcxYWVjNDE4NTc3NzIzYjlkYjQ=
   data.tar.gz: !binary |-
-    ZDk3OWY4MjMyZjE4ZDQ1N2ExZDFjYjgxMjQzYTFkZjg5MzFmMDU1MDQ3MWVi
-    MmJlZTU5MTI2OTQ3ZjY2NmY2MmMyZjA5MWMzOWU3MDBlNDQ5MGJjOGIyYjE5
-    NDYxM2EyNjNjZGE0OWE4NDA0NTgwODA5N2UyNjBlYzBlYTU3ODk=
+    MmY0ZWI5OTJjYWRiZjQxNmYwZjZlN2UxZGQ0MDQ4NTFkMzBmNWQ4ZDc0NzAz
+    MmMxYWEyMTM3ZDgzM2VkYTE3MWI3ZmI3OGIxNmUzMmQ0ZjYxYzhjMTEyZTRm
+    NzRkNzhlZmRlZWYxYzhjYzlkNmJiNmEzNjQ0NjNlMzQ4YjU1ZmY=

data/VERSION

@@ -1 +1 @@
-1.13.2
+1.13.3

data/filbunke.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: filbunke 1.13.2 ruby lib
+# stub: filbunke 1.13.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "filbunke"
-  s.version = "1.13.2"
+  s.version = "1.13.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]

data/lib/filbunke/client.rb

@@ -240,6 +240,8 @@ module Filbunke
     end
 
     def update_http_file!(file, local_file_path)
+      downloaded_file = nil
+      tmp_filename = "#{local_file_path}-#{(0...8).map { (65 + rand(26)).chr }.join}.tmp"
       begin
         async_request = if @repository.user
           Typhoeus::Request.new(
@@ -255,8 +257,7 @@ module Filbunke
           )
         end
 
-        downloaded_file = nil
-        tmp_filename = "#{local_file_path}-#{(0...8).map { (65 + rand(26)).chr }.join}.tmp"
+        
         async_request.on_headers do |response|
           if response.code != 200
             raise "Failed to fetch response(#{response.code}) for url '#{response.effective_url}' ---\n\t #{response.inspect}"
@@ -274,10 +275,12 @@ module Filbunke
           unless downloaded_file.nil?
             downloaded_file.close
           end
-          if response.code == 200
-            ::FileUtils.mv(tmp_filename, local_file_path)
-          else
-            ::FileUtils.rm(tmp_filename) if ::File.exist?(tmp_filename)
+          if ::File.exist?(tmp_filename)
+            if response.code == 200
+              ::FileUtils.mv(tmp_filename, local_file_path) 
+            else
+              ::FileUtils.rm(tmp_filename)
+            end
           end
           true
         end
@@ -287,6 +290,9 @@ module Filbunke
       rescue RuntimeError, SystemCallError, StandardError => e
         msg = ["#{e.class} - #{e.message}", *e.backtrace].join("\n\t")
         @logger.error "Failed to update file #{file.url}: #{msg}"
+        if ::File.exist?(tmp_filename)
+          ::FileUtils.rm(tmp_filename)
+        end
         false
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: filbunke
 version: !ruby/object:Gem::Version
-  version: 1.13.2
+  version: 1.13.3
 platform: ruby
 authors:
 - Wouter de Bie