filbunke 1.13.1 → 1.13.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YjVkNGQwMDVjOGIyNjI4NGI3YzE5MjljNDVlYmVhOGZlYzc0OTYzOA==
+    Y2RhNGVjMjMzZmFmZGFkOWQzMGE3OTJmYjlkZTg2NzU3NDYxNzNkNg==
   data.tar.gz: !binary |-
-    NTU5N2RjNTU3NzUzYjEwOWUzMDk1ZjcwYjA2NmQ1ZGQ1NmQ5YjU4Yg==
+    NWIzOGJiNzIwNzEwYjMxMWQwMzFkNTI4NjYzYmIzOWFkYjRkZmZiNA==
 SHA512:
   metadata.gz: !binary |-
-    YjU5Mzg0YjliMDBiOTE1ZGEyNzdlMTFlMGFjMTAwMDQ1ODVkZmE4NThlMGJi
-    MzEwZGM2ZTRiN2U4YTBkOTU1ZmFhMjUxZDZkZGRhNmE4NjJjMDA5YzA4ZjIy
-    MDhhOGM0ODdlMjUyNjBhNWNkNDUxNjZjYTExODc4MmEzNTU4ODU=
+    ZmViNTdlMWQxZjYwNGU3ZGFmODdkOWE3MzdhYzUxNTI0NDU4ZWVlMWYzNWI0
+    YzMyM2ZiM2M3Y2RkOTMzNWQ5MjQzM2UyZGJlYzkwNjRkZTc3YzcxZmFmMDNl
+    NmM3YjhhYTk1MjFkZmFjYzExODQzYmVjNzc5ZTE0NjQ2MjQ2OTY=
   data.tar.gz: !binary |-
-    M2NiMmIwMmY3NTY3M2QzOWE1OWJkOGMwODYwYjUxMzFlNzNlOTY5MzljYzYx
-    ZDJkZjg0YzMwZmI2M2FmMWE1NjE4MTJiOTc1ZDU0OTlhZjMyNDRlMThlYzYz
-    ZTUxMDJiMDBmNjRkMTIwNjk1Y2U0NWU1YWZlYzMzOGNlNmQxM2M=
+    ZDk3OWY4MjMyZjE4ZDQ1N2ExZDFjYjgxMjQzYTFkZjg5MzFmMDU1MDQ3MWVi
+    MmJlZTU5MTI2OTQ3ZjY2NmY2MmMyZjA5MWMzOWU3MDBlNDQ5MGJjOGIyYjE5
+    NDYxM2EyNjNjZGE0OWE4NDA0NTgwODA5N2UyNjBlYzBlYTU3ODk=

data/VERSION

@@ -1 +1 @@
-1.13.1
+1.13.2

data/filbunke.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: filbunke 1.13.1 ruby lib
+# stub: filbunke 1.13.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "filbunke"
-  s.version = "1.13.1"
+  s.version = "1.13.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]

data/lib/filbunke/client.rb

@@ -256,13 +256,14 @@ module Filbunke
         end
 
         downloaded_file = nil
+        tmp_filename = "#{local_file_path}-#{(0...8).map { (65 + rand(26)).chr }.join}.tmp"
         async_request.on_headers do |response|
           if response.code != 200
             raise "Failed to fetch response(#{response.code}) for url '#{response.effective_url}' ---\n\t #{response.inspect}"
           end
           @logger.debug("Updating: #{local_file_path}")
           ::FileUtils.mkdir_p(::File.dirname(local_file_path))
-          downloaded_file = ::File.new("#{local_file_path}.tmp", "wb")
+          downloaded_file = ::File.new(tmp_filename, "wb")
         end
 
         async_request.on_body do |chunk, response|
@@ -272,9 +273,11 @@ module Filbunke
         async_request.on_complete do |response|
           unless downloaded_file.nil?
             downloaded_file.close
-            ::FileUtils.mv("#{local_file_path}.tmp", local_file_path)
+          end
+          if response.code == 200
+            ::FileUtils.mv(tmp_filename, local_file_path)
           else
-            ::FileUtils.rm("#{local_file_path}.tmp") if ::File.exist?("#{local_file_path}.tmp")
+            ::FileUtils.rm(tmp_filename) if ::File.exist?(tmp_filename)
           end
           true
         end
@@ -320,22 +323,6 @@ module Filbunke
       end
     end
 
-    def write_file!(file_path, contents)
-
-      begin
-        ::File.open("#{file_path}.tmp", 'w') do |file|
-          file.write(contents)
-          file.close
-        end
-        ::FileUtils.mv "#{file_path}.tmp", file_path
-        return true
-      rescue StandardError => e
-        msg = ["#{e.class} - #{e.message}", *e.backtrace].join("\n\t")
-        @logger.error "Failed to move file #{file_path}: #{msg}"
-        return false
-      end
-    end
-
     def delete_file!(file_path)
       if ::File.exists?(file_path) then
         @logger.debug("Deleting: #{file_path}")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: filbunke
 version: !ruby/object:Gem::Version
-  version: 1.13.1
+  version: 1.13.2
 platform: ruby
 authors:
 - Wouter de Bie