field_test 0.5.3 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdb76c20b686424fab97716c260d114977a33ca9d9b41f8ba03a25523742fb49
-  data.tar.gz: 1879b26b2b96ce4083a66f41d15abf07ab61eb2d264308076a65a79adb319df2
+  metadata.gz: f9182763b694b61f732e994e50f0b18f86d60fed181d302f885cd850f19831ae
+  data.tar.gz: b5c0e167d8f0e942dad04fd19f565ec54f38593b6cb4501c5a8631670046dc39
 SHA512:
-  metadata.gz: 2167ced106ba8f40dc2b8eab444101b7e422722daee96f9b19cee3e596fb22ac18fd6999f8afc9f454e496fffa3fd403cdfefca4d36d32d4601148745b507832
-  data.tar.gz: 440498c252008895b164cb59214ef3f98cf4d31572694df985f62a5393c66abd71c8dcb56a57ddb4cff346b227cff1e4d9f8d18c79c375996de53efaa0031ba0
+  metadata.gz: cde68d5e3a16b45e2d29e25c2bbf7fc74190bc69a7ef11477b808619d54764f1107f254ac9eea893468c48678bb64545cf99ca2d57ee3f570335210f12c4e08a
+  data.tar.gz: 9e82ce617955680184e3a79c01d1028e50a0a07ff26a6751cfffb47a68345223762742f41f40741ff52bd75e85c9706c845d438b4302544f5c923cdc211d6070

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.5.5 (2023-01-29)
+
+- Added warning for non-string variants
+
+## 0.5.4 (2022-06-16)
+
+- Fixed bug in results with MySQL and multiple goals (again)
+
 ## 0.5.3 (2022-05-26)
 
 - Fixed bug in results with MySQL and multiple goals

data/README.md

@@ -332,76 +332,6 @@ Now you can do:
 user.field_test_memberships
 ```
 
-## Upgrading
-
-### 0.3.0
-
-Upgrade the gem and add to `config/field_test.yml`:
-
-```yml
-legacy_participants: true
-```
-
-Also, if you use Field Test in emails, know that the default way participants are determined has changed. Restore the previous way with:
-
-```ruby
-class ApplicationMailer < ActionMailer::Base
-  def field_test_participant
-    message.to.first
-  end
-end
-```
-
-We also recommend upgrading participants when you have time.
-
-#### Upgrading Participants
-
-Field Test 0.3.0 splits the `field_test_memberships.participant` column into `participant_type` and `participant_id`.
-
-To upgrade without downtime, create a migration:
-
-```sh
-rails generate migration upgrade_field_test_participants
-```
-
-with:
-
-```ruby
-class UpgradeFieldTestParticipants < ActiveRecord::Migration[6.0]
-  def change
-    add_column :field_test_memberships, :participant_type, :string
-    add_column :field_test_memberships, :participant_id, :string
-
-    add_index :field_test_memberships, [:participant_type, :participant_id, :experiment],
-      unique: true, name: "index_field_test_memberships_on_participant_and_experiment"
-  end
-end
-```
-
-After you run it, writes will go to both the old and new sets of columns.
-
-Next, backfill data:
-
-```ruby
-FieldTest::Membership.where(participant_id: nil).find_each do |membership|
-  participant = membership.participant
-
-  if participant.include?(":")
-    participant_type, _, participant_id = participant.rpartition(":")
-    participant_type = nil if participant_type == "cookie" # legacy
-  else
-    participant_id = participant
-  end
-
-  membership.update!(
-    participant_type: participant_type,
-    participant_id: participant_id
-  )
-end
-```
-
-Finally, remove `legacy_participants: true` from the config file. Once you confirm it’s working, you can drop the `participant` column (you can rename it first just to be extra safe).
-
 ## Credits
 
 A huge thanks to [Evan Miller](https://www.evanmiller.org/) for deriving the Bayesian formulas.

data/lib/field_test/experiment.rb

@@ -8,6 +8,11 @@ module FieldTest
       @name = attributes[:name] || @id.to_s.titleize
       @description = attributes[:description]
       @variants = attributes[:variants]
+      if @variants.any? { |v| !v.is_a?(String) }
+        # TODO add support for more types (including query parameters)
+        # or raise error in 0.6
+        warn "[field_test] Only string variants are supported (#{id})"
+      end
       @weights = @variants.size.times.map { |i| attributes[:weights].to_a[i] || 1 }
       @winner = attributes[:winner]
       @closed = attributes[:closed]
@@ -113,9 +118,10 @@ module FieldTest
             :participant
           elsif adapter_name =~ /postg/i # postgres
             "(participant_type, participant_id)"
+          elsif adapter_name =~ /mysql/i
+            "COALESCE(participant_type, ''), participant_id"
           else
             # SQLite supports single column
-            # MySQL supports multiple columns, but none can be NULL
             "COALESCE(participant_type, '') || ':' || participant_id"
           end
 

data/lib/field_test/version.rb

@@ -1,3 +1,3 @@
 module FieldTest
-  VERSION = "0.5.3"
+  VERSION = "0.5.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: field_test
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.5
 platform: ruby
 authors:
 - Andrew Kane
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-27 00:00:00.000000000 Z
+date: 2023-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.1
 signing_key:
 specification_version: 4
 summary: A/B testing for Rails