fidor_api 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7152a33b506bf53d79fbc0c821a2934fc1603e0383eb155989bdf453348d4cba
-  data.tar.gz: 284f12cf8778162c93b8830b5fb4db5f066115a63cb46c37db6ba6fcd7aece0b
+  metadata.gz: ea591697f4b9ea4d84d1b836aa2cb67de5e70d86c9cb726518c139cdfa3df157
+  data.tar.gz: d69f03db3d2efceef5ed2851d6780c088bdae26baeded6de1dbbe7144cbdaf1d
 SHA512:
-  metadata.gz: b9d5efd9dc9ef4c6b82c1834127ffd2263459bd09172d458da3c6caed1886ce9842312bea50ac37fa8b7a88f4bdaeddf4fd4fd68544664534d1b308567839c4f
-  data.tar.gz: eb6492bbab496adec66c0c981f56932cd788259f17133329ab0da05e6e97a0471635e0d1fc2f629ca67fd68a76510a254a4e2b5e36bb71ef496de7875273a7e6
+  metadata.gz: 8bd4cd844e1385350d18a38cbe9c8ecfcd333b0ff476f8be646d9e66e5c5a9590543baa73f924218459b10ef0afb7c7b8a9492dc0f4b97bb9d01b84b95d11c7d
+  data.tar.gz: ef18b392a1561fafd657720f9e7b116ae5a1c0e09d4a47a0b2560c62d79c7bb91f93f3a6c8b35c1486a96f961c78a22b8b011cae97dd0f50687b8ebc3a96a3e6

data/README.md

@@ -72,6 +72,10 @@ module FidorApi
         api_host
       end
 
+      def auth_redirect_host
+        'http://auth.custom.example.com'
+      end
+
       def auth_methods
         %i[authorization_code resource_owner_password_credentials client_credentials].freeze
       end
@@ -90,6 +94,16 @@ Rails.application.config.x.tap do |config|
 end
 ```
 
+Methods required to be implemented:
+
+| Method Name          | Expected to Return  | Usage                                                             |
+| -                    | -                   | -                                                                 |
+| `api_host`           | `String`            | Used as endpoint for the normal API calls                         |
+| `auth_host`          | `String`            | Used for the oAuth2 calls                                         |
+| `auth_redirect_host` | `String`            | Used for the web-based redirect flow URLs                         |
+| `auth_methods`       | `Array` of `Symbol` | Defines the supported oAuth2 authentication methods               |
+| `transfers_api`      | `Symbol`            | Defines which transfer API is supported. `:generic` or `:classic` |
+
 ### 1. oAuth (Rails)
 
 Redirect the user to the authorize URL:

data/lib/fidor_api/client/authentication.rb

@@ -25,7 +25,7 @@ module FidorApi
       def authorize_start(redirect_uri:, state: SecureRandom.hex(8))
         check_flow_support! :authorization_code
 
-        "#{config.environment.auth_host}/oauth/authorize" \
+        "#{config.environment.auth_redirect_host}/oauth/authorize" \
           + "?client_id=#{config.client_id}" \
           + "&redirect_uri=#{CGI.escape(redirect_uri)}" \
           + "&state=#{state}" \

data/lib/fidor_api/client/dsl.rb

@@ -49,13 +49,15 @@ module FidorApi
         end
       rescue Faraday::ClientError => e
         raise if e.response[:status] != 422
+
         model.tap { |m| m.parse_errors(e.response[:body]) }
       end
 
       POSSIBLE_CONFIRMABLE_HEADERS = %w[x-fidor-confirmation-path location].freeze
 
       def extract_confirmable_id(headers)
-        return if (tuple = headers.detect { |key, _| POSSIBLE_CONFIRMABLE_HEADERS.include? key }).nil?
+        return if (tuple = headers.detect { |key, value| POSSIBLE_CONFIRMABLE_HEADERS.include?(key) && value.present? }).nil?
+
         tuple.last.split('/').last
       end
     end

data/lib/fidor_api/environment/base.rb

@@ -9,6 +9,10 @@ module FidorApi
         raise NotImplementedError
       end
 
+      def auth_redirect_host
+        raise NotImplementedError
+      end
+
       def auth_methods
         raise NotImplementedError
       end

data/lib/fidor_api/environment/fidor_de/production.rb

@@ -10,6 +10,10 @@ module FidorApi
           'https://apm.fidor.de'.freeze
         end
 
+        def auth_redirect_host
+          'https://apm.fidor.de'.freeze
+        end
+
         def auth_methods
           %i[authorization_code].freeze
         end

data/lib/fidor_api/environment/fidor_de/sandbox.rb

@@ -10,6 +10,10 @@ module FidorApi
           'https://apm.sandbox.fidor.com'.freeze
         end
 
+        def auth_redirect_host
+          'https://apm.sandbox.fidor.com'.freeze
+        end
+
         def auth_methods
           %i[authorization_code].freeze
         end

data/lib/fidor_api/environment/future.rb

@@ -6,7 +6,11 @@ module FidorApi
       end
 
       def auth_host
-        api_host
+        'https://api.example.com'.freeze
+      end
+
+      def auth_redirect_host
+        'https://auth.example.com'.freeze
       end
 
       def auth_methods

data/lib/fidor_api/model/helpers/attribute_decimal_methods.rb

@@ -7,6 +7,7 @@ module FidorApi
           define_method name do
             value = read_attribute(name)
             return if value.nil?
+
             BigDecimal((value / 100.0).to_s)
           end
 

data/lib/fidor_api/model/transfer/generic.rb

@@ -37,6 +37,7 @@ module FidorApi
 
         def routing_type=(type)
           raise Errors::NotSupported unless SUPPORTED_ROUTING_TYPES.key?(type)
+
           @beneficiary ||= {}
           @beneficiary['routing_type'] = type
           define_methods_for(type)

data/lib/fidor_api/version.rb

@@ -1,3 +1,3 @@
 module FidorApi
-  VERSION = '2.0.0'.freeze
+  VERSION = '2.0.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fidor_api
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Fidor Solutions AG
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-10 00:00:00.000000000 Z
+date: 2018-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -126,16 +126,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.58'
+        version: 0.59.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.58'
+        version: 0.59.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement